Files
skillshare/internal/server/handler_version.go
T
Willie 8a377481cb feat(version): Homebrew-aware version check
Homebrew formula updates lag GitHub Releases by hours/days, causing
Homebrew users to see "update available" when `brew upgrade` says
already up-to-date. Now detect install method from executable path
and query `brew info --json=v2` for Homebrew installs instead of
the GitHub Release API.

- Add InstallMethod type with DetectInstallMethod() and
  FetchBrewLatestVersion() in internal/version/homebrew.go
- Check() accepts InstallMethod to branch fetch strategy
- UpdateNotification() accepts upgradeCmd (shows correct command)
- UpgradeCommand() method on InstallMethod centralizes the mapping
- doctor.go reuses versioncheck.Check() (fixes semver string
  comparison bug in old fetchUpdateMessage)
- Remove duplicated isHomebrewInstall() from upgrade.go
- Skip post-command version check for doctor (has its own)
2026-03-02 02:23:50 +08:00

49 lines
1.3 KiB
Go

package server
import (
"net/http"
"skillshare/internal/config"
versioncheck "skillshare/internal/version"
)
func (s *Server) handleVersionCheck(w http.ResponseWriter, r *http.Request) {
cliVersion := versioncheck.Version
cliUpdateAvailable := false
var cliLatest *string
// CLI version check (uses 24h cache)
if result := versioncheck.Check(cliVersion, versioncheck.InstallDirect); result != nil {
cliUpdateAvailable = result.UpdateAvailable
cliLatest = &result.LatestVersion
}
// Skill version (local) — always check global source for built-in skill
skillSourceDir := s.cfg.Source
if s.IsProjectMode() {
if globalCfg, err := config.Load(); err == nil {
skillSourceDir = globalCfg.Source
}
}
skillVersion := versioncheck.ReadLocalSkillVersion(skillSourceDir)
// Skill version (remote) — network call with 3s timeout
var skillLatest *string
skillUpdateAvailable := false
if skillVersion != "" {
if remote := versioncheck.FetchRemoteSkillVersion(); remote != "" {
skillLatest = &remote
skillUpdateAvailable = remote != skillVersion
}
}
writeJSON(w, map[string]any{
"cliVersion": cliVersion,
"cliLatest": cliLatest,
"cliUpdateAvailable": cliUpdateAvailable,
"skillVersion": skillVersion,
"skillLatest": skillLatest,
"skillUpdateAvailable": skillUpdateAvailable,
})
}