mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
* fix(install): omit the empty audit section in dry-run A dry-run skips the security audit, yet the single-skill path still printed the "Audit Findings" heading with nothing under it, which reads as if the audit ran and found an empty result. * feat(init): ask first, confirm a summary, then write The old init asked nine questions in three input styles and wrote files as it went, so cancelling midway left a half-built setup, and detection created tool folders even under --dry-run. Connecting a second machine to an existing repo was only offered at the very end, and the built-in skill defaulted to "no", which read as "not recommended" (#200). init now collects every answer into a plan, shows a summary with Yes / Change settings / Cancel, and writes nothing until confirmed. Esc cancels cleanly. A "Connect my existing skillshare repo" path checks the repo before writing, detects its layout, prefers the repo version of same-name skills and keeps local-only ones for the next push. The built-in skill is installed by default, and the first sync runs at the end so the tools work right away. Prompts use one inline huh-based component with theme colors. Without a terminal (CI, scripts, AI agents) init now applies the same defaults as pressing Enter and prints each decision with the flag that changes it, instead of silently doing less; init -p and --discover add the detected tools. Output that is not a terminal is plain text. BREAKING CHANGE: non-interactive `init` now enables git, installs the built-in skill and selects every detected tool; pass --no-git, --no-skill, --no-targets or --no-copy for the previous minimal setup. Piped or redirected output no longer contains ANSI colors; use --json where offered for machine-readable output. Refs #200 * docs(init): show the new init flow and the connect-a-repo path The getting-started page still described the old four-question wizard with a screenshot of it, the second-machine guide never mentioned the new "Connect my existing skillshare repo" choice, and the recipe told users to run pull and sync after init even though init now does both. Replace the screenshot with ones from the new flow, describe the questions, summary and cancel behavior, and explain what connecting a repo does before and after confirmation. The devcontainer example gains --no-git because init without a terminal now turns git on by default. Refs #200 * feat(devcontainer): seed fake tools and a repo with ssenv --seed Trying init by hand needed several manual steps to fake installed AI tools and a skills repo to connect. `ssenv create --seed` (and `ssnew --seed`) now creates claude/codex/cursor directories with a few skills and a local bare repo at ~/remote/skills.git, so both init paths can be tried at once. Refs #200 * fix(ui): skip the logo on 16-color terminals and hide the cursor while it plays `docker exec -it` sets only TERM=xterm, which reads as 16 colors: the logo was mapped onto the terminal's own palette and its fade-in collapsed into a few flickering cells. Below 256 colors the banner now prints only its text, and the devcontainer sets COLORTERM=truecolor. The visible cursor also jumped along the logo's left edge while frames redrew in place. It is hidden during the animation and restored on exit, including Ctrl+C. Refs #200 * style(ui): color the question mark in prompts The uncolored "?" before each question read like a stray character. It now uses the accent color of the "›" cursor. Refs #200 * fix(init): name the root git scope by what it versions "everything" suggested plugins, MCP servers and hooks were versioned too, but they live in config.yaml, which the root scope gitignores. The option and summary now say "skills, agents, extras" and note that those settings stay in each machine's config.yaml. Refs #200 * feat(init): show --discover in the new init style --discover still printed the old header, "agent(s)" counts and "+ name" lists next to the new prompt. Global and project discover now share init's answered rows (Tools, Config) and a Next line, and call the targets "AI tools" as init's banner does. Refs #200 * feat(init): replace the pixel logo with a SKILLSHARE wordmark The half-block logo looked stretched on terminals with tall line height and turned to mush when shrunk to fit. init now opens with a three-line pixel wordmark, SKILL in blue and SHARE in gold, that lights up from left to right, followed by the version and tagline on one dim line. The generated logo data and its generator script are gone. Without a terminal, without color, below 256 colors or on a narrow terminal, the banner still prints a plain "skillshare vX" line. Refs #200 * refactor(init): label the chosen tools "Targets" init called them "Tools" while the rest of the CLI, the config file and the `target` command call them targets. The answered rows and the summary now say "Targets", the same label the other commands will use. Sentences that describe what was detected ("Found 3 AI tools") stay as they are. The docs tables, the First Sync steps and both init screenshots are updated to match. Refs #200 * feat(cli): ask yes/no questions with the inline prompt uninstall, trash empty, extras remove, target add, collect, update, upgrade and audit each printed their own "[y/N]:" line and parsed the answer by hand, while init already used the inline Yes/No prompt. They now share it: esc answers no, and a declined question prints one dim "Cancelled. Nothing was …" line, as init's cancel now does too. Without a terminal the prompt reads one line from stdin instead, so piped answers such as `echo y | skillshare uninstall x` keep working. It reads byte by byte so a second question still gets its own answer. Refs #200 * feat(sync): report each target on one aligned row Sync printed a ruled header, a "Backing up" block and a "name: merged (43 linked, 0 local, 0 updated, 0 pruned)" line per target, so the counts that changed were hard to find among zeros. It now follows the init style: one row per target with only the non-zero counts, a single Backup row, and a closing line with the duration. `sync --all` names its Skills, Agents and Extras blocks and no longer explains how to set up extras when none are configured. The non-TTY text changes with it; `--json` stays the stable interface for scripts. Tests match rows through the new AssertRowContains helper. Refs #200 * feat(status): show targets as one table Status printed each target as a header with indented skills and agents lines full of bracketed modes and zero counts, and the audit policy as four lines of uppercase labels. Comparing targets meant reading every block. Each target is now one row with a skills and an agents column, a single line names the modes in use, and audit and version take one line each. Global and project mode share the renderer, so project paths read relative to the project root. Refs #200 * feat(install): report each step on one aligned row Install printed a logo, a box-drawn tree, "Next Steps" bullets and a separate "Audit Findings" block, so the result was hard to find. It now uses the same rows as sync and status: Source, Audit and Install with the destination folded to ~, then a closing line and a Next block. Spinners write through a gate that Stop closes before clearing the line. pterm's render goroutine checks IsActive and then writes, so a fast step such as install --dry-run left "Copying files..." stuck in front of the next line. Refs #200 * feat(uninstall): confirm against one line and point at undo Uninstall opened with a boxed header and Name/Path lines, and closed with the trash folder path and a "Next Steps" bullet. Now one line names the target, its folder and what it holds; the result is a single "Uninstall x → trash, kept 7 days" row; and Next offers sync, the trash restore command that undoes it, and the reinstall command when the skill came from a remote source. A batch run with --force or --dry-run no longer lists the targets twice, since there is no question for the list to support. Mixed batches are counted as items, not targets, which already names the AI tools. Refs #200 * feat(update): report each skill or repo on one Update row Update opened with an "Updating" header, the full source path and a "0 tracked repo(s), 1 skill(s)" line, then printed a Changes box and two success lines before "Next Steps". A single update is now an Update row (source or commit count, time), the commits it pulled in dim text, the Audit row, and Next. A batch ends with the audit result and one closing line that leaves out zero counts. Progress bars now clear themselves when they stop, like spinners, so a finished batch no longer leaves "[3/3] ... 100% Done" behind. Refs #200 * feat(check): list what needs attention and close with one line Check opened with a header, the full source path and an item count, counted skills with updates without naming them, and ended with two "Run ..." hints. It now prints one row per repo, skill or agent that needs attention (behind, update available, stale, failed), a closing line that leaves out zero counts, and the update command under Next. A single-name check is one row, like update. Refs #200 * feat(push,pull): report commit, push and pull as aligned rows Push and pull opened with a header and closed with "Push complete" or "Pull complete", so they never said what they committed, where they pushed, or what a pull brought in. Push now prints a Commit row (file count and message) and a Push row naming the upstream branch, never the remote URL since it can carry credentials. Pull prints a Pull row with the commit and file counts and the commits themselves, as update does for a tracked repository, before the sync output. Dry runs list the changed files as ~ + - instead of raw porcelain codes, and error hints are dim notes instead of info lines. Refs #200 * feat(upgrade): report the CLI and the skill on one row each Upgrade opened with the logo and printed a tree of steps per part (current version, latest version, status) ending in "Already up to date ✓". Each part is now one row, such as "✓ CLI v0.22.0 → v0.23.0 · 3.1s" or "✓ Skill v0.23.0, already up to date", with spinners that clear. Sync is offered under Next only when the skill changed, and the star request is a dim line at the end. Refs #200 * feat(new): report the created skill on one row New printed a "New Skill Created" header, the full path, and numbered "Next steps" that told the user to edit the file and run sync. It now prints "✓ Created ~/…/SKILL.md", the folders a pattern added, and sync under Next. A dry run shows the same row, a Preview section with the template, and the dry-run line. Refs #200 * feat(trash): list items and restores as aligned rows The plain trash list printed each item as an info line with its size and age in parentheses under a "Trash" header, and restore printed two success/info lines plus a "Next Steps" label. The list is now rows of name, size and age with one closing count, and restore is one row naming where the item went back, with sync under Next. An item trashed under a minute ago reads "just now" instead of "just now ago". Refs #200 * feat(collect): list local items and results as aligned rows Collect opened with a header, listed local items as "[target] path" list items under a second header, then printed a third header before the per-item results and a metric summary line. It now lists each local item as a row (name, target, path), asks the inline confirm, prints one row per result and closes with "Collected N skills" plus sync and, when the source is a git repository, commit under Next. Refs #200 * feat(hooks): show hooks and their changes as aligned rows Hooks printed "Hooks source: <path>" as an info line, statuses through the fixed-width Status helper, and results as sentences ending in "Run 'skillshare hooks sync' when ready." Hooks and Agent file changes are now rows, with conflicts marked as failures and inactive outputs as warnings, saves and applies close with one line, and the next command sits under Next. The list's "Pending sync" section no longer shows entries that are already in place. Refs #200 * feat(mcp): show servers, changes and checks as aligned rows MCP printed "MCP source: <path>" as an info line, plan changes through the fixed-width Status helper, results as sentences that named the next command inline, and check summaries as "2 server(s) checked: 1 error(s)". Changes and parked servers are now rows with conflicts marked as failures, saves and applies close with one line and Next, and check marks each server with its findings beneath and closes with "Checked 2 servers: 1 error". The Status helper had no callers left and is removed. Refs #200 * feat(plugin): show packages, plans and results as aligned rows Plugin text output was raw "name · target · id · state" lines with "Warning:", "Includes:" and "Revision:" prefixes, and the list walked a map so packages came out in a different order each run. Packages, discovered candidates, planned changes and results are now rows sorted by name, marked by state (registered, not installed, pending, blocked, failed), with details as dim notes and the dry-run line after a preview. JSON output is unchanged. Refs #200 * feat(audit): replace header and summary boxes with rows Audit framed its context in a header box (mode, path, block rule, policy), numbered batch results "[1/2]", printed per-skill verdicts as "→ Aggregate risk / Block decision" lines, and closed with a Summary box that listed every count including zeros. The context is now one title line with a dim note, flagged skills are aligned rows with their highest severity, the summary leaves out zero counts, and the run closes with one line saying whether anything was blocked and by which severity, followed by the command to see the first blocked skill's findings. The progress bar no longer writes its final frame when stdout is not a terminal; that frame had no newline and ran into the next line. Refs #200 * feat(audit): show audit rules as aligned rows The rules list was a fixed-width table framed by 90-character dividers with a "(N rules: N enabled, N disabled)" footer, and rule changes were sentences like "Set severity for X → HIGH". Rules are now rows keyed by ID with a colored severity and the pattern dimmed, disabled rules dim as a whole, the list closes with a count that names disabled rules only when there are some, and each change is one row. Refs #200 * feat(search): drop the logo and tree, show results as rows Search opened with the ASCII logo, drew its progress as a ├─/└─ tree, listed results under a column header with dividers, and ended installs with "Run 'skillshare sync' to distribute to all targets". Results are now aligned rows with the source, stars or risk, and the description and tags beneath; a single install reports the same Install row as `skillshare install`; batch installs list only failures before one Done line; and sync and audit sit under Next. Login and rate-limit problems name the command that fixes them. Non-terminal output no longer prints a "name: installing..." line per skill. Refs #200 * feat(backup): show backups and restores as rows with one closing line Backup and restore opened with headers, announced dry runs with a warning before doing anything, summarized with an operation box, and followed a backup with a "Recent backups" list. Targets now back up in name order as rows with folded paths, runs close with one Done line (and Next restore), listings are rows keyed by timestamp or path with a total, and dry runs end with the shared dry-run line. Cleanup reports how many backups remain instead of a separate "Current" line. Refs #200 * feat(help): one line per command, subcommands in each command's help The top-level help opened with the ASCII logo and listed about 70 lines across ten uppercase sections plus 15 examples, so it did not fit a screen, yet it left out analyze and the common options. It now lists each command once in six groups with the common options, and points to `<command> --help` for subcommands. The mcp, plugin, hooks and extras pages use the same layout and keep all their content. A mistyped command prints one error with the closest command instead of the whole help, a lone option such as --no-tui shows the help, and `skillshare version` prints one line. Refs #200 * feat(extras): show extras and their changes as rows with Next Extras printed a header, "→ name" lines with ad-hoc colored marks (including ✗ for targets that were only waiting for a sync), and ended each change with a sentence naming the next command. The list now shows each extra as a bold name over aligned target rows (! for drift or not synced) and closes with a count and, when something is pending, Next sync extras. Init, collect, add/remove target, mode and source changes close with one Done line, details become notes, and dry-run collect ends with the shared dry-run line. Refs #200 * feat(target): show targets as sections and rows with Next Target info and the plain list printed "Key:" lines at two indent levels, with "(none)" for every unset filter, and remove printed "Backing up" / "Unlinking" headers with one line per step. Info now shows the name over Skills and Agents sections with aligned rows, the list gives each target one row per resource with details dimmed, and empty filters are left out. Remove reports one row per target (plus its backups) and closes with a Done count; dry runs say what would happen per target and end with the shared dry-run line. Skills on/off, add and mode/naming/filter changes close with Done and Next. Refs #200 * feat(doctor): report checks as aligned rows and end with Next Doctor opened with the ASCII logo, split its report under divider headers, mixed ✓/→/! lines with full paths and "(s)" counts, listed targets in random map order, and ended with a bare warning count that left the fix to scattered "Run:" hints. Checks now print as aligned rows under bold sections (Environment, Targets, Extras, MCP/hooks/ plugins, Storage, Version), paths fold to ~, targets are sorted with one row per resource, and the report closes with a Done line plus up to three Next commands collected from the checks (sync, sync agents, sync hooks, upgrade, ...). The --json output is unchanged. Refs #200 * feat(hub): drop the logo and report hub changes with Done hub index opened with the ASCII logo and a tree of spinner steps, then repeated the result as "→ Mode / Skills / Output" lines with the full path. It now shows one spinner that clears itself and a Done line naming the folded output path, skill count and duration, with the index contents as a note. hub list shows aligned rows with the default and built-in hubs marked in dim text instead of a "*" column, and the add, remove and default commands close with a Done line. Refs #200 * test(install): match the shared dry-run line in online tests The online-tagged install tests still looked for the old "dry-run" banner, which install no longer prints since the restyle. They are skipped by default, so the mismatch only showed under -tags online. Refs #200 * fix(target): align remove rows on target names only The label column was sized for "<name>-agents" so an agents backup could fit, which left a wide gap on every row when no agents were backed up. The agents backup row now uses the target name too and says "agents backed up", so the column fits the names. Refs #200 * fix(update): list each item in a batch dry run A batch dry run only said "Would update N skills". Off a terminal the names leaked out through the progress bar's title lines, but on a terminal those lines clear, so the dry run never said which skills or repos it would touch. It now prints one Update row per item, as the single-item dry run does. Refs #200 * fix(ui): keep the progress bar silent off a terminal Off a terminal the bar printed "Title (0/N)", every title change and every phase header as permanent lines, which a terminal shows only as a frame that clears itself. Audit left a stale "Scanning skills (0/7)" line, and scripts saw different content than a terminal. The bar now prints nothing off a terminal, like the spinner. Refs #200 * fix(audit): avoid a double blank line before Summary The audit header ends with a blank line and Summary added its own, so a clean scan with no result rows showed two blank lines in a row. The Summary title no longer adds one; the result rows add it when present. Refs #200 * fix(mcp): drop the blank line above "Saved the MCP source" A save with no backup or migration notes printed a blank line with nothing above it, so mcp add and mcp edit opened on an empty line. Refs #200 * fix(doctor): stop repeating the extra's name in its findings Extras findings printed "rules rules → /home/me/.claude/rules: 1 file(s) out of sync": the row label already names the extra, the path was not folded to ~, and the count used "file(s)". The rows now start at the arrow, fold the path and pluralize the count. JSON details keep the extra's name so each line still stands alone. Refs #200 * fix(doctor): show integrity issues as rows under Integrity Tampered skills and missing hashes printed as free "! Skill integrity: N skill(s) ..." lines after the verified row, breaking the aligned Environment rows. They now sit under a single Integrity row, which turns to ! when any skill has an issue. Refs #200 * fix(doctor): pluralize the Skillignore and Trash rows The rows read "1 patterns, 1 skills ignored" and "1 item(s) (50 B), oldest <1 day". They now read "1 pattern, 1 skill ignored" and "1 item, 50 B · oldest under a day". The JSON messages keep their wording, since scripts may match on them. Refs #200 * docs: show the restyled output of batch 3 commands The reference pages still showed the old output of upgrade, new, trash, collect, audit, search, backup, restore, extras, hub, target and doctor: divider headers, arrow-prefixed lines and "(s)" plurals. The examples now match what the commands print, in all five locales, and the doctor check table uses the new row labels. Refs #200 * feat(trash): let trash empty skip its confirmation with --force Scripts had no way to empty the trash: off a terminal the confirmation reads stdin and cancels on EOF. --force (-f) skips it, as it does for uninstall and extras remove. Refs #200 * fix(doctor): show source, link and target problems as rows Missing sources, unsupported links, folders without SKILL.md, unknown skill targets, bad include/exclude patterns and broken symlinks printed as free "✗ Source not found: …" lines between the aligned rows. They now use the row of the check they belong to, and broken symlinks or a missing source add a Next suggestion. Refs #200 * fix(ui): leave out durations that would read 0.0s Fast commands ended with "· 0.0s", which says nothing. Every result line now formats its time through ui.Took, which init already used for its steps: durations under 0.05s are left out. Refs #200 * fix(ui): print dev builds without a v prefix Version labels were built as "v" + version everywhere, so a dev build printed "vdev". VersionLabel adds the prefix only when the version starts with a digit, and the logo, help header, version command and upgrade output share it. Refs #200 * fix: pluralize category and drop "just now ago" The checklist status bar appended "s" to its item name and printed "categorys". The trash TUI formatted ages with its own helper that added "ago" after "just now". plural now handles consonant + y, and the trash TUI uses the shared timeAgo, which makes formatAge unused. Refs #200 * fix(target): drop the parenthesized counts in the plain list The plain target list printed "merged (43 shared, 0 local)" while target info and doctor print "merged · 43 shared" with zero counts left out. The sync summary now returns both forms from one scan, so the TUI and --json keep their existing text and the plain list matches the other commands. Refs #200 * test(backup): make the agents backup test back something up The test only synced agents, which become symlinks into the source and are skipped by backup, so it passed without any backup being written. It now adds a target-local agent and checks that the file lands in the backup. Refs #200 * refactor(cli): render every command's --help with printHelp About forty help pages were hand-aligned raw strings with "Usage:", "Options:" and "Examples:" headings, while hooks, mcp, plugin, extras and the top-level help already used printHelp. They now share it, so headings, option order (short flag first) and alignment match across commands. Examples align on their own column so long commands no longer push option descriptions to the right, and "--help, -h" rows are dropped as on the converted pages. Refs #200 * feat(enable): print enable and disable results as rows enable/disable still used the old "Disabled: x (added to .skillignore)" line plus a "Run skillshare sync" sentence. They now print one row per pattern, a Next hint after a change, and the dry-run closing line, like the other restyled commands. Refs #200 * fix(sync): pluralize the leftover cleanup note Project sync printed "Cleaned 1 leftover skill(s)". The note now uses the singular or plural noun, and the sync docs show it as the dim note it is instead of an arrow line. Refs #200 * fix(cli): drop the arrow info lines left in install, update and sync These commands were restyled, but about fifty messages still went through ui.Info, which prints a leading arrow, and several said "skill(s)" or "item(s)". Hints now print as dim notes, empty results ("No agents found") as closing lines, follow-up commands as Next, and counts use the singular or plural noun. Refs #200 * fix(cli): tidy small leftovers found in the recorded output doctor printed "0 minutes ago" for a fresh backup and an ASCII arrow in the Update row, unlike trash and upgrade, which say "just now" and "v1.2.0 → v1.3.0". The "bring the Targets up to date" hint capitalized a word mid-sentence, and search --list showed hub sources under the home directory as a cut-off absolute path instead of folding it to ~. JSON messages keep their wording. Refs #200 * fix(search): fit a home-folded source path in the list Folding the home directory to ~ was not enough: a typical local hub path such as ~/.config/skillshare/skills/frontend/react is 42 characters, so the 40-character cap still cut it. Fifty characters next to the 24-character name column stays within 80 columns. Refs #200 * feat(list): print the plain list with rows and a closing count The --no-tui list still used the old header with a divider and an arrow on every skill, so it looked unlike every other restyled command. Skills now line up in one column under their group, tracked repos use the ✓ / ! marks, and the list closes with a count split by tracked, remote and local (zero counts left out). Project mode keeps its scope as a dim "· project" after the title. Global and project had copied the same plain-output code; both now call printSkillList. The loading spinner clears itself instead of leaving a "Loaded N skills" line. Refs #200 * fix(cli): show help for subcommand --help instead of running it target add/remove/list, trash list/empty and hub list/remove passed --help through as an argument, so they ran the command, failed on a target or hub named "--help", or rejected the flag. tui on --help even switched the TUI on. Each now prints its command's help page. The tui status and toggle lines also move to the row and Done style. Refs #200 * feat(diff): print differences as rows and close with next steps The plain diff still printed a Summary line, divider headers, arrow hints and per-target "scanning" lines when output was not a terminal. Each group of targets now lists one row per kind of change ("New a, b"), targets in sync share a single ✓ row, extras use the same rows, and diff closes with a count and up to three commands. The suggested sync command follows what differs: sync, sync agents, sync extras or sync --all. Agents no longer show as "New 1 skill", because rows name the change rather than counting skills. "skillshare diff all", listed in the help, failed with "target 'all' not found"; it now diffs everything, the same as no argument. Refs #200 * test: sync the install warning summary and gofmt two status tests The "6 findings" wording changed in an earlier commit, but the unit test under cmd/ still expected "6 finding(s)": scripts/test.sh and make check only run ./internal and ./tests, so the cmd tests never ran. Two status tests also had comment alignment gofmt rejects, which fails make check's fmt-check. Refs #200 * test: run the cmd unit tests in scripts/test.sh CI runs go test ./cmd/skillshare/... ./internal/..., but the local runner behind make test and make check only ran ./internal/..., so a stale assertion in cmd/skillshare passed locally and would only fail in CI. Refs #200 * feat(cli): restyle commit and analyze output commit and analyze were the last git and inspection commands still printing the old header and table layouts. They now use the same rows, Done line, and Next hints as push and pull, so a commit reads like the commit row of push, and analyze shows each target group as a bold name with aligned token rows instead of a boxed table. Refs #200 * feat(log): show entries as rows and fold the log path The plain log view still opened each section with a boxed header that printed the absolute log path, then a TIME | CMD | STATUS table. Entries now read like every other command: a status mark, the command, when it ran and how long it took, with details indented beneath. The log path is folded to ~ and moves to a dim footnote. log --stats drops its divider and ends with one summary line. It and the TUI stats panel said "just now ago" for a fresh entry; both now use timeAgo, which already handles that case. Refs #200 * feat(cli): restyle completion, ui and leftover arrow lines completion --install, ui start/stop and a few notices still printed arrow info lines with absolute paths. They now end with a Done line, fold paths to ~, and give config-file lines their own bold heading so the lines to paste read apart from the hints. The empty extras TUI now says the same thing as extras list. Refs #200 * feat(init): report git changes on an existing setup as rows init --remote and init --git-root on an existing setup still printed arrow lines with absolute paths and spinner results in a different voice. They now print aligned Git, Remote, Pull and Git root rows like a fresh init, end a dry run with the shared Dry run line, and give the choices after a remote check as Next commands. A source repo the user created before init had no fallback identity, so on a machine without git config the follow-up commit failed and dumped git's whole "Please tell me who you are" message. The existing repo now gets the same local fallback a new one does. Refs #200 * feat(doctor): warn when a newer built-in skill is published status already compared the skillshare skill with the published one, but doctor only printed the local version, so a run meant to find problems called an old skill healthy. doctor now fetches the published version alongside the CLI update check and suggests upgrade --skill. Both commands share a semver comparison. status compared with !=, so a skill ahead of main (a dev build) was reported as having an update. Refs #200 * fix(cli): count batch audit warnings in words and clear progress spinners The batch install and update audit summary still printed "2 skill(s)" and "warning(s)" after the rest of the output switched to "1 skill" / "2 skills". uninstall and agent update also left "Found N skills" and "Check complete" behind, progress messages the restyle clears. Refs #200 * fix(cli): say so when diff or analyze has no targets With no targets configured, diff reported "No differences" and analyze printed only its "Add -v" hint, both reading like a healthy result. They now say no targets are configured and suggest target add, as target list does. Refs #200 * fix(diff): align values across target sections Each target section sized its labels on its own, so a section with "Local only" started its values two columns later than one with only "New", and the list read ragged. All sections now share one width. Refs #200 * fix(doctor): count built-in skill warnings in the summary The skill rows (not found, missing version, newer version available) were marked as warnings and counted by --json, but never reached the text summary, so doctor could print "! Skill not found" and close with "All checks passed". The all-good integration test only passed because of this; it now installs the built-in skill it needs. Refs #200 * fix(init): stop writing a git identity into existing repos On a repo the user created, init stored skillshare@local in the repo config so its one commit would work. That setting outranks --global, so the advice we printed never took effect and later pushes went out as skillshare@local. The commit now gets the fallback through env vars only. The note for repos init creates names the repo-level command that actually overrides it. Dry runs also wrote .gitignore into existing repos while closing with "nothing was written", and warned about --no-git when it was not passed; both now only describe what would happen. Refs #200 * fix(cli): tell "no targets" apart from "nothing reaches them" diff and analyze said "No targets configured" and suggested adding one whenever there was nothing to show, including when targets exist but have skills turned off or no skill is meant for them. Refs #200 * fix(log): drop the trailing separator on instant entries Entries with no recorded duration ended in a dangling " · ". Also removes the formatRelativeTime alias the stats restyle left unused; its test now covers formatDurationShort directly. Refs #200 * docs: match tui, project list and log examples to the real output The tui and project list examples used label widths the CLI does not print, and the plain log example claimed to show non-TTY output, which joins each entry's details on one line. Refs #200 * perf(version): cache the published skill version for a day doctor and status asked GitHub for the latest skill version on every run, adding up to 3 s when offline. They now reuse the answer for 24 hours, the same interval the CLI update check caches for. upgrade --skill still fetches fresh and records what it got. Refs #200 * perf(server): reuse the cached skill version on the dashboard The version endpoint fetched the published skill version on every call, like doctor and status did, so it now shares their 24-hour cache. It also treated any difference as an update, offering a "newer" skill to anyone running a local build ahead of main. Refs #200 * test(redteam): match the restyled update --diff heading update --diff now titles its file list "Files changed" in sentence case, like every other section, so the check for the list looked for the old "Files Changed" box title and failed although the list was there. Refs #200 * test(cli): keep /tmp fixtures unfolded where HOME is /tmp scripts/test.sh now runs the cmd unit tests, so the docker sandbox runs them too, with HOME=/tmp. shortenPath then folds the /tmp fixtures in four tests to ~ and their exact-path checks fail. The tests now point the cached home elsewhere while they run. Refs #200 * fix(init): find skills/ in a repo that holds nothing else The check for a skills/ folder ran only when the repo root had no skill folders, but it counted skills/ itself as one, so it never ran. A repo with only skills/ became the source as a whole, one level too high. Refs #200 * fix(init): keep the skills git scope for a custom source With a remote that has no skills yet, init defaulted to versioning the whole skillshare folder. For a --source outside that folder it holds none of the user's skills, so the commit and every later push carried nothing while init reported the remote as linked. Refs #200 * test(sync): check only the Agents section for updated agents The restyle turned the old "0 updated" check on the agent summary into "no 'updated' anywhere", which also covered the Skills section. On macOS the first project sync reports the skill as updated there, so the test failed on something it was never meant to check. Refs #200
1431 lines
43 KiB
Go
1431 lines
43 KiB
Go
//go:build !online
|
|
|
|
package integration
|
|
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"skillshare/internal/testutil"
|
|
)
|
|
|
|
func TestInit_Fresh_CreatesConfigAndSource(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Remove config file to simulate fresh state
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "✓ Config")
|
|
|
|
// Verify config was created
|
|
if !sb.FileExists(sb.ConfigPath) {
|
|
t.Error("config file should be created")
|
|
}
|
|
|
|
// Verify source directory was created
|
|
if !sb.FileExists(sb.SourcePath) {
|
|
t.Error("source directory should be created")
|
|
}
|
|
|
|
cfg := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(cfg, "__pycache__/") {
|
|
t.Errorf("config should include default __pycache__/ ignore, got:\n%s", cfg)
|
|
}
|
|
}
|
|
|
|
func TestInit_WithSourceFlag_UsesCustomPath(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Remove config file
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
customSource := filepath.Join(sb.Home, "my-skills")
|
|
|
|
result := sb.RunCLI("init", "--source", customSource, "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "~/my-skills")
|
|
|
|
// Verify custom source was created
|
|
if !sb.FileExists(customSource) {
|
|
t.Error("custom source directory should be created")
|
|
}
|
|
}
|
|
|
|
func TestInit_DryRun_DoesNotWrite(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
os.RemoveAll(sb.SourcePath)
|
|
|
|
result := sb.RunCLI("init", "--dry-run")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Dry run")
|
|
|
|
if sb.FileExists(sb.ConfigPath) {
|
|
t.Error("dry-run should not create config")
|
|
}
|
|
|
|
if sb.FileExists(sb.SourcePath) {
|
|
t.Error("dry-run should not create source directory")
|
|
}
|
|
|
|
defaultSkillPath := filepath.Join(sb.SourcePath, "skillshare", "SKILL.md")
|
|
if sb.FileExists(defaultSkillPath) {
|
|
t.Error("dry-run should not create default skill")
|
|
}
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_ReturnsError(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create config to simulate already initialized
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
result := sb.RunCLI("init")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "already initialized")
|
|
}
|
|
|
|
func TestInit_CreatesDefaultSkill(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Remove config file
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Use flags for reliability (survey MultiSelect doesn't work well in non-TTY stdin)
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
// Verify default skillshare skill was created
|
|
defaultSkillPath := filepath.Join(sb.SourcePath, "skillshare", "SKILL.md")
|
|
if !sb.FileExists(defaultSkillPath) {
|
|
t.Error("default skillshare skill should be created")
|
|
}
|
|
}
|
|
|
|
func TestInit_DetectsCLI_OffersImport(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Remove config file
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create existing claude skills directory with a skill
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
testSkillPath := filepath.Join(claudeSkillsPath, "test-skill")
|
|
os.MkdirAll(testSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(testSkillPath, "SKILL.md"), []byte("# Test"), 0644)
|
|
|
|
result := sb.RunCLI("init", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "claude")
|
|
}
|
|
|
|
func TestInit_WithSkills_CopiesOnConfirm(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Remove config file
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create existing claude skills directory with a skill
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
testSkillPath := filepath.Join(claudeSkillsPath, "my-test-skill")
|
|
os.MkdirAll(testSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(testSkillPath, "SKILL.md"), []byte("# My Test Skill"), 0644)
|
|
|
|
result := sb.RunCLI("init", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "1 imported")
|
|
|
|
// Check if skill was copied to source
|
|
copiedSkillPath := filepath.Join(sb.SourcePath, "my-test-skill", "SKILL.md")
|
|
if !sb.FileExists(copiedSkillPath) {
|
|
t.Error("skill should be copied to source")
|
|
}
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_RemoteFlag_AddsRemote(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create config to simulate already initialized
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Initialize git in source directory
|
|
cmd := exec.Command("git", "init")
|
|
cmd.Dir = sb.SourcePath
|
|
if err := cmd.Run(); err != nil {
|
|
t.Skip("git not available")
|
|
}
|
|
|
|
// Run init with --remote on already initialized setup
|
|
result := sb.RunCLI("init", "--remote", "git@github.com:test/skills.git")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertRowContains(t, "Remote", "origin → git@github.com:test/skills.git")
|
|
|
|
// Verify remote was added
|
|
cmd = exec.Command("git", "remote", "-v")
|
|
cmd.Dir = sb.SourcePath
|
|
output, err := cmd.Output()
|
|
if err != nil {
|
|
t.Errorf("failed to check git remote: %v", err)
|
|
}
|
|
if !strings.Contains(string(output), "git@github.com:test/skills.git") {
|
|
t.Errorf("remote should be configured, got: %s", output)
|
|
}
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_RemoteFlag_DryRun(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Initialize git in source directory
|
|
cmd := exec.Command("git", "init")
|
|
cmd.Dir = sb.SourcePath
|
|
if err := cmd.Run(); err != nil {
|
|
t.Skip("git not available")
|
|
}
|
|
|
|
result := sb.RunCLI("init", "--remote", "git@github.com:test/skills.git", "--dry-run")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertRowContains(t, "Remote", "would add origin → git@github.com:test/skills.git")
|
|
result.AssertOutputContains(t, "Dry run")
|
|
if _, err := os.Stat(filepath.Join(sb.SourcePath, ".gitignore")); err == nil {
|
|
t.Error("dry run must not write .gitignore into the existing repo")
|
|
}
|
|
|
|
// Verify remote was NOT added
|
|
cmd = exec.Command("git", "remote", "-v")
|
|
cmd.Dir = sb.SourcePath
|
|
output, _ := cmd.Output()
|
|
if strings.Contains(string(output), "github.com") {
|
|
t.Error("dry-run should not add remote")
|
|
}
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_RemoteFlag_AlreadyExists(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Initialize git with existing remote
|
|
cmd := exec.Command("git", "init")
|
|
cmd.Dir = sb.SourcePath
|
|
if err := cmd.Run(); err != nil {
|
|
t.Skip("git not available")
|
|
}
|
|
|
|
cmd = exec.Command("git", "remote", "add", "origin", "git@github.com:existing/repo.git")
|
|
cmd.Dir = sb.SourcePath
|
|
cmd.Run()
|
|
|
|
// Try to add different remote
|
|
result := sb.RunCLI("init", "--remote", "git@github.com:new/repo.git")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertRowContains(t, "Remote", "origin is already git@github.com:existing/repo.git")
|
|
result.AssertOutputContains(t, "remote set-url origin git@github.com:new/repo.git")
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_RemoteFlag_SameRemote(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Initialize git with existing remote
|
|
cmd := exec.Command("git", "init")
|
|
cmd.Dir = sb.SourcePath
|
|
if err := cmd.Run(); err != nil {
|
|
t.Skip("git not available")
|
|
}
|
|
|
|
cmd = exec.Command("git", "remote", "add", "origin", "git@github.com:test/skills.git")
|
|
cmd.Dir = sb.SourcePath
|
|
cmd.Run()
|
|
|
|
// Try to add same remote
|
|
result := sb.RunCLI("init", "--remote", "git@github.com:test/skills.git")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertRowContains(t, "Remote", "already origin → git@github.com:test/skills.git")
|
|
// The repo was created without an identity; init must still commit.
|
|
result.AssertOutputNotContains(t, "Author identity unknown")
|
|
// ...without writing an identity into the user's repo, which would
|
|
// outrank one they set globally later.
|
|
cmd = exec.Command("git", "config", "--local", "user.name")
|
|
cmd.Dir = sb.SourcePath
|
|
if out, err := cmd.Output(); err == nil {
|
|
t.Errorf("expected no repo-local user.name, got %q", strings.TrimSpace(string(out)))
|
|
}
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_RemoteFlag_NoRepo_DryRun(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
result := sb.RunCLI("init", "--remote", "git@github.com:test/skills.git", "--dry-run")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertRowContains(t, "Git", "would initialize in")
|
|
result.AssertRowContains(t, "Remote", "would add origin → git@github.com:test/skills.git")
|
|
result.AssertOutputNotContains(t, "--no-git")
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_RemoteFlag_NoGit_AutoInitsGit(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Config exists but git is NOT initialized (simulates second machine setup)
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
result := sb.RunCLI("init", "--remote", "git@github.com:test/skills.git")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertRowContains(t, "Remote", "origin → git@github.com:test/skills.git")
|
|
|
|
// Verify git was initialized
|
|
gitDir := filepath.Join(sb.SourcePath, ".git")
|
|
if _, err := os.Stat(gitDir); os.IsNotExist(err) {
|
|
t.Error("git should have been auto-initialized")
|
|
}
|
|
|
|
// Verify remote was added
|
|
cmd := exec.Command("git", "remote", "-v")
|
|
cmd.Dir = sb.SourcePath
|
|
output, err := cmd.Output()
|
|
if err != nil {
|
|
t.Errorf("failed to check git remote: %v", err)
|
|
}
|
|
if !strings.Contains(string(output), "git@github.com:test/skills.git") {
|
|
t.Errorf("remote should be configured, got: %s", output)
|
|
}
|
|
}
|
|
|
|
func TestInit_AlreadyInitialized_RemoteFlag_WithNoGit_DoesNotCreateCommit(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Initialize git repo and create initial commit.
|
|
cmd := exec.Command("git", "init")
|
|
cmd.Dir = sb.SourcePath
|
|
if err := cmd.Run(); err != nil {
|
|
t.Skip("git not available")
|
|
}
|
|
testutil.RunGit(t, sb.SourcePath, "config", "user.email", "test@example.com")
|
|
testutil.RunGit(t, sb.SourcePath, "config", "user.name", "Test User")
|
|
|
|
seedDir := filepath.Join(sb.SourcePath, "seed-skill")
|
|
if err := os.MkdirAll(seedDir, 0o755); err != nil {
|
|
t.Fatalf("failed to create seed skill dir: %v", err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(seedDir, "SKILL.md"), []byte("# Seed"), 0o644); err != nil {
|
|
t.Fatalf("failed to write seed SKILL.md: %v", err)
|
|
}
|
|
testutil.RunGit(t, sb.SourcePath, "add", "-A")
|
|
testutil.RunGit(t, sb.SourcePath, "commit", "-m", "initial")
|
|
beforeHead := testutil.RunGit(t, sb.SourcePath, "rev-parse", "HEAD")
|
|
|
|
// Add dirty file that should remain uncommitted when --no-git is used.
|
|
dirtyDir := filepath.Join(sb.SourcePath, "dirty-skill")
|
|
if err := os.MkdirAll(dirtyDir, 0o755); err != nil {
|
|
t.Fatalf("failed to create dirty skill dir: %v", err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(dirtyDir, "SKILL.md"), []byte("# Dirty"), 0o644); err != nil {
|
|
t.Fatalf("failed to write dirty SKILL.md: %v", err)
|
|
}
|
|
|
|
result := sb.RunCLI("init", "--remote", "git@github.com:test/skills.git", "--no-git")
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "--no-git")
|
|
|
|
afterHead := testutil.RunGit(t, sb.SourcePath, "rev-parse", "HEAD")
|
|
if beforeHead != afterHead {
|
|
t.Fatalf("expected no new commit with --no-git, before=%s after=%s", beforeHead, afterHead)
|
|
}
|
|
|
|
status := testutil.RunGit(t, sb.SourcePath, "status", "--porcelain")
|
|
if !strings.Contains(status, "dirty-skill") {
|
|
t.Fatalf("expected dirty file to remain uncommitted, got status: %s", status)
|
|
}
|
|
}
|
|
|
|
// ============================================
|
|
// Non-interactive flag tests
|
|
// ============================================
|
|
|
|
func TestInit_NoCopy_StartsEmpty(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create existing skills directory
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
testSkillPath := filepath.Join(claudeSkillsPath, "my-skill")
|
|
os.MkdirAll(testSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(testSkillPath, "SKILL.md"), []byte("# Test"), 0644)
|
|
|
|
// Run init with --no-copy and --no-targets to skip prompts
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "--no-copy")
|
|
|
|
// Verify skill was NOT copied (only skillshare skill should exist)
|
|
copiedSkillPath := filepath.Join(sb.SourcePath, "my-skill")
|
|
if sb.FileExists(copiedSkillPath) {
|
|
t.Error("skill should NOT be copied when using --no-copy")
|
|
}
|
|
}
|
|
|
|
func TestInit_CopyFromByName(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create existing claude skills directory with a skill
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
testSkillPath := filepath.Join(claudeSkillsPath, "copy-test-skill")
|
|
os.MkdirAll(testSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(testSkillPath, "SKILL.md"), []byte("# Copy Test"), 0644)
|
|
|
|
// Run init with --copy-from claude
|
|
result := sb.RunCLI("init", "--copy-from", "claude", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "1 from claude")
|
|
|
|
// Verify skill was copied
|
|
copiedSkillPath := filepath.Join(sb.SourcePath, "copy-test-skill", "SKILL.md")
|
|
if !sb.FileExists(copiedSkillPath) {
|
|
t.Error("skill should be copied when using --copy-from claude")
|
|
}
|
|
}
|
|
|
|
func TestInit_CopyFromByPath(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create custom skills directory
|
|
customPath := filepath.Join(sb.Home, "custom-skills")
|
|
os.MkdirAll(customPath, 0755)
|
|
testSkillPath := filepath.Join(customPath, "path-test-skill")
|
|
os.MkdirAll(testSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(testSkillPath, "SKILL.md"), []byte("# Path Test"), 0644)
|
|
|
|
// Run init with --copy-from as a path
|
|
result := sb.RunCLI("init", "--copy-from", customPath, "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
// Verify skill was copied
|
|
copiedSkillPath := filepath.Join(sb.SourcePath, "path-test-skill", "SKILL.md")
|
|
if !sb.FileExists(copiedSkillPath) {
|
|
t.Error("skill should be copied when using --copy-from with path")
|
|
}
|
|
}
|
|
|
|
func TestInit_TargetsCSV(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create both claude and cursor directories
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
cursorSkillsPath := filepath.Join(sb.Home, ".cursor", "skills")
|
|
os.MkdirAll(cursorSkillsPath, 0755)
|
|
|
|
// Run init with --targets specifying both
|
|
result := sb.RunCLI("init", "--no-copy", "--targets", "claude,cursor", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Targets claude, cursor")
|
|
|
|
// Verify config has both targets
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "claude:") {
|
|
t.Error("config should contain claude target")
|
|
}
|
|
if !strings.Contains(configContent, "cursor:") {
|
|
t.Error("config should contain cursor target")
|
|
}
|
|
}
|
|
|
|
func TestInit_AllTargets(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create multiple CLI directories
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
cursorSkillsPath := filepath.Join(sb.Home, ".cursor", "skills")
|
|
os.MkdirAll(cursorSkillsPath, 0755)
|
|
|
|
// Run init with --all-targets
|
|
result := sb.RunCLI("init", "--no-copy", "--all-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "universal")
|
|
|
|
// Verify config has targets (including auto-detected universal)
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "claude:") || !strings.Contains(configContent, "cursor:") {
|
|
t.Errorf("config should contain all detected targets, got: %s", configContent)
|
|
}
|
|
if !strings.Contains(configContent, "universal:") {
|
|
t.Errorf("config should auto-include universal target when any CLI is detected, got: %s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_UniversalAutoDetected(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create only a claude skills directory — universal path (~/.agents/) does
|
|
// NOT exist on disk, yet init should auto-include it as a recommended target.
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
|
|
// Remove other sandbox defaults so only claude is detected
|
|
os.RemoveAll(filepath.Join(sb.Home, ".codex"))
|
|
os.RemoveAll(filepath.Join(sb.Home, ".cursor"))
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--all-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
// Verify config includes universal pointing to ~/.agents/skills
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "universal:") {
|
|
t.Errorf("config should contain universal target, got:\n%s", configContent)
|
|
}
|
|
|
|
agentsPath := filepath.Join(sb.Home, ".agents", "skills")
|
|
if !strings.Contains(configContent, agentsPath) {
|
|
t.Errorf("universal target should point to %s, got:\n%s", agentsPath, configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_Discover_UniversalAutoAdded(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Config has claude only, no universal
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
|
|
// Create a new agent directory so detectNewAgents finds something
|
|
cursorSkillsPath := filepath.Join(sb.Home, ".cursor", "skills")
|
|
os.MkdirAll(cursorSkillsPath, 0755)
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets:
|
|
claude:
|
|
path: ` + claudeSkillsPath + `
|
|
`)
|
|
|
|
// Run discover with --select cursor — universal should also appear as candidate
|
|
result := sb.RunCLI("init", "--discover", "--select", "cursor,universal")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
// Verify config now has both cursor and universal
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "cursor:") {
|
|
t.Errorf("config should contain cursor target, got:\n%s", configContent)
|
|
}
|
|
if !strings.Contains(configContent, "universal:") {
|
|
t.Errorf("config should contain universal target (auto-added candidate), got:\n%s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_NoTargets(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create a CLI directory
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
|
|
// Run init with --no-targets
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "--no-targets")
|
|
|
|
// Verify config has empty targets
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if strings.Contains(configContent, "claude:") {
|
|
t.Error("config should NOT contain any targets when using --no-targets")
|
|
}
|
|
}
|
|
|
|
func TestInit_NoGit_SkipsGitInit(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Run init with --no-git
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "--no-git")
|
|
|
|
// Verify .git was NOT created
|
|
gitDir := filepath.Join(sb.SourcePath, ".git")
|
|
if sb.FileExists(gitDir) {
|
|
t.Error(".git directory should NOT exist when using --no-git")
|
|
}
|
|
}
|
|
|
|
func TestInit_GitFlag_InitializesGit(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Run init with --git
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
// Verify .git was created
|
|
gitDir := filepath.Join(sb.SourcePath, ".git")
|
|
if !sb.FileExists(gitDir) {
|
|
t.Error(".git directory should exist when using --git")
|
|
}
|
|
}
|
|
|
|
func TestInit_MutualExclusion_CopyFromAndNoCopy(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Run init with both --copy-from and --no-copy
|
|
result := sb.RunCLI("init", "--copy-from", "claude", "--no-copy")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "mutually exclusive")
|
|
}
|
|
|
|
func TestInit_MutualExclusion_TargetsFlags(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Run init with both --targets and --all-targets
|
|
result := sb.RunCLI("init", "--no-copy", "--targets", "claude", "--all-targets", "--no-git")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "mutually exclusive")
|
|
}
|
|
|
|
func TestInit_MutualExclusion_GitFlags(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Run init with both --git and --no-git
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--git", "--no-git", "--no-skill")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "mutually exclusive")
|
|
}
|
|
|
|
func TestInit_FullNonInteractive(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create existing skills
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
testSkillPath := filepath.Join(claudeSkillsPath, "full-test")
|
|
os.MkdirAll(testSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(testSkillPath, "SKILL.md"), []byte("# Full Test"), 0644)
|
|
|
|
// Full non-interactive: copy from claude, all targets, with git, no skill
|
|
result := sb.RunCLI("init", "--copy-from", "claude", "--all-targets", "--git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "✓ Config")
|
|
|
|
// Verify skill was copied
|
|
if !sb.FileExists(filepath.Join(sb.SourcePath, "full-test", "SKILL.md")) {
|
|
t.Error("skill should be copied")
|
|
}
|
|
|
|
// Verify git was initialized
|
|
if !sb.FileExists(filepath.Join(sb.SourcePath, ".git")) {
|
|
t.Error(".git should exist")
|
|
}
|
|
|
|
// Verify config has target
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "claude:") {
|
|
t.Error("config should contain claude target")
|
|
}
|
|
}
|
|
|
|
// ============================================
|
|
// Discover mode tests
|
|
// ============================================
|
|
|
|
func TestInit_AlreadyInitialized_ErrorMentionsDiscover(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create config to simulate already initialized
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
result := sb.RunCLI("init")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "--discover")
|
|
}
|
|
|
|
func TestInit_Discover_NoNewAgents(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Remove extra agent directories that sandbox creates by default
|
|
os.RemoveAll(filepath.Join(sb.Home, ".codex"))
|
|
os.RemoveAll(filepath.Join(sb.Home, ".cursor"))
|
|
|
|
// Create config with claude target (the only agent)
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets:
|
|
claude:
|
|
path: ` + claudeSkillsPath + `
|
|
`)
|
|
|
|
// Run discover - no new agents should be found since only claude exists and is already configured
|
|
result := sb.RunCLI("init", "--discover")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "No new AI tools found")
|
|
}
|
|
|
|
func TestInit_Discover_DoesNotExpandSharedDirectoryTargets(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sharedParent := filepath.Join(sb.Home, ".agents")
|
|
os.MkdirAll(sharedParent, 0755)
|
|
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
codexSkillsPath := filepath.Join(sb.Home, ".codex", "skills")
|
|
cursorSkillsPath := filepath.Join(sb.Home, ".cursor", "skills")
|
|
copilotSkillsPath := filepath.Join(sb.Home, ".copilot", "skills")
|
|
universalSkillsPath := filepath.Join(sharedParent, "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
os.MkdirAll(codexSkillsPath, 0755)
|
|
os.MkdirAll(cursorSkillsPath, 0755)
|
|
os.MkdirAll(copilotSkillsPath, 0755)
|
|
// gemini has a path of its own, so discover has at least one genuinely new
|
|
// agent to offer — codex resolves to the already-configured universal target.
|
|
os.MkdirAll(filepath.Join(sb.Home, ".gemini", "skills"), 0755)
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets:
|
|
claude:
|
|
path: ` + claudeSkillsPath + `
|
|
cursor:
|
|
path: ` + cursorSkillsPath + `
|
|
copilot:
|
|
path: ` + copilotSkillsPath + `
|
|
universal:
|
|
path: ` + universalSkillsPath + `
|
|
`)
|
|
|
|
result := sb.RunCLI("init", "--discover", "--select", "zed")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "zed was not found on this machine")
|
|
result.AssertOutputNotContains(t, "✓ Targets")
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if strings.Contains(configContent, "zed:") {
|
|
t.Errorf("config should not contain zed target, got:\n%s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_Discover_WithSelect_AddsNewAgent(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create initial config with claude only
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets:
|
|
claude:
|
|
path: ` + claudeSkillsPath + `
|
|
`)
|
|
|
|
// Create cursor directory (new agent)
|
|
cursorSkillsPath := filepath.Join(sb.Home, ".cursor", "skills")
|
|
os.MkdirAll(cursorSkillsPath, 0755)
|
|
|
|
// Run discover with --select
|
|
result := sb.RunCLI("init", "--discover", "--select", "cursor")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Targets cursor")
|
|
|
|
// Verify config now has cursor
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "cursor:") {
|
|
t.Errorf("config should contain cursor target, got: %s", configContent)
|
|
}
|
|
// Should still have claude
|
|
if !strings.Contains(configContent, "claude:") {
|
|
t.Errorf("config should still contain claude target, got: %s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_Discover_WithMode_OnlyAppliesToNewTargets(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
cursorSkillsPath := filepath.Join(sb.Home, ".cursor", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
os.MkdirAll(cursorSkillsPath, 0755)
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
mode: merge
|
|
targets:
|
|
claude:
|
|
path: ` + claudeSkillsPath + `
|
|
mode: symlink
|
|
`)
|
|
|
|
result := sb.RunCLI("init", "--discover", "--select", "cursor", "--mode", "copy")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Targets cursor")
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "mode: symlink") {
|
|
t.Errorf("existing target mode should remain unchanged, got:\n%s", configContent)
|
|
}
|
|
if !strings.Contains(configContent, "cursor:") || !strings.Contains(configContent, "mode: copy") {
|
|
t.Errorf("new target should be added with mode copy, got:\n%s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_Discover_WithSelect_MultipleAgents(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create initial config with no targets
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Create multiple agent directories
|
|
os.MkdirAll(filepath.Join(sb.Home, ".claude", "skills"), 0755)
|
|
os.MkdirAll(filepath.Join(sb.Home, ".cursor", "skills"), 0755)
|
|
os.MkdirAll(filepath.Join(sb.Home, ".codex", "skills"), 0755)
|
|
|
|
// Run discover with --select for multiple agents
|
|
result := sb.RunCLI("init", "--discover", "--select", "claude,cursor")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Targets claude, cursor")
|
|
|
|
// Verify config has both
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "claude:") {
|
|
t.Error("config should contain claude target")
|
|
}
|
|
if !strings.Contains(configContent, "cursor:") {
|
|
t.Error("config should contain cursor target")
|
|
}
|
|
// Should NOT have codex (not selected)
|
|
if strings.Contains(configContent, "codex:") {
|
|
t.Error("config should NOT contain codex target")
|
|
}
|
|
}
|
|
|
|
func TestInit_Discover_DryRun(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create initial config
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Create new agent directory
|
|
os.MkdirAll(filepath.Join(sb.Home, ".cursor", "skills"), 0755)
|
|
|
|
// Run discover with --dry-run
|
|
result := sb.RunCLI("init", "--discover", "--select", "cursor", "--dry-run")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Dry run")
|
|
|
|
// Verify config was NOT modified
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if strings.Contains(configContent, "cursor:") {
|
|
t.Error("dry-run should NOT add cursor to config")
|
|
}
|
|
}
|
|
|
|
func TestInit_Select_RequiresDiscover(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Run init with --select but without --discover
|
|
result := sb.RunCLI("init", "--select", "cursor")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "--select requires --discover")
|
|
}
|
|
|
|
func TestInit_Discover_SkipsAlreadyConfigured(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create config with claude already
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets:
|
|
claude:
|
|
path: ` + claudeSkillsPath + `
|
|
`)
|
|
|
|
// Try to add claude again via --select
|
|
result := sb.RunCLI("init", "--discover", "--select", "claude")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "claude is already set up")
|
|
}
|
|
|
|
func TestInit_Discover_UnknownAgent(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Create initial config
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
// Try to add unknown agent
|
|
result := sb.RunCLI("init", "--discover", "--select", "unknownagent")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Unknown AI tool: unknownagent")
|
|
}
|
|
|
|
func TestInit_ModeFlag_SetsDefaultMode(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--mode", "copy", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "mode: copy") {
|
|
t.Errorf("config should contain mode: copy, got:\n%s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_ModeFlag_Invalid(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--mode", "invalid", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "invalid --mode value")
|
|
}
|
|
|
|
// ============================================
|
|
// Skill flag tests
|
|
// ============================================
|
|
|
|
func TestInit_NoSkill_SkipsInstall(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "--no-skill")
|
|
|
|
// Verify skill was NOT installed
|
|
skillPath := filepath.Join(sb.SourcePath, "skillshare", "SKILL.md")
|
|
if sb.FileExists(skillPath) {
|
|
t.Error("skill should NOT be installed when using --no-skill")
|
|
}
|
|
}
|
|
|
|
func TestInit_SkillFlag_InstallsSkill(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
// Verify skill was installed (either downloaded or fallback)
|
|
skillPath := filepath.Join(sb.SourcePath, "skillshare", "SKILL.md")
|
|
if !sb.FileExists(skillPath) {
|
|
t.Error("skill should be installed when using --skill")
|
|
}
|
|
}
|
|
|
|
func TestInit_Fresh_ConfigHasSchemaComment(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
result.AssertSuccess(t)
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
firstLine := strings.SplitN(configContent, "\n", 2)[0]
|
|
if !strings.HasPrefix(firstLine, "# yaml-language-server: $schema=") {
|
|
t.Errorf("config should start with schema comment, got first line: %q", firstLine)
|
|
}
|
|
}
|
|
|
|
func TestInit_SuccessMessage_ShowsNextSteps(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "skillshare install <repo>")
|
|
}
|
|
|
|
// ============================================
|
|
// --subdir flag tests (global mode only)
|
|
// ============================================
|
|
|
|
func TestInit_Subdir_SetsSourcePath(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--subdir", "skills", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "✓ Config")
|
|
|
|
// Verify config source ends with /skills (the subdir)
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
expectedSuffix := filepath.Join("skillshare", "skills", "skills")
|
|
if !strings.Contains(configContent, expectedSuffix) {
|
|
t.Errorf("config source should end with skills/skills (subdir appended), got:\n%s", configContent)
|
|
}
|
|
|
|
// Verify subdirectory was created
|
|
subdirPath := filepath.Join(sb.SourcePath, "skills")
|
|
if !sb.FileExists(subdirPath) {
|
|
t.Error("subdir should be created inside source path")
|
|
}
|
|
}
|
|
|
|
func TestInit_Subdir_ListFindsSkillsInSubdir(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Init with --subdir
|
|
result := sb.RunCLI("init", "--subdir", "skills", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
result.AssertSuccess(t)
|
|
|
|
// Create a skill inside the subdir
|
|
subdirSkillPath := filepath.Join(sb.SourcePath, "skills", "subdir-skill")
|
|
os.MkdirAll(subdirSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(subdirSkillPath, "SKILL.md"), []byte("---\nname: subdir-skill\ndescription: test\n---\n# Test"), 0644)
|
|
|
|
// List should find the skill
|
|
listResult := sb.RunCLI("list", "--no-tui")
|
|
listResult.AssertSuccess(t)
|
|
listResult.AssertOutputContains(t, "subdir-skill")
|
|
}
|
|
|
|
func TestInit_Subdir_SyncWorksWithSubdir(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Create a claude target directory
|
|
claudeSkillsPath := filepath.Join(sb.Home, ".claude", "skills")
|
|
os.MkdirAll(claudeSkillsPath, 0755)
|
|
|
|
// Init with --subdir and a target
|
|
result := sb.RunCLI("init", "--subdir", "myskills", "--no-copy", "--targets", "claude", "--no-git", "--no-skill")
|
|
result.AssertSuccess(t)
|
|
|
|
// Create a skill inside the subdir
|
|
subdirSkillPath := filepath.Join(sb.SourcePath, "myskills", "sync-test")
|
|
os.MkdirAll(subdirSkillPath, 0755)
|
|
os.WriteFile(filepath.Join(subdirSkillPath, "SKILL.md"), []byte("---\nname: sync-test\ndescription: test\n---\n# Sync Test"), 0644)
|
|
|
|
// Sync should work
|
|
syncResult := sb.RunCLI("sync", "--no-tui")
|
|
syncResult.AssertSuccess(t)
|
|
syncResult.AssertOutputContains(t, "Synced 1 skill")
|
|
|
|
// Verify symlink was created in target
|
|
symlinkPath := filepath.Join(claudeSkillsPath, "sync-test")
|
|
if _, err := os.Lstat(symlinkPath); os.IsNotExist(err) {
|
|
t.Error("skill symlink should be created in target after sync")
|
|
}
|
|
}
|
|
|
|
func TestInit_Subdir_ForcesGlobalModeInProjectDir(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
// Simulate a project directory with .skillshare/config.yaml
|
|
projectDir := filepath.Join(sb.Home, "myproject")
|
|
os.MkdirAll(filepath.Join(projectDir, ".skillshare"), 0755)
|
|
os.WriteFile(filepath.Join(projectDir, ".skillshare", "config.yaml"), []byte("skills: []\ntargets: {}\n"), 0644)
|
|
|
|
// Remove global config so init can run fresh
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Run init --subdir from inside the project directory
|
|
// Without the fix, this would route to project mode and fail with "unknown option"
|
|
result := sb.RunCLIInDir(projectDir, "init", "--subdir", "skills", "--no-copy", "--no-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "✓ Config")
|
|
}
|
|
|
|
func TestInit_Subdir_DryRunDoesNotCreate(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
os.RemoveAll(sb.SourcePath)
|
|
|
|
result := sb.RunCLI("init", "--subdir", "skills", "--no-copy", "--no-targets", "--no-git", "--no-skill", "--dry-run")
|
|
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "Dry run")
|
|
|
|
// Config should not exist
|
|
if sb.FileExists(sb.ConfigPath) {
|
|
t.Error("dry-run should not create config")
|
|
}
|
|
}
|
|
|
|
func TestInit_MutualExclusion_SkillFlags(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--no-targets", "--no-git", "--skill", "--no-skill")
|
|
|
|
result.AssertFailure(t)
|
|
result.AssertAnyOutputContains(t, "mutually exclusive")
|
|
}
|
|
|
|
// ============================================
|
|
// Codex shares the universal ~/.agents/skills path
|
|
// ============================================
|
|
|
|
func TestInit_CodexOnly_AddsUniversalInsteadOfCodex(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Only ~/.codex exists (created by the sandbox); Codex reads ~/.agents/skills,
|
|
// so it must be credited to the universal target, not a codex target.
|
|
os.RemoveAll(filepath.Join(sb.Home, ".claude"))
|
|
os.RemoveAll(filepath.Join(sb.Home, ".cursor"))
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--all-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "universal:") {
|
|
t.Errorf("config should contain universal target, got:\n%s", configContent)
|
|
}
|
|
if strings.Contains(configContent, "codex:") {
|
|
t.Errorf("config should not contain a separate codex target, got:\n%s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_CodexAndClaude_AddsClaudeAndUniversal(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
os.RemoveAll(filepath.Join(sb.Home, ".cursor"))
|
|
os.MkdirAll(filepath.Join(sb.Home, ".claude", "skills"), 0755)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--all-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
for _, want := range []string{"claude:", "universal:"} {
|
|
if !strings.Contains(configContent, want) {
|
|
t.Errorf("config should contain %s, got:\n%s", want, configContent)
|
|
}
|
|
}
|
|
if strings.Contains(configContent, "codex:") {
|
|
t.Errorf("config should not contain a separate codex target, got:\n%s", configContent)
|
|
}
|
|
}
|
|
|
|
func TestInit_TargetsCodex_UsesAgentsPath(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--targets", "codex", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
agentsPath := filepath.Join(sb.Home, ".agents", "skills")
|
|
if !strings.Contains(configContent, agentsPath) {
|
|
t.Errorf("codex target should point to %s, got:\n%s", agentsPath, configContent)
|
|
}
|
|
}
|
|
|
|
func TestSync_CodexTarget_WritesToAgentsPath(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
sb.RunCLI("init", "--no-copy", "--targets", "codex", "--no-git", "--no-skill").AssertSuccess(t)
|
|
sb.CreateSkill("codex-skill", map[string]string{"SKILL.md": "# Codex Skill"})
|
|
|
|
sb.RunCLI("sync").AssertSuccess(t)
|
|
|
|
if !sb.IsSymlink(filepath.Join(sb.Home, ".agents", "skills", "codex-skill")) {
|
|
t.Error("skill should be linked into ~/.agents/skills")
|
|
}
|
|
if sb.FileExists(filepath.Join(sb.Home, ".codex", "skills", "codex-skill")) {
|
|
t.Error("skill should not be written to the deprecated ~/.codex/skills")
|
|
}
|
|
}
|
|
|
|
func TestInit_GooseOnly_AddsUniversalInsteadOfGoose(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
|
|
// Goose now reads ~/.agents/skills, so only ~/.config/goose identifies it
|
|
// and the detection must be credited to the universal target.
|
|
for _, dir := range []string{".claude", ".codex", ".cursor"} {
|
|
os.RemoveAll(filepath.Join(sb.Home, dir))
|
|
}
|
|
os.MkdirAll(filepath.Join(sb.Home, ".config", "goose"), 0755)
|
|
|
|
result := sb.RunCLI("init", "--no-copy", "--all-targets", "--no-git", "--no-skill")
|
|
|
|
result.AssertSuccess(t)
|
|
|
|
configContent := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(configContent, "universal:") {
|
|
t.Errorf("config should contain universal target, got:\n%s", configContent)
|
|
}
|
|
if strings.Contains(configContent, "goose:") {
|
|
t.Errorf("config should not contain a separate goose target, got:\n%s", configContent)
|
|
}
|
|
}
|
|
|
|
// ============================================
|
|
// Headless defaults (no terminal: every question takes its default)
|
|
// ============================================
|
|
|
|
func TestInit_Headless_NoFlags_AppliesDefaults(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
claudeSkill := filepath.Join(sb.Home, ".claude", "skills", "my-skill")
|
|
os.MkdirAll(claudeSkill, 0755)
|
|
os.WriteFile(filepath.Join(claudeSkill, "SKILL.md"), []byte("---\nname: my-skill\n---\n# Mine\n"), 0644)
|
|
|
|
result := sb.RunCLI("init")
|
|
result.AssertSuccess(t)
|
|
|
|
cfg := sb.ReadFile(sb.ConfigPath)
|
|
if !strings.Contains(cfg, "claude:") {
|
|
t.Errorf("detected tools should become targets, got:\n%s", cfg)
|
|
}
|
|
if !sb.FileExists(filepath.Join(sb.SourcePath, "my-skill", "SKILL.md")) {
|
|
t.Error("existing skills should be imported")
|
|
}
|
|
if !sb.FileExists(filepath.Join(sb.SourcePath, ".git")) {
|
|
t.Error("git should be initialized")
|
|
}
|
|
if !sb.FileExists(filepath.Join(sb.SourcePath, "skillshare", "SKILL.md")) {
|
|
t.Error("built-in skill should be installed")
|
|
}
|
|
if !sb.IsSymlink(claudeSkill) {
|
|
t.Error("the tool's copy matches the source, so sync should replace it with a link")
|
|
}
|
|
}
|
|
|
|
func TestInit_Headless_RemoteWithSameNameSkill_UsesRepoVersion(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
remote := createSkillsRemote(t, sb.Root, map[string]string{"pdf-tools": "repo version", "tdd": "repo tdd"})
|
|
local := filepath.Join(sb.Home, ".claude", "skills", "pdf-tools")
|
|
os.MkdirAll(local, 0755)
|
|
os.WriteFile(filepath.Join(local, "SKILL.md"), []byte("local version"), 0644)
|
|
|
|
result := sb.RunCLI("init", "--remote", remote, "--no-skill")
|
|
result.AssertSuccess(t)
|
|
result.AssertOutputContains(t, "repo version used for pdf-tools")
|
|
|
|
if got := sb.ReadFile(filepath.Join(sb.SourcePath, "pdf-tools", "SKILL.md")); got != "repo version" {
|
|
t.Errorf("same-name skill should keep the repo version, got %q", got)
|
|
}
|
|
if !sb.FileExists(filepath.Join(sb.SourcePath, "tdd", "SKILL.md")) {
|
|
t.Error("the repo's other skills should be pulled")
|
|
}
|
|
}
|
|
|
|
func TestInit_DryRun_DoesNotCreateToolFolders(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
os.Remove(sb.ConfigPath)
|
|
os.RemoveAll(filepath.Join(sb.Home, ".cursor"))
|
|
os.MkdirAll(filepath.Join(sb.Home, ".cursor"), 0755)
|
|
|
|
result := sb.RunCLI("init", "--dry-run")
|
|
result.AssertSuccess(t)
|
|
|
|
if sb.FileExists(filepath.Join(sb.Home, ".cursor", "skills")) {
|
|
t.Error("detection must not create a tool's skills folder")
|
|
}
|
|
}
|
|
|
|
// createSkillsRemote makes a bare repo whose top level holds the given
|
|
// skills (name → SKILL.md content) and returns its file:// URL.
|
|
func createSkillsRemote(t *testing.T, root string, skills map[string]string) string {
|
|
t.Helper()
|
|
work := filepath.Join(root, "remote-work")
|
|
bare := filepath.Join(root, "remote.git")
|
|
for name, content := range skills {
|
|
os.MkdirAll(filepath.Join(work, name), 0755)
|
|
os.WriteFile(filepath.Join(work, name, "SKILL.md"), []byte(content), 0644)
|
|
}
|
|
for _, args := range [][]string{
|
|
{"init", "-q", "-b", "main"},
|
|
{"add", "."},
|
|
{"-c", "user.name=t", "-c", "user.email=t@t", "commit", "-qm", "skills"},
|
|
{"clone", "-q", "--bare", ".", bare},
|
|
} {
|
|
cmd := exec.Command("git", args...)
|
|
cmd.Dir = work
|
|
if out, err := cmd.CombinedOutput(); err != nil {
|
|
t.Fatalf("git %v: %v (%s)", args, err, out)
|
|
}
|
|
}
|
|
return "file://" + bare
|
|
}
|