mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-18 18:04:17 +00:00
* fix(check): compare project-relative local sources and record install layout Project installs record a local source as typed (./vendor/skill), relative to the project root, so check skipped them. Resolve them against the project root in both the CLI and the dashboard. The copied shape of a local install was inferred from its file hashes, so a CLI install whose source held only SKILL.md looked like a dashboard collection-root install: a child skill added at the source later was neither reported by check nor copied by update. Record the layout (skill-file or directory) at install time and keep the hash heuristic only for entries written before the field existed. * fix(install): let a recorded layout decide the update shape without hashes An entry whose hashing failed at install time still knows what was copied; returning false there would turn a SKILL.md-only update into a full copy.
133 lines
4.7 KiB
Go
133 lines
4.7 KiB
Go
package server
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"skillshare/internal/config"
|
|
"skillshare/internal/install"
|
|
)
|
|
|
|
func TestHandleCheck_EmptySource(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/check", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
TrackedRepos []any `json:"tracked_repos"`
|
|
Skills []any `json:"skills"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.TrackedRepos) != 0 {
|
|
t.Errorf("expected 0 tracked repos, got %d", len(resp.TrackedRepos))
|
|
}
|
|
if len(resp.Skills) != 0 {
|
|
t.Errorf("expected 0 skills, got %d", len(resp.Skills))
|
|
}
|
|
}
|
|
|
|
// addTrackedRepoWithBrokenIndex clones a tracked repo from a local origin and
|
|
// corrupts its index, so `git status` fails while `git fetch` still succeeds.
|
|
func addTrackedRepoWithBrokenIndex(t *testing.T, sourceDir, name string) string {
|
|
t.Helper()
|
|
seed := t.TempDir()
|
|
initGitRepo(t, seed)
|
|
origin := filepath.Join(t.TempDir(), "origin.git")
|
|
runGit(t, seed, "clone", "--bare", seed, origin)
|
|
runGit(t, sourceDir, "clone", origin, name)
|
|
repoDir := filepath.Join(sourceDir, name)
|
|
// fetch reads the index for submodule recursion unless it is disabled.
|
|
runGit(t, repoDir, "config", "fetch.recurseSubmodules", "false")
|
|
if err := os.WriteFile(filepath.Join(repoDir, ".git", "index"), []byte("corrupt"), 0644); err != nil {
|
|
t.Fatalf("corrupt index: %v", err)
|
|
}
|
|
return repoDir
|
|
}
|
|
|
|
func TestHandleCheck_DirtyCheckErrorReported(t *testing.T) {
|
|
s, src := newTestServer(t)
|
|
addTrackedRepoWithBrokenIndex(t, src, "_team")
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/check", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
var resp struct {
|
|
TrackedRepos []repoCheckResult `json:"tracked_repos"`
|
|
}
|
|
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("failed to decode response: %v", err)
|
|
}
|
|
if len(resp.TrackedRepos) != 1 || resp.TrackedRepos[0].Status != "error" {
|
|
t.Fatalf("expected one repo with status error, got %+v", resp.TrackedRepos)
|
|
}
|
|
}
|
|
|
|
// TestURLBranchGroupRemoteHash_DefaultBranchUsesAuth verifies that a skill
|
|
// without a pinned branch still probes the remote HEAD with token auth, as the
|
|
// CLI check does. The fake git answers ls-remote only when the auth env
|
|
// carries the token.
|
|
func TestURLBranchGroupRemoteHash_DefaultBranchUsesAuth(t *testing.T) {
|
|
const token = "ghp_check_default_branch_token"
|
|
fakeBin := t.TempDir()
|
|
script := "#!/bin/sh\n" +
|
|
"case \"$GIT_CONFIG_KEY_0\" in *" + token + "*) ;; *) echo 'fatal: Authentication failed' >&2; exit 128;; esac\n" +
|
|
"printf '0123456789abcdef0123456789abcdef01234567\\tHEAD\\n'\n"
|
|
if err := os.WriteFile(filepath.Join(fakeBin, "git"), []byte(script), 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Setenv("PATH", fakeBin+string(os.PathListSeparator)+os.Getenv("PATH"))
|
|
t.Setenv("GIT_CONFIG_COUNT", "")
|
|
t.Setenv("GITHUB_TOKEN", token)
|
|
|
|
hash, err := urlBranchGroup{url: "https://github.com/org/private-skills.git"}.remoteHash()
|
|
if err != nil {
|
|
t.Fatalf("remoteHash without branch failed: %v", err)
|
|
}
|
|
if !strings.HasPrefix("0123456789abcdef0123456789abcdef01234567", hash) || hash == "" {
|
|
t.Fatalf("unexpected hash %q", hash)
|
|
}
|
|
}
|
|
|
|
func TestHandleCheck_ProjectRelativeLocalSourceIsCompared(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
projectRoot := t.TempDir()
|
|
skillsDir := filepath.Join(projectRoot, ".skillshare", "skills")
|
|
os.MkdirAll(skillsDir, 0755)
|
|
s.projectRoot = projectRoot
|
|
s.projectCfg = &config.ProjectConfig{}
|
|
if err := s.projectCfg.Save(projectRoot); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
vendor := filepath.Join(projectRoot, "vendor", "team-skill")
|
|
os.MkdirAll(vendor, 0755)
|
|
os.WriteFile(filepath.Join(vendor, "SKILL.md"), []byte("---\nname: team-skill\n---\n# v1"), 0644)
|
|
// Project installs record the source as typed, relative to the project root.
|
|
source := &install.Source{Type: install.SourceTypeLocalPath, Raw: "./vendor/team-skill", Path: vendor, Name: "team-skill"}
|
|
if _, err := install.Install(source, filepath.Join(skillsDir, "team-skill"), install.InstallOptions{SourceDir: skillsDir, SkipAudit: true}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
os.WriteFile(filepath.Join(vendor, "SKILL.md"), []byte("---\nname: team-skill\n---\n# v2"), 0644)
|
|
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, httptest.NewRequest(http.MethodGet, "/api/check", nil))
|
|
|
|
if !strings.Contains(rr.Body.String(), `"status":"update_available"`) {
|
|
t.Errorf("expected update_available for the relative source, got %s", rr.Body.String())
|
|
}
|
|
}
|