mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
filepath.Walk fails on Windows NTFS junctions with "Incorrect function" because os.Lstat returns nil info, bypassing all junction-detection logic and crashing the entire backup for that target. This means one unreadable junction prevents ALL local skills from being backed up. Replace with os.ReadDir + os.Lstat so junctions are identified and skipped before any read attempt. Also add Windows CI and unit tests for copyDir. Fixes runkids/skillshare#7
191 lines
4.2 KiB
Go
191 lines
4.2 KiB
Go
package backup
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"sort"
|
|
"time"
|
|
)
|
|
|
|
// BackupDir returns the backup directory path.
|
|
// Returns empty string if home directory cannot be determined.
|
|
func BackupDir() string {
|
|
home, err := os.UserHomeDir()
|
|
if err != nil {
|
|
return ""
|
|
}
|
|
return filepath.Join(home, ".config", "skillshare", "backups")
|
|
}
|
|
|
|
// Create creates a backup of the target directory
|
|
// Returns the backup path
|
|
func Create(targetName, targetPath string) (string, error) {
|
|
backupDir := BackupDir()
|
|
if backupDir == "" {
|
|
return "", fmt.Errorf("cannot determine backup directory: home directory not found")
|
|
}
|
|
|
|
// Check if target exists and has content
|
|
info, err := os.Lstat(targetPath)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
return "", nil // Nothing to backup
|
|
}
|
|
return "", err
|
|
}
|
|
|
|
// Skip if it's already a symlink (no local data to backup)
|
|
if info.Mode()&os.ModeSymlink != 0 {
|
|
return "", nil
|
|
}
|
|
|
|
// Check if directory has any content
|
|
entries, err := os.ReadDir(targetPath)
|
|
if err != nil || len(entries) == 0 {
|
|
return "", nil // Empty, nothing to backup
|
|
}
|
|
|
|
// Create backup directory with timestamp
|
|
timestamp := time.Now().Format("2006-01-02_15-04-05")
|
|
backupPath := filepath.Join(backupDir, timestamp, targetName)
|
|
|
|
if err := os.MkdirAll(backupPath, 0755); err != nil {
|
|
return "", fmt.Errorf("failed to create backup directory: %w", err)
|
|
}
|
|
|
|
// Copy target contents to backup
|
|
if err := copyDir(targetPath, backupPath); err != nil {
|
|
return "", fmt.Errorf("failed to backup: %w", err)
|
|
}
|
|
|
|
return backupPath, nil
|
|
}
|
|
|
|
// List returns all backups sorted by date (newest first)
|
|
func List() ([]BackupInfo, error) {
|
|
backupDir := BackupDir()
|
|
if backupDir == "" {
|
|
return nil, fmt.Errorf("cannot determine backup directory: home directory not found")
|
|
}
|
|
|
|
entries, err := os.ReadDir(backupDir)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
return nil, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
var backups []BackupInfo
|
|
for _, entry := range entries {
|
|
if !entry.IsDir() {
|
|
continue
|
|
}
|
|
|
|
backupPath := filepath.Join(backupDir, entry.Name())
|
|
info, err := entry.Info()
|
|
if err != nil {
|
|
continue
|
|
}
|
|
|
|
// List targets in this backup
|
|
targetEntries, _ := os.ReadDir(backupPath)
|
|
var targets []string
|
|
for _, t := range targetEntries {
|
|
if t.IsDir() {
|
|
targets = append(targets, t.Name())
|
|
}
|
|
}
|
|
|
|
backups = append(backups, BackupInfo{
|
|
Timestamp: entry.Name(),
|
|
Path: backupPath,
|
|
Targets: targets,
|
|
Date: info.ModTime(),
|
|
})
|
|
}
|
|
|
|
// Sort by date (newest first)
|
|
sort.Slice(backups, func(i, j int) bool {
|
|
return backups[i].Date.After(backups[j].Date)
|
|
})
|
|
|
|
return backups, nil
|
|
}
|
|
|
|
// BackupInfo holds information about a backup
|
|
type BackupInfo struct {
|
|
Timestamp string
|
|
Path string
|
|
Targets []string
|
|
Date time.Time
|
|
}
|
|
|
|
// copyDir copies a directory recursively, skipping symlinks and junctions.
|
|
// Uses os.ReadDir + os.Lstat instead of filepath.Walk to avoid failures
|
|
// when os.Lstat on Windows junctions returns nil info with an error.
|
|
func copyDir(src, dst string) error {
|
|
if err := os.MkdirAll(dst, 0755); err != nil {
|
|
return err
|
|
}
|
|
|
|
entries, err := os.ReadDir(src)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, entry := range entries {
|
|
srcPath := filepath.Join(src, entry.Name())
|
|
dstPath := filepath.Join(dst, entry.Name())
|
|
|
|
// Use Lstat to detect symlinks/junctions without following them
|
|
info, err := os.Lstat(srcPath)
|
|
if err != nil {
|
|
// Cannot stat (e.g. broken junction on Windows) — skip
|
|
continue
|
|
}
|
|
|
|
// Skip symlinks and junctions — they point to source, not local data
|
|
if info.Mode()&os.ModeSymlink != 0 {
|
|
continue
|
|
}
|
|
|
|
if info.IsDir() {
|
|
if err := copyDir(srcPath, dstPath); err != nil {
|
|
return err
|
|
}
|
|
} else if info.Mode().IsRegular() {
|
|
if err := copyFile(srcPath, dstPath); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// copyFile copies a single file
|
|
func copyFile(src, dst string) error {
|
|
srcFile, err := os.Open(src)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer srcFile.Close()
|
|
|
|
srcInfo, err := srcFile.Stat()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
dstFile, err := os.OpenFile(dst, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, srcInfo.Mode())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer dstFile.Close()
|
|
|
|
_, err = io.Copy(dstFile, srcFile)
|
|
return err
|
|
}
|