Files
skillshare/internal/server/handler_mcp_test.go
T
Willie bfc402fe96 feat(mcp): open an Agent's MCP config folder, and project files, from the dashboard (#554)
* feat(mcp): open an Agent's MCP config folder, and project files, from the dashboard

A user who wants their own editor (Notepad++ on Windows) found setting
both PATH and $EDITOR too much just to open a config file, and could not
find any entry point for the MCP files of an mcp.projects root (#538).

Each Agent row on the MCP page now also has Open folder, which opens the
folder holding the file in the file manager, so any program can open it
from there. Before the Agent has written its file, it opens the closest
folder that exists. The project MCP tab gets the same Agents list for
that project's files. The open endpoint resolves project paths from the
config, as it does global ones, so a request still cannot name another
file, and folder and file opens keep the same-machine and headless
guards. The file manager launch is shared with the extensions folder.

* fix(mcp): keep a project's existing Agent files listed for remote viewers

Codex review: the project MCP tab built its Agents list from the
project's targets plus the files this viewer could open. A viewer on a
LAN address or behind a proxy can open none, so an existing file of an
Agent outside the project's targets dropped off the list, although the
docs say it shows with its path and only the open buttons go.

The list now returns which files exist apart from whether this viewer
may open them, and the page shows the open buttons only when local.

* fix(mcp): list the Agents a project's own servers write to in its file rail

Codex review: a server that exists only in one project can pick Agents
outside the project's targets, and sync writes their project files, but
the project tab listed only the project's targets and files that already
existed. Before the first sync such an Agent had no row, so its path
could not be copied and its folder could not be opened.

The list now also takes the targets of the project's own servers. Global
servers reach a project only through its targets, so they add nothing.
The rule lives in mcpView as projectFileTargets, with a unit test.
2026-10-13 15:00:39 +08:00

384 lines
15 KiB
Go

package server
import (
"encoding/json"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"slices"
"strings"
"testing"
syncpkg "skillshare/internal/sync"
)
func TestMCPPiImportSourceSelection(t *testing.T) {
s, sourceDir := newTestServerWithExtras(t, nil, "")
home, agent, root, account := t.TempDir(), t.TempDir(), t.TempDir(), t.TempDir()
t.Setenv("HOME", home)
t.Setenv("PI_CODING_AGENT_DIR", agent)
data := []byte("source: " + sourceDir + "\ntargets:\n pi-work: {agent: pi, config_dir: " + account + "}\nmcp:\n projects:\n " + root + ": {}\n")
if err := os.WriteFile(s.configPath(), data, 0600); err != nil {
t.Fatal(err)
}
list := httptest.NewRecorder()
s.handleMCPList(list, httptest.NewRequest(http.MethodGet, "/api/mcp", nil))
var view struct {
ImportSources map[string][]struct{ Target, Path, PiExtension string }
}
if list.Code != 200 || json.Unmarshal(list.Body.Bytes(), &view) != nil {
t.Fatal(list.Body.String())
}
for _, scope := range []string{"", root} {
for _, target := range []string{"pi", "pi-work"} {
base := agent
if target == "pi-work" {
base = account
}
if scope != "" {
base = filepath.Join(root, ".pi")
}
found := map[string]string{}
for _, source := range view.ImportSources[scope] {
if source.Target == target {
found[source.PiExtension] = source.Path
}
}
if scope != "" && target == "pi-work" {
if len(found) != 0 {
t.Fatal("project offered an account")
}
continue
}
// Pi's built-in file, and the adapter's, which is still read for import.
if len(found) != 2 || found["builtin"] != filepath.Join(base, "mcp.json") || found["pi-mcp-adapter"] != filepath.Join(base, "mcp-adapter.json") {
t.Fatalf("%s %s: %+v", scope, target, found)
}
if err := os.MkdirAll(base, 0755); err != nil {
t.Fatal(err)
}
for file, command := range map[string]string{"mcp.json": "native", "mcp-adapter.json": "adapter"} {
if err := os.WriteFile(filepath.Join(base, file), []byte(`{"mcpServers":{"docs":{"command":"`+command+`"}}}`), 0600); err != nil {
t.Fatal(err)
}
}
// A dashboard from before 0.23.0 may still send pi-mcp-extension; it reads mcp.json.
for mode, command := range map[string]string{"builtin": "native", "pi-mcp-adapter": "adapter", "pi-mcp-extension": "native"} {
body, _ := json.Marshal(map[string]string{"from": target, "root": scope, "piExtension": mode})
w := httptest.NewRecorder()
s.handleMCPImport(w, httptest.NewRequest(http.MethodPost, "/api/mcp/import", strings.NewReader(string(body))))
var result struct {
Candidates []struct {
From string
Warnings []string
Server struct{ Command string }
}
}
if w.Code != 200 || json.Unmarshal(w.Body.Bytes(), &result) != nil || len(result.Candidates) != 1 || result.Candidates[0].From != target || result.Candidates[0].Server.Command != command {
t.Fatalf("%s %s %s: %s", scope, target, mode, w.Body)
}
}
}
}
// An exact source must neither fall back to the other file nor accept non-Pi modes.
if err := os.Remove(filepath.Join(agent, "mcp.json")); err != nil {
t.Fatal(err)
}
for _, body := range []string{`{"from":"pi","piExtension":"builtin"}`, `{"from":"pi","piExtension":"unknown"}`, `{"from":"claude","piExtension":"builtin"}`} {
w := httptest.NewRecorder()
s.handleMCPImport(w, httptest.NewRequest(http.MethodPost, "/api/mcp/import", strings.NewReader(body)))
if w.Code != 400 {
t.Fatalf("accepted %s: %s", body, w.Body)
}
}
}
func TestMCPAPIPreviewAndApply(t *testing.T) {
s, _ := newTestServerWithExtras(t, nil, "")
home := t.TempDir()
t.Setenv("HOME", home)
t.Setenv("CLAUDE_CONFIG_DIR", "")
body := `{"mutation":{"name":"docs","server":{"url":"https://example.com/mcp","targets":["claude"]}}}`
preview := httptest.NewRecorder()
s.handleMCPPreview(preview, httptest.NewRequest(http.MethodPost, "/api/mcp/preview", strings.NewReader(body)))
if preview.Code != 200 {
t.Fatalf("preview: %s", preview.Body.String())
}
var p struct {
Revision string `json:"revision"`
}
if err := json.Unmarshal(preview.Body.Bytes(), &p); err != nil {
t.Fatal(err)
}
if _, err := os.Stat(filepath.Join(home, ".claude.json")); !os.IsNotExist(err) {
t.Fatal("preview wrote native file")
}
apply := httptest.NewRecorder()
request := strings.TrimSuffix(body, "}") + `,"sync":true,"revision":"` + p.Revision + `"}`
s.handleMCPConfigure(apply, httptest.NewRequest(http.MethodPost, "/api/mcp", strings.NewReader(request)))
if apply.Code != 200 {
t.Fatalf("apply: %s", apply.Body.String())
}
if _, err := os.Stat(filepath.Join(home, ".claude.json")); err != nil {
t.Fatal(err)
}
}
func TestMCPListIgnoresUnresolvableUnusedTarget(t *testing.T) {
s, _ := newTestServerWithExtras(t, nil, "")
xdg := t.TempDir()
t.Setenv("HOME", t.TempDir())
t.Setenv("XDG_CONFIG_HOME", xdg)
for _, name := range []string{"opencode.json", "opencode.jsonc"} {
path := filepath.Join(xdg, "opencode", name)
if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(path, []byte("{}"), 0644); err != nil {
t.Fatal(err)
}
}
w := httptest.NewRecorder()
s.handleMCPList(w, httptest.NewRequest(http.MethodGet, "/api/mcp", nil))
if w.Code != http.StatusOK {
t.Fatalf("status = %d body = %s", w.Code, w.Body.String())
}
}
func TestMCPRoutesRejectRebindingHost(t *testing.T) {
s, _ := newTestServerWithExtras(t, nil, "")
s.addr = "127.0.0.1:19420"
routes := []string{"GET /api/mcp", "GET /api/mcp/check", "POST /api/mcp", "POST /api/mcp/preview", "POST /api/mcp/import", "POST /api/mcp/restore"}
for _, route := range routes {
method, path, _ := strings.Cut(route, " ")
req := httptest.NewRequest(method, path, strings.NewReader(`{}`))
req.RemoteAddr = "127.0.0.1:5555"
req.Host = "attacker.example:19420"
w := httptest.NewRecorder()
s.mux.ServeHTTP(w, req)
if w.Code != http.StatusForbidden {
t.Fatalf("%s: status = %d, want 403", route, w.Code)
}
}
}
func TestMCPPiBuiltinProjectRenderAndPaths(t *testing.T) {
s, _ := newTestServerWithExtras(t, nil, "")
home, root := t.TempDir(), t.TempDir()
t.Setenv("HOME", home)
t.Setenv("PI_CODING_AGENT_DIR", "")
configPath := s.configPath()
data, err := os.ReadFile(configPath)
if err != nil {
t.Fatal(err)
}
data = append(data, []byte("\nmcp:\n targets: [pi]\n servers:\n docs:\n command: docs\n piExtension: builtin\n projects:\n "+root+":\n servers: {}\n")...)
if err := os.WriteFile(configPath, data, 0600); err != nil {
t.Fatal(err)
}
body, _ := json.Marshal(map[string]any{"mutation": map[string]any{"project": root, "name": "docs", "server": map[string]any{"command": "docs", "piExtension": "builtin", "targets": []string{"pi"}, "piOptions": map[string]any{"exposure": "deferred"}}}})
result := httptest.NewRecorder()
s.handleMCPRender(result, httptest.NewRequest(http.MethodPost, "/api/mcp/render", strings.NewReader(string(body))))
var rendered struct {
Rendered []struct {
Path string
Content string
Error string
}
}
if result.Code != 200 || json.Unmarshal(result.Body.Bytes(), &rendered) != nil || len(rendered.Rendered) != 1 || rendered.Rendered[0].Path != filepath.Join(root, ".pi", "mcp.json") || rendered.Rendered[0].Error != "" {
t.Fatalf("wrong project render: %s", result.Body)
}
if _, err := os.Stat(rendered.Rendered[0].Path); !os.IsNotExist(err) {
t.Fatal("render wrote native config")
}
list := httptest.NewRecorder()
s.handleMCPList(list, httptest.NewRequest(http.MethodGet, "/api/mcp", nil))
var view struct{ Paths map[string]string }
if list.Code != 200 || json.Unmarshal(list.Body.Bytes(), &view) != nil || view.Paths["pi"] != filepath.Join(home, ".pi", "agent", "mcp.json") {
t.Fatalf("wrong mode path label: %s", list.Body)
}
}
func TestMCPRenderRejectsProjectOverrideInProjectMode(t *testing.T) {
s, _ := newTestServerWithExtras(t, nil, "")
s.projectRoot = t.TempDir()
body := `{"mutation":{"project":"/other/project","name":"docs","server":{"command":"docs","targets":["pi"],"piExtension":"builtin"}}}`
w := httptest.NewRecorder()
s.handleMCPRender(w, httptest.NewRequest(http.MethodPost, "/api/mcp/render", strings.NewReader(body)))
if w.Code != 400 || !strings.Contains(w.Body.String(), "project mode") {
t.Fatalf("%d %s", w.Code, w.Body)
}
}
// The dashboard's sync saves the config without the settings 0.23.0 retired, keeping the
// previous version in the file history, so the list no longer shows their notices.
func TestMCPSyncSavesTheConfigWithoutRetiredSettings(t *testing.T) {
s, sourceDir := newTestServerWithExtras(t, nil, "")
t.Setenv("HOME", t.TempDir())
t.Setenv("PI_CODING_AGENT_DIR", t.TempDir())
data := "source: " + sourceDir + "\nmcp:\n targets: [pi]\n servers:\n docs:\n command: docs\n piExtension: pi-mcp-adapter\n"
if err := os.WriteFile(s.configPath(), []byte(data), 0600); err != nil {
t.Fatal(err)
}
plan, err := s.mcpService().Preview()
if err != nil || !plan.Migrates || len(plan.Notices) != 2 {
t.Fatalf("%+v %v", plan, err)
}
body, _ := json.Marshal(map[string]any{"mutation": map[string]any{}, "revision": plan.Revision, "sync": true})
w := httptest.NewRecorder()
s.handleMCPConfigure(w, httptest.NewRequest(http.MethodPost, "/api/mcp", strings.NewReader(string(body))))
if w.Code != 200 || !strings.Contains(w.Body.String(), `"migrated":[{"path":`) {
t.Fatalf("%d %s", w.Code, w.Body)
}
if saved, _ := os.ReadFile(s.configPath()); strings.Contains(string(saved), "piExtension") || !strings.Contains(string(saved), "command: docs") {
t.Fatalf("saved config:\n%s", saved)
}
versions, err := syncpkg.FileBackupVersions(s.configPath())
if err != nil || len(versions) != 1 || versions[0].Reason != syncpkg.BackupReasonMigrate {
t.Fatalf("backups: %+v %v", versions, err)
}
if kept, _, err := syncpkg.ReadFileBackupVersion(s.configPath(), versions[0].ID); err != nil || string(kept) != data {
t.Fatalf("backup: %s %v", kept, err)
}
list := httptest.NewRecorder()
s.handleMCPList(list, httptest.NewRequest(http.MethodGet, "/api/mcp", nil))
if list.Code != 200 || strings.Contains(list.Body.String(), `"notices"`) || strings.Contains(list.Body.String(), `"migrates"`) {
t.Fatalf("list: %s", list.Body)
}
}
func TestMCPOpenOnlyListedConfigFiles(t *testing.T) {
s, _ := newTestServerWithExtras(t, nil, "")
home := t.TempDir()
t.Setenv("HOME", home)
t.Setenv("USERPROFILE", home)
t.Setenv("CLAUDE_CONFIG_DIR", "")
t.Setenv("VISUAL", "")
t.Setenv("EDITOR", "true")
// A browser on this machine, then ones elsewhere: on the LAN, and behind a reverse proxy on
// this machine that keeps the browser's Host or adds a forwarding header.
local := func(r *http.Request) { r.RemoteAddr, r.Host = "127.0.0.1:1", "localhost:19420" }
remote := map[string]func(*http.Request){
"lan": func(r *http.Request) { r.RemoteAddr, r.Host = "192.168.1.9:1", "192.168.1.5:19420" },
"proxy host": func(r *http.Request) { r.RemoteAddr, r.Host = "127.0.0.1:1", "192.168.1.5" },
"proxy header": func(r *http.Request) {
local(r)
r.Header.Set("X-Forwarded-For", "192.168.1.9")
},
}
list := func(from func(*http.Request)) string {
req := httptest.NewRequest(http.MethodGet, "/api/mcp", nil)
from(req)
rec := httptest.NewRecorder()
s.handleMCPList(rec, req)
return rec.Body.String()
}
open := func(from func(*http.Request), body string) *httptest.ResponseRecorder {
req := httptest.NewRequest(http.MethodPost, "/api/mcp/open", strings.NewReader(body))
from(req)
rec := httptest.NewRecorder()
s.handleMCPOpen(rec, req)
return rec
}
if rec := open(local, `{"target":"../etc/passwd"}`); rec.Code != 400 {
t.Fatalf("unknown target: %d", rec.Code)
}
if rec := open(local, `{"target":"claude"}`); rec.Code != 404 {
t.Fatalf("missing file: %d", rec.Code)
}
path := filepath.Join(home, ".claude.json")
if err := os.WriteFile(path, []byte("{}"), 0600); err != nil {
t.Fatal(err)
}
for name, from := range remote {
if body := list(from); !strings.Contains(body, `"openable":[]`) {
t.Fatalf("%s list: %s", name, body)
}
if rec := open(from, `{"target":"claude"}`); rec.Code != 403 {
t.Fatalf("%s open: %d", name, rec.Code)
}
}
if body := list(local); !strings.Contains(body, `"openable":["claude"]`) {
t.Fatalf("local list: %s", body)
}
rec := open(local, `{"target":"claude"}`)
var resp openInEditorResponse
if rec.Code != 200 || json.Unmarshal(rec.Body.Bytes(), &resp) != nil || resp.Editor != "true" || resp.Path != path {
t.Fatalf("open: %d %s", rec.Code, rec.Body)
}
}
func TestMCPOpenProjectConfigFile(t *testing.T) {
s, _ := newTestServerWithExtras(t, nil, "")
root := t.TempDir()
t.Setenv("HOME", t.TempDir())
t.Setenv("VISUAL", "")
t.Setenv("EDITOR", "true")
data, err := os.ReadFile(s.configPath())
if err != nil {
t.Fatal(err)
}
data = append(data, []byte("\nmcp:\n projects:\n "+root+": {}\n")...)
if err := os.WriteFile(s.configPath(), data, 0600); err != nil {
t.Fatal(err)
}
path := filepath.Join(root, ".gemini", "settings.json")
if err := os.MkdirAll(filepath.Dir(path), 0700); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(path, []byte("{}"), 0600); err != nil {
t.Fatal(err)
}
local := func(r *http.Request) *http.Request { r.RemoteAddr, r.Host = "127.0.0.1:1", "localhost:19420"; return r }
list := httptest.NewRecorder()
s.handleMCPList(list, local(httptest.NewRequest(http.MethodGet, "/api/mcp", nil)))
var view struct {
ProjectPaths map[string]map[string]string
ProjectExisting map[string][]string
}
if json.Unmarshal(list.Body.Bytes(), &view) != nil || view.ProjectPaths[root]["gemini"] != path || !slices.Equal(view.ProjectExisting[root], []string{"gemini"}) {
t.Fatalf("list: %s", list.Body)
}
// A viewer elsewhere still sees which files exist, to list them; only opening is local.
remote := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, "/api/mcp", nil)
req.RemoteAddr, req.Host = "192.168.1.9:1", "192.168.1.5:19420"
s.handleMCPList(remote, req)
if json.Unmarshal(remote.Body.Bytes(), &view) != nil || !slices.Equal(view.ProjectExisting[root], []string{"gemini"}) {
t.Fatalf("remote list: %s", remote.Body)
}
open := func(body string) *httptest.ResponseRecorder {
rec := httptest.NewRecorder()
s.handleMCPOpen(rec, local(httptest.NewRequest(http.MethodPost, "/api/mcp/open", strings.NewReader(body))))
return rec
}
if rec := open(`{"target":"gemini","project":"/not/configured"}`); rec.Code != 400 {
t.Fatalf("unknown project: %d", rec.Code)
}
body, _ := json.Marshal(map[string]string{"target": "gemini", "project": root})
rec := open(string(body))
var resp openInEditorResponse
if rec.Code != 200 || json.Unmarshal(rec.Body.Bytes(), &resp) != nil || resp.Path != path {
t.Fatalf("open: %d %s", rec.Code, rec.Body)
}
// A folder opens before the Agent writes its file; the editor needs the file.
missing, _ := json.Marshal(map[string]string{"target": "cursor", "project": root})
if rec := open(string(missing)); rec.Code != 404 {
t.Fatalf("missing file: %d", rec.Code)
}
t.Setenv("SKILLSHARE_HEADLESS", "1")
folder, _ := json.Marshal(map[string]any{"target": "cursor", "project": root, "folder": true})
if rec := open(string(folder)); rec.Code != 409 || !strings.Contains(rec.Body.String(), "file manager") {
t.Fatalf("folder: %d %s", rec.Code, rec.Body)
}
}
func TestNearestDir(t *testing.T) {
root := t.TempDir()
if got := nearestDir(filepath.Join(root, ".cursor", "rules")); got != root {
t.Fatalf("nearestDir = %s, want %s", got, root)
}
}