Files
skillshare/internal/server/handler_toggle_test.go
Willie af7654712c fix(server): log a disable that a .local rule overrides
When a "!" rule in .skillignore.local overrode a single disable, the handler
returned 409 before its only ops log call, although AddPattern had already
written the pattern to .skillignore. The shared file changed with no trace in
the log. Log the attempt with status "error" and the reason before returning.
2026-10-04 19:40:44 +08:00

38 lines
1.2 KiB
Go

package server
import (
"net/http"
"net/http/httptest"
"strings"
"testing"
"skillshare/internal/oplog"
)
func TestHandleDisableSkill_OverriddenByLocalNegation_Conflict(t *testing.T) {
s, src := newTestServer(t)
seedLocalNegation(t, src)
req := httptest.NewRequest(http.MethodPost, "/api/resources/feature-radar__feature-radar/disable", nil)
rr := httptest.NewRecorder()
s.handler.ServeHTTP(rr, req)
if rr.Code != http.StatusConflict || !strings.Contains(rr.Body.String(), ".skillignore.local") {
t.Fatalf("expected 409 naming .skillignore.local, got %d: %s", rr.Code, rr.Body.String())
}
}
// The conflict still leaves the pattern in .skillignore, so the change must be logged.
func TestHandleDisableSkill_OverriddenByLocalNegation_LogsError(t *testing.T) {
s, src := newTestServer(t)
seedLocalNegation(t, src)
rr := httptest.NewRecorder()
s.handler.ServeHTTP(rr, httptest.NewRequest(http.MethodPost, "/api/resources/feature-radar__feature-radar/disable", nil))
entries, _ := oplog.Read(s.configPath(), oplog.OpsFile, 10)
if len(entries) != 1 || entries[0].Command != "disable" || entries[0].Status != "error" {
t.Fatalf("expected one disable error entry, got %+v", entries)
}
}