mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
The project-root self-install guard lived only in the CLI handler, so the web UI could still copy the project root into its own .skillshare/skills/ subtree in project mode. Extract the check into a shared install.RejectProjectRootLocalInstall and apply it in handleInstall and handleInstallBatch, returning 400 with the same guidance. Also restructure the rejection message into a cause line plus an actionable "Run '...'" hint, matching the project's error convention.
42 lines
1.3 KiB
Go
42 lines
1.3 KiB
Go
package install
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
)
|
|
|
|
// RejectProjectRootLocalInstall returns an error when source is a local path
|
|
// that resolves to the project root itself. Installing the project root into
|
|
// its own .skillshare/skills/ subtree would recursively copy the destination
|
|
// back into itself (see discussion #227). Callers should surface the returned
|
|
// error to the user.
|
|
//
|
|
// Returns nil for non-local sources, an empty root, or any local path that is
|
|
// not the project root.
|
|
func RejectProjectRootLocalInstall(source *Source, root string) error {
|
|
if source == nil || source.Type != SourceTypeLocalPath || root == "" {
|
|
return nil
|
|
}
|
|
sourcePath, err := filepath.Abs(source.Path)
|
|
if err != nil {
|
|
return fmt.Errorf("invalid source path: %w", err)
|
|
}
|
|
projectRoot, err := filepath.Abs(root)
|
|
if err != nil {
|
|
return fmt.Errorf("invalid project root: %w", err)
|
|
}
|
|
sourcePath, err = filepath.EvalSymlinks(sourcePath)
|
|
if err != nil {
|
|
if !os.IsNotExist(err) {
|
|
return fmt.Errorf("cannot resolve source path: %w", err)
|
|
}
|
|
} else if resolvedRoot, rootErr := filepath.EvalSymlinks(projectRoot); rootErr == nil {
|
|
projectRoot = resolvedRoot
|
|
}
|
|
if sourcePath == projectRoot {
|
|
return fmt.Errorf("cannot install the project root into itself\nRun 'skillshare install ./my-skill -p' to install a specific skill subdirectory instead")
|
|
}
|
|
return nil
|
|
}
|