Files
Willie c040917bc7 fix(security): enforce credential and filesystem trust boundaries (#861)
Bind provider credentials to canonical or explicitly configured HTTPS origins and preserve that policy across remote consumers. Reject cross-site credentialed reads, linked fallback directories, and discovered-agent writes outside the source; audit staged content before rooted atomic publication.

Add boundary regressions, private Git update coverage, stable cross-platform fixtures, and aligned documentation. Verified the integrated main baseline with all executed CI checks passing.
2026-11-11 23:17:54 +08:00

242 lines
7.7 KiB
Go

package check
import (
"os"
"os/exec"
"path/filepath"
"testing"
"skillshare/internal/install"
)
func TestParseLsTreeOutput(t *testing.T) {
// -z output: NUL-terminated entries, so a newline belongs to the path.
input := "040000 tree abc123def456789012345678901234567890abcd\tskills/my-skill\x00" +
"040000 tree 1234567890abcdef1234567890abcdef12345678\tdata/other\x00" +
"040000 tree 0000000000000000000000000000000000000000\tdata/odd\nname\x00"
result := parseLsTreeOutput(input)
if len(result) != 3 {
t.Fatalf("expected 3 entries, got %d: %v", len(result), result)
}
if _, ok := result["data/odd\nname"]; !ok {
t.Errorf("expected path with a newline kept whole, got %v", result)
}
if result["skills/my-skill"] != "abc123def456789012345678901234567890abcd" {
t.Errorf("unexpected hash for skills/my-skill: %s", result["skills/my-skill"])
}
if result["data/other"] != "1234567890abcdef1234567890abcdef12345678" {
t.Errorf("unexpected hash for data/other: %s", result["data/other"])
}
}
func TestParseLsTreeOutput_Empty(t *testing.T) {
result := parseLsTreeOutput("")
if len(result) != 0 {
t.Errorf("expected empty map, got %d entries", len(result))
}
}
func TestParseLsTreeOutput_MalformedLines(t *testing.T) {
input := "not a valid line\x00\x00040000 tree abc123\tvalid/path\x00"
result := parseLsTreeOutput(input)
if len(result) != 1 {
t.Fatalf("expected 1 valid entry, got %d", len(result))
}
if result["valid/path"] != "abc123" {
t.Errorf("unexpected hash: %s", result["valid/path"])
}
}
func TestFetchRemoteTreeHashes_Valid(t *testing.T) {
// Set up a bare remote repo with a subdir
remote := setupBareRepoWithSubdir(t, "skills/my-skill", "SKILL.md", "# Test Skill")
result := FetchRemoteTreeHashes("file://"+remote, install.ParseOptions{})
if result == nil {
t.Fatal("expected non-nil result")
}
hash, ok := result["skills/my-skill"]
if !ok {
t.Fatal("expected skills/my-skill in result")
}
if len(hash) != 40 {
t.Errorf("expected 40-char hash, got %d: %s", len(hash), hash)
}
// Also check parent directory is listed
if _, ok := result["skills"]; !ok {
t.Error("expected skills/ parent directory in result")
}
}
func TestFetchRemoteTreeHashes_InvalidURL(t *testing.T) {
result := FetchRemoteTreeHashes("file:///nonexistent/repo", install.ParseOptions{})
if result != nil {
t.Errorf("expected nil for invalid URL, got %v", result)
}
}
func TestFetchRemoteTreeHashes_SubdirNotFound(t *testing.T) {
remote := setupBareRepoWithSubdir(t, "skills/exists", "SKILL.md", "# Exists")
result := FetchRemoteTreeHashes("file://"+remote, install.ParseOptions{})
if result == nil {
t.Fatal("expected non-nil result")
}
if _, ok := result["skills/not-here"]; ok {
t.Error("did not expect skills/not-here in result")
}
}
func TestFetchRemoteTreeHashes_StableAfterUnrelatedChange(t *testing.T) {
// Create a bare remote with one skill
dir := t.TempDir()
work := filepath.Join(dir, "work")
bare := filepath.Join(dir, "bare.git")
gitRun(t, "", "init", "--bare", bare)
gitRun(t, "", "clone", bare, work)
gitConfig(t, work)
// Add a skill subdir
skillDir := filepath.Join(work, "skills", "stable")
os.MkdirAll(skillDir, 0755)
os.WriteFile(filepath.Join(skillDir, "SKILL.md"), []byte("# Stable"), 0644)
gitRun(t, work, "add", "-A")
gitRun(t, work, "commit", "-m", "add stable skill")
gitRun(t, work, "push", "origin", "HEAD")
hash1 := FetchRemoteTreeHashes("file://"+bare, install.ParseOptions{})
if hash1 == nil {
t.Fatal("expected non-nil result for first fetch")
}
stableHash1 := hash1["skills/stable"]
// Add an unrelated file and push
os.WriteFile(filepath.Join(work, "README.md"), []byte("# Readme"), 0644)
gitRun(t, work, "add", "-A")
gitRun(t, work, "commit", "-m", "unrelated change")
gitRun(t, work, "push", "origin", "HEAD")
hash2 := FetchRemoteTreeHashes("file://"+bare, install.ParseOptions{})
if hash2 == nil {
t.Fatal("expected non-nil result for second fetch")
}
stableHash2 := hash2["skills/stable"]
if stableHash1 != stableHash2 {
t.Errorf("tree hash changed despite no changes in skills/stable: %s → %s", stableHash1, stableHash2)
}
}
func TestFetchRemoteTreeHashes_SymlinkBlanksContainingDirs(t *testing.T) {
dir := t.TempDir()
work := filepath.Join(dir, "work")
bare := filepath.Join(dir, "bare.git")
gitRun(t, "", "init", "--bare", bare)
gitRun(t, "", "clone", bare, work)
gitConfig(t, work)
linked := filepath.Join(work, "skills", "linked")
plain := filepath.Join(work, "skills", "plain")
os.MkdirAll(linked, 0755)
os.MkdirAll(plain, 0755)
os.MkdirAll(filepath.Join(work, "shared"), 0755)
os.WriteFile(filepath.Join(linked, "SKILL.md"), []byte("# Linked"), 0644)
os.WriteFile(filepath.Join(plain, "SKILL.md"), []byte("# Plain"), 0644)
os.WriteFile(filepath.Join(work, "shared", "ref.md"), []byte("v1"), 0644)
// A non-ASCII name makes git quote the path unless -z is used.
if err := os.Symlink(filepath.Join("..", "..", "shared", "ref.md"), filepath.Join(linked, "réf.md")); err != nil {
t.Skipf("symlinks unavailable: %v", err)
}
gitRun(t, work, "add", "-A")
gitRun(t, work, "commit", "-m", "add skills")
gitRun(t, work, "push", "origin", "HEAD")
result := FetchRemoteTreeHashes("file://"+bare, install.ParseOptions{})
if result == nil {
t.Fatal("expected non-nil result")
}
// A blank hash still marks the dir as present, so the skill reads as
// update_available rather than stale.
for _, d := range []string{"skills/linked", "skills"} {
if hash, ok := result[d]; !ok || hash != "" {
t.Errorf("%s: expected present with empty hash, got %q (present=%v)", d, hash, ok)
}
}
if len(result["skills/plain"]) != 40 {
t.Errorf("skills/plain: expected a tree hash, got %q", result["skills/plain"])
}
if _, ok := result["skills/plain/SKILL.md"]; ok {
t.Error("blob entries must not appear in the result")
}
}
// --- test helpers ---
func setupBareRepoWithSubdir(t *testing.T, subdir, filename, content string) string {
t.Helper()
dir := t.TempDir()
work := filepath.Join(dir, "work")
bare := filepath.Join(dir, "bare.git")
gitRun(t, "", "init", "--bare", bare)
gitRun(t, "", "clone", bare, work)
gitConfig(t, work)
fullDir := filepath.Join(work, subdir)
os.MkdirAll(fullDir, 0755)
os.WriteFile(filepath.Join(fullDir, filename), []byte(content), 0644)
gitRun(t, work, "add", "-A")
gitRun(t, work, "commit", "-m", "initial")
gitRun(t, work, "push", "origin", "HEAD")
return bare
}
func gitConfig(t *testing.T, dir string) {
t.Helper()
gitRun(t, dir, "config", "user.email", "test@test.com")
gitRun(t, dir, "config", "user.name", "test")
}
func gitRun(t *testing.T, dir string, args ...string) {
t.Helper()
cmd := exec.Command("git", args...)
if dir != "" {
cmd.Dir = dir
}
cmd.Env = append(os.Environ(),
"GIT_AUTHOR_NAME=test",
"GIT_AUTHOR_EMAIL=test@test.com",
"GIT_COMMITTER_NAME=test",
"GIT_COMMITTER_EMAIL=test@test.com",
)
out, err := cmd.CombinedOutput()
if err != nil {
t.Fatalf("git %v failed: %s\n%s", args, err, out)
}
}
// Git exports GIT_DIR to hooks; `git init --bare` honors it and would turn the
// caller's repository bare (#852).
func TestFetchRemoteTreeHashes_IgnoresCallerGitDir(t *testing.T) {
remote := setupBareRepoWithSubdir(t, "skills/my-skill", "SKILL.md", "# Test Skill")
host := filepath.Join(t.TempDir(), "host")
if out, err := exec.Command("git", "init", "-q", host).CombinedOutput(); err != nil {
t.Fatalf("git init: %v\n%s", err, out)
}
t.Setenv("GIT_DIR", filepath.Join(host, ".git"))
FetchRemoteTreeHashes("file://"+remote, install.ParseOptions{})
out, _ := exec.Command("git", "config", "--file", filepath.Join(host, ".git", "config"), "core.bare").Output()
if string(out) != "false\n" {
t.Errorf("caller repository core.bare = %q, want false", out)
}
}