Files
skillshare/internal/plugin/source_compat_test.go
Willie a996a5bbfd feat(plugin): show version and Codex logo for plugins with no Agent
A plugin added without choosing an Agent has no binding, so the
dashboard had nowhere to read its version from and always drew the
default icon.

Record the source version on the package when it is added, and let
rows without one ask their source once. Read interface.logo from the
Codex manifest (inside the plugin, image types, 256KB max) and draw
it in the list and in the add preview, falling back to the default
icon.
2026-09-29 11:25:50 +08:00

151 lines
4.9 KiB
Go

package plugin
import (
"context"
"slices"
"testing"
)
func TestManifestFailureIsTargetLocal(t *testing.T) {
root := fixture(t)
writeFile(t, root, ".cursor-plugin/plugin.json", "{")
d, err := Discover(context.Background(), root)
if err != nil {
t.Fatal(err)
}
c := d.Candidates[0]
if !slices.Contains(c.Targets, "claude") || slices.Contains(c.Targets, "cursor") {
t.Fatalf("wrong targets: %+v", c)
}
}
func TestOpenCodeConventionalEntryWithoutSDK(t *testing.T) {
root := fixture(t)
writeFile(t, root, "package.json", `{"name":"demo","main":".opencode/plugins/demo.js"}`)
writeFile(t, root, ".opencode/plugins/demo.js", "export const Demo = async () => ({})")
d, err := Discover(context.Background(), root)
if err != nil {
t.Fatal(err)
}
if !slices.Contains(d.Candidates[0].Targets, "opencode") {
t.Fatal("OpenCode convention was not detected")
}
}
func TestOrdinaryNPMPackageIsNotPlugin(t *testing.T) {
root := t.TempDir()
writeFile(t, root, "package.json", `{"name":"ordinary","main":"index.js"}`)
writeFile(t, root, "index.js", "export default {}")
if _, err := Discover(context.Background(), root); err == nil {
t.Fatal("ordinary package accepted")
}
}
func TestPiConventionalPackage(t *testing.T) {
root := t.TempDir()
writeFile(t, root, "package.json", `{"name":"demo","keywords":["pi-package"]}`)
writeFile(t, root, "extensions/demo.ts", "export default () => {}")
d, err := Discover(context.Background(), root)
if err != nil {
t.Fatal(err)
}
if !slices.Contains(d.Candidates[0].Targets, "pi") {
t.Fatal("Pi convention was not detected")
}
}
func TestMissingOpenCodeEntryNamesTheSentenceAndTheFile(t *testing.T) {
root := fixture(t)
writeFile(t, root, "package.json", `{"name":"demo","dependencies":{"@opencode-ai/plugin":"1"}}`)
d, err := DiscoverOptions(context.Background(), root, "", "dist/main.js")
if err != nil {
t.Fatal(err)
}
info := d.Candidates[0].TargetInfo["opencode"]
if info.ProblemKey != "plugins.problem.opencodeEntryMissing" || info.ProblemArgs["entry"] != "dist/main.js" || info.Problem == "" {
t.Fatalf("problem is not translatable: %+v", info)
}
}
func TestExplicitOpenCodeEntry(t *testing.T) {
root := t.TempDir()
writeFile(t, root, "package.json", `{"name":"custom","main":"index.js"}`)
writeFile(t, root, "entry.js", "export const plugin = async () => ({})")
d, err := DiscoverOptions(context.Background(), root, "", "entry.js")
if err != nil {
t.Fatal(err)
}
if d.Candidates[0].TargetInfo["opencode"].Entry != "entry.js" {
t.Fatalf("entry ignored: %+v", d)
}
if _, err := DiscoverOptions(context.Background(), root, "", "../outside.js"); err == nil {
t.Fatal("escaped explicit entry")
}
if _, err := DiscoverRef(context.Background(), root, "main"); err == nil {
t.Fatal("local source accepted Git ref")
}
}
func TestBrokenCatalogDoesNotHideValidManifest(t *testing.T) {
root := fixture(t)
writeFile(t, root, ".cursor-plugin/marketplace.json", "{")
d, err := Discover(context.Background(), root)
if err != nil {
t.Fatal(err)
}
if len(d.Candidates) != 1 || len(d.Warnings) != 1 {
t.Fatalf("unexpected discovery: %+v", d)
}
}
func TestDroidPluginTargetNotSupported(t *testing.T) {
if slices.Contains(Targets, "droid") {
t.Fatal("Droid must not be offered")
}
root := fixture(t)
d, err := Discover(context.Background(), root)
if err != nil {
t.Fatal(err)
}
if slices.Contains(d.Candidates[0].Targets, "droid") {
t.Fatal("Droid compatibility must not be advertised")
}
}
func TestNativeManifestPrecedesPortableFallback(t *testing.T) {
root := fixture(t)
writeFile(t, root, "plugin.json", `{"$schema":"https://agent-plugins.org/schemas/1.0.0/plugin.schema.json","name":"demo","version":"old"}`)
d, err := Discover(context.Background(), root)
if err != nil {
t.Fatal(err)
}
if d.Candidates[0].TargetInfo["codex"].Manifest != ".codex-plugin/plugin.json" {
t.Fatal("portable fallback hid native manifest")
}
writeFile(t, root, "plugin.json", "{")
d, err = Discover(context.Background(), root)
if err != nil || !slices.Contains(d.Candidates[0].Targets, "codex") {
t.Fatalf("broken fallback hid native manifest: %+v %v", d, err)
}
}
func TestCodexLogoComesFromTheManifestInsideThePlugin(t *testing.T) {
root := fixture(t)
writeFile(t, root, ".codex-plugin/plugin.json", `{"name":"demo","version":"1.0.0","skills":"./skills","interface":{"logo":"./logo.png"}}`)
writeFile(t, root, "logo.png", "png-bytes")
d, err := Discover(context.Background(), root)
if err != nil {
t.Fatal(err)
}
if got := d.Candidates[0].TargetInfo["codex"].Logo; got != "data:image/png;base64,cG5nLWJ5dGVz" {
t.Fatalf("logo not read: %q", got)
}
writeFile(t, root, ".codex-plugin/plugin.json", `{"name":"demo","version":"1.0.0","skills":"./skills","interface":{"logo":"../outside.png"}}`)
if d, err = Discover(context.Background(), root); err != nil {
t.Fatal(err)
}
if got := d.Candidates[0].TargetInfo["codex"].Logo; got != "" {
t.Fatalf("logo outside the plugin was read: %q", got)
}
}