package server import ( "bytes" "encoding/json" "net/http" "net/http/httptest" "os" "path/filepath" "strings" "testing" "skillshare/internal/config" "skillshare/internal/oplog" "skillshare/internal/testutil" ) func TestHandlePutConfig_WritesOpsLog(t *testing.T) { tmp := t.TempDir() testutil.SetIsolatedXDG(t, tmp) sourceDir := filepath.Join(tmp, "skills") if err := os.MkdirAll(sourceDir, 0755); err != nil { t.Fatalf("failed to create source dir: %v", err) } cfgPath := filepath.Join(tmp, "config", "config.yaml") t.Setenv("SKILLSHARE_CONFIG", cfgPath) if err := os.MkdirAll(filepath.Dir(cfgPath), 0755); err != nil { t.Fatalf("failed to create config dir: %v", err) } initialRaw := "source: " + sourceDir + "\ntargets: {}\n" if err := os.WriteFile(cfgPath, []byte(initialRaw), 0644); err != nil { t.Fatalf("failed to write initial config: %v", err) } s := New(&config.Config{ Source: sourceDir, Targets: map[string]config.TargetConfig{}, }, "127.0.0.1:0", "", "") payload, _ := json.Marshal(map[string]string{"raw": initialRaw}) req := httptest.NewRequest(http.MethodPut, "/api/config", bytes.NewReader(payload)) rr := httptest.NewRecorder() s.mux.ServeHTTP(rr, req) if rr.Code != http.StatusOK { t.Fatalf("unexpected status: got %d, body=%s", rr.Code, rr.Body.String()) } entries, err := oplog.Read(cfgPath, oplog.OpsFile, 10) if err != nil { t.Fatalf("failed to read ops log: %v", err) } if len(entries) == 0 { t.Fatal("expected at least one operations log entry") } if entries[0].Command != "config" { t.Fatalf("expected latest command to be config, got %q", entries[0].Command) } if entries[0].Status != "ok" { t.Fatalf("expected latest status to be ok, got %q", entries[0].Status) } } func TestHandleAuditAll_WritesAuditLog(t *testing.T) { tmp := t.TempDir() testutil.SetIsolatedXDG(t, tmp) sourceDir := filepath.Join(tmp, "skills") skillDir := filepath.Join(sourceDir, "safe-skill") if err := os.MkdirAll(skillDir, 0755); err != nil { t.Fatalf("failed to create skill dir: %v", err) } if err := os.WriteFile(filepath.Join(skillDir, "SKILL.md"), []byte("# Safe\n\nNo suspicious content."), 0644); err != nil { t.Fatalf("failed to write skill file: %v", err) } cfgPath := filepath.Join(tmp, "config", "config.yaml") t.Setenv("SKILLSHARE_CONFIG", cfgPath) if err := os.MkdirAll(filepath.Dir(cfgPath), 0755); err != nil { t.Fatalf("failed to create config dir: %v", err) } initialRaw := "source: " + sourceDir + "\ntargets: {}\n" if err := os.WriteFile(cfgPath, []byte(initialRaw), 0644); err != nil { t.Fatalf("failed to write initial config: %v", err) } s := New(&config.Config{ Source: sourceDir, Targets: map[string]config.TargetConfig{}, }, "127.0.0.1:0", "", "") req := httptest.NewRequest(http.MethodGet, "/api/audit", nil) rr := httptest.NewRecorder() s.mux.ServeHTTP(rr, req) if rr.Code != http.StatusOK { t.Fatalf("unexpected status: got %d, body=%s", rr.Code, rr.Body.String()) } entries, err := oplog.Read(cfgPath, oplog.AuditFile, 10) if err != nil { t.Fatalf("failed to read audit log: %v", err) } if len(entries) == 0 { t.Fatal("expected at least one audit log entry") } if entries[0].Command != "audit" { t.Fatalf("expected latest command to be audit, got %q", entries[0].Command) } if entries[0].Status != "ok" { t.Fatalf("expected latest status to be ok, got %q", entries[0].Status) } } func TestHandleAuditAll_HighOnlyClassifiedAsWarning(t *testing.T) { tmp := t.TempDir() testutil.SetIsolatedXDG(t, tmp) sourceDir := filepath.Join(tmp, "skills") skillDir := filepath.Join(sourceDir, "high-only-skill") if err := os.MkdirAll(skillDir, 0755); err != nil { t.Fatalf("failed to create skill dir: %v", err) } if err := os.WriteFile(filepath.Join(skillDir, "SKILL.md"), []byte("# CI helper\nsudo apt-get install -y jq"), 0644); err != nil { t.Fatalf("failed to write skill file: %v", err) } cfgPath := filepath.Join(tmp, "config", "config.yaml") t.Setenv("SKILLSHARE_CONFIG", cfgPath) if err := os.MkdirAll(filepath.Dir(cfgPath), 0755); err != nil { t.Fatalf("failed to create config dir: %v", err) } initialRaw := "source: " + sourceDir + "\ntargets: {}\n" if err := os.WriteFile(cfgPath, []byte(initialRaw), 0644); err != nil { t.Fatalf("failed to write initial config: %v", err) } s := New(&config.Config{ Source: sourceDir, Targets: map[string]config.TargetConfig{}, }, "127.0.0.1:0", "", "") req := httptest.NewRequest(http.MethodGet, "/api/audit", nil) rr := httptest.NewRecorder() s.mux.ServeHTTP(rr, req) if rr.Code != http.StatusOK { t.Fatalf("unexpected status: got %d, body=%s", rr.Code, rr.Body.String()) } var resp struct { Summary struct { Total int `json:"total"` Passed int `json:"passed"` Warning int `json:"warning"` Failed int `json:"failed"` } `json:"summary"` } if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil { t.Fatalf("failed to decode response body: %v", err) } if resp.Summary.Total != 1 || resp.Summary.Warning != 1 || resp.Summary.Failed != 0 { t.Fatalf("unexpected summary: %+v", resp.Summary) } entries, err := oplog.Read(cfgPath, oplog.AuditFile, 10) if err != nil { t.Fatalf("failed to read audit log: %v", err) } if len(entries) == 0 { t.Fatal("expected at least one audit log entry") } e := entries[0] if e.Status != "ok" { t.Fatalf("expected audit status ok for high-only findings, got %q", e.Status) } if failed, ok := e.Args["failed"].(float64); !ok || int(failed) != 0 { t.Fatalf("expected failed=0 in log args, got %v", e.Args["failed"]) } warningSkills := toStringSlice(e.Args["warning_skills"]) if len(warningSkills) != 1 || warningSkills[0] != "high-only-skill" { t.Fatalf("expected warning_skills to contain high-only-skill, got %v", warningSkills) } if failedSkills := toStringSlice(e.Args["failed_skills"]); len(failedSkills) > 0 { t.Fatalf("expected no failed_skills for high-only findings, got %v", failedSkills) } } func TestHandleInstall_WritesDetailedInstallLog(t *testing.T) { tmp := t.TempDir() testutil.SetIsolatedXDG(t, tmp) sourceDir := filepath.Join(tmp, "skills") if err := os.MkdirAll(sourceDir, 0755); err != nil { t.Fatalf("failed to create source dir: %v", err) } cfgPath := filepath.Join(tmp, "config", "config.yaml") t.Setenv("SKILLSHARE_CONFIG", cfgPath) if err := os.MkdirAll(filepath.Dir(cfgPath), 0755); err != nil { t.Fatalf("failed to create config dir: %v", err) } initialRaw := "source: " + sourceDir + "\ntargets: {}\n" if err := os.WriteFile(cfgPath, []byte(initialRaw), 0644); err != nil { t.Fatalf("failed to write initial config: %v", err) } localSource := filepath.Join(tmp, "install-source") if err := os.MkdirAll(localSource, 0755); err != nil { t.Fatalf("failed to create local source: %v", err) } if err := os.WriteFile(filepath.Join(localSource, "SKILL.md"), []byte("# Installable Skill"), 0644); err != nil { t.Fatalf("failed to write SKILL.md: %v", err) } s := New(&config.Config{ Source: sourceDir, Targets: map[string]config.TargetConfig{}, }, "127.0.0.1:0", "", "") payload, _ := json.Marshal(map[string]any{ "source": localSource, "name": "ui-installed-skill", }) req := httptest.NewRequest(http.MethodPost, "/api/install", bytes.NewReader(payload)) rr := httptest.NewRecorder() s.mux.ServeHTTP(rr, req) if rr.Code != http.StatusOK { t.Fatalf("unexpected status: got %d, body=%s", rr.Code, rr.Body.String()) } entries, err := oplog.Read(cfgPath, oplog.OpsFile, 10) if err != nil { t.Fatalf("failed to read ops log: %v", err) } if len(entries) == 0 { t.Fatal("expected at least one operations log entry") } e := entries[0] if e.Command != "install" { t.Fatalf("expected latest command to be install, got %q", e.Command) } if e.Status != "ok" { t.Fatalf("expected latest status to be ok, got %q", e.Status) } detail := e.Args if detail["mode"] != "global" { t.Fatalf("expected mode=global, got %#v", detail["mode"]) } if detail["skill_count"] != float64(1) && detail["skill_count"] != 1 { t.Fatalf("expected skill_count=1, got %#v", detail["skill_count"]) } installed, ok := detail["installed_skills"].([]any) if !ok || len(installed) != 1 || installed[0] != "ui-installed-skill" { t.Fatalf("expected installed_skills to contain ui-installed-skill, got %#v", detail["installed_skills"]) } } func toStringSlice(v any) []string { switch vals := v.(type) { case nil: return nil case []string: return vals case []any: out := make([]string, 0, len(vals)) for _, item := range vals { if s, ok := item.(string); ok { out = append(out, s) } } return out default: return nil } } func TestHandleInstall_ErrorAlsoWritesInstallLog(t *testing.T) { tmp := t.TempDir() testutil.SetIsolatedXDG(t, tmp) sourceDir := filepath.Join(tmp, "skills") if err := os.MkdirAll(sourceDir, 0755); err != nil { t.Fatalf("failed to create source dir: %v", err) } cfgPath := filepath.Join(tmp, "config", "config.yaml") t.Setenv("SKILLSHARE_CONFIG", cfgPath) if err := os.MkdirAll(filepath.Dir(cfgPath), 0755); err != nil { t.Fatalf("failed to create config dir: %v", err) } initialRaw := "source: " + sourceDir + "\ntargets: {}\n" if err := os.WriteFile(cfgPath, []byte(initialRaw), 0644); err != nil { t.Fatalf("failed to write initial config: %v", err) } localSource := filepath.Join(tmp, "install-source") if err := os.MkdirAll(localSource, 0755); err != nil { t.Fatalf("failed to create local source: %v", err) } if err := os.WriteFile(filepath.Join(localSource, "SKILL.md"), []byte("# Installable Skill"), 0644); err != nil { t.Fatalf("failed to write SKILL.md: %v", err) } s := New(&config.Config{ Source: sourceDir, Targets: map[string]config.TargetConfig{}, }, "127.0.0.1:0", "", "") payload, _ := json.Marshal(map[string]any{ "source": localSource, "name": "dupe-skill", }) req1 := httptest.NewRequest(http.MethodPost, "/api/install", bytes.NewReader(payload)) rr1 := httptest.NewRecorder() s.mux.ServeHTTP(rr1, req1) if rr1.Code != http.StatusOK { t.Fatalf("unexpected status for first install: got %d, body=%s", rr1.Code, rr1.Body.String()) } req2 := httptest.NewRequest(http.MethodPost, "/api/install", bytes.NewReader(payload)) rr2 := httptest.NewRecorder() s.mux.ServeHTTP(rr2, req2) if rr2.Code != http.StatusInternalServerError { t.Fatalf("expected second install to fail, got %d, body=%s", rr2.Code, rr2.Body.String()) } entries, err := oplog.Read(cfgPath, oplog.OpsFile, 10) if err != nil { t.Fatalf("failed to read ops log: %v", err) } if len(entries) == 0 { t.Fatal("expected at least one operations log entry") } e := entries[0] if e.Command != "install" { t.Fatalf("expected latest command to be install, got %q", e.Command) } if e.Status != "error" { t.Fatalf("expected latest status to be error, got %q", e.Status) } if !strings.Contains(e.Message, "already exists") { t.Fatalf("expected error message to mention existing skill, got %q", e.Message) } }