#508 made --track --force clone first and replace the existing tracked repo
only after the clone succeeds, and refuse a local source (path or file://
URL) that is, or lies inside, that tracked repo. Users relying on --force to
recover a broken repo need to know the old one is kept on failure, and why a
source under the destination is rejected.
* fix(collect,install): collect only real skills; let --track take a local git path
collect treated every directory in a target as a local skill, so a scratch
folder was listed and `collect --force` copied it into the source. A folder
now counts only when it holds SKILL.md; the dashboard scan shares
FindLocalSkills and the dashboard collect request rejects such a folder.
`install /path/to/repo --track` failed with "requires a git repository
source" while file:///path worked. A local path that is a git repository
root is now normalized to the same file:// clone URL for --track (also past
the --branch guard); other local folders get an error that names file://.
Help text, docs (English and i18n) and the built-in skill reference follow.
* fix(install): keep the drive letter in file:// clone URLs for local --track paths
A Windows path such as C:/repo produced file://C:/repo, which makes C: the
URI authority instead of part of the path, so a tracked install from a local
Windows repository could clone the wrong location. Prefix the missing slash
so the URL is file:///C:/repo; POSIX paths are unchanged. Also cover the
dashboard install endpoint with a local-path --track test.
* fix(collect,install): keep UNC file URLs intact; require SKILL.md to be a file
The drive-letter fix lived in the helper shared with explicit file:// URLs,
which rewrote file://server/share/repo into a local path. Keep the slash
logic in the local-path --track case only and leave explicit URLs as parsed.
A subdirectory named SKILL.md passed the existence check, so a scratch folder
holding one was still collected. Both collect entry points (scan and the
dashboard request) now share sync.HasSkillFile, which rejects directories.
* fix(install): escape the local path in the file:// URL used by --track
Git decodes a file:// URL, so a repository path containing %20, %2F, a space
or # was cloned from a different path than the one IsGitRepo accepted. Build
the URL with net/url so those characters are escaped; drive-letter and POSIX
paths keep their form. The integration test now installs from a directory
whose name contains a space and a literal %20.
* fix(install): accept a local bare repository path for --track
A bare repository has HEAD and objects at its root but no .git entry, so the
local-path check rejected it while file:///same/path cloned fine. Add
IsLocalGitRepo (working tree or bare) and use it for both the --track
normalization and the --branch guard.
* test(install): build the bare repo path from a Windows file URL correctly
makeRemote returns file:///C:/dir on Windows; trimming only file:// left
/C:/dir, which filepath.Abs turned into D:\C:\dir, so the bare-repo test
failed on the Windows runner. Drop the slash before the drive letter.
* fix(install): refuse a --track local source that is the install destination
--force removes the tracked destination before cloning. When the local path
given to --track is that same directory, the removal deleted the only clone
source (and any unpushed work) before the clone failed. Compare the two with
os.SameFile, which also covers symlinked paths, and stop before touching the
destination.
* fix(install,collect): keep a tracked source inside its destination; reject special SKILL.md files
--track --force removed the destination before cloning, so a local source
nested below it (or given as an explicit file:// URL) was deleted along with
any unpushed work, and the clone then failed. Resolve the source and refuse
when it is the destination or lies under it, for dry runs too.
HasSkillFile used a not-a-directory test, so a FIFO named SKILL.md counted as
a skill and the collect copy blocked on it. Require a regular file; a
symlinked SKILL.md still resolves through os.Stat.
* fix(install): treat file://localhost URLs as local clone sources
Git clones file://localhost/path from the local filesystem, but the
containment guard only recognised an empty authority, so --track --force
could still delete a source given that way. Accept localhost (any case) as
local.
* test(install): build the localhost file URL from a slash path
On Windows the temp path starts with a drive letter, so prefixing it onto
file://localhost produced file://localhostC:\... instead of a valid URL and
the case failed on the Windows runner. Convert to slashes and add the
separator explicitly.
* fix(install): clone --track --force into a staging dir and swap it in last
--force removed the existing tracked repo before cloning, so any source that
lived under it (plain path, file:///, file://localhost, UNC, symlink or 8.3
alias) was destroyed before git could read it, and a failed clone also lost
the old repo. Clone beside the destination, run the checks and the audit on
the staging copy, then move the old repo aside, rename the new one in and
drop the backup; on any failure the staging copy is removed and the old repo
stays. The pre-removal containment refusal now covers plain local paths only
(the url.Parse special-casing is gone).
* fix(install): refuse a file:// --track source inside the forced destination
The staged swap in 7375400 still lost data for a file:///, file://localhost
or UNC source nested under the destination: the clone succeeded, the old repo
(with the source inside it) was renamed to the backup, and removing the backup
deleted the source's uncommitted work, which a clone cannot carry.
Restore the file URL to local path mapping (now including UNC hosts) so the
containment refusal covers every local spelling, not only plain paths. The
test now keeps an uncommitted file in the source and requires it to survive.
* fix(install): apply the source-inside-destination refusal only to --force
The refusal ran before the --update branch, so `install <tracked repo path>
--track --update` was rejected even though an update pulls the existing
checkout in place and removes nothing. Only the forced replacement can
destroy a source that lives under the destination, so check there.
* fix(install): report a forced clone's root skill under its tracked name
With --force the repo is discovered in the .skillshare-clone-<stamp> staging
directory, and discoverSkills names a root SKILL.md after the directory, so
the CLI summary, dashboard response and oplog listed a random staging name
instead of _foo. Use the tracked name for the root entry.
* fix(install): stage fresh tracked clones so cleanup never hits another installer
A fresh tracked install cloned straight into the destination, and the
deferred cleanup removed it on any failure. If another process created the
same tracked repo between the existence check and the clone, the failing
install deleted that process's checkout. Clone every install into its own
staging directory and rename it in last; a claimed destination makes the
rename fail and only the staging copy is removed.
* fix(sync): replace copy-mode copies with links when switching back to merge
Switching a target from copy back to merge left every copy whose entry name
did not change as a real folder. Merge sync treated it as the user's own
folder, so status and doctor kept saying "run skillshare sync" while sync
changed nothing, and only `sync --force` turned it into a link.
Copy mode already replaces merge-mode links with copies on its own, so merge
sync now replaces a folder the manifest records with a checksum (a copy-mode
copy) with a link, without --force. Folders the manifest does not record, or
records as a link, stay untouched. The pre-sync target backup is unchanged.
The CLI and dashboard diffs name these entries as copies sync replaces
instead of suggesting --force, and the sync-modes docs describe the switch.
* fix(sync): keep copy-mode copies the user edited when switching to merge
The first version replaced any folder the manifest recorded as a copy-mode
copy. The manifest checksum is only a record, so a copy edited since copy
mode made it was deleted too, and `sync --json` and project-mode dashboard
sync take no pre-sync backup to restore it from.
Replace the folder only while it still hashes to the recorded checksum
(Manifest.OwnsCopy). An edited copy is kept and `sync --force` still
replaces it; diff keeps suggesting --force for it. A copy whose name: was
rewritten by prefixed naming, or that was made with custom ignore patterns,
no longer hashes to the source checksum and is kept the same way.
* fix(ui): say a copy-mode copy in a merge target is replaced by a link
The Sync page picks a row's text from the diff item's action alone. The
copy-mode copy that merge sync now replaces comes from the server as an
update, which the page worded as "Link is broken or points elsewhere. Will
be relinked" even though no link exists yet.
Match the server's reason and show "Copy made by copy mode. Will be replaced
by a link" instead, in all eleven dashboard languages.
* docs(sync): say only unedited copy-mode copies are replaced on merge sync
The sync-modes paragraph promised that copies copy mode made are replaced
with links without --force. Merge sync keeps a copy that no longer hashes to
the checksum copy mode recorded, so an edited copy, or one whose name: copy
mode rewrote for prefixed naming, still needs --force.
State the three cases in sync-modes and qualify the diff Modified and Local
override labels, in English and the ja, ko, zh-Hans and zh-Hant copies.
* fix(sync): keep the copy until its replacement link exists
Replacing a copy-mode copy removed the folder first and then created the
link. If creating the link failed (no symlink or junction rights on a
Windows or network filesystem), sync returned an error with the skill gone
from the target. This path now also runs on a plain sync, not only on
--force.
Park the folder beside the entry, create the link, then delete the parked
folder; on failure the folder is moved back. A parked folder left by a run
that died mid-way may be the only copy, so the next sync stops with a message
instead of deleting it. The manifest also forgets the copy-mode mtime and
naming records of an entry that is now a link.
* test(sourcefs): register replaceWithLink's target writes in the raw-write ratchet
The previous commit moved the merge-mode folder replacement into
replaceWithLink, which the ratchet reports as new raw os calls and the old
os.RemoveAll allowance as stale. All of them act on the sync target, not the
skills source, like the neighbouring entries.
* fix(sync): bound the parked copy's name and document the naming exception
The folder parked while a link is created was named after the entry, so an
entry near the 255-byte filename limit (a long flattened nested skill)
could not be moved aside and its replacement failed. The parked name is now
a fixed-length hash of the entry name.
sync-modes also says what happens when `target_naming` changes in the same
sync: the copy gets a new entry name and the prune pass removes it as an
orphan whether or not it was edited, as it did before this change.
* feat(sync): make prefixed target naming misconfigurations visible
Prefixed naming (#497) works, but several of its failure modes only showed up
at sync time or gave advice that cannot be followed:
- A collision that only prefixing creates told the user to "rename one in
SKILL.md", which a tracked skill cannot do, and never said the prefix caused
it. The hint now names the prefixing and points at renaming the other skill or
re-tracking the repo with --name.
- `target add` silently wrote mode: copy when the inherited naming is prefixed.
The CLI now says so.
- A target that resolves to prefixed outside copy mode was reported only by
sync. status, doctor and target list (plain and JSON) now flag it, and the
sync/validation and `--skills=true` errors say how to fix it.
- The dim "duplicate skill names (isolated by ...)" line printed on every sync
even when nothing was wrong, and before a failing sync. Isolated duplicates
are not a problem, so it is dropped; the website docs still showed an
outdated form of this output and are corrected in all locales.
* fix(status): flag prefixed-outside-copy in the TUI list and status --json
Codex review of #503 found two surfaces the new check missed:
- The interactive `target list` (the default on a terminal) never read the
item's naming error, so a prefixed + merge target looked healthy there. The
list row now marks the mode with "!" and the detail panel shows the fix.
- `status --json` (global and project) builds its target entries directly, so
scripts got no signal. Each target now carries a `warning` string, matching
`target list --json`.
* docs(troubleshooting): sync no longer prints a message for isolated duplicates
The collision troubleshooting tip still said sync shows an info message when
filters isolate duplicate skill names. That line was dropped, so the tip now
says sync prints nothing about them. Codex review of #503 flagged the stale
English page and its four translations.
* fix(config): point managed-project naming errors at the project settings
The "set mode: copy on the target" hint is wrong for a target a global
`projects:` entry expands into: it cannot be edited with `target` or under
`targets:`, and the mode lives in the project's skills settings. The hint now
depends on whether the target belongs to a managed project (Codex review of
#503).
The naming/mode check becomes a TargetConfig method so status, doctor and
target list share it, which also lets the hint see the project root. Along the
way: doctor reuses it, the TUI list renders the mode once, and
reportTargetAdded takes a flag instead of comparing a mode string.
* fix(config): hint the project settings for managed-project naming errors
ProjectNamingError (the config-load check for a global `projects:` entry) still
returned the bare naming error, so a project that inherits prefixed with a
non-copy mode got no fix. It now names the project's skills settings, like the
expanded targets do. The built-in skill's sync reference also mentions that
status, doctor and target list flag the misconfiguration before sync.
Found by the second /code-review pass on #503.
* fix(sync): detect prefix collisions from the colliding paths
reportCollisions decided a collision came from prefixing when its name was not
also a duplicate in the source. A tracked skill that joined two ordinary
skills already sharing the name was therefore sent to the "rename one in
SKILL.md" hint, which a tracked skill cannot follow (Codex review of #503).
A collision on a prefixed target that includes a tracked path now gets the
tracked-skill hint, whatever else shares the name. The wording no longer claims
prefixing renamed the skill, since a name that already starts with the repo
name is unchanged.
* fix(sync): use discovered repo metadata for the tracked-skill hint
The collision hint treated any path segment starting with "_" as a tracked
repo, so an ordinary skill under a folder such as org/_drafts (no .git) was
told it could not be renamed and to re-track a repo that does not exist. It now
uses DiscoveredSkill.IsInRepo, the same signal prefixed naming uses.
The prefixed docs also gain the fix for a target a global `projects:` entry
expands into (projects.<root>.skills.mode: copy), since `target` cannot edit
those. Both from Codex review of #503.
* fix(sync): keep both collision hints when targets disagree
The same name can clash on a prefixed target with a tracked skill and on
another target between ordinary skills only. The prefixed flag was OR-ed across
targets, so the second case lost its rename/filter hint. Track both kinds
separately while grouping, and print each hint that applies (Codex review of
#503).
* fix(sync): keep the rename hint inside a mixed collision group
When a tracked skill and two ordinary skills share a prefixed name, re-tracking
the repo fixes only the tracked one; the ordinary pair still clashes and is
excluded. The group now also shows the rename/filter hint when at least two of
its participants are not tracked (Codex review of #503).
* fix(sync): offer filters in the tracked-skill collision hint
Two tracked skills of the same repo with the same name collide after
prefixing, and neither renaming a tracked skill nor re-tracking the repo
separates them. The hint now also names include/exclude filters, so every
collision on a prefixed target has an actionable remedy (Codex review of #503).
* docs(sync-modes): limit the target list claim to targets under targets
target list builds from the config without project expansion, so it cannot
flag a target a `projects:` entry expands into; status and doctor can. The
prefixed paragraph and the built-in skill reference said all three flag it
(Codex review of #503).
* fix(sync): close gaps found while simulating the prefixed naming switch
Simulating the #497 reporter's switch from merge + flat to copy + prefixed
turned up four problems:
- `target X --mode copy --target-naming prefixed` applied only --mode, since
the setter dispatch returned after the first flag. Both flags given
together now check the final pair, then apply in an order that keeps the
saved pair valid (copy mode first, any other mode last).
- Skipped skills were only counted, so a prefixed name over 64 characters
vanished with "1 skill(s) skipped". Sync now names the first five with
their reason; the cap keeps huge sources from flooding the output.
- In copy mode a merge-mode link to the skill was not a managed entry, so
when a local folder held the new name the old link was pruned and the
skill left the target, contrary to the documented "old managed entry is
preserved". Copy mode now migrates such links like managed copies.
- PATCH /api/targets validated the mode/naming pair against the current
skills state, so disabling skills while changing mode was rejected. It now
checks the state the request leaves the target in.
* docs(target): drop stray space in the Japanese mode+naming sentence
* fix(diff): save paired target settings once and report kept legacy entries
- `target X --mode M --target-naming N` ran the two setters, each saving
the config, so a failed second save left half the change behind (Codex
on #504). Both fields are now set and saved once, after the final pair
is checked.
- When a local folder holds the name a skill's naming now gives it, sync
keeps the skill under its old entry and leaves the folder alone, even
with --force. diff still called the folder a "local copy" and suggested
`sync --force`, which does nothing for it. CLI and Web API diff, copy
and merge mode, now report the folder and the entry the skill stays at.
* fix(sync): migrate only links the manifest records as merge-made
Copy mode treated any link to the skill's source at an old naming's name as
the entry merge mode left behind, so a user's own link was renamed and
replaced with a copy (Codex on #504). A link now migrates only when the
manifest records it as "symlink", which merge mode writes for links it makes;
other links stay as the user left them. The value is now a named constant.
* fix(diff): mark kept legacy entries as unaffected by force
Two problems Codex found on #504:
- The Web API diff sent a local folder on a skill's new name as a "skip",
which the dashboard shows as an edited entry that Force replaces. Sync
keeps that folder and the legacy entry even with force, so the preview
promised a change that never happens. It is now its own "kept" action,
shown with its reason and not counted.
- `target X --mode M --target-naming N` printed the target's own naming as
the old value, so a target inheriting standard or prefixed showed
"flat -> ...". It now prints the naming the target had in effect.
* fix(diff): keep kept-name conflicts out of the sync count
Two problems Codex found on #504:
- A local folder on a skill's new name counted toward "N to sync" and
fell through to the plain `skillshare sync` hint, though sync changes
nothing there until the folder is renamed or removed. Such rows now
carry a kept flag, count as neither sync nor local, and print their own
hint; a target whose only row is kept still shows that row.
- The dashboard grouped targets by row name and icon only, so two targets
keeping the same skill at different old entries merged and showed one
target's old location for both. The row detail is now part of the key.
* fix(diff): do not list a kept local folder's files as deletions
A kept row (a local folder on a skill's new name) still pointed at that
folder, so `diff --stat` and `--patch` listed each of its files as removed,
though sync never touches the folder (Codex on #504). Kept rows no longer
point at a target directory, so no file-level diff is built for them in the
CLI or the TUI.
* fix(diff): report kept skills consistently in every diff view
An exhaustive review of the kept-row change (prompted by two Codex findings
on #504) found the same gap in several places:
- A target whose only rows were kept was summarized as "in sync", and mixed
summaries left it out of every count. Such targets now count as "N kept
under old name" with a warning mark, and the scan progress counts them.
- Plain output and the TUI hid where the skill stays; rows now read
"name (stays at old-name)". The TUI also lacked the kept Next hint and
called kept-only targets "differs"; it now matches the plain output.
- `diff --json` emitted kept rows as "remove", indistinguishable from
local-only folders; it now emits "kept", as the Web API does. The diff
docs' JSON example also showed actions the CLI never emits.
- Renamed rows whose old entry is a merge-made link showed a bogus file
stat, because the link was walked as a file; a link now stands for the
folder it points to.
- A dry-run migration printed "Would copy" to the old path; it now names
the new one.
* fix(sync): stop reporting kept folders and skipped skills as pending work (#509)
Three reports told users to do something sync cannot do, or hid what it
did:
- Copy and merge sync kept a folder the user made on a skill's name but
counted it as "up to date" with no hint. Sync now counts it as local and
adds one capped line per target naming the folders and saying that
`sync --force` replaces them. The line is added in SyncSkillTarget, so
the dashboard gets it too.
- status and doctor counted skills that sync skips on purpose (invalid
names under standard or prefixed naming, name collisions) as "not
synced — run skillshare sync". Running sync can never add them, so the
advice looped. They now compare against the skills sync places.
- diff marked a target whose only items were local-only folders as "to
sync" and `synced: false`. Those items are still listed, but they no
longer make the target pending.
* fix(target): apply every setting flag, require flag values, report no-ops as unchanged (#507)
* fix(target): apply every setting flag, require flag values, report no-ops as unchanged
`skillshare target <name>` dispatched --mode, --agent-mode and
--target-naming through an if-chain that returned after the first match,
so `--agent-mode copy --target-naming prefixed` applied one setting and
silently dropped the other. Filters, --skills and --dry-run had the same
early-return problem.
- Check --mode, --agent-mode and --target-naming as a whole and save
once, in global and project mode (one targetSettingsUpdate replaces six
per-flag functions).
- Reject --mode/--agent-mode/--target-naming combined with filters or
--skills, and --dry-run without --skills, instead of dropping them.
- A value flag followed by another flag (or an empty string) now reports
"<flag> requires a value"; `--target-naming -p` used to report an
invalid naming '-p'.
- A value the target already has is reported as unchanged and the config
is not rewritten.
* fix(target): leave the skills pair alone on agents-only changes
A target with skills off may keep target_naming prefixed with a merge
mode it cannot sync; validateGlobalTarget and validateProjectTarget only
check that pair for enabled skills. The combined settings update ran the
pair check for every setting, so `target claude --agent-mode copy` was
refused on such a target although the old agent-mode handler never looked
at skills settings. Check the pair only when --mode or --target-naming is
given.
* docs(target): show combined settings in --help and the built-in skill
The combined --mode/--agent-mode/--target-naming form is now the way to
move a target to copy + prefixed in one step, but neither the help
examples nor the built-in skill's target reference showed it.
Sync re-copies a managed copy whose recorded naming differs from the
current one, for example after a migration stopped between the rename
and the re-copy. Diff skipped it on the mtime fast path and reported the
target in sync while its SKILL.md kept the old name. Check the recorded
naming first in both the CLI and the dashboard diff.
The command reference, both schemas and the dashboard field help still
said skills target naming is ignored in symlink mode, while prefixed is
refused there.
After target_naming changes, sync renames the managed entry in place,
but diff looked only under the new name, so the CLI and the dashboard
showed the skill as new while hiding the old entry. Resolve the legacy
entry and report it as a rename instead.
Codex review on #499: the conflict pages said "none of these matter in
symlink mode", which reads as if a symlink target and a merge or copy
target on one folder were fine too. Mode still conflicts there; only
filters and naming stop mattering when both targets use symlink.
The sync command page said filters keep flat names only for standard
naming; prefixed names target entries from SKILL.md as well, so the same
caveat applies. Translations follow.
A /simplify pass on #499 found the symlink exception too narrow: symlink
mode links the whole folder to the source and reads neither target naming
nor include/exclude, yet two symlink targets with different filters were
still reported as undoing each other. State the rule once (same symlink
mode means same folder contents) instead of exempting only naming, and
resolve the mode with cmp.Or like sync's isSymlinkMode rather than a
local copy of the sync package's resolver. Docs now say none of these
settings matter in symlink mode.
Users need to know when prefixed helps (same-named skills from different
tracked repos), what name it produces, that it is copy-only, and that
switching between any two namings now renames managed entries in place.
The translated pages follow, the ja and zh-Hans naming headings get an
explicit target-naming id so the new links resolve, and the target_naming
runbook gains steps for prefixed sync, flat -> prefixed -> standard
migration and the merge-mode rejection.
Codex review on #499: the troubleshooting and doctor pages explained the
conflict as one target adding what the other filters out, and offered
"give both targets the same filters" as a fix. When the conflict comes
from mode or target naming, that fix does nothing and the explanation
doesn't match what happens (entries renamed, links swapped for copies).
Describe the conflict as each sync undoing the other's work and say all
three settings must agree, in English and the four translations.
Codex review on #499: after 588d29c7 the conflict check skips
target_naming when the shared mode is symlink, but the doctor, sync and
troubleshooting pages (and their translations) still said any naming
difference makes shared targets undo each other. That could lead users
to turn off a valid symlink target, so qualify the rule.
The warning now reads "different settings", but the explanatory prose
around it in the doctor and common-errors pages still described the
conflict as include/exclude filters only. Name mode and target_naming
there as well, in English and the four translated doc sets.
Two targets writing one skills folder with different target_naming or
mode undo each other on every sync (flat links vs standard names, merge
vs copy), but only include/exclude were compared, so sync and doctor
fell back to the generic shared-path hint.
Compare the effective mode and target naming too, so an unset value
equals the default it resolves to. The global default mode is not
carried on the target, so SkillsFolderConflicts takes it from its three
callers. The warning now says "different settings" instead of "different
filters".
Fixes#498
The dashboard page reference did not mention Install all, Prune, Discard
all, the unmatched filter notice, Edit target/Edit extra, or that New
skill and Link folder moved into the Install menu, so readers had no way
to find them from the docs.
The CLI's `--remove-target --prune` removed a symlink-mode target no matter
where it pointed, while the dashboard removed it only when it still linked
to the extra's source folder. A user who repointed that link at their own
folder could lose it from the CLI. Both now go through one shared
sync.ClearExtraTarget, so the safer rule applies everywhere; the CLI warns
and leaves anything that is not a link to the source instead of failing.
Refs #491
A directory extra used to sync every file to every target, so a tool that
only wanted a few docs got the whole folder. Each target can now set
gitignore-style include/exclude patterns, matched on the path inside the
source. Merge targets prune links to files that stop matching; copy targets
keep earlier copies, since nothing records which copied files are ours.
Filters are rejected for symlink mode and single-file extras, and sync warns
when an include matches nothing.
The dashboard previously forced users to delete and re-add a target or an
extra to change it. Edit target now changes the folder, file name, mode,
flatten and filters with a live preview; Edit extra renames an extra or
points it at another source folder. A moved target or source drops the
links left at the old place and syncs right away.
CLI: --include/--exclude on extras init, and --add-include, --add-exclude,
--remove-include, --remove-exclude on extras <name>.
Refs #435
The 0.25.2 fixes changed behavior the command pages still described
the old way: update said any .git/ directory makes a tracked repo, the
uninstall Project Mode section missed --into repos and the refusal
inside a tracked repo, and the audit rule table lacked
prompt-injection-5. Also translate the uninstall example comments that
were left in English in ja, ko, zh-Hans and zh-Hant.
Reuse the shared tracked checkout resolver after checking the typed path so uninstall org/team finds org/_team without taking precedence over an existing skill or folder. Classify tracked targets by the underscore checkout rule across CLI uninstall entry points, retaining ambiguity errors and the shared inside-repo refusal.
Codex review of #481 found three problems with the shorthand change:
- `update org/team -p` and the dashboard stream updated the org/_team
repo even when a skill exists at org/team, which used to win because
the shorthand was not rewritten there. FindTrackedCheckoutUnlessSkill
skips the nested shorthand when a directory exists at the typed path;
plain names keep their repo-first behavior.
- Global `update team/` cleaned the name for repo matching but not for
skill matching, so it silently updated `_team` instead of reporting the
skill/repo collision that `update team` reports. resolveByBasename now
cleans the name once for both.
- The update.md example sits in the Project Mode section but lacked -p
(also in the four translations).
A repo installed with `--track --into org` lives at `org/_team`. Only
POST /api/update accepted `org/team`; the dashboard stream and
`update -p` prefixed the whole name (`_org/team`), and global `update`
compared the full name with the basename, so each reported not found.
Move the candidate rule (the name as typed, then `_` added to the last
segment, never leaving the source root) into install.FindTrackedCheckout
and the basename match into install.MatchTrackedRepos, and use them from
the single update, the stream, project and global CLI update. A shorthand
resolves to its own `org/_team`, never to a top-level `_team`; plain names
and full paths keep their behavior.
Avoid blocking legitimate Markdown SDK parameters and ambiguous disclosure advice by default while retaining visible HIGH findings and strict-policy gating. Preserve explicit concealment, custom severity overrides, and shell dataflow coverage in HTML and comments. Add regression coverage and document rule-ID compatibility.
The CLI removed any skill or folder inside a tracked repo on its own:
`skillshare uninstall _team/foo` moved the skill out of the repo's
checkout, and `_team/vendor/_lib` (a submodule) was even treated as a
tracked repo because the CLI marks every git checkout as one. Either way
the repo was left dirty for the next update. The dashboard already
refused single skills inside a repo, but the rule lived only in its
handler.
The rule now lives in internal/uninstall, which both the CLI and the
dashboard go through: an item below a "_"-prefixed git checkout fails
with ErrInsideRepo in Preflight and Run, even with --force. A followed
source link is the user's own checkout, so skills below it can still be
removed one at a time.
The uninstall reference documents the rule and how to name a repo
installed with --into, with ja/ko/zh-Hans/zh-Hant translations.
The dashboard now asks again and force-uninstalls a tracked repo with
uncommitted changes or an unreadable git status, and a project's
sources.mcp file is refused when it resolves outside the project. The
ui and mcp command pages did not say either.
The leak check compared only source skills, so a skill the user keeps
in ~/.claude/skills (which merge mode preserves) passed as harmless,
although OpenCode loads it. Read the writer's folder too and count
entries sync did not put there and OpenCode's own folder lacks.
The wording no longer says these skills are left out by filters, and
the suggestion asks to sync them to opencode, which fits both causes.
Refs #458
A symlink-mode writer exposes the whole source, so doctor cannot tell
which skills OpenCode receives from that folder and keeps the general
warning. The page said the check only lists leaked skills, which is
not true in that setup.
Refs #458
With OPENCODE_DISABLE_CLAUDE_CODE_SKILLS set, OpenCode does not read
.claude/skills, yet doctor still warned that skills leak in through
it, so a user who had already fixed the leak could never clear the
warning.
Record in targets.yaml which environment variables turn off each
also_scans folder and skip those folders in RuntimeScanPaths when a
variable is true in skillshare's environment, read the way OpenCode
reads it. doctor, sync, the dashboard and readsFrom then agree, and
doctor says which variable caused the skip, because OpenCode may run
with another environment. The doctor hint now comes from the same
table.
Refs #458
OpenCode loads skill files concurrently, so which copy of a name wins
is not fixed; its own folder does not reliably win. A source skill
synced to both folders is harmless anyway because both copies have
the same content. Count only source skills in OpenCode's folder, so a
local skill there no longer marks a same-named skill from another
folder as already present.
The comparison used each target's filtered selection, which skips the
target_naming: standard validation and collision handling sync applies.
When two skills named dev collide in OpenCode's standard folder, sync
writes neither there, yet a claude target filtered to one of them
still delivered it to OpenCode and no warning appeared. Use the
resolved skills that sync writes instead.
Refs #458
OpenCode reads .claude/skills and .agents/skills first and its own
skills folder last, keeping the last skill of each name. A skill synced
to both opencode and claude therefore loads once, yet doctor and the
sync summary warned on every setup with both targets, with no way to
silence it.
The real effect is different: skills kept out of opencode by targets:
or include/exclude still reach it through another target's folder.
For opencode, count only those skills, name them in doctor, and point
at OpenCode's OPENCODE_DISABLE_CLAUDE_CODE_SKILLS and
OPENCODE_DISABLE_EXTERNAL_SKILLS. Other runtimes keep the old check
until their rule for same-named skills is verified.
Refs #458
Saves follow a symlinked config.yaml to its target so dotfile links
survive. For a project config that also lets a cloned repository point
.skillshare/config.yaml at any file the user can write, including one
that does not exist yet, and every project save, plugin change, hooks
change, MCP change, or legacy migration would then rewrite or create it.
All five writers now resolve the destination through one helper,
utils.ConfigWritePath. A global config keeps writing through its link.
A project config must resolve inside its project; otherwise the save
fails and names the link so the user can replace it with a regular
file. The one-time legacy migration skips persisting instead, and the
next save reports the link.
The CLI and dashboard update a tracked repo through update.TrackedRepo,
which never looked for submodules. A pull that turned a skill directory
into a submodule reported success and the skill vanished on the next
sync. TrackedRepoResult now carries the skipped-submodule warnings and
both callers show them.
Refs #433
skillshare never fetches submodules, so a gitlink is an empty directory
after any clone. Installing that path reported success with nothing in
it, a path inside it failed with a misleading "does not exist", and
whole-repo discovery dropped its skills without a word.
Refuse a subdir that is or lies inside a submodule, naming the
submodule, its pinned commit and upstream URL, and warn for each
submodule skipped by whole-repo discovery and --track.
Refs #433
Release-As: 0.25.1
The pages added with the block modes covered what they write, not what
the review fixes made them do. The sharing guide still said sync
overwrites a modified target, which is wrong for a block: sync stops
until the edit is collected or the block is rewritten.
The guide, the extras reference and the built-in skill now cover the
block's Collect and Rewrite choices, block statuses, the target file
dialog, what a mode change removes, how restore treats a block, and
the cases a block target is refused. Common errors gains an Extras
section for the four new messages. The --mode help of extras init,
--add-target and the mode command listed only import among the
single-file modes; it now lists prepend and append too.
Refs #436
Tools without an @import directive (codex, gemini, cursor) could only
take a shared instruction file as a symlink or copy, which replaces the
target's own file. Teams that want one shared AGENTS.md plus the user's
own notes in the same file had no way to express that.
prepend and append write the source into the target file as a managed
block fenced by skillshare:extra markers that carry the source path and
a content hash. Sync inserts the block once and then rewrites it in
place, status reports modified when the block body no longer matches
its hash, Collect copies the edited body back to the source, Reapply
rewrites the block from the source, and restore removes only the
block. Lines outside the block, and markers inside code fences, are
never touched. Several managed blocks (and an import line) may share
one target file; the connection validator only rejects a file when a
replacing mode (symlink, copy, merge) is involved.
Refs #436
Bring the pages, the built-in skill and the translations up to date with
the pending release before the Release PR is reviewed: the README Latest
callouts for v0.25.0; mcp serve, Oh My Pi, DeepSeek Harness and GitLab Duo
in the ja, ko, zh-Hans and zh-Hant pages; the `--` option and the --enable
rollback of link and unlink; the missing serve skip reasons and its
cross-origin refusal; standard naming rules; junctions kept across volumes;
OMP accounts receiving native code hooks; and the 79-target count.
A non-loopback --http listener accepted a bearer token over plain HTTP,
so anyone on the path could read the token and the skills. Off loopback
it now also needs --tls-cert and --tls-key and serves HTTPS; loopback
stays plain, so a TLS-terminating proxy in front still works.
The Agent Skills format caps compatibility at 500 characters, and hosts
that validate entries reject longer ones, so serve skips such a skill
with a warning, as it does for an overlong description.
metadata is deliberately not held to the format's string values: lists
there are common, tool-fallback clients read them fine, and skipping
those skills would hide them from every client to satisfy a few.
A managed project's name may hold spaces, so the Skillshare tab built
`--target my app@claude`, which the save path split into two words and
serve rejected as an unknown target. The command is now joined from
quoted words.
The Agent Skills format caps a description at 1,024 characters, and
hosts validating entries reject longer ones, so serve skips such a skill
with a warning instead of advertising it. The docs list every skip reason.
Agents on a disposable VM, in a hosted assistant or behind an MCP gateway can
reach an MCP endpoint but not the folder skills sync to, so they got tools and
none of the user's skills (#428).
`skillshare mcp serve` is a read-only server for the skills skillshare already
manages. It declares io.modelcontextprotocol/skills and implements skills/list,
skills/get and resources/read: one entry per skill, its URI from the source
path, the full frontmatter, and every file with a sha256 digest and size.
--target applies that target's selection, and the source is reread at most
every 5 seconds so install, update, enable and disable show up without a
restart; unchanged files keep their digest. stdio is the default; --http
serves Streamable HTTP and needs SKILLSHARE_MCP_TOKEN off loopback.
Skills the extension cannot carry are skipped with a warning instead of being
published incomplete: a name that breaks the Agent Skills rules or differs from
its directory, more than 512 files or 16 MiB, or a nested skill that is not
served. --check lists them without serving. The naming rules moved to
internal/skillpkg so sync and the server share them.
Few clients support the extension yet, so the server also offers list_skills
and read_skill tools. A client that declares the extension does not see them,
so it never gets each skill twice.
sync.SelectTargetSkills is the one place that turns discovered skills into a
target's selection (enabled, include/exclude, frontmatter targets).
Refs: #428
Reject unsupported client registration values and CIMD client or callback conflicts before syncing invalid settings to Pi. Keep dcr and custom Pi options supported, identify the legacy codemode alias, and document current Pi launch behavior.
Rewrite frontmatter as bytes and read and write target assignments through sourcefs with the discovery follow policy. Refuse nested SKILL.md links with per-skill batch errors or HTTP 400 while regular followed skills remain editable and outside files stay unchanged.
Copy staged directory links as concrete content through the source root, skip dangling links, and reject directory cycles. Preserve the existing skill under a sibling name and restore it if moving or copying the replacement fails so followed checkout updates cannot discard the old content.
Recreate nested links with their stored target text instead of dropping them before removing the original skill. Reuse the junction target resolution and symlink fallback used by moveLink without traversing link contents.