362 Commits
Author SHA1 Message Date
Willie d882f05848 docs: cover forced tracked-repo uninstall and project MCP source boundary
The dashboard now asks again and force-uninstalls a tracked repo with
uncommitted changes or an unreadable git status, and a project's
sources.mcp file is refused when it resolves outside the project. The
ui and mcp command pages did not say either.
2026-10-07 14:12:59 +08:00
Willie 3ec60a3732 fix(doctor): count skills kept by hand in another target's folder
The leak check compared only source skills, so a skill the user keeps
in ~/.claude/skills (which merge mode preserves) passed as harmless,
although OpenCode loads it. Read the writer's folder too and count
entries sync did not put there and OpenCode's own folder lacks.

The wording no longer says these skills are left out by filters, and
the suggestion asks to sync them to opencode, which fits both causes.

Refs #458
2026-10-07 12:58:22 +08:00
Willie 2481179424 Merge branch 'main' into runkids/458-opencode-env 2026-10-07 12:52:39 +08:00
Willie c3c9e06f44 docs(doctor): note when the OpenCode leak check falls back
A symlink-mode writer exposes the whole source, so doctor cannot tell
which skills OpenCode receives from that folder and keeps the general
warning. The page said the check only lists leaked skills, which is
not true in that setup.

Refs #458
2026-10-07 12:15:28 +08:00
Willie 8606dc4940 feat(doctor): honor OpenCode switches that turn off external skills
With OPENCODE_DISABLE_CLAUDE_CODE_SKILLS set, OpenCode does not read
.claude/skills, yet doctor still warned that skills leak in through
it, so a user who had already fixed the leak could never clear the
warning.

Record in targets.yaml which environment variables turn off each
also_scans folder and skip those folders in RuntimeScanPaths when a
variable is true in skillshare's environment, read the way OpenCode
reads it. doctor, sync, the dashboard and readsFrom then agree, and
doctor says which variable caused the skip, because OpenCode may run
with another environment. The doctor hint now comes from the same
table.

Refs #458
2026-10-07 11:40:51 +08:00
Willie 834f88efb9 fix(doctor): compare resolved skills when judging OpenCode overlap
OpenCode loads skill files concurrently, so which copy of a name wins
is not fixed; its own folder does not reliably win. A source skill
synced to both folders is harmless anyway because both copies have
the same content. Count only source skills in OpenCode's folder, so a
local skill there no longer marks a same-named skill from another
folder as already present.

The comparison used each target's filtered selection, which skips the
target_naming: standard validation and collision handling sync applies.
When two skills named dev collide in OpenCode's standard folder, sync
writes neither there, yet a claude target filtered to one of them
still delivered it to OpenCode and no warning appeared. Use the
resolved skills that sync writes instead.

Refs #458
2026-10-07 11:10:30 +08:00
Willie d055f9c22a fix(doctor): warn about OpenCode overlap only when skills leak
OpenCode reads .claude/skills and .agents/skills first and its own
skills folder last, keeping the last skill of each name. A skill synced
to both opencode and claude therefore loads once, yet doctor and the
sync summary warned on every setup with both targets, with no way to
silence it.

The real effect is different: skills kept out of opencode by targets:
or include/exclude still reach it through another target's folder.
For opencode, count only those skills, name them in doctor, and point
at OpenCode's OPENCODE_DISABLE_CLAUDE_CODE_SKILLS and
OPENCODE_DISABLE_EXTERNAL_SKILLS. Other runtimes keep the old check
until their rule for same-named skills is verified.

Refs #458
2026-10-07 11:00:05 +08:00
Willie 3f1a4d1310 Merge remote-tracking branch 'origin/main' into runkids/project-config-symlink-policy 2026-10-07 10:30:47 +08:00
Willie f4c77d53c3 fix(config): refuse project config writes that leave the project
Saves follow a symlinked config.yaml to its target so dotfile links
survive. For a project config that also lets a cloned repository point
.skillshare/config.yaml at any file the user can write, including one
that does not exist yet, and every project save, plugin change, hooks
change, MCP change, or legacy migration would then rewrite or create it.

All five writers now resolve the destination through one helper,
utils.ConfigWritePath. A global config keeps writing through its link.
A project config must resolve inside its project; otherwise the save
fails and names the link so the user can replace it with a regular
file. The one-time legacy migration skips persisting instead, and the
next save reports the link.
2026-10-07 10:19:12 +08:00
Willie f2f663689b fix(install): warn about submodules on tracked updates
The CLI and dashboard update a tracked repo through update.TrackedRepo,
which never looked for submodules. A pull that turned a skill directory
into a submodule reported success and the skill vanished on the next
sync. TrackedRepoResult now carries the skipped-submodule warnings and
both callers show them.

Refs #433
2026-10-07 09:35:59 +08:00
Willie b7265d6496 fix(install): refuse git submodule paths instead of installing empty dirs
skillshare never fetches submodules, so a gitlink is an empty directory
after any clone. Installing that path reported success with nothing in
it, a path inside it failed with a misleading "does not exist", and
whole-repo discovery dropped its skills without a word.

Refuse a subdir that is or lies inside a submodule, naming the
submodule, its pinned commit and upstream URL, and warn for each
submodule skipped by whole-repo discovery and --track.

Refs #433

Release-As: 0.25.1
2026-10-07 01:58:59 +08:00
Willie 3875c16e26 docs(extras): describe how prepend and append blocks behave and fail
The pages added with the block modes covered what they write, not what
the review fixes made them do. The sharing guide still said sync
overwrites a modified target, which is wrong for a block: sync stops
until the edit is collected or the block is rewritten.

The guide, the extras reference and the built-in skill now cover the
block's Collect and Rewrite choices, block statuses, the target file
dialog, what a mode change removes, how restore treats a block, and
the cases a block target is refused. Common errors gains an Extras
section for the four new messages. The --mode help of extras init,
--add-target and the mode command listed only import among the
single-file modes; it now lists prepend and append too.

Refs #436
2026-10-07 00:59:14 +08:00
Willie 05ff8c675a feat(extras): prepend and append modes for single-file extras
Tools without an @import directive (codex, gemini, cursor) could only
take a shared instruction file as a symlink or copy, which replaces the
target's own file. Teams that want one shared AGENTS.md plus the user's
own notes in the same file had no way to express that.

prepend and append write the source into the target file as a managed
block fenced by skillshare:extra markers that carry the source path and
a content hash. Sync inserts the block once and then rewrites it in
place, status reports modified when the block body no longer matches
its hash, Collect copies the edited body back to the source, Reapply
rewrites the block from the source, and restore removes only the
block. Lines outside the block, and markers inside code fences, are
never touched. Several managed blocks (and an import line) may share
one target file; the connection validator only rejects a file when a
replacing mode (symlink, copy, merge) is involved.

Refs #436
2026-10-07 00:04:00 +08:00
Willie d62fa4fd3d docs: sync docs with the 0.25.0 changes
Bring the pages, the built-in skill and the translations up to date with
the pending release before the Release PR is reviewed: the README Latest
callouts for v0.25.0; mcp serve, Oh My Pi, DeepSeek Harness and GitLab Duo
in the ja, ko, zh-Hans and zh-Hant pages; the `--` option and the --enable
rollback of link and unlink; the missing serve skip reasons and its
cross-origin refusal; standard naming rules; junctions kept across volumes;
OMP accounts receiving native code hooks; and the 79-target count.
2026-10-06 17:37:14 +08:00
Willie 2647e79ef9 feat(mcp): require HTTPS for mcp serve off loopback
A non-loopback --http listener accepted a bearer token over plain HTTP,
so anyone on the path could read the token and the skills. Off loopback
it now also needs --tls-cert and --tls-key and serves HTTPS; loopback
stays plain, so a TLS-terminating proxy in front still works.
2026-10-06 16:08:44 +08:00
Willie d13e03adfc fix(mcp): skip skills whose compatibility exceeds the format limit
The Agent Skills format caps compatibility at 500 characters, and hosts
that validate entries reject longer ones, so serve skips such a skill
with a warning, as it does for an overlong description.

metadata is deliberately not held to the format's string values: lists
there are common, tool-fallback clients read them fine, and skipping
those skills would hide them from every client to satisfy a few.
2026-10-06 15:00:35 +08:00
Willie 96593f9411 fix(mcp): quote the served target and cap skill descriptions
A managed project's name may hold spaces, so the Skillshare tab built
`--target my app@claude`, which the save path split into two words and
serve rejected as an unknown target. The command is now joined from
quoted words.

The Agent Skills format caps a description at 1,024 characters, and
hosts validating entries reject longer ones, so serve skips such a skill
with a warning instead of advertising it. The docs list every skip reason.
2026-10-06 14:47:41 +08:00
Willie cc7d802411 feat(mcp): serve skills over MCP with the SEP-2640 Skills extension
Agents on a disposable VM, in a hosted assistant or behind an MCP gateway can
reach an MCP endpoint but not the folder skills sync to, so they got tools and
none of the user's skills (#428).

`skillshare mcp serve` is a read-only server for the skills skillshare already
manages. It declares io.modelcontextprotocol/skills and implements skills/list,
skills/get and resources/read: one entry per skill, its URI from the source
path, the full frontmatter, and every file with a sha256 digest and size.
--target applies that target's selection, and the source is reread at most
every 5 seconds so install, update, enable and disable show up without a
restart; unchanged files keep their digest. stdio is the default; --http
serves Streamable HTTP and needs SKILLSHARE_MCP_TOKEN off loopback.

Skills the extension cannot carry are skipped with a warning instead of being
published incomplete: a name that breaks the Agent Skills rules or differs from
its directory, more than 512 files or 16 MiB, or a nested skill that is not
served. --check lists them without serving. The naming rules moved to
internal/skillpkg so sync and the server share them.

Few clients support the extension yet, so the server also offers list_skills
and read_skill tools. A client that declares the extension does not see them,
so it never gets each skill twice.

sync.SelectTargetSkills is the one place that turns discovered skills into a
target's selection (enabled, include/exclude, frontmatter targets).

Refs: #428
2026-10-06 14:18:16 +08:00
Willie 8f79733b4f fix(mcp): validate Pi CIMD OAuth settings
Reject unsupported client registration values and CIMD client or callback conflicts before syncing invalid settings to Pi. Keep dcr and custom Pi options supported, identify the legacy codemode alias, and document current Pi launch behavior.
2026-10-06 09:52:16 +08:00
Willie 9db36b472a Merge remote-tracking branch 'origin/main' into runkids/419-link-unlink
# Conflicts:
#	internal/server/handler_skills.go
#	skills/skillshare/references/TROUBLESHOOTING.md
#	website/docs/reference/commands/ui.md
#	website/docs/reference/targets/configuration.md
#	website/i18n/ja/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/ja/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/i18n/ko/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/ko/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/i18n/zh-Hant/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/zh-Hant/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/src/data/featureMap.ts
2026-10-05 22:49:25 +08:00
Willie 891c687a47 fix(server): anchor target frontmatter writes to the source
Rewrite frontmatter as bytes and read and write target assignments through sourcefs with the discovery follow policy. Refuse nested SKILL.md links with per-skill batch errors or HTTP 400 while regular followed skills remain editable and outside files stay unchanged.
2026-10-05 22:35:00 +08:00
Willie 51f2beadd1 fix(install): retain existing skills until replacement succeeds
Copy staged directory links as concrete content through the source root, skip dangling links, and reject directory cycles. Preserve the existing skill under a sibling name and restore it if moving or copying the replacement fails so followed checkout updates cannot discard the old content.
2026-10-05 22:28:43 +08:00
Willie 38c223bd74 fix(trash): preserve nested links in cross-device copies
Recreate nested links with their stored target text instead of dropping them before removing the original skill. Reuse the junction target resolution and symlink fallback used by moveLink without traversing link contents.
2026-10-05 22:24:39 +08:00
Willie 113d410da7 fix(hub): apply the source follow policy to local discovery
Hub index, built-in search, and draft candidates discovered only the source path, dropping the follow policy used by the inventory. Add optional walk options to the shared Hub functions and pass the operation policy from dashboard handlers and CLI indexing.

Explicit CLI sources use the active config policy while retaining configuration-free indexing. Cover global/project modes, enabled/disabled following, all three handlers, and CLI source overrides; document the behavior in all website locales and built-in guidance.
2026-10-05 22:03:47 +08:00
Willie 1254fe522d fix(doctor): classify unavailable links by their destination
Standard target naming uses frontmatter names, so matching target entry names misclassified unavailable source skills as broken and suggested pruning. Read the stored link destination, resolve relative paths, and compare it with unavailable source roots; retain name matching only when the link target cannot be read.

Cover absolute and relative destinations and an unrelated broken link whose name resembles a followed skill. Document that standard target names receive the same waiting classification.
2026-10-05 21:56:01 +08:00
Willie 98300a2eec fix(install): recognize gitdir files as checkouts
Followed worktrees and submodules were discovered as tracked repos but bypassed guards that required a .git directory. Widen IsGitRepo to accept a directory or regular gitdir file and reuse it in discovery and reconciliation. All existing callers classify checkouts or run Git commands; none requires the directory layout, so a separate predicate would retain inconsistent decisions.

Exercise actual followed worktrees in CLI and dashboard update fixtures, including project mode and force retries, and document that they receive the same checkout guards.
2026-10-05 21:53:12 +08:00
Willie e7eecffeab Merge remote-tracking branch 'origin/main' into runkids/274-follow-source-links 2026-10-05 21:32:38 +08:00
Willie 064048da89 fix(server): list files from followed skill roots
A symlink passed as a filepath.Walk root is listed as a single file, so root-of-link skills returned files containing only a dot. Reuse the discovery follow policy to resolve the walk root and compute relative file names from it while retaining logical resource paths.

Cover global/project responses and disabled following, update the existing traversal inventory, and document root-of-link file browsing in all website locales and troubleshooting guidance.
2026-10-05 21:31:29 +08:00
Willie 1a472eb0ab fix(check): resolve followed checkouts by explicit name
Filtered checks dropped the follow policy when resolving a basename, so a linked checkout visible in an unfiltered check was reported as not found by its name. Forward the operation policy to the resolver and cover both global and project checks against a local Git remote.

Document checking followed checkouts by link name in the command reference and built-in guidance.
2026-10-05 21:24:56 +08:00
Willie e8242affc3 fix(update): exclude followed checkouts from missing repo recovery
Missing-repo discovery ignored the operation follow policy, so tracked metadata added a skipped checkout back to update --all and allowed --force to reset it. Thread the policy through missing-repo detection and its CLI/server callers, including rehydration, so existing followed checkouts remain excluded.

Cover global and project updates with dirty tracked checkouts and force, as well as shared and dashboard rehydration. Document that --force does not override the batch skip.
2026-10-05 21:22:47 +08:00
Willie a280a20f8c Merge remote-tracking branch 'origin/runkids/274-follow-source-links' into runkids/419-link-unlink
# Conflicts:
#	internal/sourcewalk/follow_test.go
#	skills/skillshare/references/TROUBLESHOOTING.md
2026-10-05 21:19:53 +08:00
Willie df7a6ad73d fix(sourcewalk): preserve inventory on followed traversal failures
Discovery callbacks may ignore filesystem errors after a followed target passes its availability probe. Record these failures in the shared Follow policy before dispatching callbacks so sync and reconciliation preserve entries missing from an incomplete inventory.

Keep ordinary vanished-child races tolerated, while treating loss of the target itself as unavailable. Cover both walkers and merge/copy pruning, and document read failures in the English and translated configuration guidance.
2026-10-05 20:46:45 +08:00
Willie 97446744ff feat(omp): add native Oh My Pi support (#423)
* feat(omp): add native Oh My Pi support

Support OMP skills, instructions, MCP, code hooks and guarded extension selection using its verified native contracts rather than Pi aliases.

Add reviewed marketplace plugin installation, cache-preserving scoped removal and fresh-cache reinstall. Align Pi/OMP extension cards and localize inventory guidance while keeping native ownership and read-only constraints.

Include regression coverage, isolated E2E runbooks, documentation and verification policies. Native plugin updates and unverified runtime platforms remain guarded.

Refs #409

* fix(omp): guard runtime ownership and localize inventory guidance

Native install recursively replaces its runtime destination, and a missing cache manifest could leave the real runtime link installed after removal. Bind and recheck an absent reviewed destination, and recover removal names only from verified scope-local links.

Localize fixed backend reasons and warnings across dashboard locales while preserving paths and external diagnostics. Restore the reviewed source in the existing reinstall fixture and record real native verification.

* fix(omp): allow forgetting natively removed plugins

A different plugin can retain node_modules after native uninstall deletes this installation. When its cache, registration and known runtime state are absent, forget only the stale Skillshare binding instead of demanding runtime-name proof for unrelated files.

Extend the existing removal recovery test with a failing-before-fix case that verifies the binding is dropped and unrelated native lock bytes and plugin files are preserved. make check passes.
2026-10-05 20:36:39 +08:00
Willie 3265259d1a docs(source-links): use unlink for link removal guidance
The linked-root skill guard makes uninstall refuse some first-level links, so generic link-removal instructions could direct users to a command that fails.

Point configuration, FAQ, unlink reference, and built-in skill guidance to unlink or the dashboard Unlink action, preserving target folders for checkout and root-skill links across all five documentation locales.
2026-10-05 20:36:28 +08:00
Willie cd6e0165dd fix(uninstall): refuse skills at followed link roots
A root skill discovered through a followed source link occupies the link entry itself. Moving that entry to trash silently unlinks every nested skill instead of removing one skill.

Share the root-skill guard across single and batch API handlers and CLI uninstall, report the unlink action clearly, and preserve explicit unlink and nested skill removal.
2026-10-05 20:02:58 +08:00
Willie 42ed06e3e4 fix(cli): accept option terminators for link and unlink
Stop parsing mode and command options after -- so valid link names and relative paths beginning with a hyphen can be addressed. Document the unlink form in every command locale and verify that -g and -p after the terminator remain names.
2026-10-05 18:27:12 +08:00
Willie 93708478a6 docs(source-links): describe the dashboard unlink action
The dashboard section of the ui reference only covered Link folder. Add
the final unlink design so the docs match the shipped UI: the linked
group row, the hover icon button with confirmation, trash restore,
single-skill uninstall inside a link, and the absence of repo actions.
2026-10-05 18:27:12 +08:00
Willie 86cb2d51d9 docs(source-links): document link, unlink and the dashboard Link folder action
follow_source_links only follows a link that already exists, and the docs
told users to create it with ln -s or mklink /J. The guards then surfaced
only in doctor, after the link existed. Now that skillshare link checks the
target first and picks a junction on Windows, the docs point at the command
and keep the manual way as a note.

Adds command pages for link and unlink, quick-reference and index rows, the
dashboard Link folder sentence, all four translations, and the built-in
skill guidance.

Refs #419
2026-10-05 18:27:12 +08:00
Willie aafb7e7e96 fix(ui): keep followed checkouts out of dashboard updates
Separate user-owned followed Git checkouts into linked_repos in check and resources responses so the Updates tab renders information instead of tracked errors or retry actions. Refuse dashboard updates before Git runs, including force retries and descendant skills, while leaving managed repositories unchanged.
2026-10-05 18:26:12 +08:00
Willie c5c9289781 fix(discovery): surface skipped source link warnings
Keep one follow policy per list and status operation and report its skipped links without hiding healthy inventory. Send JSON diagnostics to stderr and expose sourceLinkWarnings in the dashboard resources response, reusing the sync warning formatter.
2026-10-05 18:26:12 +08:00
Willie 5eb6d496ec docs(source-links): cover command pages, the built-in skill, and all four translations
The follow_source_links feature touched doctor, update, uninstall,
trash, install and audit behavior without their command pages saying
so, and the ja, ko, zh-Hans and zh-Hant site translations had none of
the new content. Translate every changed page and align the built-in
skill's doctor and troubleshooting references.
2026-10-05 16:03:47 +08:00
Willie bcf567f80d docs(source-links): align follow_source_links docs with the review fixes
Covers the guard order, file links, update --all and dirty checkouts,
--group forms, restore through the link, what Git stages for a link,
the sync and audit JSON warnings, and the junction-chain case in the
Windows runbook.
2026-10-05 15:48:45 +08:00
Willie 956db6d122 fix(update): keep --all away from followed checkouts
update --all treated a followed source link as a managed tracked repo:
with --force it ran git reset --hard inside the user's own checkout and
silently discarded their local edits, and an audit-gate rollback would
do the same. --all now skips any tracked repo behind a followed link
with a warning that names the by-name form, which keeps its documented
behavior.
2026-10-05 15:42:01 +08:00
Willie 8092b234b7 fix(source-links): judge overlap before existence and keep doctor from suggesting prune
A link into a sync target that is not created yet was reported as a
missing target, which marked the inventory incomplete and held back
pruning for a link that would never be followed. The where-it-points
guards now run on the link text before the does-it-exist check, so such
a link is an overlap and the run prunes as usual.

doctor reported the dangling target links behind an unmounted source
link as broken symlinks and suggested `skillshare sync` to prune them,
while sync deliberately keeps them. Those links are now a warning that
names the waiting source link and carries no prune suggestion.
2026-10-05 15:27:42 +08:00
Willie c876711458 docs: add the Windows runbook for followed source links
Record how the junction case is verified through the UTM guest and point the testing topic and the config reference at it, replacing the 'not yet verified' caveat now that the ARM64 run passed.
2026-10-05 15:17:16 +08:00
Willie 660cc33c28 docs: describe keeping linked skills on an external drive
The unmounted-drive case is the main reason the incomplete-inventory guard exists, so spell out what each command does while the drive is away, what the AI tools see in symlink versus copy mode, and why the mount path must stay stable.
2026-10-05 15:02:52 +08:00
Willie d61cea9ec7 docs: describe the link decision flow and writes through followed links
Wave 2 made writes behind a followed first-level link land in the real
checkout, so the "current limits" paragraph written for the discovery-only
version was no longer true. Replace it with the actual write semantics, add
the walker decision flowchart the design discussion settled on, and record
the sourcefs/sourcewalk policy contract in the CLI development topic.

Refs #274
2026-10-05 14:56:29 +08:00
Willie b8de508d60 docs: document opt-in first-level source links
Explain follow_source_links in global and project configuration and distinguish linked source roots from first-level discovery. Document real-checkout update risks, cleanup guards, source write limits, Git staging warnings, and unverified Windows junction support.
2026-10-05 14:10:23 +08:00
Willie 64b9255075 feat(ui): link each part of a target from the Targets list
The Syncing column described what a target gets as one line of text,
and the whole row led to the Skills tab, so reaching a target's MCP,
Hooks or instruction file took an extra click and a search for the
tab. Each part is now its own link into that tab, and the connected
shared AGENTS.md shows up by its file name, so the list says at a
glance which targets are not connected yet.
2026-10-05 13:51:01 +08:00
Willie 751d0b50fa docs: bring translations and status up to date for 0.24.5
Release prep for 0.24.5 found three places where the docs no longer
matched what the pending range changed:

- The Codex portable-manifest rule (Codex installs from a root
  plugin.json when a package has both manifests, so Skillshare expects
  its version, or 1.0.0) was only in the English plugin reference.
- The .skillignore.local behavior (a pattern without / matches at any
  depth, the dashboard shows the .local rules in Settings > Files and
  reports a toggle they override as failed, and GET /api/skillignore
  returns the .local file) was only in the English filtering and ui
  references.
- The status reference did not say that the agents column counts only
  the agents a target syncs, after .agentignore, the target's
  include/exclude and each agent's targets frontmatter.

The ja, ko, zh-Hans and zh-Hant pages now carry the first two, and every
language carries the third. The Latest callout in README.md and its
translations now describes 0.24.5, which includes a feature.
2026-10-05 01:13:15 +08:00