378 Commits
Author SHA1 Message Date
Willie bf34d8009b fix(ui): center audit finding severity dot 2026-06-14 13:37:35 +08:00
Willie 80f1e04657 fix(ui): surface missing tracked repos on Dashboard "Update All"
The Dashboard uses POST /api/update (not the stream) and only inspected
res.results.length, so a fresh machine whose only tracked repos are
missing on disk fell through to the "no tracked repos" toast with no
rehydrate hint — leaving one web update-all entry point with the old
issue #212 symptom.

- Type the POST /api/update response with missingTrackedRepos.
- Guard against a null results slice (Go returns nil → JSON null) before
  filtering, and only show "no tracked repos" when there is genuinely
  nothing — including no missing repos.
- When missing tracked repos are reported, show a warning toast pointing
  the user to the Updates page to rehydrate; string added to all 11 locales.

Follow-up to 54dd7d12.
2026-06-11 15:44:20 +08:00
Willie 54dd7d12a3 fix(update): surface missing tracked repos in update --all across CLI, API, and UI
When tracked repo metadata is committed but the gitignored clone dirs are
absent on a fresh machine, `update --all` silently reported zero work: the
batch path skipped missing repos with no message, and the web UI's
update-all paths only listed repos present on disk.

Missing tracked repos are now detected and surfaced everywhere:
- CLI: a warning block (human output) plus an aggregated
  `missing_tracked_repos` summary (names + one-shot rehydrate hint) in JSON;
  the per-item error is concise. Fixed for both global and project modes,
  and batch and single-target paths.
- Server: GET /api/update/missing-tracked-repos and the update-all/stream
  summaries report them; POST /api/update/rehydrate re-clones them from
  metadata (mirrors bare `skillshare install`).
- UI: the Update page shows a warning banner listing missing repos with a
  Rehydrate button; strings added to all 11 locales.

Closes #212
2026-06-11 15:32:28 +08:00
Willie 90f9609e64 feat(resources): add batch enable/disable in web UI
Add multi-select mode to the Resources page so users can enable or
disable many skills or agents at once (issue #203), instead of toggling
each one individually.

- New POST /api/resources/batch/toggle endpoint (skills + agents) backed
  by the shared .skillignore/.agentignore, returning per-item results and
  an updated/unchanged/failed summary
- Selection mode across grid, tree, and table views with a unified
  checkbox, folder-level tri-state select-all in the tree, a bottom
  action bar (Enable applies immediately, Disable confirms first), and
  optimistic updates
- i18n keys for all 11 locales
2026-06-05 23:41:03 +08:00
Willie 306d1e3ccd perf(ui): virtualize trash list 2026-06-03 22:33:11 +08:00
Willie 2b45618f74 feat(search): clearer hub load errors with structured toast
Hub fetch failures surfaced only a bare "fetch hub: HTTP 400" toast, with no indication of which hub failed or how to fix it.

Hub load errors now name the likely cause and include the URL for every failure mode (4xx/auth, malformed URL, invalid JSON, unreachable host, missing local file). The Search page renders them as a structured toast titled with the failing hub, and Toast gained an optional title for this.
2026-06-03 15:38:17 +08:00
Willie 694d784799 fix(preview): render SKILL.md for non-github.com hub sources
The web UI skill preview always fetched SKILL.md via api.github.com, so skills from GHE or other non-github.com hubs showed only index metadata (name, description, tags) instead of the full rendered content.

FetchPreview now resolves the source platform: github.com and GHE use the host's REST Contents API, while other platforms (GitLab, Bitbucket, Azure, SSH) fall back to a shallow clone. Sources whose content can't be retrieved degrade gracefully with a clear notice in the modal.

Fixes #193
2026-06-03 15:37:57 +08:00
Willie bc7c657714 fix(ui): portal Select dropdown, fix devcontainer Vite HMR, sync i18n
- Select: render the dropdown through a portal so it escapes ancestor
  stacking contexts (it was clipped behind the search box); in the
  playful theme match the trigger's wobble radius instead of the inline
  uniform radius
- devcontainer: mount ui/ and website/ node_modules as anonymous volumes
  so platform-native rolldown bindings install in-container (Vite failed
  to start with host darwin bindings); force CHOKIDAR_USEPOLLING because
  virtiofs does not reliably deliver inotify events, so saves were
  silently missed and HMR stopped firing
- SearchPage: remove the "submit a PR to skillshare-hub" prompt
- i18n: drop the now-unused search.hub.submitPrPrompt key and add the
  missing extras.* keys across all locales to restore key/placeholder
  parity with English
2026-06-03 14:42:36 +08:00
Willie ad6a2224f0 fix(ui): keep each extension download spinner independent
The Extensions section tracked the in-flight download with a single
`string | null`, so starting a second download cleared the first one's
loading state. Track in-flight downloads in a `Set<string>` so concurrent
downloads each keep their own spinner.

Also add ismferd to the README contributors.
2026-06-02 18:45:27 +08:00
Willie 86b91efe95 feat(extras): refine per-target management UI and path resolution
UI (Extras page):
- Label per-target flatten/extension/mode controls with column headers
- Render flatten as a dropdown so it matches the adjacent selects
- Collapse the add-target form behind a button and widen the path input
- Confirm before removing a target
- Polish layout: tinted icon, inset source chip, hover rows, aligned columns

Components:
- Select: bound the dropdown width so long option descriptions wrap instead
  of stretching the popup across the page
- Toast: render messages multi-line, widen the container, and give
  error/warning toasts more time to read

Sync feedback:
- Restructure extras sync-failure toasts into readable lines and fix the
  contradictory "N more errors" count (new nMoreErrors translation)

CLI/server:
- Match extra target paths by resolved absolute path (handles ~ vs /home)
  when adding, removing, or updating targets
2026-06-02 18:40:00 +08:00
Willie ab06f7b69e i18n(extras): add target add/remove toast translations 2026-06-02 17:32:26 +08:00
Willie 37ac6c5078 feat(ui): per-target add/remove controls on Extras page 2026-06-02 17:20:01 +08:00
Willie 8ee8ab76fe feat(ui): add addExtraTarget/removeExtraTarget API client methods 2026-06-02 17:17:44 +08:00
Willie e983ecf750 feat(ui): surface doctor suggestions on Health Check page
The doctor --json output gained a `suggestions` field (see eb99118d), but the web Health Check page silently dropped it. Render the remediation suggestions under each check's expandable detail block.

- Add optional `suggestions` to the DoctorCheck type

- Render suggestions list in CheckRow; make rows expandable when only suggestions are present

- Add `doctor.suggestions` i18n key across all 11 locales
2026-05-31 21:07:20 +08:00
Willie 1183e0a366 fix: improve codex agent extension validation 2026-05-31 13:39:41 +08:00
Willie 2f6f6bd052 fix(git): enforce root-scope safety on commit/push instead of warning
Root-scope git operations detected hazards but proceeded anyway, letting
preventable mistakes reach the remote:

- Nested git repos were only warned about, then committed/pushed as empty
  submodules (silent data loss). Now commit/push abort (CLI non-zero exit,
  server 400) until the nested repos are disabled, and the web UI disables
  the commit/push buttons while any are present.
- The pre-stage safety sweep ran before the dry-run check, so `--dry-run`
  wrote .gitignore and ran `git rm --cached config.yaml`. The sweep/guard is
  now strictly read-only on dry-run and only reports what would change.
- Server git endpoints used EffectiveGitRoot() without validating git_root,
  so a hand-edited invalid scope silently fell back to skills. They now share
  a gitSource() guard that rejects invalid scopes with 400, mirroring the
  CLI's resolveGitRoot.
2026-05-30 19:23:12 +08:00
Willie 599c6e2160 fix(ui): honor status filter in grouped resources view
The grouped (folder tree) view ignored statusFilter in its isSearching, clear-filters, and empty-state logic, so filtering to Enabled/Disabled with no matches looked like an empty library instead of a filtered view with no results. Mirror the grid/table behavior by including statusFilter in all three checks.
2026-05-30 19:23:12 +08:00
Willie 53e4a02a7b i18n(git-root): clarify config.yaml tracked notice (explain machine-specific paths) 2026-05-30 19:23:12 +08:00
Willie eda9ac75a4 feat(git-root): guard root scope against submodule traps and config leaks
At the root git_root scope, `git add -A` over the config base directory
records any subdirectory that has its own .git (e.g. the skills source) as
an empty submodule, and can commit the machine-specific config.yaml.

- Detect nested repos and warn before commit/push (CLI) or surface them on
  the Git Sync page with a one-click "Disable nested .git" action (UI),
  which renames .git to .git.disabled (reversible) and drops any stale
  gitlink from the index so the directory's files track as normal blobs.
- Keep config.yaml out of a root-scope repo automatically: ensure it is
  ignored and untrack it (git rm --cached) before staging, on both the CLI
  and the web UI commit/push paths.
- Expose nestedRepos/configTracked in GET /api/git/status and add
  POST /api/git/absorb-nested (validated against detected nested repos).
2026-05-30 19:23:12 +08:00
Willie d5c865870a refactor(ui): tidy Git Sync scope selector and not-a-repo layout
- Move the git_root scope selector from its own row into the status bar
  alongside branch/HEAD, matching the repo-info layout
- Lay out the not-a-repo Initialize button inline (justify-between) so it
  no longer floats awkwardly below the warning row
2026-05-30 19:23:12 +08:00
Willie 96ead0b361 feat(ui): make Git Sync not-a-repo state actionable
The not-a-repo state was a dead end: the scope switcher only rendered once a
repo existed, so there was no way to initialize git or set a remote from the
UI. Add an 'Initialize git repository' button that opens the existing scope
dialog (with optional remote) — POST /api/git/root already inits the scope
repo and wires origin. Dialog title/message adapt for the init case.

Also detect a missing git executable: gitStatus reports gitInstalled (via
exec.LookPath), the page shows a clear 'Git is not installed' notice instead
of a cryptic 500 on init, and handleSetGitRoot rejects with a plain message.
2026-05-30 19:23:12 +08:00
Willie 53e5b2455b feat(ui): set git remote during scope switch on Git Sync page
The Git Sync scope switcher now accepts an optional remote URL, reaching
UI parity with the CLI's `init --git-root <scope> --remote <url>`. The
POST /api/git/root handler takes an optional remoteURL and wires origin on
the just-initialized scope repo via a new git.SetOrAddRemote helper (adds
origin when absent, updates the URL otherwise). Adds gitSync.scope.remote*
strings across all locales.
2026-05-30 19:23:12 +08:00
Willie 20b0d426a0 feat(ui): add enabled/disabled status filter to Resources page
Mirror the list TUI status filter in the web dashboard. A single
monochrome toggle button sits beside the source filter chips (separated
by a divider) and cycles All -> Enabled -> Disabled. Counts are scoped
to the active tab and compose orthogonally with the source filter.
2026-05-30 19:23:12 +08:00
Willie 372dd65768 fix(extras): enforce --force contract and consistent status for transform extensions
Transform-extension sync previously wrote each generated file via
runExtensionFile unconditionally, so a regular local target file (e.g. a
hand-edited hello.toml) could be overwritten from hello.md without --force,
violating the same conflict contract that copy/merge modes honor.

- Split runExtension (subprocess → bytes) from runExtensionFile (writes),
  and have syncExtraTransform apply the conflict/force rules: idempotent
  when identical, skipped on conflict without --force, overwrite with
  --force, and auto-replace leftover symlinks.
- Centralize the copy-only mode rule in SyncExtra so the API and CLI reject
  extension+merge/symlink identically; align the server sync handler's mode
  normalization (EffectiveMode's "merge" default no longer leaks through).
- CLI `extras list` no longer short-circuits to an "extension" status before
  existence/drift checks. Status is now computed via output_ext-aware
  CheckSyncStatus; a new Extension field carries the display label, decoupled
  from sync status (plain-text + TUI rendering updated).
- Roll back the optimistic cache update in the UI mode-change handler on
  failure (fixes the unused-var build break).

Adds regression tests covering conflict skip/force/idempotent/symlink-replace
and non-copy mode rejection.
2026-05-30 19:23:12 +08:00
Willie fd897ad39c refactor(ui): use stable keys for extras target lists
Replace array-index keys with data-derived keys: the Add Extra modal gives
each TargetEntry a generated id (paths can be empty/duplicate while
editing), and ExtraCard keys by the target's unique path. Prevents stale
input/render state when rows are added or removed.
2026-05-30 19:23:12 +08:00
Willie 5fbe4a76f0 feat(ui): remove installed extensions with in-use guard
Add a Remove action to each installed extension in the Config Extensions
list (DELETE /api/extensions/{name}). The list now reports used_by — the
extras whose targets reference each extension — so the row shows an
in-use badge and the confirm dialog warns, in danger style, which extras
will fail on next sync before removing. Path-traversal names are rejected
server-side. Includes server tests for usage reporting and removal.
2026-05-30 19:23:12 +08:00
Willie 049625522b feat(ui): guide to Config when no extensions installed
The per-target extension picker was hidden entirely when nothing was
installed, leaving no hint that transforms exist. Replace the empty space
with an 'Install an extension' link (in both the Add Extra modal and
ExtraCard) that deep-links to /config?tab=extensions; ConfigPage now reads
the tab query param to open the Extensions tab directly.
2026-05-30 19:23:12 +08:00
Willie ce023b180f feat(ui): show extension descriptions and clarify wording
The Available list showed only a bare name with no hint of what each
built-in does. Render the catalog description next to it. Also broaden the
section copy: extensions pipe each file through a script (not only
'convert to a format'), and reword the source-path help to make the
intent clearer.
2026-05-30 19:23:12 +08:00
Willie 9bafda4fa3 refactor(ui): use Checkbox component and lock chip in Extras targets
The raw <input type=checkbox> and greyed-out mode select looked out of
place against the hand-drawn design. Use the shared Checkbox component for
Flatten, and render a read-only lock chip (instead of a disabled select)
when an extension forces copy mode — in both the Add Extra modal and
ExtraCard so the two stay consistent.
2026-05-30 19:23:12 +08:00
Willie 3779718631 fix(ui): clarify extras source path help 2026-05-30 19:23:12 +08:00
Willie 67ac184b71 feat(ui): label and clarify target row in Add Extra modal
Add column headers (Path / Extension / Mode) so first-time users can
tell the controls apart. When an extension is selected, replace the
greyed-out mode select with a read-only "copy" lock chip plus a
"runs in copy mode" hint — the disabled control read as broken rather
than intentionally locked.
2026-05-30 19:23:12 +08:00
Willie a42cf78f19 feat(ui): add extension picker to Add Extra modal
The create-extra dialog now offers the same per-target extension
dropdown as the Extras cards. Selecting an extension forces the target
into copy mode and disables the mode selector. createExtra carries the
extension, and the server coerces such targets to copy mode on create.
2026-05-30 19:23:12 +08:00
Willie 3b927ff4f1 fix(ui): open extensions directory in file manager, not editor
The "Open directory" action launched a text editor; switch it to the
OS file manager (Finder on macOS, Explorer on Windows, xdg-open on
Linux/BSD) so it reveals the folder as users expect. Drop the editor
override parameter and the {editor} toast placeholder.
2026-05-30 19:23:12 +08:00
Willie f6eca1fc7d feat(ui): add extensions management to Config page
Add an "Extensions" tab to the Config page for managing transform
extensions in the active mode (global or project):

- GET /api/extensions lists installed extensions with their manifest
  descriptions, merged with the built-in catalog so users can see what
  is available to download.
- POST /api/extensions/install downloads a whitelisted built-in
  extension into the active mode's extensions directory.
- POST /api/extensions/open opens that directory in the user's editor,
  mirroring the skill "open in editor" affordance.

ExtensionSpec now carries the manifest description so the list can
surface it. The UI shows installed extensions with a built-in badge,
available built-ins with a Download button, and an Open-directory
action. Strings are translated across all 11 locales.
2026-05-30 19:23:12 +08:00
Willie f6c9b98562 feat(ui): add per-target extension picker to Extras page
Surface the per-target extension transform in the dashboard. A new
GET /api/extras/extensions endpoint lists extensions available in the
current mode's directory (global or project), and the Extras page renders
a picker per target. Selecting an extension forces copy mode (transforms
are copy-only) and locks the mode control; changes apply optimistically
via the query cache. Adds i18n keys across all locales.
2026-05-30 19:23:12 +08:00
Willie e51134af24 feat(git-root): surface scope mismatch in UI and document git_root field
Add Config.GitRootMismatch() as the single source of truth for detecting
when the git repo lives at a different scope than git_root configures, and
reuse it across the CLI guidance, the server status response (scopeMismatch
/mismatchScope/mismatchDir), and a new warning banner on the Git Sync page.

Document git_root in the config structure-view field docs (fieldDocs) and the
GitStatus client type, and add the gitSync.scope.* / gitSync.mismatch.* i18n
keys across all locales to keep dictionary parity.

Cover the behavior with config, server handler, and CLI integration tests:
push/pull honor the root scope (agents files reach the remote, config.yaml
stays untracked), POST /git/root inits+persists the scope and rejects invalid
scopes and project mode, and git status reports scope mismatches.
2026-05-30 19:23:12 +08:00
Willie 54d6706168 feat(ui): switch git_root scope from the Git Sync page 2026-05-30 19:23:12 +08:00
Willie d6b6b929de feat(ui): validate git_root scope in config editor 2026-05-30 19:23:12 +08:00
Willie d6600e744a feat: add UI local commit action 2026-05-27 16:28:50 +08:00
Willie ff8860c9cd fix(ui): preserve update check status after update 2026-05-27 13:56:38 +08:00
Willie 4e532615f6 fix: persist update check status in dashboard 2026-05-26 15:57:36 +08:00
Willie 89080cf4f1 refactor(install): typed ambiguity error with counts, save one clone
The mixed-tracked-repo recovery path used a fragile substring match on
the error message and re-cloned the repo via /discover to count skills
and agents. Both problems share one root cause: the counts InferTrackedKind
already computed during the failed first install were thrown away.

- Add install.TrackKindAmbiguousError carrying the discovered Skills /
  Agents counts. InferTrackedKind returns it on the ambiguous branch.
  Error() preserves the legacy message verbatim so CLI output is unchanged.
- Server handleInstall track branch uses errors.As to detect it and emits
  writeCodedError with stable code 'install.track_kind_ambiguous' plus
  skills/agents counts in error_params.
- UI replaces the substring match with an ApiError.code check and reads
  counts straight from err.params, skipping the second /discover clone.
- Add unit tests asserting errors.As, count fidelity, and explicit-kind
  short-circuit (no clone).

Net result: 2 clones instead of 3 on the mixed-track recovery path, and a
stable cross-language contract instead of a brittle English substring.
2026-05-26 11:05:32 +08:00
Willie 209c9d740c fix(ui): support --kind for tracked install of mixed repos (#167)
Installing a mixed git repo (containing both skills and agents) with
'Track' enabled failed with 'tracked install is ambiguous; pass --kind
skill or --kind agent', and the UI gave no way to recover.

- api.install: add optional 'kind' param (backend already supports it)
- InstallForm: detect the ambiguity error, fetch counts via /discover,
  and prompt the user to pick Skills or Agents via a kind-selector
  dialog; re-run install with the chosen kind
- Snapshot all install params (source/name/into/branch/force/skipAudit)
  at error time so a later kind selection cannot drift if the user
  edits the form behind the dialog
- Fall back to the original ambiguity error if /discover fails, so the
  user is not left with only a confusing secondary error
- Render the kind selector in both collapsible and non-collapsible
  return branches so the fix works for any InstallForm caller
- preventClose while installing so an in-flight kind selection is not
  cancelled by Escape / backdrop click
- Hoist KindOption out of the render body to keep its component
  identity stable across parent re-renders (no more autoFocus refire)

UI redesign of the kind selector:
- Replace ConfirmDialog wrapper with DialogShell + stacked card-style
  kind buttons (icon + label + count + chevron)
- Title row gains an X close affordance; remove the redundant bottom
  Cancel/divider to match other modals

i18n: drop legacy skillsButton/agentsButton/cancelText keys; add
skillsLabel/agentsLabel/itemCount across all 11 locales with fully
native phrasing (no mixed English in non-English locales).
2026-05-26 10:47:09 +08:00
Willie 012a4ba97e fix(ui): resolve stuck update checks 2026-05-25 00:33:26 +08:00
Willie a2f958d288 feat(ui): background mode, in-place upgrade, and PWA support
Three user-visible additions to the web dashboard, plus the CLI surface
needed to drive them.

* `skillshare ui start` / `skillshare ui stop` — run the dashboard as a
  managed background process. Re-running start reuses the existing
  healthy process; stop uses the remembered host/port. Foreground
  `skillshare ui` keeps working unchanged. Process tracking lives in
  ui_process_{unix,windows,other}.go via a PID + current-state file.
* `--app` — opens the dashboard in a Chromium app-mode window (Chrome,
  Edge, Brave) on macOS, Windows, and Linux for a separate Dock/taskbar
  entry without browser chrome.
* In-place upgrade from the browser — the Update dialog and the Doctor
  page's Version card now expose an Update now button. Backed by two
  new endpoints (POST /api/upgrade, POST /api/restart in
  handler_restart_upgrade.go); the browser polls GET /api/health and
  reloads once the new server is ready. Dev builds short-circuit with
  `devMode: true` and a simulated restart so the flow can be exercised
  without rebuilding the binary.
* Progressive Web App — site.webmanifest, app icons (192/512), and a
  minimal service worker registered from main.tsx. Supporting browsers
  can install the dashboard as a standalone desktop app.
* Doctor Version card redesign — state-coloured icon (blue when an
  update is available, green when up to date), explicit
  `current → latest` delta, Update button only when there is something
  to upgrade.
* i18n — translate "DEV mode" in zh-TW / zh-CN / ko (previously left
  as raw English).

Adds CHANGELOG.md and website changelog entries for v0.19.20 and
refreshes website/docs/reference/commands/ui.md to document the new
modes, --app flag, new REST endpoints, and the in-place upgrade flow.
2026-05-24 01:21:06 +08:00
Willie 996d00e342 feat(config): migrate consumers to Effective*Source helpers (Phase 3+5)
Make the v0.19.16 sources map actually do something: route all path
reads through Config.EffectiveSkillsSource() / EffectiveAgentsSource() /
EffectiveExtrasSource() so users who set sources.skills / sources.agents /
sources.extras get the configured paths everywhere.

Mechanical changes (~50 files):
- cmd/skillshare/**: replace cfg.Source / cfg.ExtrasSource reads with
  cfg.EffectiveSkillsSource() / cfg.EffectiveExtrasSource()
- internal/server/**: replace s.cfg.Source / s.cfg.ExtrasSource reads
  with the same helpers; server.skillsSource() / gitignoreDir() use the
  global-mode helper
- internal/config/config_validate.go: validate using EffectiveSkillsSource
  while still rejecting configs that set neither field explicitly
- internal/config/reconcile.go, registry.go: read via helpers

Behavioral fixes (paired with the migration):
- extras init / extras source / POST /api/extras no longer silently
  backfill the legacy extras_source field — the runtime fallback inside
  EffectiveExtrasSource() handles it. This stops surprise diffs in users'
  config.yaml after running extras commands.
- extras source command writes back to whichever field the user already
  configured (sources.extras if set, otherwise legacy extras_source) so
  the update is not shadowed.
- source_type in /api/extras and extras list correctly reports "default"
  vs "extras_source" by inspecting the raw (unresolved) configured value;
  sources.extras counts as configured for this purpose.

UI:
- ui/src/lib/fieldDocs.ts: neutralize sources / sources.* descriptions
  so they describe both project and global modes (Phase 5).

Preserved (intentional):
- Direct writes to cfg.Source / cfg.AgentsSource / cfg.ExtrasSource in
  init, migrate.go, cloneForSave, and server.reloadConfig — these are
  raw-field writes, not path reads.
- Updated test expectations for the removed backfills.
2026-05-21 14:49:11 +08:00
Willie a0d5b561dd docs(ui): add sources map entries to fieldDocs for ConfigPage assistant 2026-05-21 13:57:58 +08:00
Willie 9a7271c1ae fix: address PR #151 review feedback
- Project mode JSON sync now includes context_cost (was nil)
- Server handler respects symlink mode (skips include/exclude filters)
- checkBudget reports all targets exceeding threshold (not just worst)
- Budget warnings include target name in CLI and UI output
- ConfigPage indentation restored to original 2-space style
2026-05-11 21:34:38 +08:00
Willie 786af85ae4 feat(ui): add i18n for context cost section on Sync page
All 11 locales: en, zh-TW, zh-CN, ja, ko, de, es, fr, pt-BR, id, fa.
2026-05-11 21:34:38 +08:00
Willie 06d2f9fefa refactor(ui): remove redundant context budget card from ConfigPage
The assistant panel already shows field documentation via JSON schema.
A static reference card is redundant and breaks the page's interaction
pattern of cursor-driven contextual help.
2026-05-11 21:34:38 +08:00