697 Commits
Author SHA1 Message Date
Willie 8ffb8698de fix: allow default global skills source
Validate global configs against the effective skills source so sync --global honors the default source when source and sources.skills are omitted.

Add unit and integration coverage for issue #238.
2026-06-29 17:51:13 +08:00
Willie 3743a1ef3f fix(sync): honor file ignore patterns in copy mode
Apply config ignore patterns to copy-mode file traversal, checksum, mtime, CLI diff, and server sync/diff paths.

Add default ignores for .DS_Store, .git, and __pycache__ in global and project init configs.

Tests: go test ./... -count=1
2026-06-29 10:30:11 +08:00
Willie 30bdd72b6f fix: retry nested GitLab repo URLs
Retry generic HTTPS clone failures by progressively treating additional path segments as part of a nested GitLab repository. Limit retry to repo-boundary errors and preserve the final fallback error for debugging.
2026-06-18 23:56:54 +08:00
jnhu 6bddfbbe1d fix(trash): fix two regressions from PR #230 path hardening
- List() now uses trashLogicalName() to produce slash-separated logical
  names, preventing Windows backslash paths that validateTrashName rejects.
- ensureUnderBase/ensureStrictlyUnderBase now use filepath.Abs+filepath.Rel
  instead of string prefix, fixing false escapes when base is '.'.
- Add regression tests for Restore(entry, '.'), nested List->Restore roundtrip,
  sibling prefix rejection, and validateTrashName backslash enforcement.
2026-06-17 14:30:24 +08:00
jnhu 1ad13588ad harden trash path boundary checks 2026-06-16 22:57:28 +08:00
Willie 54ae7b04e2 fix(install): reject project-root self-install via web UI
The project-root self-install guard lived only in the CLI handler, so the
web UI could still copy the project root into its own .skillshare/skills/
subtree in project mode. Extract the check into a shared
install.RejectProjectRootLocalInstall and apply it in handleInstall and
handleInstallBatch, returning 400 with the same guidance.

Also restructure the rejection message into a cause line plus an
actionable "Run '...'" hint, matching the project's error convention.
2026-06-16 10:04:57 +08:00
Willie ebe8cc277e fix(install): prevent project root self-install
Reject project-mode installs that target the current project root and add a copy-layer guard that skips destination subtrees during recursive copies. This prevents install ./ -p from recursively copying .skillshare/skills into itself on Windows.
2026-06-15 22:21:46 +08:00
Willie 9e488bf5c1 fix(update): prevent panic when skill metadata is unreadable
A corrupt or unreadable .metadata.json caused LoadMetadataWithMigration
to return a nil store whose error was discarded, so update --all
dereferenced a nil MetadataStore in GetByPath and crashed with a raw
stack trace. Guard GetByPath against a nil receiver and surface the
load failure as a resolve warning instead.
2026-06-15 14:34:46 +08:00
Willie ab8bc4c1f2 Merge branch 'main' of github.com:runkids/skillshare 2026-06-15 11:13:03 +08:00
Willie c5544c5e65 fix(install): preserve unsafe blob subdirs for validation
Trim SKILL.md suffixes without filepath.Dir so traversal segments remain visible to SEC003 subdir validation. Add regression coverage for GitHub, GitLab, and Bitbucket blob-style skill URLs.
2026-06-15 11:12:44 +08:00
Willie d21d31e86c test(install): cover unsafe subdirs across source parsers
Add SEC003 regression cases for SSH, file, Azure, and generic HTTPS source parser branches so traversal rejection stays covered beyond the GitHub parser.
2026-06-15 11:12:44 +08:00
jnhu 087b5ee846 fix(install): validate repo subdir and source name in ParseSourceWithOptions
Reject unsafe subdirs that contain path traversal (..), NUL bytes,
control characters, backslashes, absolute paths, and URL-encoded
traversal (single, double, or overly deep encoding). Validate derived
source names and CloneURLs for NUL and control characters.

SEC003: github.com/owner/repo/../../etc/passwd previously produced a
Source with Subdir containing traversal segments. Now rejected.
2026-06-15 11:12:44 +08:00
Willie 0519b0bb52 fix: preserve readable metadata permissions
Ensure the atomic metadata save path writes .metadata.json with 0644 permissions so Git and other tooling can read it after install/update operations.
2026-06-15 10:46:38 +08:00
Willie 306bf99e0e fix(version): handle release version formats
Accept leading v prefixes during version checks, keep local metadata builds in dev mode unless they are clean exact release tags, and prevent cleanup warnings from leaking into JSON-mode stderr.
2026-06-14 15:54:25 +08:00
Willie 140df6b4c9 fix(server): surface git fetch failures
Return errors from branch refresh and checkout when git fetch fails instead of serving stale refs or proceeding with checkout.

Cover branch-list and checkout fetch failures with server regression tests.
2026-06-14 15:08:19 +08:00
Willie 224607af81 fix(server): fail source updates when remote update fails
Update tracked repo remotes before persisting source metadata so the API cannot report success while the on-disk git remote remains unchanged.

Cover both remote update failure and successful remote plus metadata updates.
2026-06-14 15:01:51 +08:00
Willie 6f49546476 fix(install): warn when temp repo cleanup fails
Route temp clone cleanup through a shared helper that logs cleanup failures with path and error while preserving existing best-effort cleanup semantics.

Cover cleanup failure logging with a deterministic unit test.
2026-06-14 14:52:22 +08:00
Willie 7280ec265f fix(version): reject malformed version segments
Return explicit comparison errors for non-numeric version segments instead of treating them as zero.

Fail closed in update checks when current or cached latest versions are malformed, and cover numeric, malformed, and cache-preserving cases.
2026-06-14 14:01:01 +08:00
Willie 5d684393f1 fix: propagate lint rule load errors 2026-06-14 13:44:36 +08:00
Willie e5cf18eef5 fix(server): preserve targets when cleanup fails 2026-06-14 13:37:35 +08:00
britz 1bcd02a3d9 fix: cache lint load error in package state to persist across Once calls 2026-06-14 13:37:24 +08:00
britz 4439d118fe fix: replace panic with error returns in loadLintRules and LintSkill 2026-06-14 13:37:24 +08:00
britz 11c31ab742 fix: handle os.Remove and filepath.Rel errors in symlink conversion 2026-06-14 02:43:32 +08:00
Willie 01d721a670 fix(git): preserve push stdout diagnostics 2026-06-13 22:15:25 +08:00
jnhu b48d23b312 fix(git): sanitize push remote error output 2026-06-13 22:07:03 +08:00
Willie 54dd7d12a3 fix(update): surface missing tracked repos in update --all across CLI, API, and UI
When tracked repo metadata is committed but the gitignored clone dirs are
absent on a fresh machine, `update --all` silently reported zero work: the
batch path skipped missing repos with no message, and the web UI's
update-all paths only listed repos present on disk.

Missing tracked repos are now detected and surfaced everywhere:
- CLI: a warning block (human output) plus an aggregated
  `missing_tracked_repos` summary (names + one-shot rehydrate hint) in JSON;
  the per-item error is concise. Fixed for both global and project modes,
  and batch and single-target paths.
- Server: GET /api/update/missing-tracked-repos and the update-all/stream
  summaries report them; POST /api/update/rehydrate re-clones them from
  metadata (mirrors bare `skillshare install`).
- UI: the Update page shows a warning banner listing missing repos with a
  Rehydrate button; strings added to all 11 locales.

Closes #212
2026-06-11 15:32:28 +08:00
Willie abdee142b9 fix(ui): respect agent filters during sync 2026-06-11 01:46:08 +08:00
Willie 59754ca3e6 fix(sync): resolve agent target aliases 2026-06-11 01:32:34 +08:00
Willie 51656e9cb3 fix(sync): keep project agent symlinks stable across syncs on symlinked paths
Project-mode agent sync re-reported every agent as updated on the second
sync when the project lived under a symlinked ancestor (e.g. macOS temp
dirs under /var -> /private/var), failing idempotency on macOS CI.

Two interacting causes:

- shouldUseRelative was unstable: on the first sync the target directory
  does not exist yet, so evalOrClean fell back to a non-resolved path and
  the under-project-root check failed, producing an absolute link; on the
  second sync the directory existed and resolved, so it wanted a relative
  link and reformatted the existing one. evalOrClean now resolves the
  deepest existing ancestor and re-appends the missing tail, so the answer
  is the same whether or not the leaf exists.
- The existing-symlink comparison only did a direct string compare, so a
  stable relative link whose resolved target carried the unresolved alias
  prefix looked like it pointed elsewhere. It now canonicalizes both sides
  via EvalSymlinks on the slow path, mirroring isSymlinkToSource.

Adds a regression test that reproduces the symlinked-ancestor case on any
platform.
2026-06-11 01:18:05 +08:00
Willie 9176c86ae9 feat(targets): add agents sync and factory alias to droid target
Factory Droid stores custom droids as markdown with YAML frontmatter in
.factory/droids/, which maps onto skillshare's existing agents sync. Add
the agents path so droids sync alongside skills, and register a factory
alias so the target is discoverable by brand name.

Refs #213
2026-06-11 00:53:27 +08:00
Willie 2b08bdf400 fix: use relative project symlinks for agents 2026-06-10 23:39:45 +08:00
Willie ef57f030dc fix: report missing tracked repositories 2026-06-10 15:37:16 +08:00
Willie 90f9609e64 feat(resources): add batch enable/disable in web UI
Add multi-select mode to the Resources page so users can enable or
disable many skills or agents at once (issue #203), instead of toggling
each one individually.

- New POST /api/resources/batch/toggle endpoint (skills + agents) backed
  by the shared .skillignore/.agentignore, returning per-item results and
  an updated/unchanged/failed summary
- Selection mode across grid, tree, and table views with a unified
  checkbox, folder-level tri-state select-all in the tree, a bottom
  action bar (Enable applies immediately, Disable confirms first), and
  optimistic updates
- i18n keys for all 11 locales
2026-06-05 23:41:03 +08:00
Willie 6e86537987 fix(audit): honor enabled:false for synthetic tier and cross-skill findings
Tier and cross-skill findings are generated programmatically rather than
compiled from the rule list, so they bypassed the disabled-ID filter applied
at rule-compile time. Setting enabled:false in audit-rules.yaml marked the
rule disabled in the listing but the scan still fired it at full severity.

Filter synthetic findings against the disabled-ID set in both the skill-scan
and single-file paths, threading the set through the cross-skill call sites
(analyzer, cmd, server). Fixes #204.
2026-06-05 20:51:32 +08:00
Willie e4ba03334a chore: release v0.20.8 2026-06-05 13:56:07 +08:00
jnhu 6b8923d260 replace em dash with colon in test message to avoid Unicode warning 2026-06-04 20:28:12 +08:00
jnhu 4b9d04aa80 optimize skillignore globstar memoization 2026-06-04 20:28:12 +08:00
jnhu 872a6ada8c fix(skillignore): memoize matchSegments to prevent exponential backtracking
Repeated ** segments caused O(N^K) recursive backtracking where K is
the number of consecutive globstars. Convert to index-based recursion
with (patternIndex, pathIndex) memoization, reducing to O(P*N).

The change is intended to preserve existing matching behavior while
avoiding repeated evaluation of the same (patternIndex, pathIndex)
states. Existing tests pass, and additional globstar semantics tests
were added to guard the core behavior.

Fixes exponential hang on patterns like **/**/**/**/0 with 150+ segment
paths (previously >2s, now ~60ms).
2026-06-04 20:28:12 +08:00
Willie 419bbaabf0 fix(server): uninstall disabled skills from resource endpoint 2026-06-03 22:33:11 +08:00
Willie 2b45618f74 feat(search): clearer hub load errors with structured toast
Hub fetch failures surfaced only a bare "fetch hub: HTTP 400" toast, with no indication of which hub failed or how to fix it.

Hub load errors now name the likely cause and include the URL for every failure mode (4xx/auth, malformed URL, invalid JSON, unreachable host, missing local file). The Search page renders them as a structured toast titled with the failing hub, and Toast gained an optional title for this.
2026-06-03 15:38:17 +08:00
Willie 694d784799 fix(preview): render SKILL.md for non-github.com hub sources
The web UI skill preview always fetched SKILL.md via api.github.com, so skills from GHE or other non-github.com hubs showed only index metadata (name, description, tags) instead of the full rendered content.

FetchPreview now resolves the source platform: github.com and GHE use the host's REST Contents API, while other platforms (GitLab, Bitbucket, Azure, SSH) fall back to a shallow clone. Sources whose content can't be retrieved degrade gracefully with a clear notice in the modal.

Fixes #193
2026-06-03 15:37:57 +08:00
Jason Blackburn b4be5a16e2 fix(audit): respect .skillignore for tracked hub repos in audit scan (#191) 2026-06-03 11:02:30 +08:00
Willie ccbe941291 feat: add Zed editor target
Zed added agent-skills support in vercel-labs/skills v1.5.8, using the
universal ~/.agents/skills (global) and .agents/skills (project) paths with
a flat-only skill layout. Register it as a built-in target and document it.

Since Zed shares the universal .agents/skills project path, it is auto-grouped
under the universal target by GroupedProjectTargets(); the docs note reflects
this. Verified in devcontainer: internal/config tests pass and zed resolves
via KnownTargetNames().
2026-06-03 00:21:29 +08:00
Willie acb150dfe3 fix(server): allow uninstalling disabled skills via Web UI
The skill list endpoint discovers skills with DiscoverSourceSkillsAll
(which includes disabled skills), but the uninstall handler used
DiscoverSourceSkills, which excludes anything listed in .skillignore.
A disabled skill therefore stayed visible in the dashboard yet failed
to uninstall with "skill not found".

Switch handleBatchUninstallSkills to DiscoverSourceSkillsAll so the two
endpoints agree on which skills exist. The CLI was unaffected.

Fixes #190
2026-06-02 23:48:09 +08:00
Willie 86b91efe95 feat(extras): refine per-target management UI and path resolution
UI (Extras page):
- Label per-target flatten/extension/mode controls with column headers
- Render flatten as a dropdown so it matches the adjacent selects
- Collapse the add-target form behind a button and widen the path input
- Confirm before removing a target
- Polish layout: tinted icon, inset source chip, hover rows, aligned columns

Components:
- Select: bound the dropdown width so long option descriptions wrap instead
  of stretching the popup across the page
- Toast: render messages multi-line, widen the container, and give
  error/warning toasts more time to read

Sync feedback:
- Restructure extras sync-failure toasts into readable lines and fix the
  contradictory "N more errors" count (new nMoreErrors translation)

CLI/server:
- Match extra target paths by resolved absolute path (handles ~ vs /home)
  when adding, removing, or updating targets
2026-06-02 18:40:00 +08:00
Willie 78a06da3d2 feat(server): add per-target add/remove endpoints for extras 2026-06-02 17:16:21 +08:00
Willie c47785abd9 feat(sync): add PruneExtraTarget wrapper for per-target cleanup 2026-06-02 17:06:12 +08:00
Willie 1d0ee69955 feat: support SSH hub sources for private and GHE hosts
Hub index fetch previously handled only unauthenticated HTTP(S) GET or
local file paths, leaving private and GitHub Enterprise repos out of
reach — raw HTTPS URLs redirect to login before token headers apply, and
SSH-style hub URLs were unrecognized.

Resolve SSH hub sources by shallow-cloning the repo with the user's SSH
keys and reading the index from it. The in-repo index path uses the
existing //path subdir convention (consistent with `install`), defaulting
to skillshare-hub.json at the repo root. Both scp-style and ssh:// URLs
are accepted. In the web dashboard, SSH clones are restricted to saved
hubs so a request-supplied URL can't drive an arbitrary clone.

Ref #185
2026-06-02 16:29:25 +08:00
Willie 6c29934a4f feat: add agents path to copilot target
Copilot CLI uses the same .agent.md format Skillshare already syncs to
Claude and OpenCode, so no transformation is needed — only a missing
registry path. Add global (~/.copilot/agents) and project (.github/agents)
agent paths per GitHub's documented custom-agent locations.

Closes #184
2026-06-01 15:08:22 +08:00
Letiancheng Lee d35ed81789 fix: recognize GHE data residency hosts 2026-05-31 22:28:33 +08:00