The doctor --json output gained a `suggestions` field (see eb99118d), but the web Health Check page silently dropped it. Render the remediation suggestions under each check's expandable detail block.
- Add optional `suggestions` to the DoctorCheck type
- Render suggestions list in CheckRow; make rows expandable when only suggestions are present
- Add `doctor.suggestions` i18n key across all 11 locales
Root-scope git operations detected hazards but proceeded anyway, letting
preventable mistakes reach the remote:
- Nested git repos were only warned about, then committed/pushed as empty
submodules (silent data loss). Now commit/push abort (CLI non-zero exit,
server 400) until the nested repos are disabled, and the web UI disables
the commit/push buttons while any are present.
- The pre-stage safety sweep ran before the dry-run check, so `--dry-run`
wrote .gitignore and ran `git rm --cached config.yaml`. The sweep/guard is
now strictly read-only on dry-run and only reports what would change.
- Server git endpoints used EffectiveGitRoot() without validating git_root,
so a hand-edited invalid scope silently fell back to skills. They now share
a gitSource() guard that rejects invalid scopes with 400, mirroring the
CLI's resolveGitRoot.
The grouped (folder tree) view ignored statusFilter in its isSearching, clear-filters, and empty-state logic, so filtering to Enabled/Disabled with no matches looked like an empty library instead of a filtered view with no results. Mirror the grid/table behavior by including statusFilter in all three checks.
At the root git_root scope, `git add -A` over the config base directory
records any subdirectory that has its own .git (e.g. the skills source) as
an empty submodule, and can commit the machine-specific config.yaml.
- Detect nested repos and warn before commit/push (CLI) or surface them on
the Git Sync page with a one-click "Disable nested .git" action (UI),
which renames .git to .git.disabled (reversible) and drops any stale
gitlink from the index so the directory's files track as normal blobs.
- Keep config.yaml out of a root-scope repo automatically: ensure it is
ignored and untrack it (git rm --cached) before staging, on both the CLI
and the web UI commit/push paths.
- Expose nestedRepos/configTracked in GET /api/git/status and add
POST /api/git/absorb-nested (validated against detected nested repos).
- Move the git_root scope selector from its own row into the status bar
alongside branch/HEAD, matching the repo-info layout
- Lay out the not-a-repo Initialize button inline (justify-between) so it
no longer floats awkwardly below the warning row
The not-a-repo state was a dead end: the scope switcher only rendered once a
repo existed, so there was no way to initialize git or set a remote from the
UI. Add an 'Initialize git repository' button that opens the existing scope
dialog (with optional remote) — POST /api/git/root already inits the scope
repo and wires origin. Dialog title/message adapt for the init case.
Also detect a missing git executable: gitStatus reports gitInstalled (via
exec.LookPath), the page shows a clear 'Git is not installed' notice instead
of a cryptic 500 on init, and handleSetGitRoot rejects with a plain message.
The Git Sync scope switcher now accepts an optional remote URL, reaching
UI parity with the CLI's `init --git-root <scope> --remote <url>`. The
POST /api/git/root handler takes an optional remoteURL and wires origin on
the just-initialized scope repo via a new git.SetOrAddRemote helper (adds
origin when absent, updates the URL otherwise). Adds gitSync.scope.remote*
strings across all locales.
Mirror the list TUI status filter in the web dashboard. A single
monochrome toggle button sits beside the source filter chips (separated
by a divider) and cycles All -> Enabled -> Disabled. Counts are scoped
to the active tab and compose orthogonally with the source filter.
Transform-extension sync previously wrote each generated file via
runExtensionFile unconditionally, so a regular local target file (e.g. a
hand-edited hello.toml) could be overwritten from hello.md without --force,
violating the same conflict contract that copy/merge modes honor.
- Split runExtension (subprocess → bytes) from runExtensionFile (writes),
and have syncExtraTransform apply the conflict/force rules: idempotent
when identical, skipped on conflict without --force, overwrite with
--force, and auto-replace leftover symlinks.
- Centralize the copy-only mode rule in SyncExtra so the API and CLI reject
extension+merge/symlink identically; align the server sync handler's mode
normalization (EffectiveMode's "merge" default no longer leaks through).
- CLI `extras list` no longer short-circuits to an "extension" status before
existence/drift checks. Status is now computed via output_ext-aware
CheckSyncStatus; a new Extension field carries the display label, decoupled
from sync status (plain-text + TUI rendering updated).
- Roll back the optimistic cache update in the UI mode-change handler on
failure (fixes the unused-var build break).
Adds regression tests covering conflict skip/force/idempotent/symlink-replace
and non-copy mode rejection.
Replace array-index keys with data-derived keys: the Add Extra modal gives
each TargetEntry a generated id (paths can be empty/duplicate while
editing), and ExtraCard keys by the target's unique path. Prevents stale
input/render state when rows are added or removed.
Add a Remove action to each installed extension in the Config Extensions
list (DELETE /api/extensions/{name}). The list now reports used_by — the
extras whose targets reference each extension — so the row shows an
in-use badge and the confirm dialog warns, in danger style, which extras
will fail on next sync before removing. Path-traversal names are rejected
server-side. Includes server tests for usage reporting and removal.
The per-target extension picker was hidden entirely when nothing was
installed, leaving no hint that transforms exist. Replace the empty space
with an 'Install an extension' link (in both the Add Extra modal and
ExtraCard) that deep-links to /config?tab=extensions; ConfigPage now reads
the tab query param to open the Extensions tab directly.
The Available list showed only a bare name with no hint of what each
built-in does. Render the catalog description next to it. Also broaden the
section copy: extensions pipe each file through a script (not only
'convert to a format'), and reword the source-path help to make the
intent clearer.
The raw <input type=checkbox> and greyed-out mode select looked out of
place against the hand-drawn design. Use the shared Checkbox component for
Flatten, and render a read-only lock chip (instead of a disabled select)
when an extension forces copy mode — in both the Add Extra modal and
ExtraCard so the two stay consistent.
Add column headers (Path / Extension / Mode) so first-time users can
tell the controls apart. When an extension is selected, replace the
greyed-out mode select with a read-only "copy" lock chip plus a
"runs in copy mode" hint — the disabled control read as broken rather
than intentionally locked.
The create-extra dialog now offers the same per-target extension
dropdown as the Extras cards. Selecting an extension forces the target
into copy mode and disables the mode selector. createExtra carries the
extension, and the server coerces such targets to copy mode on create.
The "Open directory" action launched a text editor; switch it to the
OS file manager (Finder on macOS, Explorer on Windows, xdg-open on
Linux/BSD) so it reveals the folder as users expect. Drop the editor
override parameter and the {editor} toast placeholder.
Add an "Extensions" tab to the Config page for managing transform
extensions in the active mode (global or project):
- GET /api/extensions lists installed extensions with their manifest
descriptions, merged with the built-in catalog so users can see what
is available to download.
- POST /api/extensions/install downloads a whitelisted built-in
extension into the active mode's extensions directory.
- POST /api/extensions/open opens that directory in the user's editor,
mirroring the skill "open in editor" affordance.
ExtensionSpec now carries the manifest description so the list can
surface it. The UI shows installed extensions with a built-in badge,
available built-ins with a Download button, and an Open-directory
action. Strings are translated across all 11 locales.
Surface the per-target extension transform in the dashboard. A new
GET /api/extras/extensions endpoint lists extensions available in the
current mode's directory (global or project), and the Extras page renders
a picker per target. Selecting an extension forces copy mode (transforms
are copy-only) and locks the mode control; changes apply optimistically
via the query cache. Adds i18n keys across all locales.
Add Config.GitRootMismatch() as the single source of truth for detecting
when the git repo lives at a different scope than git_root configures, and
reuse it across the CLI guidance, the server status response (scopeMismatch
/mismatchScope/mismatchDir), and a new warning banner on the Git Sync page.
Document git_root in the config structure-view field docs (fieldDocs) and the
GitStatus client type, and add the gitSync.scope.* / gitSync.mismatch.* i18n
keys across all locales to keep dictionary parity.
Cover the behavior with config, server handler, and CLI integration tests:
push/pull honor the root scope (agents files reach the remote, config.yaml
stays untracked), POST /git/root inits+persists the scope and rejects invalid
scopes and project mode, and git status reports scope mismatches.
The mixed-tracked-repo recovery path used a fragile substring match on
the error message and re-cloned the repo via /discover to count skills
and agents. Both problems share one root cause: the counts InferTrackedKind
already computed during the failed first install were thrown away.
- Add install.TrackKindAmbiguousError carrying the discovered Skills /
Agents counts. InferTrackedKind returns it on the ambiguous branch.
Error() preserves the legacy message verbatim so CLI output is unchanged.
- Server handleInstall track branch uses errors.As to detect it and emits
writeCodedError with stable code 'install.track_kind_ambiguous' plus
skills/agents counts in error_params.
- UI replaces the substring match with an ApiError.code check and reads
counts straight from err.params, skipping the second /discover clone.
- Add unit tests asserting errors.As, count fidelity, and explicit-kind
short-circuit (no clone).
Net result: 2 clones instead of 3 on the mixed-track recovery path, and a
stable cross-language contract instead of a brittle English substring.
Installing a mixed git repo (containing both skills and agents) with
'Track' enabled failed with 'tracked install is ambiguous; pass --kind
skill or --kind agent', and the UI gave no way to recover.
- api.install: add optional 'kind' param (backend already supports it)
- InstallForm: detect the ambiguity error, fetch counts via /discover,
and prompt the user to pick Skills or Agents via a kind-selector
dialog; re-run install with the chosen kind
- Snapshot all install params (source/name/into/branch/force/skipAudit)
at error time so a later kind selection cannot drift if the user
edits the form behind the dialog
- Fall back to the original ambiguity error if /discover fails, so the
user is not left with only a confusing secondary error
- Render the kind selector in both collapsible and non-collapsible
return branches so the fix works for any InstallForm caller
- preventClose while installing so an in-flight kind selection is not
cancelled by Escape / backdrop click
- Hoist KindOption out of the render body to keep its component
identity stable across parent re-renders (no more autoFocus refire)
UI redesign of the kind selector:
- Replace ConfirmDialog wrapper with DialogShell + stacked card-style
kind buttons (icon + label + count + chevron)
- Title row gains an X close affordance; remove the redundant bottom
Cancel/divider to match other modals
i18n: drop legacy skillsButton/agentsButton/cancelText keys; add
skillsLabel/agentsLabel/itemCount across all 11 locales with fully
native phrasing (no mixed English in non-English locales).
Three user-visible additions to the web dashboard, plus the CLI surface
needed to drive them.
* `skillshare ui start` / `skillshare ui stop` — run the dashboard as a
managed background process. Re-running start reuses the existing
healthy process; stop uses the remembered host/port. Foreground
`skillshare ui` keeps working unchanged. Process tracking lives in
ui_process_{unix,windows,other}.go via a PID + current-state file.
* `--app` — opens the dashboard in a Chromium app-mode window (Chrome,
Edge, Brave) on macOS, Windows, and Linux for a separate Dock/taskbar
entry without browser chrome.
* In-place upgrade from the browser — the Update dialog and the Doctor
page's Version card now expose an Update now button. Backed by two
new endpoints (POST /api/upgrade, POST /api/restart in
handler_restart_upgrade.go); the browser polls GET /api/health and
reloads once the new server is ready. Dev builds short-circuit with
`devMode: true` and a simulated restart so the flow can be exercised
without rebuilding the binary.
* Progressive Web App — site.webmanifest, app icons (192/512), and a
minimal service worker registered from main.tsx. Supporting browsers
can install the dashboard as a standalone desktop app.
* Doctor Version card redesign — state-coloured icon (blue when an
update is available, green when up to date), explicit
`current → latest` delta, Update button only when there is something
to upgrade.
* i18n — translate "DEV mode" in zh-TW / zh-CN / ko (previously left
as raw English).
Adds CHANGELOG.md and website changelog entries for v0.19.20 and
refreshes website/docs/reference/commands/ui.md to document the new
modes, --app flag, new REST endpoints, and the in-place upgrade flow.
Make the v0.19.16 sources map actually do something: route all path
reads through Config.EffectiveSkillsSource() / EffectiveAgentsSource() /
EffectiveExtrasSource() so users who set sources.skills / sources.agents /
sources.extras get the configured paths everywhere.
Mechanical changes (~50 files):
- cmd/skillshare/**: replace cfg.Source / cfg.ExtrasSource reads with
cfg.EffectiveSkillsSource() / cfg.EffectiveExtrasSource()
- internal/server/**: replace s.cfg.Source / s.cfg.ExtrasSource reads
with the same helpers; server.skillsSource() / gitignoreDir() use the
global-mode helper
- internal/config/config_validate.go: validate using EffectiveSkillsSource
while still rejecting configs that set neither field explicitly
- internal/config/reconcile.go, registry.go: read via helpers
Behavioral fixes (paired with the migration):
- extras init / extras source / POST /api/extras no longer silently
backfill the legacy extras_source field — the runtime fallback inside
EffectiveExtrasSource() handles it. This stops surprise diffs in users'
config.yaml after running extras commands.
- extras source command writes back to whichever field the user already
configured (sources.extras if set, otherwise legacy extras_source) so
the update is not shadowed.
- source_type in /api/extras and extras list correctly reports "default"
vs "extras_source" by inspecting the raw (unresolved) configured value;
sources.extras counts as configured for this purpose.
UI:
- ui/src/lib/fieldDocs.ts: neutralize sources / sources.* descriptions
so they describe both project and global modes (Phase 5).
Preserved (intentional):
- Direct writes to cfg.Source / cfg.AgentsSource / cfg.ExtrasSource in
init, migrate.go, cloneForSave, and server.reloadConfig — these are
raw-field writes, not path reads.
- Updated test expectations for the removed backfills.
- Project mode JSON sync now includes context_cost (was nil)
- Server handler respects symlink mode (skips include/exclude filters)
- checkBudget reports all targets exceeding threshold (not just worst)
- Budget warnings include target name in CLI and UI output
- ConfigPage indentation restored to original 2-space style
The assistant panel already shows field documentation via JSON schema.
A static reference card is redundant and breaks the page's interaction
pattern of cursor-driven contextual help.
Add azure_hosts config parameter (analogous to gitlab_hosts) that allows
users to register self-hosted Azure DevOps Server hostnames so they
receive proper URL parsing without appending .git to clone URLs.
- Add AzureHosts field to Config and ProjectConfig structs
- Add SKILLSHARE_AZURE_HOSTS env var support with merge semantics
- Generalize hostname validation into shared normalizeHostList/mergeHostsFromEnv
- Add azureOnPremPattern regex and parseAzureOnPrem for /_git/ URL routing
- Add isAzureHost for config-based host detection (no auto-detect)
- Update TrackName to handle on-prem Azure DevOps clone URLs
- Wire AzureHosts through InstallContext, ParseOptions, and Server
- Add JSON Schema, UI fieldDocs, and website documentation
- Add 19 new tests covering config, source parsing, and server
Closes#147
- Add ErrSkillNotFound sentinel error in search/preview.go so callers
can distinguish 404 from other errors with errors.Is instead of
brittle string matching
- Cap previewCache at 200 entries with TTL purge + full reset on
overflow to prevent unbounded memory growth
- Make Card and SearchResultsTable rows keyboard-accessible
(role=button, tabIndex=0, Enter/Space handlers)
- Refactor SkillPreviewModal to accept a single SearchResult prop
instead of 6 individual fields — reduces prop drilling and keeps
the modal in sync with the result shape
- Fix search_online_test: add --list flag so output is not gated
behind interactive TUI
Add a preview modal so users can read a skill's SKILL.md content
before installing. Clicking a search result card or table row opens
the modal; the Install button is now inside the modal.
Backend:
- New GET /api/preview?source=owner/repo/path endpoint
- FetchSkillContent fetches SKILL.md from GitHub Contents API
- Git Tree API fallback for hub sources where the install shorthand
doesn't match the repo's actual file path
- In-memory TTL cache (5 min) via sync.Map
- Proper 404/429/500 error handling with rate-limit support
Frontend:
- SkillPreviewModal component (DialogShell-based, lazy-fetch)
- Cards and table rows clickable to open preview
- Graceful fallback: if fetch fails but hub metadata exists, show
description + tags instead of error
- Hide Stars column in table view for hub mode
- Fix Card component missing onClick prop passthrough
- Fix IntersectionObserver not reconnecting after loading more items
- Prevent background scroll when any modal is open (DialogShell)
- i18n keys added to all 11 locales
Closes#141
Add PATCH /api/resources/{name}/source endpoint to update the source URL
for installed skills. For tracked repos, all sibling skills sharing the
same git remote are updated together with the new repo base URL, and the
git remote origin is also updated.
Frontend changes:
- Add Source URL input field in the skill editor (visible for all skills
with metadata)
- Use shared Input/Textarea components in FrontmatterEditor for visual
consistency, with new size='sm' variant
- Replace custom kind-badge/tracked-badge with shared KindBadge/SourceBadge
components in the editor header
- Preserve original YAML frontmatter formatting when only the body or
source URL is changed (avoids spurious quote style / line wrap diffs)
- Skip diff review dialog when only source URL is modified
Backend fixes:
- Two-pass skill lookup in handleGetSkill: prefer exact FlatName match
over baseName fallback to prevent name collisions between standalone
and tracked repo skills
- Add basename-only fallback in MetadataStore.GetByPath for tracked repo
skills stored with short keys
- Use cfg.Source (global) consistently in save/patch handlers to match
the source used by list/detail handlers in project mode
Closes#142
Extract highlightArgs utility from SkillEditor to shared lib so both
the editor and ResourceDetailPage render $ARGUMENTS with the warning
badge style.
- Add p/li component overrides in ResourceDetailPage mdComponents
- Move .arg-token CSS from scoped editor styles to global index.css
- Simplify argsCount to hasArgs boolean (count display removed)
- Remove ×{count} prefix from argsHint in all 11 locales
The shared SegmentedControl has no gap between icon and label, making
Edit/Split/Preview look cramped. Revert the visual to the original
editor-themed .seg-btn/.seg-group CSS (4px icon gap, paper background,
shadow-sm active state).
Keep the DRY JSX win by introducing a small EditorSegment helper that
renders the same markup the three inline call sites previously duplicated.
resolveFieldPath() was intentionally updated in 7c913086 to treat bare
list values like "- skill-a" as resolvable keys (for short-form target
name docs lookup), but the corresponding test still asserted the old
null-returning behaviour and had been failing silently ever since.
Follow-up to the earlier simplify pass — addresses the larger refactors
called out by the three review agents:
- Drop local SegmentedField in favour of the shared SegmentedControl used
across the dashboard; reuse it for the Fields/YAML toggle, the
Edit/Split/Preview mode switcher, and the enum frontmatter fields. Removes
~34 lines of duplicated .seg-group / .seg-btn CSS.
- Split the 80-line FrontmatterField if/else into per-type subcomponents
(EnumField / BoolField / ArrayField / TextField) dispatched from a small
FieldControl switch. The synthetic 'conditional' field type is gone —
visibility is now a plain 'showWhen' predicate on a 'text' field, with an
optional 'placeholder' override.
- Extract a shared CollapsibleGroup wrapper; both FrontmatterGroup and
FrontmatterMetadataGroup use it, deleting the copy-pasted fm-group chrome.
- requestAnimationFrame-throttle the synced-scroll handlers. Previously
every onScroll event (~60×/s) ran buildSyncAnchors, which measures
scrollHeight / getComputedStyle / querySelectorAll and sometimes the DOM
mirror. Now one pass per frame per scroll source, with RAF + timer
cleanup on unmount.
useLineDiff consolidation was considered but skipped — computeLineDiff
returns only add/remove rows, whereas DiffView needs the eq rows for the
side-by-side view, so merging would complicate the shared hook.