Commit Graph
32 Commits
Author SHA1 Message Date
Willie 046e35a566 fix(devcontainer): forward port 3000 for docs site
The `docs` command starts Docusaurus on :3000 inside the container,
but compose only published 5173 and 19420 to the host. The
`forwardPorts` entry in devcontainer.json only takes effect under
VS Code / the devcontainer CLI; `make devc` uses plain
`docker compose`, which honors only the compose `ports:` mapping.

Publish 3000 so `docs` is reachable from the host browser.
2026-05-29 01:12:28 +08:00
Willie 9d837e943f fix(devcontainer): fix project mode UI and port cleanup
Two issues fixed:

1. Air's full_bin does not run through sh -c, so the previous
   "cd ... && /workspace/..." in SKILLSHARE_UI_EXEC_PREFIX was
   silently failing (cd exits 0, binary never runs). Replace with
   a wrapper script that does cd + exec.

2. Port cleanup relied on fuser which is missing in containers.
   Add pids_on_port() that reads /proc/net/tcp6 to find socket
   inodes and maps them back to PIDs. Three-layer cleanup:
   PID file → pkill pattern → port-level kill.

Also improve error messages: show the stuck PIDs and fix command
instead of the unhelpful "slow start" message.
2026-03-13 11:48:04 +08:00
Willie 7a6e78783b fix(build): separate host and devcontainer binary output paths
Devcontainer `make build` previously wrote a Linux binary to
`bin/skillshare` via the shared volume mount, overwriting the host's
macOS binary and causing `exec format error`.

Introduce a `BINARY` variable (Makefile) / `SKILLSHARE_BINARY` env var
(mise) so devcontainer builds to `/usr/local/bin/skillshare` while the
host keeps `bin/skillshare`. Also update `scripts/test.sh` to respect
a pre-set `SKILLSHARE_TEST_BINARY` instead of unconditionally
overwriting it.
2026-03-12 16:45:02 +08:00
Willie 48f1d3767f fix(test): improve extras runbooks with jq assertions, idempotency, and init cleanup
- Replace python3 JSON parsing with native mdproof jq: assertions across
  extras_refactor_json_runbook (7 steps simplified)
- Add cat>> idempotency guards (sed -i cleanup) before YAML appends
- Add ssenv --init default extras cleanup in Step 1 of extras_commands
  and sync_extras runbooks to prevent false failures
- Rename runbook.json → mdproof.json (mdproof only reads mdproof.json)
- Move /tmp cleanup from step_setup to setup (per-runbook, not per-step)
  to avoid breaking cross-step dependencies
- Fix ensure-mdproof.sh to upgrade dev binary to latest release
- Add .mdproof/lessons-learned.md with 5 documented gotchas
- Update cli-e2e-test SKILL.md with assertion types, jq best practices,
  --init extras checklist item, and /mdproof skill collaboration
2026-03-12 16:45:02 +08:00
Willie 478b4ee336 refactor(runbook): replace built-in runner with mdproof
The in-tree runbook runner (tools/runbook/, 25 Go files, ~4500 LOC)
has been extracted into the standalone mdproof project and is no
longer needed here.

Removed:
- tools/runbook/ — parser, executor, assertions, reporters, tests
- .devcontainer/bin/runbook — wrapper that built from tools/runbook
- ai_docs/runbook-guide.md — docs describing the old runner
- Makefile build-runbook target

The cli-e2e-test skill, runbook.json, and ensure-mdproof.sh already
reference the external mdproof binary for all E2E test execution.
2026-03-11 04:53:08 +08:00
Willie e589447d70 fix(devcontainer): resolve runbook paths against workspace root
When inside an ssenv isolated shell, HOME changes and relative paths
like ai_docs/tests/ don't resolve. The wrapper now rewrites relative
non-flag arguments to /workspace/<path> when the file exists there.
2026-03-11 04:53:08 +08:00
Willie cdf7263516 feat(devcontainer): add runbook shortcut command
Auto-builds from source on each invocation, same pattern as the
ss/skillshare wrapper. Added to help screen and setup.sh quick
start message. Updated guide to document the shortcut.
2026-03-11 04:53:08 +08:00
Willie 7c582cbe21 docs: update v0.16.13 changelog to match project style
Expand bug fix descriptions, add grouped layout ASCII example,
and sync website changelog.
2026-03-06 23:10:48 +08:00
Willie 657b833569 fix: suppress devcontainer redirect for -j flag and show tracked badge in filter mode
- Add -j short flag to wants_machine_output() in devcontainer wrapper,
  preventing stderr banner noise for `skillshare list -j` etc.
- Show tracked repo name badge on skill items so filtered results remain
  distinguishable when group headers are absent. Two tracked skills from
  different repos now render with their repo origin visible.
2026-03-06 23:10:48 +08:00
Willie f115ab5e0e fix(tui): show skill name and group in list detail panel
The detail panel header was rendered on L00 (same row as the list title),
making the skill name invisible. Push content to L01 with a leading newline
and use colorSkillPath for consistent group/name coloring matching the left
panel. Compress status/date/targets into a single metadata line to save
vertical space. Show full source URL and synced targets in Quick Facts.

Also suppress devcontainer stderr redirect message in --json/--format modes
and fix audit summary field name (analyzerCount → activeAnalyzers).
2026-03-06 23:10:48 +08:00
Willie 7d49f4a035 fix(devcontainer): expose ports for standalone docker compose usage
VS Code auto-forwards ports via devcontainer.json forwardPorts, but
running `docker compose up` directly left 5173/19420 unreachable from
the host. Add explicit port mappings so the UI works without VS Code.
2026-03-03 16:08:11 +08:00
Willie 474bf3e4c1 feat(devcontainer): standalone lifecycle without VS Code dependency
`make devc` now builds, initialises, and enters the devcontainer in one
step — no VS Code required. A unified `scripts/devc.sh` replaces the old
`devcontainer_shell.sh` with full lifecycle subcommands (up/shell/down/
restart/reset/status).

Key changes:
- Dockerfile Stage 2 copies node+pnpm from ui-builder (removes need for
  devcontainer feature, benefits sandbox playground too)
- profile.d scripts moved from setup.sh → start-dev.sh so they survive
  container recreation (down → up) without re-running full setup
- Volume-based sentinel (~/.devcontainer-initialized) lets devc.sh skip
  setup.sh when volumes persist, cutting restart to ~2s
- Go toolchain PATH added to profile.d (login shell was losing it)
- Makefile/mise.toml gain devc-up/-down/-restart/-reset/-status targets
- Website docs updated with terminal-first flow and CLI path in diagrams
2026-03-03 16:08:11 +08:00
Willie 0afab5cb7b fix(sync): resolve race condition for targets sharing the same path
Multiple targets (e.g. universal/amp/kimi/replit) share ~/.config/agents/skills.
Parallel sync caused concurrent goroutines to race on os.Symlink for the same
destination, producing "file exists" errors.

Fix: group entries by resolved target path so same-path targets run sequentially
within one goroutine. Different-path targets remain fully parallel.

Also addresses PR #52 review feedback:
- audit: replace O(N²) findElapsed with O(1) index-aligned elapsed slice
- test-brew-upgrade: explicit go check + mktemp -d (replaces || true and /tmp)

Add 6 integration tests covering shared-path race condition, idempotency,
--force mode, mixed paths, filters, and output verification.
2026-02-26 22:27:23 +08:00
Willie 3710969f9d fix(upgrade): contain brew output in tree spinners, fix GitHub release tree structure
Homebrew path: replace direct stdout pipe with TreeSpinner + bytes.Buffer
so brew output no longer breaks the tree layout. Captured output is only
shown on failure for debugging.

GitHub release path: switch download/UI-asset spinners from StartSpinner
to StartTreeSpinner with correct isLast flags, add tree-line prefix to
confirmation prompt, use StepEnd for cancel.

Add TreeSpinner.Warn() and TreeLine() helper to internal/ui.
Add devcontainer test-brew-upgrade script to simulate Homebrew path.
2026-02-26 22:27:23 +08:00
Willie a5ba6e48f3 feat(ssenv): add ssrm shortcut for force-deleting environments
ssrm <name> is equivalent to ssenv delete <name> --force.
Added to shortcuts wrapper, ssenv shortcuts help, and help page.
2026-02-25 07:02:54 +08:00
Willie 1926725fd8 fix(ssenv): use PROMPT_COMMAND for PS1 and create .claude/.codex dirs
Replace static PS1 prepend with a dynamic PROMPT_COMMAND hook to prevent
prompt duplication when ssenv-shortcuts.sh is sourced multiple times.
The hook also auto-clears the prefix when SSENV_ACTIVE is unset (reset/delete).

Add .claude and .codex to ensure_layout() so new environments include
these directories by default.
2026-02-25 07:02:54 +08:00
Willie c5d32111f7 dev: overhaul devcontainer experience with persistence and enhanced tooling
Improve the sandbox development environment to support "new user" simulation
while maintaining a high-quality developer experience.

Changes:
- Persistence: Redirect HOME to /home/developer and add a persistent volume
  to preserve shell history, gh auth state, and isolated environments.
- Tooling: Pre-install GitHub CLI (gh), air (hot-reload), and delve (dlv)
  in the sandbox Dockerfile.
- Isolated Envs:
    - Update ssenv to store environments in persistent $HOME/.ss-envs.
    - Add --init flag to ssnew/ssenv to auto-run 'ss init -g' in new envs.
    - Add visual PS1 indicator when an isolated environment is active.
- DX Refinements:
    - Add a centralized 'help' command (aliased to override bash built-in).
    - Fix ANSI color rendering in help script.
    - Robust PROJECT_ROOT redirection in skillshare wrapper script.
    - Support /home/developer in setup.sh environment checks.
2026-02-25 07:02:54 +08:00
Willie 792d236485 feat: optimize tracked subdir installs and devcontainer isolation
Implement remaining Issue 46 optimizations and developer experience fixes.

Install and update optimization:
- optimize install --track for subdirectory sources by attempting sparse checkout first while preserving git metadata
- fallback to existing tracked clone strategy on sparse capability or sparse path errors
- clean sparse created destination before fallback clone to avoid destination already exists failures
- improve tracked install spinner wording for subdir sources
- add tracked subdir unit tests for sparse success and sparse to full clone fallback

Progress user experience:
- normalize git progress lines by stripping volatile transfer rate suffix
- dedupe and throttle spinner and tree spinner update frequency to reduce tty flicker
- add unit tests for spinner progress normalization and throttling behavior

GitHub API messaging:
- improve rate limit guidance to suggest setting token env vars or using gh auth login

Devcontainer isolation:
- make ssenv enter command mode run from isolated environment cwd
- fix setup global init detection to use skillshare status global mode
- add auto mode hint in devcontainer wrapper when workspace project config takes precedence

E2E and tests:
- expand Issue 46 runbook with install, install track, update, no token fallback, sparse paths, and isolation checks
- update compact warning output test expectations to match current grouped warning rendering

Verification:
- go test internal install package
- go test internal install sparse and tracked subdir tests
- go test internal ui package
- go test cmd skillshare package
- go build skillshare binary and run integration TestInstall_Subdir
- run tracked subdir tests inside devcontainer
2026-02-25 07:02:54 +08:00
Willie 7e1b29a5a7 refactor(devcontainer): dedupe ssenv shortcut setup and unify mode prompt 2026-02-24 01:47:38 +08:00
Willie 4c628e9dc9 Add devcontainer ssenv workflow and AI test guide 2026-02-24 01:47:38 +08:00
Willie 7ab4c626fa Harden devcontainer skillshare entrypoints 2026-02-24 01:47:38 +08:00
Willie 6656877b4a fix: make air install non-fatal during devcontainer setup
go install air can fail due to network issues. The ui command already
has fallback auto-install, so setup.sh should not abort on failure.
2026-02-23 04:18:01 +08:00
Willie 70dec0a821 fix: resolve air binary path and use entrypoint config
Air installed via `go install` lands in GOPATH/bin, not GOROOT/bin.
Resolve the path dynamically with fallback auto-install. Also replace
deprecated `bin` with `entrypoint` in .air.toml.
2026-02-23 04:18:01 +08:00
Willie b93d8f103a fix: wait for API port and fix project-mode cwd with air
Air needs time to compile before the server is ready. Add a
wait-for-port loop (max 30s) so the dashboard URL is only shown
after the API is actually listening.

For project mode, use SKILLSHARE_UI_EXEC_PREFIX to cd into the
project directory before exec'ing the binary, since skillshare ui -p
relies on os.Getwd() and air must build from /workspace.
2026-02-23 04:18:01 +08:00
Willie 1637b1905f feat: integrate air hot-reload into devcontainer
Replace manual build+nohup with air in the `ui` command and install
air during setup so .go changes auto-restart the API server.
2026-02-23 04:18:01 +08:00
Willie 13d9b82be7 fix: devcontainer token loading from .env and host env fallback
- Remove token vars from remoteEnv (localEnv overrides .env with empty)
- Pass host tokens via docker-compose environment as fallback
- Add profile.d script to source .devcontainer/.env in login shells
- Add sandbox token passthrough for GitLab/Bitbucket/generic tokens
- Add root .env to .gitignore
2026-02-22 15:13:10 +08:00
Willie 62b215fd53 fix: keep devcontainer project mode out of workspace root 2026-02-21 06:07:35 +08:00
Willie 084d93bf94 feat(devcontainer): add credential-helper toggle and token forwarding
Add tooling for testing private repo auth inside the devcontainer:

- credential-helper script (on/off/status) with --eval mode to
  toggle both git credential helper and token env vars in one command
- remoteEnv forwards host token env vars (GITHUB_TOKEN, GITLAB_TOKEN,
  BITBUCKET_TOKEN, BITBUCKET_USERNAME, SKILLSHARE_GIT_TOKEN)
- docker-compose env_file for .devcontainer/.env (optional, gitignored)
- start-dev.sh auto-detects GITHUB_TOKEN from gh CLI on container start
- .env.example template for all supported tokens
- docker-sandbox.md documents token sources and private repo testing
2026-02-21 06:07:35 +08:00
Willie eb397c5fed chore(devcontainer): make ss instant and self-healing 2026-02-21 06:07:35 +08:00
Willie 595fe84c6b refactor(devcontainer): simplify dev server management
Replace dev-servers with self-contained `ui` and `docs` commands:
- `ui` / `ui -p`: build binary, start API (global/project) + Vite
- `ui stop`: stop API + Vite
- `docs` / `docs stop`: start/stop Docusaurus
- Remove `ui-p` script (merged into `ui -p`)
- Fix PID reuse false-positive in is_running() via /proc/cmdline
- Fix process tree cleanup in do_stop() (kill children before parent)
- Fix pkill pattern to match `skillshare-dev` binary name
- Update devcontainer.json port labels and ordering
- Update docker-sandbox.md to reflect new commands
2026-02-20 22:13:33 +08:00
Willie 1b5056d0ea refactor(docker): unify versions, consolidate init scripts, add sandbox-logs
- Add `make sandbox-logs` / `mise run sandbox:logs` convenience target
- Unify Docker build versions via ARG: Node 24, pnpm 10.28.0, Go 1.25.5
- Extract shared demo content to scripts/create-demo-content.sh, slim down
  setup.sh and sandbox_playground_up.sh from ~150 duplicated lines each
- Move devcontainer scripts (ui, ui-p, docs) to .devcontainer/bin/
  (source-controlled, survives make clean) with auto mode-switching
2026-02-20 12:22:02 +08:00
Willie 626f0f2240 feat(devcontainer): add Node.js 24, auto-start dev servers, and dev-servers manager
Enable full frontend development inside the devcontainer without
falling back to the host. Three dev servers (Go API :19420, Vite :5173,
Docusaurus :3000) start automatically via postStartCommand and can be
managed with the `dev-servers` CLI (start/stop/restart/status/logs).

Key changes:
- Add Node.js 24 + pnpm devcontainer feature
- Auto-install ui/ and website/ dependencies in setup.sh
- Add dev-servers.sh process manager with PID tracking
- Replace shell aliases with PATH scripts (ss, skillshare-ui, etc.)
- Set Vite server.host: true for container accessibility
- Make ui-dev Go server host configurable via SKILLSHARE_UI_HOST env var
- Forward ports 5173 and 3000 alongside 19420
- Harden setup.sh with environment guard and safe_cleanup helpers
- Update docker-sandbox.md with frontend development section
2026-02-20 04:12:34 +08:00