mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-20 12:23:22 +00:00
f052d5c945ec47bac86a3e84892922a2ef2ce27b
79
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
afe5eaa959 |
docs(ui): describe the dashboard row for a repo with no checkout
Since #880, the Dashboard lists a tracked repository that is recorded in metadata but not cloned on this machine, marks it "No checkout on this machine", and its Uninstall removes only the record and audit acceptances. The Dashboard row in the ui reference still described only checkout uninstalls, so readers could expect the repo to move to trash. |
||
|
|
fab72f79e1 |
fix(doctor): stop the plugin check from holding back later checks (#889)
* fix(doctor): stop the plugin check from holding back later checks The dashboard's Doctor page streams checks as doctor finds them, but the plugin check asks each Agent's native CLI what is installed and can take many seconds. Checks run in order, so backups, trash and the version checks waited behind it while the page showed only an unlabeled skeleton row, with nothing saying which check was still running. When doctor streams, the plugin check now runs in the background. It is streamed first as a "pending" row in its place, the checks after it stream as soon as they finish, and its result follows. The full result keeps the check in its original place. Text output and plain --json run it inline as before. The dashboard shows a pending row as the check's name with a spinner and "Checking", replaces it in place when the result arrives, keeps it visible under every filter, and drops the unlabeled skeleton while it is shown. The /api/doctor/stream reference documents the pending row. * fix(doctor): show the skill scan and Git status as running Doctor scans the skill source before it streams its first check, and runs git status on the source inline. On a large source either can take seconds, and the dashboard showed only an unlabeled skeleton meanwhile. A streamed doctor now sends a pending "source" row before the scan, and runs the Git check in the background like the plugin check, so the checks after it no longer wait. A finished background check is recorded at the next check instead of at the end, so its row does not stay pending after its result is known. The pending row now holds the check's place in the result while it runs. |
||
|
|
9dbcd925d8 |
feat(audit): honor findings accepted with --force via --respect-accepted (#872)
* feat(audit): honor findings accepted with --force via --respect-accepted install and update --force record the findings a user accepted in audit_accepted, but audit ignored that record. A skill installed with --force therefore kept failing `skillshare audit` in CI with no way to let the accepted findings pass (#869). audit --respect-accepted marks those findings as acknowledged. They stay in every output (JSON acknowledged: true, a text/TUI note, "(accepted earlier)" in Markdown, SARIF external suppressions), but they are counted in summary.accepted instead of their severity and no longer fail the audit. Without the flag nothing changes, so existing CI gates keep their behavior. A changed file or snippet produces a new key and blocks again. Tracked repositories record acceptances at the repo root with paths relative to it, so ApplyAcceptedFindings walks up from each skill to match them. The install, update and edit gates use the same function and now honor repo-wide acceptances for skills inside tracked repos too. The dashboard always honors accepted findings: the Audit page mutes them and counts them apart, the skill Audit tab collapses them, and the Dashboard attention card no longer lists a skill whose only blocking findings were accepted. The CLI JSON summary and the server summary share Result.CountOpenBySeverity so both count accepted findings the same way. The oplog records the accepted count and the log views show it. * fix(audit): match acceptances when a single file is scanned A single-file scan names its findings by the file's base name, but the ancestor lookup used the file's whole path as the prefix, so it hashed SKILL.md/SKILL.md instead of the recorded SKILL.md. Auditing a skill file directly with --respect-accepted, and auditing agents inside a tracked repository in the CLI or the dashboard, still failed on unchanged accepted findings. For a file target the prefix is now the file's own directory. |
||
|
|
65f3c8d1b9 |
fix(ui): show health checks as they finish instead of after the slowest (#870)
* fix(ui): show health checks as they finish instead of after the slowest
The Doctor page waited for the whole `doctor --json` run before showing
anything. One slow check, such as plugin checks waiting on a native CLI
that does not answer, kept the page on a skeleton for 30 seconds, and the
server's 30-second write timeout could cut the response off entirely.
`doctor --json` now prints each check as a {"check": ...} line when the
internal _SKILLSHARE_DOCTOR_STREAM variable is set, before its usual
result. The new GET /api/doctor/stream relays those lines as Server-Sent
Events and sends the full result as `done`; it has no write deadline and
stops doctor when the client leaves. The page shows checks as they
arrive and replaces them with the final result.
* fix(ui): show the server's reason when a stream fails
The audit, diff and doctor streams send an `error` event with the reason,
but the shared EventSource helper treated it like a dropped connection
and showed only a generic message. It now uses the reason the server
sent, and keeps the generic message for a real disconnect.
* fix(doctor): skip Git reads in the hooks check when no hooks are configured
The hooks check loaded the full hooks inventory, which also scans
unmanaged native and Git hooks twice: about 12 git calls even with no
hooks configured, none of which doctor reports. Doctor now reads the
hooks section first and previews a sync only when there is something to
check.
|
||
|
|
c040917bc7 |
fix(security): enforce credential and filesystem trust boundaries (#861)
Bind provider credentials to canonical or explicitly configured HTTPS origins and preserve that policy across remote consumers. Reject cross-site credentialed reads, linked fallback directories, and discovered-agent writes outside the source; audit staged content before rooted atomic publication. Add boundary regressions, private Git update coverage, stable cross-platform fixtures, and aligned documentation. Verified the integrated main baseline with all executed CI checks passing. |
||
|
|
0580bd79bd |
feat(ui): add a refresh button to the Hubs page (#814)
The Hubs page keeps a hub's skill list for two minutes and does not refetch on window focus. The server reads the index fresh on every request (git hubs are re-cloned), so after someone pushes an updated skillshare-hub.json the only way to see it was to wait or reload the whole page. A refresh icon button next to the filter refetches the list on demand. It spins and is disabled while loading; the current list stays on screen, and a failed fetch shows the existing error note above it. Your own (draft) Hubs are local and do not get the button. |
||
|
|
e9dc4d0360 |
feat(server)!: answer only at localhost, IP addresses and trusted origins (#811)
DNS rebinding lets a page point its own domain at the user's machine, which makes its requests same-origin to the dashboard, so the CSRF guard cannot refuse them. Only the MCP, Hooks and Plugins routes required a localhost or IP Host, so such a page could still install, sync and push. That rule also blocked those three pages for people who run the dashboard behind their own reverse proxy (#809). The dashboard now answers every route only at localhost, an IP address, the --host name, and origins given with --trusted-origin or SKILLSHARE_UI_TRUSTED_ORIGINS. Configuration stays outside config.yaml so the dashboard cannot widen its own trust through its config API. A trusted origin must match the Host with its scheme, and an Origin header, when sent, must be that origin. A refused browser gets a page with the exact setting to copy, the API gets it in the error, and the server log names each refused Host once. BREAKING CHANGE: a dashboard opened by a domain name, such as a reverse proxy, a Tailscale or mDNS name, or a Docker service name, now returns 403 on every page until that address is trusted, for example with `skillshare ui start --trusted-origin https://skills.example.com`. Release-As: 0.30.0 |
||
|
|
ec9b3e688c |
fix(server): refuse dashboard changes sent from other sites (#810)
A web page can submit a form or a no-cors fetch to the local dashboard without a CORS preflight, and the handlers accept a text/plain or empty body. Only the MCP, Hooks and Plugins routes checked where a request came from, so any site the user visited could add targets, install, sync, commit, push or upgrade, whenever the browser let the request reach localhost. Every POST, PUT, PATCH and DELETE now needs Fetch Metadata, when sent, to say same-origin, and Origin, when sent, to match the Host. A client that sends neither, such as curl, is unchanged, because a page cannot make a browser omit both on a cross-origin request. The update stream runs updates over GET, as EventSource only opens GET, so it gets the same check. The nginx example now forwards $http_host, which keeps the port, since a proxy that drops it would now fail every change, not only MCP. |
||
|
|
ac49959f83 |
docs(hooks): note the dashboard Hooks page needs localhost or an IP
The Hooks page uses the same DNS rebinding guard as the MCP page (requireLocalHooks), so through a domain name or a reverse proxy its requests return 403. The reverse proxy note only mentioned MCP, so a user behind a proxy had no warning that Hooks would fail too. |
||
|
|
f3dec2fde9 |
docs(ui): describe the filter preview search
The dashboard reference walked through each Targets page control but not the search box #799 added above the include/exclude preview, which is also shared by project pages and the Extras Edit target dialog. Release-As: 0.29.2 |
||
|
|
51107fb1ac |
fix(projects): save new projects in config.yaml again (#793)
* fix(projects): save new projects in config.yaml again v0.29.0 wrote every project add, edit and remove to a machine-local registry, so a project added on one machine never reached config.yaml or the other machines that share it (#792). Most people share one config.yaml and expect a new project to follow it. config.yaml is the default again. Machine-local storage stays as an explicit choice: --machine-local on add, or projects_storage: machine-local for every new project, with --shared to override it. The new share command moves a local project into config.yaml, and localize still copies one to this machine. Edits and removals stay in the layer that owns the project; removing a local copy of a config.yaml project keeps config.yaml's version unless --shared asks to remove both, so one machine cannot silently drop a project for the others. Exclusions written by v0.29.0 are left as they are. The dashboard picks storage once, in the Add project dialog, and offers the two removal choices only where both copies exist. Moving a project between layers stays a CLI command, so the detail page keeps one job. Closes #792 * fix(projects): recheck both layers after a confirmation, sync the saved key remove and share ask before taking the config lock, then compared only the merged entry after locking. A share or localize from another terminal moves a project between layers without changing that entry, so a remove confirmed for this machine's copy could then delete config.yaml's declaration for every machine, and a confirmed share could overwrite config.yaml settings changed meanwhile. The recheck now compares the owning layer and config.yaml's declaration too (ProjectLayerState). Re-adding a project that v0.29.0 hid restores config.yaml's own key, which can be spelled differently from the folder given to add (~/app versus an absolute path). add --sync looked the project up by the given spelling and failed with "project not found" after saving it; it now syncs the key that was saved. * test(projects): make the layer tests hold on Windows The mutation-sequence test looked the shared project up by filepath.Join, but the fixture spells config.yaml's key $ROOT/app; on Windows the two spellings differ, so the lookup found nothing. It now asks the config for the key it uses. The remove save-failure test blocked the local registry, but removing a config.yaml project now writes config.yaml. On Linux the registry check still failed with ENOTDIR first, which hid the mismatch; on Windows that reads as a missing file and the save went through. The test now blocks config.yaml, as the edit save-failure test does, and its hook no longer shadows the config path with the target path. --------- Co-authored-by: sim <sim@example.invalid> |
||
|
|
2c41fa57cc |
fix(ui): let any git source switch branch on the skill detail page (#790)
A skill installed from a non-default branch of an SSH or other-host remote (git@host:o/r.git, Gitea, self-hosted HTTPS) could not switch back to main: the Branch picker was greyed out with "This source can only use its default branch" (#787). The picker reused /api/hub/refs, which only lists refs for GitHub, GitLab and Bitbucket web URLs because a hub entry pins its ref in the URL. Reinstalling from a branch does not need that; the update endpoint already accepts any git source. /api/hub/refs now takes anyGit, which lists a non-pinnable git source's refs while still reporting pinnable=false. The detail page asks for it under its own query key; the hub editors keep the old request, so they run no extra ls-remote for sources they cannot pin. Closes #787 Co-authored-by: sim <sim@example.invalid> |
||
|
|
3ab92f35b2 |
docs: fill gaps found in the 0.29.0 docs sweep
Checking every user-visible change since v0.28.4 against the docs found these gaps: - ui.md: GET /api/audit now returns warnings and incomplete; an incomplete scan warns instead of reporting all clear and appears under Needs attention; a project branch switch records the branch in .skillshare/config.yaml. Also fixes a lowercase sentence start. - audit-engine.md: Markdown and SARIF carry the per-resource coverage counts added in #756. - audit-rules.md: the files row pointed at a "File Scoping" section that does not exist; it now links to File Applicability. - log.md: project localize logs a localize action. - built-in skill: how an unreadable followed source link is reported. Translations are updated to match. |
||
|
|
ddc33fb8c7 |
feat(audit): keep an incomplete scan visible in Markdown, the TUI and the dashboard (#786)
* feat(audit): show unfollowed source links in Markdown and the TUI When a followed source link could not be read, only text output (and JSON's warnings/incomplete fields) said so. A Markdown report looked like a full scan, and the TUI covered the warnings printed before it opened, so a partial scan read as complete there. Item 25 of #746 asks for incomplete status to stay visible in human reports, including under --min-severity. Markdown now ends its summary with a "Source links not followed" section, led by an "Incomplete scan" line when a link could not be read. The TUI summary line starts with the count in the warning colour. JSON and SARIF are unchanged. * feat(ui): mark a partial audit scan on the dashboard The audit API dropped the source-link warnings the scan collected, so the dashboard showed a scan that skipped an unreadable followed link as complete. Item 25 of #746 asks for incomplete status to stay visible in every human report, the dashboard included. GET /api/audit and the stream's done event now carry warnings and incomplete with the same meaning as `audit --format json`, and the Audit page shows the count beside the Skills/Agents tabs. * feat(ui): stop calling an incomplete audit scan all clear After a scan that skipped an unreadable followed source link, the Audit page still toasted "no dangerous content" and the Dashboard's Quick Scan toasted "All clear", while the home page showed nothing, so a partial scan still read as a clean one there. Both toasts now warn that the scan is incomplete, and the home page's "Needs attention" list gets a row linking to the Audit page. One helper words the note for the Audit page label, both toasts and the row. --------- Co-authored-by: sim <sim@example.invalid> |
||
|
|
5e90cf4b71 |
feat(ui): show a skill's branch and switch it from the detail page (#784)
* feat(ui): show a skill's branch and switch it from the detail page A skill installed with --branch looked the same in the dashboard as one from the default branch, and moving it to another branch meant a manual reinstall from the CLI (#783). The list, tiles, tree pane and Updates tab now tag the branch a skill was installed from. The detail page lists the source's branches; picking one confirms, then reinstalls through POST /api/update with a new `branch` field, so the audit gate and the local-changes check still apply and a branch without the skill leaves the install in place. In project mode, reconciling config.yaml only added missing skills, so a reinstall from another branch (the switch, or install --branch --force) left config.yaml naming the old branch while the lock pinned the new commit. Reconcile now moves the declared branch with the record. Closes #783 * fix(update): make branch switches install the requested branch safely Codex review of #784 found four ways a switch could misreport or lose work: - A root skill installed as a full clone took the pull fast path on later switches, pulling its current branch instead of the requested one. The fast path now applies only when the checkout is already on that branch. - A branch whose skill folder lacks SKILL.md replaced the skill with a plain folder. A staged update now refuses a candidate without SKILL.md when the installed copy has one, and keeps the install. - Reconciling config.yaml from local metadata could rewrite a teammate's newer branch declaration back to a stale one on an unrelated install. The generic reconcile change is reverted; the switch updates only the switched skill's declaration. - The config editor cache kept the old branch after a switch, so a later save could undo it. A successful switch now invalidates the config query. --------- Co-authored-by: sim <sim@example.invalid> |
||
|
|
5dd9925c98 |
fix(projects): keep registrations in machine-local state (#769)
Keep machine-specific project changes out of shared configuration while preserving shared registrations and making their origin visible. Handle missing replicated roots and preserve startup maintenance for mutating commands. |
||
|
|
11add19544 |
feat(ui): note how Nix updates the CLI in the update dialog (#771)
* feat(ui): show the install's own upgrade command in the update dialog The update dialog always offered `skillshare upgrade` for the terminal. On Nix that command only prints advice, and Homebrew users are better served by `brew upgrade skillshare`, so the right command appeared only after a click on Update returned an error. /api/version now detects the install method, reports its command as upgradeCommand, and looks up the latest version the way the CLI update notice does for that method. The dialog shows that command, or the existing "update your Nix configuration and rebuild" text when a Nix configuration provides skillshare, so no new translations are needed. * fix(ui): keep `skillshare upgrade` in the update dialog, add only a Nix note Review of the previous commit found three regressions: - `skillshare upgrade` already runs `brew upgrade` on Homebrew and also updates the built-in skill. Showing `brew upgrade skillshare` (or the nix profile command) instead broke the case where only the skill is outdated: the shown command updates nothing. - /api/version looked up the latest version through `brew info` on Homebrew, inside the request with no timeout. Homebrew's auto-update could stall the dialog, and a server without brew on PATH never showed an update. - The rendered dialog tests only checked shown text, which wiki/frontend.md says to leave to screenshots. The dialog keeps `skillshare upgrade` and the GitHub lookup. /api/version reports nixUpgradeCommand only for Nix installs, and when a newer CLI is pending the dialog adds the existing Nix advice under the command. The decision lives in nixUpdateNote, unit-tested in upgradeError.test.ts. |
||
|
|
4fd4058be2 |
test(upgrade): cover the Nix branches of upgrade and doctor (#768)
#764 changed how upgrade and doctor treat Nix-store binaries but only tested the version and server layers. A later edit to upgradeCLIBinary could start replacing a store binary, or drop the note the dashboard matches for its 409, without any test failing. Two package variables let the tests fake the executable path and the latest release. The ui.md pages said /api/upgrade refuses Nix installs. It still updates the built-in skill and answers 409 only when a newer CLI is waiting, and the dialog shows `skillshare upgrade` until clicked. |
||
|
|
64c8a3f34e |
feat: add Nix flake and handle Nix-store installs in upgrade (#764)
* feat: add Nix flake and stop self-upgrade of Nix-store installs Add flake.nix with packages, overlays.default, checks and a formatter, building nix/package.nix with the unit tests in the Nix sandbox. The version comes from the Release Please manifest, so releases need no Nix edit. A Nix workflow runs `nix flake check` on non-docs changes. `skillshare upgrade` now detects binaries under /nix/store/ and prints `nix profile upgrade skillshare` instead of replacing a read-only store path; update notices and doctor suggest the same command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(upgrade): give Nix installs the right update path everywhere The first flake commit sent every /nix/store binary to `nix profile upgrade`, failed a plain `skillshare upgrade` with exit 1 even when the CLI was current, and left the dashboard with a generic 500. - Tell `nix profile` installs (the profile manifest lists the store path) from NixOS, Home Manager and overlay installs, which are told to update their configuration and rebuild. Detection lives in one helper shared by the update notice, doctor, upgrade and the dashboard. - `upgrade` on Nix reports "already up to date" or prints the hint and exits 0; the built-in skill still updates. - The dashboard runs the upgrade so the skill updates, then answers 409 `upgrade.nix` with the command when a newer CLI waits on Nix. The UI shows localized text for it in all 11 locales. - Installs skip the unit tests; the flake's checks enable them. postPatch lowers only the go directive's patch version and fails evaluation with a clear message when go.mod needs a newer Go minor. CI also builds the package on macOS. - Docs, translations, the built-in skill reference and the release topic describe the new behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5729eee088 |
feat(project): manage global registrations from the CLI (#603)
Add global project list, show, add, edit, sync and remove so setup scripts can register repositories without editing YAML or opening the dashboard. Keep dry runs read-only and report completed work when a target fails. Reuse the shared project service and sync runners. Include command docs, translations, completions and regression coverage. Quote overlap hints for their shell and log partial project syncs consistently with ordinary sync. |
||
|
|
f3d23ccb0c |
feat(ui): draw skill trees as curved branches and animate folding
Nested packages sat in a grey inset panel and the folder tree drew one straight line per level, so neither showed which row a child hangs from. Both now use one faint spine under the parent with a rounded elbow into each child that stops short of its checkbox or icon, in an opaque colour so overlapping strokes leave no darker seam. Opening and closing a package or folder now grows and shrinks instead of jumping; collapsed content is inert while it shrinks, and reduced motion turns the animation off. Nested row actions line up with top-level rows, and a selected folder's block keeps straight sides. |
||
|
|
a96c5e55f2 |
fix(ui): warn that uninstalling a package removes its nested skills (#636)
* fix(ui): warn that uninstalling a package removes its nested skills Uninstalling a skill moves its whole folder to the trash, so the skills nested inside it go too, but the confirmation listed only the one skill. It now counts them in the title, marks the package row and adds a note. Selecting a package together with its nested skills (select all does this) also sent every name to the server, which trashed the package first and then failed on each child whose folder was already gone. The dialog now sends only the outermost selected skills. The success toast uses the same count as the title; it reported the server's per-name count, which read as fewer removals than confirmed. * fix(ui): keep nested skills of a linked folder root in uninstall A linked folder whose root is itself a skill can only be unlinked, so the server refuses to trash it. Collapsing the selection to that root dropped its selected children from the request and none of them were removed. A linked root no longer counts as holding its children: they are sent on their own and the root row does not claim to remove them. |
||
|
|
1a79971df4 |
feat(ui): show skill descriptions in the list and redesign package rows (#635)
* feat(ui): show skill descriptions in the list and let expand all open packages Reviewing a large library meant opening each detail page just to read what a skill does (#627, proposal in #631). The resources list response now carries each skill's and agent's frontmatter description, read in the same pass as manual-only, and the list shows it truncated under the name with the full text on hover. The read now decodes the frontmatter once for both fields. An unquoted ": " in a description is invalid YAML, so a failed decode falls back to the line scanner instead of dropping the description and manual-only. Editing a skill refreshes the list too, so the new description shows right away. Expand all / Collapse all also opens and closes nested-skill packages from #624; before, it only touched source and folder groups. Closes #627 * feat(ui): redesign list packages as an inset panel with a description switch The chevron-in-a-column nesting read as a second, unrelated table and gave no room for the descriptions #627 asks for. A count pill after the package name now opens its skills in one quiet inset panel, with deeper packages indented under a faint guide, so the hierarchy stays readable at any depth. The rest closes the gaps left against #627: a Show > Descriptions switch keeps the compact list one click away, keyboard focus reveals the full description, a search opens only the packages holding a match without overwriting what the user left open, and the selection bar says how many selected items are out of view. Only the name opens the detail page, since whole-row clicks were easy to trigger by accident once rows held more text. * fix(ui): keep linked-folder matches when searching a folder group Searching while grouped by folder took package ancestors only from skills whose folderOf matched the group key, but groupByFolder keys a linked folder's skills by the link name. Every skill in a linked folder fell out of its own group, so the header counted a match and drew no row. The ancestor pool is now each folder group's unfiltered skills, keyed by groupByFolder itself, which always contains the group's matches. * fix(ui): keep the .ss-r .nm.m rule the design token export reads Merging it into :is(.ss-r, .ss-nr) .nm.m removed the exact selector that scripts/design/tokens.py looks up for the row name type scale, so the design token tests failed in CI. |
||
|
|
a65414fa2f |
feat(ui): nest skill packages under their parent in the list view
A package that ships its own SKILL.md plus nested skills used to list every child as a peer, so one large package could fill the page and hide which skills belong together (#624, proposal in #625). The list view now puts each skill under the nearest skill whose folder holds it, within its current group. Packages start collapsed with a nested count, a search opens them so matches stay visible, and paging counts top-level rows so a package is never split across pages. Selection, select-all and bulk actions still work per skill. Closes #624 |
||
|
|
a2112ff681 |
feat(ui): keep all local or all remote in the pull conflict dialog
A pull with dozens of conflicting files meant clicking "Keep this version" once per file. Two buttons now set every file to the same side; individual files can still be switched afterwards. |
||
|
|
fe92a50b1b |
fix(upgrade): preserve UI assets for the pre-upgrade version (#571)
An already-running UI server still reads lazy-loaded chunks from its versioned cache after the CLI binary is upgraded. Preserve the pre-upgrade version alongside the downloaded version so upgrade cleanup does not break page navigation. Add a multi-version cleanup regression test and document the retention policy and accepted consecutive-upgrade limitation across all website locales. |
||
|
|
925dd98312 |
fix(ui): show post-update sync only for pending changes (#533)
A successful source update does not always require a target sync: existing symlinks already expose the updated content. Recheck the per-kind diff before offering Sync Now, refresh it when resources change, and report check failures without claiming targets are current. Cover stale previews and post-sync dismissal with regression tests, and align the dashboard, workflow, source/target, and built-in skill documentation across locales. |
||
|
|
1f1bbd1846 |
docs(ui): describe the dashboard actions added since 0.25.2
The dashboard page reference did not mention Install all, Prune, Discard all, the unmatched filter notice, Edit target/Edit extra, or that New skill and Link folder moved into the Install menu, so readers had no way to find them from the docs. |
||
|
|
d882f05848 |
docs: cover forced tracked-repo uninstall and project MCP source boundary
The dashboard now asks again and force-uninstalls a tracked repo with uncommitted changes or an unreadable git status, and a project's sources.mcp file is refused when it resolves outside the project. The ui and mcp command pages did not say either. |
||
|
|
d62fa4fd3d |
docs: sync docs with the 0.25.0 changes
Bring the pages, the built-in skill and the translations up to date with the pending release before the Release PR is reviewed: the README Latest callouts for v0.25.0; mcp serve, Oh My Pi, DeepSeek Harness and GitLab Duo in the ja, ko, zh-Hans and zh-Hant pages; the `--` option and the --enable rollback of link and unlink; the missing serve skip reasons and its cross-origin refusal; standard naming rules; junctions kept across volumes; OMP accounts receiving native code hooks; and the 79-target count. |
||
|
|
9db36b472a |
Merge remote-tracking branch 'origin/main' into runkids/419-link-unlink
# Conflicts: # internal/server/handler_skills.go # skills/skillshare/references/TROUBLESHOOTING.md # website/docs/reference/commands/ui.md # website/docs/reference/targets/configuration.md # website/i18n/ja/docusaurus-plugin-content-docs/current/reference/commands/ui.md # website/i18n/ja/docusaurus-plugin-content-docs/current/reference/targets/configuration.md # website/i18n/ko/docusaurus-plugin-content-docs/current/reference/commands/ui.md # website/i18n/ko/docusaurus-plugin-content-docs/current/reference/targets/configuration.md # website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/commands/ui.md # website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/targets/configuration.md # website/i18n/zh-Hant/docusaurus-plugin-content-docs/current/reference/commands/ui.md # website/i18n/zh-Hant/docusaurus-plugin-content-docs/current/reference/targets/configuration.md # website/src/data/featureMap.ts |
||
|
|
064048da89 |
fix(server): list files from followed skill roots
A symlink passed as a filepath.Walk root is listed as a single file, so root-of-link skills returned files containing only a dot. Reuse the discovery follow policy to resolve the walk root and compute relative file names from it while retaining logical resource paths. Cover global/project responses and disabled following, update the existing traversal inventory, and document root-of-link file browsing in all website locales and troubleshooting guidance. |
||
|
|
93708478a6 |
docs(source-links): describe the dashboard unlink action
The dashboard section of the ui reference only covered Link folder. Add the final unlink design so the docs match the shipped UI: the linked group row, the hover icon button with confirmation, trash restore, single-skill uninstall inside a link, and the absence of repo actions. |
||
|
|
86cb2d51d9 |
docs(source-links): document link, unlink and the dashboard Link folder action
follow_source_links only follows a link that already exists, and the docs told users to create it with ln -s or mklink /J. The guards then surfaced only in doctor, after the link existed. Now that skillshare link checks the target first and picks a junction on Windows, the docs point at the command and keep the manual way as a note. Adds command pages for link and unlink, quick-reference and index rows, the dashboard Link folder sentence, all four translations, and the built-in skill guidance. Refs #419 |
||
|
|
aafb7e7e96 |
fix(ui): keep followed checkouts out of dashboard updates
Separate user-owned followed Git checkouts into linked_repos in check and resources responses so the Updates tab renders information instead of tracked errors or retry actions. Refuse dashboard updates before Git runs, including force retries and descendant skills, while leaving managed repositories unchanged. |
||
|
|
64b9255075 |
feat(ui): link each part of a target from the Targets list
The Syncing column described what a target gets as one line of text, and the whole row led to the Skills tab, so reaching a target's MCP, Hooks or instruction file took an extra click and a search for the tab. Each part is now its own link into that tab, and the connected shared AGENTS.md shows up by its file name, so the list says at a glance which targets are not connected yet. |
||
|
|
d4c2f6e9a0 |
fix(server): report toggles that .local ignore rules override
Disabling a skill only checked that its path was written to .skillignore. A "!" rule in .skillignore.local is applied after that file, and an unanchored one such as "!feature-radar" re-includes every path segment with that name, so the skill stayed enabled while the dashboard reported success. The dashboard also never showed the .local file, so nothing explained why. Single and batch toggles now re-discover after writing and report an item that did not reach the requested state as failed, naming the overriding file; the batch toast shows the first failure's reason. GET /api/skillignore and /api/agentignore return the .local file, and Settings > Files shows its rules above the editor. |
||
|
|
887461b36a |
perf(upgrade): download release assets over parallel ranges (#381)
* perf(upgrade): download release assets over parallel ranges release-assets.githubusercontent.com throttles each connection on some networks. The 9.6 MB darwin_arm64 archive took 122-171 s over one connection but 25 s as 8 ranges, each on its own connection, with an identical checksum. `skillshare upgrade` and the first `skillshare ui` of a new version both waited minutes on that download. DownloadToFile probes with `Range: bytes=0-0`; a 206 answer splits the file into ranges fetched in parallel from the redirected URL, and a 200 answer streams the single response as before, so servers without range support cost no extra request. Size limits and checksum verification are unchanged. The UI asset download is about 2 MB now, so the docs no longer say 1 MB. * fix(upgrade): keep the caller's transport for parallel ranges Each range built its client from http.DefaultTransport, so a caller's custom transport (private CA, authenticated proxy, custom dialer) only applied to the probe. The ranges then failed or bypassed the caller's network setup even though the probe succeeded. Each range now copies the caller's client with a clone of its *http.Transport, which keeps those settings and still gives the range its own connection. A transport that cannot be cloned is shared as is. |
||
|
|
8c1818612e |
docs(ui): list hooks among the dashboard counts
|
||
|
|
355b42ee57 |
feat(cli): one frame and keymap for every TUI, inline prompts, file viewer (#370)
* chore(devcontainer): add a TUI screenshot kit Recreating the devcontainer wipes vhs and the browser it drives, so every TUI review started with a manual reinstall. The start script now installs the recording tools when they are missing and skips straight through when they are present. record-tui.sh screenshots each full-screen TUI in its own fresh ssenv, filled by tui-fixture.sh through real commands, so the TUI redesign can compare before and after on the same data. Refs #200 * feat(cli): ask small choices inline instead of full screen The restore source, new-skill wizard, install skill picker and the other checklist prompts each took over the whole screen for a handful of options, and the answer vanished once chosen. They now use the same inline prompt as init: the question appears in place, collapses into a "✓ label value" line, and stays in the scrollback. Lists longer than the visible rows can be narrowed with /, and esc inside the filter only leaves the filter. Every inline prompt shows one key line in the wording the full-screen TUIs will share. The new wizard drops its esc-goes-back steps: esc cancels, as in init. Refs #200 * feat(cli): give the list TUI the shared frame and keymap The full-screen TUIs each had their own header, footer and key letters, so the same action used different keys per screen and the help line listed everything at once. list is the first screen on a shared frame: one title line with scope, counts and tabs, the list and details side by side without dividers, and one key line with the common keys and the position. Everything else moves under ?, and confirmations ask on the key line so the list stays visible. Keys follow one lowercase letter per action (u update, d uninstall, t enable/disable, m manual only, ! audit). The All tab and the s status cycle are gone: tab switches skills and agents, and status: in the filter or --status covers enabled/disabled. Rows drop the group prefix that the heading above them already shows. Refs #200 * docs: drop key-by-key TUI instructions from command pages The command pages carried key tables, screen mock-ups and one bullet per key for every full-screen TUI, in five languages. The TUIs now show their keys on screen, so these pages repeated what the screen says and went stale with every key change (several already listed keys that no longer exist). Each TUI section is now one paragraph on what the screen shows and what it can do. What the screen does not explain stays: the filter tag syntax, what manual only does to SKILL.md, the analyze color thresholds, when audit opens its TUI, and that target changes are saved to config immediately. Refs #200 * feat(cli): move the trash TUI onto the shared frame The trash TUI replaced the whole screen with a confirmation and a spinner, so you lost sight of what you had selected, and r/d did nothing until something was ticked. It now uses the shared frame: checkbox rows with size and age, details beside them, and the confirmation, the names it covers, the running operation and its result on the bottom lines. With nothing selected, r and d act on the row under the cursor. Refs #200 * feat(cli): move the log TUI onto the shared frame Log rows were two-line "[date] COMMAND — status" blocks, stats lived behind s as a separate screen, and delete swapped the help bar for a prompt you could miss. Rows are now one line with time, command and a status mark; Entries and Stats are tabs on the title line next to the count and success rate; and the delete confirmation takes over the key line. With nothing selected, d deletes the entry under the cursor. Row delegates no longer force a 40-column minimum, which wrapped every row in lists narrower than that. Refs #200 * feat(cli): move the audit TUI onto the shared frame The audit TUI had its own tab bar, a divider column and a two-line summary footer, and esc quit even with a filter typed. It now uses the shared frame: scan counts and the Skills / Agents tabs on the title line, the worst severity at the right of each row, the scan-wide severity, threat and policy summary on the note line, and esc clears the filter before quitting. Rows under a group no longer repeat the group's name. Colored title facts keep their color instead of being dimmed. Refs #200 * feat(cli): move the audit rules TUI onto the shared frame The rules browser used keys no other screen shared: s for severity, space to toggle and R pressed twice to reset. It now follows the shared keymap: t turns a rule or pattern on or off, e asks for the new severity on the key line, and R asks yes/no before deleting audit-rules.yaml. The severity tabs sit on the title line, rows show the rule count or "off" at the right, and rule rows drop the pattern prefix the group row already shows. Space still toggles. When the title line is too narrow for every tab, it shows only the active one instead of clipping them. Refs #200 * feat(cli): move the analyze TUI onto the shared frame Analyze put the target switcher, a stats line and the help text in a three-line footer and sorted with s, which means sync everywhere else. It now uses the shared frame: skill count and always-loaded and on-demand tokens on the title line, one tab per target group, o to sort with the current order on the key line, and esc clears the filter before quitting. The details follow the list layout, and lint warnings use the ! mark the CLI uses. renderDetailSection and renderFactRow had no other callers and are removed. Refs #200 * feat(cli): move the diff TUI onto the shared frame The diff browser drew ruled separators, "── Next Steps ──" banners and an arrow before every suggested command, and esc quit with a filter typed. It now uses the shared frame: target, extra and difference counts on the title line, what differs at the right of each row, group rows like the list's, plain headings in the details, and esc clears the filter before quitting. Refs #200 * feat(cli): move the restore TUI onto the shared frame Restore replaced the whole screen for the confirmation, the running operation and the result, rendered two-line rows, and esc quit even with a filter typed. It now uses the shared frame: the target or the chosen target and its backup count on the title line, one-line rows with backup count and age or skill count and size at the right, and the confirmation, what it covers, the spinner and the result on the bottom lines. Esc clears the filter, then goes back, then quits. Refs #200 * feat(cli): move the MCP manager onto the shared frame and keymap The MCP manager used its own letters (a add, x remove, b backups, r refresh), hid the details behind Enter, and printed two help bars. It now uses the shared frame and the keys every other TUI uses: n add, i import, e edit, d remove, s sync, r restore, with the details of the selected server beside the list and ? for all keys. Refresh is gone because the manager reloads after every action. Command docs drop the key table, and the how-to page and built-in skill name the new keys. Refs #200 * feat(cli): move the search selector onto the shared frame The search selector rendered two-line checkbox rows, put the details under the list, used s for "search again" although s means sync everywhere else, and Enter with nothing selected silently cancelled. It now uses the shared frame with the keyword and counts on the title line, one-line rows with stars or risk at the right, and the details beside the list. Esc clears the filter, then goes back to the keyword prompt; Enter with nothing selected installs the row under the cursor, as r and d do in other TUIs. The command page drops its screen mock-up and key list, and no longer claims the search restarts after an install. Refs #200 * feat(cli): move the target TUI onto the shared frame and keymap The target TUI had five uppercase keys (M, N, I, E, R), a separate skills-or-agents picker before three of them, and full-screen pickers and remove confirmation. e now opens one menu of every setting the target has (skills mode, naming, include, exclude; agents mode, include, exclude, with agent filters marked as ignored in symlink mode), and the pickers and pattern editor open beside the list. d asks on the key line with the command it will run and what removal does. Patterns are added with n, as everywhere else. Also drops the filter style helper the MCP change left unused. Refs #200 * feat(cli): move the extras TUI onto the shared frame and keymap The extras TUI used six uppercase keys (N, X, S, C, M, F), each with its own full-screen menu, and a full-screen confirmation. It now uses the shared frame and keys: n new, d remove, s sync, c collect, and e for one menu with the mode and flatten setting of every target. The target menu and mode picker open beside the list, and confirmations ask on the key line with what the action does. The picker row helper moves to the shared frame, and the split and scroll-hint helpers no TUI uses any more are removed. Refs #200 * feat(cli): share one framed file viewer between list and extras The list and extras file viewers were two copies of the same layout with the old look: an indented title, a │ column between the tree and the file, and a hard-coded yellow cursor. Both now draw through one renderer in the shared frame: the skill or extra and the open file on the title line, the tree beside the file without a divider, and the scroll position at the end of the key line. Refs #200 * feat(cli): ask for a large repo's folder inline Installing from a repo with 50+ skills opened a full-screen folder browser with its own filter bar and key line, then dropped back to an inline skill checklist. The folder question is now an inline select like every other install prompt: the first choice installs everything below the current folder, esc goes up one level, and the chosen folder collapses into a "✓ folder" line before the skill list appears. The screenshot fixture gains a 60-skill repo so the picker can be recorded, and the filter-bar and page-info helpers that only the old picker used are removed. Refs #200 * feat(cli): ask for MCP and plugin values inline MCP and plugin values were typed into a separate textarea program that submitted on ctrl+d, a key no other prompt uses. They now go through a new ui.Text prompt drawn like the other inline questions: enter submits, alt+enter starts a new line, and the box grows with the value. The MCP name is a single line, so it uses ui.Input. Answers are not echoed afterwards because a value can hold a secret. Refs #200 * feat(cli): drop the full-screen MCP change preview Every MCP add, edit, remove, restore and sync already prints its plan inline and then asks whether to apply it. The full-screen preview in between showed the same changes again and needed one more enter, so it is removed along with the review step of the prompts interface. The confirm question loses its "Review complete" prefix, and a blank line now separates it from the plan. Refs #200 * feat(cli): ask extras init questions inline `extras init` without arguments ran its own full-screen wizard with a hand-drawn cursor and a different key line on every step. It now asks the same questions inline, like `init`: each answer collapses into a "✓" line, the target line shows where the file lands, and esc cancels with "Nothing was created". A new ui.InputValid keeps a question open and shows the error under it until the answer passes, which the name, file name and per-target file name questions need. Refs #200 * fix(cli): drop stale key hints from MCP prompts and help `mcp --help` still listed the manager keys from before its redesign (a add, x remove, b backups, r refresh), and several MCP and plugin questions repeated "Esc cancels" or claimed `a` selects all, while the key line under every prompt already shows the real keys (ctrl+a for all). The help now just says where the keys are, and the questions keep only what the key line cannot say. The MCP command page drops the same key list in all five locales. Refs #200 * feat(cli): open a skill's files at its audit findings The audit TUI listed each finding's file, line and one-line snippet, but judging whether a finding is real needs the lines around it, and that meant leaving the TUI to open the file by hand. Enter now opens the selected skill's files at its most severe finding, with the raw text numbered and the flagged line marked; n/N steps through the findings in the order the details number them, and the line above the keys says which finding is shown. The viewer state lives in a new fileBrowser so analyze and trash can open skills the same way. Long lines wrap under their text instead of being cut, since the evidence is often at the end of a line. Refs #200 * feat(cli): open a skill's files from analyze Analyze flags lint issues such as a description that is too short, but the screen only showed the description text, so fixing a skill meant finding its folder first. Enter now opens the selected skill's files, including local ones that live only in a target, as raw numbered text with the front matter, and the line above the keys repeats the first lint issue so it can be checked against what is written. Refs #200 * feat(cli): open a trashed item's files before restoring The trash TUI showed only the first fifteen lines of SKILL.md, which is not enough to tell two trashed versions apart or to see a skill's other files. Enter now opens the item's files in the same viewer as list and analyze, rendered as Markdown, and esc returns to the trash. Refs #200 * fix(cli): leave front matter out of the agent viewer in list Opening an agent in the list TUI rendered its whole file as Markdown, so the front matter came out as a horizontal rule and a "## name: ..." heading. Skills already drop it because the details panel shows the name and description; agents now read their body the same way. Refs #200 * test(cli): compare trash restore destinations home-relative The trash TUI shows restore destinations through shortenPath, so with HOME=/tmp, as in the offline Docker sandbox job, /tmp/skills prints as ~/skills and the tests that expected the absolute path failed. They now expect whatever shortenPath gives for the same path. Refs #200 * fix(cli): show control characters in viewed files as symbols The file viewers in list, extras, audit, analyze and trash wrote a file's bytes to the terminal as they were. Audit and analyze exist to inspect skills that may not be trusted, and a SKILL.md with an ESC or OSC sequence could rewrite the screen or the window title instead of being shown. Control characters are now replaced with same-width symbols such as ␛ before rendering, which keeps line numbers and the marked finding line in place; newlines and tabs are kept and CRLF is read as LF. Refs #200 * fix(cli): open audit findings in files the tree leaves out The file tree skips dotfiles and stops at three levels and 200 entries, but the audit scan reads root dotfiles and goes deeper. A finding in such a file, like a root .env, left the viewer on the previous file with the new finding's note above unrelated text. Opening a finding now adds its file to the top of the tree under its full relative path when it is missing, so the marked line is always the one reported. Refs #200 * fix(devcontainer): exit nonzero when a TUI screenshot fails to record record-tui.sh printed FAIL for a screen whose vhs run failed but still exited 0, so an unattended run looked like every screenshot was taken. It now remembers a failure, keeps cleaning up and recording the other screens, and exits 1 at the end. Refs #200 * fix(cli): keep other files' front matter and fit text to the pane Two problems in the shared file viewer: - It dropped YAML front matter from every Markdown file, so a trashed skill's README or template lost its metadata, which nothing else in the trash view shows. Only SKILL.md and a single-file agent drop it now, since their name and description appear in the details. - The open file was wrapped to at least 40 columns. In a narrow terminal that is wider than the right pane, so the layout wrapped each row a second time, breaking lines apart and moving the marked finding line. Text now wraps to the pane's real width. Refs #200 * fix(cli): keep frame lines within the terminal width joinEnds padded the title, confirm and filter lines but never cut them, so a long search query, path or command made the line wrap. Every TUI sizes its body for a fixed four lines of frame, so the wrap pushed the bottom of the body off the screen. Long text is now cut from the left side, keeping the status or tabs on the right. Lines are left alone until the terminal has reported its width. Refs #200 * fix(cli): show a nested skill's folder when no group heading names it List rows dropped the first path segment for every skill on the grounds that the group heading above shows it. With a single group, or a filter that leaves one, there is no heading, so frontend/react showed as just react and same-named skills from two folders looked alike. Rows now drop it only under a heading; a tracked skill's repo dir is still dropped as before. Refs #200 * fix(ui): let esc leave a prompt's filter after enter found nothing The inline prompt guessed the filter state from key presses and treated enter as leaving the filter. huh's Select stays in the filter when enter has no match, so the next esc, meant to leave the filter, cancelled the question instead: one folder level back in the large-repo picker, or the whole install at the top. The prompt now asks the field whether it is filtering. Refs #200 * fix(cli): show control characters in the trash preview as symbols The trash details panel prints the first lines of a trashed SKILL.md, and it wrote them to the terminal as they were. The file viewers already pass text through printableText so an ESC or OSC sequence in a skill is shown instead of acted on; the preview now does the same. Refs #200 * fix(cli): scroll an agent's text with the wheel anywhere in list An open agent has no file tree, but the wheel still treated the left quarter of the screen as the tree, so scrolling there did nothing. The whole screen now scrolls the agent's text. Refs #200 * fix(ui): read prompt answers after the prompt has run The prompt helpers returned "value, runPrompt(..., &value)". The Go spec leaves the order between reading value and the call unspecified, so a compiler may return the value from before the user answered. gc 1.25 runs the call first, so answers arrive today, but nothing guarantees it. Each helper now runs the prompt into err and then returns the value. Refs #200 * fix(cli): name hidden Unicode and skip oversized files in the viewer Two gaps in the file viewer used to inspect untrusted skills: - Zero-width and bidirectional characters passed through unchanged, although the audit reports them as HIGH (Trojan Source). Opening such a finding reordered or hid the text instead of showing the cause. They now appear as <U+202E> and the like. - Moving onto a file read all of it, then copied it again while numbering and wrapping, with no size limit. The audit skips files over 1 MB; the viewer now does too and says the file is too large. Refs #200 * fix(cli): show control characters in viewed file names as symbols File contents in the viewer already pass through printableText, but the tree and the title printed file and skill names as they were. A file named with an ESC sequence, a newline or a bidirectional character in a skill under review could still reach the terminal, or break the frame across lines. Names now go through printableName, which also shows a newline or tab as a symbol so the name stays on one line. Refs #200 |
||
|
|
5d269e8e4c |
feat(push): add --pull for two-way sync in one command (#354)
* feat(push): add --pull for two-way sync in one command Users editing skills on several machines have to remember push on one and pull on the other, and a push from a machine that is behind fails until they pull first. push --pull commits local changes, merges the remote with the same merge semantics pull uses, pushes, and syncs the git root scope. A conflict stops before anything is pushed and keeps the local commit; a target sync failure after a successful push is reported separately so the user knows the remote is already updated. It never rebases or force-pushes. commit rejects --pull instead of silently ignoring it, since both commands share the argument parser. * docs(push): document push --pull across guides and translations Cover the new flag on the push reference, the cross-machine sync guide, the quick reference, the daily workflow and the cross-machine recipe, in English and the ja, ko, zh-Hans and zh-Hant translations, plus the built-in skill's sync reference. * fix(push): print the scope's sync command when --pull sync fails A bare 'skillshare sync' retry hint defaults to skills and may pick project mode, so it does not redo an agents, extras, or root sync. Derive both the sync and the hint from one per-scope list. * fix(pull): sync extras for the root git scope The root scope versions skills, agents and extras, but pull and push --pull only synced skills and agents, so merged extras changes never reached their targets. * fix(server): sync extras after a root-scope pull The root scope versions extras too, but the dashboard pull only synced skills and agents, so merged extras never reached their targets. Matches the CLI fix. * feat(ui): add a Sync both ways action to Git Sync Mirrors skillshare push --pull: commit local changes, merge the remote and sync targets, then push, in one click. A pull conflict stops at the existing review before anything is pushed. * feat(ui): confirm Sync both ways and list what it will do Sync both ways commits, merges and pushes in one click, so ask first and show the concrete outcome (files to commit, remote commits to merge, scope, push target, conflict behavior) before changing anything. * fix(ui): make Sync both ways match push --pull It skipped target sync when the pull was already up to date, stopped on an empty remote instead of pushing, and the pull dropped extras warnings. Add alwaysSync and a remote_empty code to /api/pull and surface all extras warnings. |
||
|
|
6e176ddb0c |
feat(extras): share Markdown memory across agents (#349)
* feat(extras): add shared Markdown memory management Store user-managed notes in extras/memory for global and project scopes. Add CLI operations, a nested dashboard browser, versioned edits, and backup-backed deletion and recovery. Connect selected agents with reviewed, marked reading guidance while preserving existing instruction files and routes. Add explicit INDEX linking, conflict draft comparison, and copy-content previews. Document the workflow in five website locales with English screenshots and translate dashboard copy across all eleven locales. Native automatic memory remains separate from this shared file overlay. Validation: make check; 22 UI tests; TypeScript and ESLint; production UI build; six isolated CLI E2E steps; five-locale website build; explicit Claude-write/fresh-Codex-read smoke test. * feat(memory): support dashboard note moves and redesign browser Add version-checked rename and folder moves without replacing existing notes. Back up the old path and preserve content and permissions while refreshing selection, search, index warnings, and backup links. Integrate the two-pane Memory browser and compact agent controls. Refresh all English screenshots and document move/link/history behavior in five locales. Validation: make check, scoped UI tests, TypeScript, ESLint, UI production build, five-locale website build, locale parity, and visible Chrome workflow checks. * fix(memory): recheck reviewed files before committing changes Preserve external edits detected after note backup or draft preparation, and create new notes exclusively. Revalidate each guidance file before writing, report stale partial failures, and correct the built-in move/rename documentation. * fix(memory): repair initialization and preserve note recovery scope Detect missing starter files before dashboard note creation and refresh the index after initialization. Honor requested backup paths, include external project memory sources in recovery scope, and log initialization failures after partial mutations. * fix(memory): protect guidance creates and match Windows history paths Create new reviewed instruction files exclusively to preserve competing writes. Match Windows history links with native backup paths while keeping POSIX names and backup API paths intact. * fix(memory): require configured extra for external backup access Keep project backup scope inside the repository unless a valid memory folder extra enables its external source. Cover listing, version preview and restore denial without changing configured-source recovery. * fix(memory): lock backup scope validation through restore Validate project memory backup access under the restore write lock so concurrent extra deletion cannot revoke access between validation and writing. Hold read locks across scoped backup reads as well. |
||
|
|
b86b52a491 |
feat(ui): share several plugins as one install command
Passing plugins to a teammate meant looking up each source, plugin name and ref and typing a `skillshare plugin add` per plugin. The Plugins page now has Share, in the header and in each row's menu. It lists the plugins added from an HTTPS source, and copies one line that adds the ticked ones in order. Each add passes --no-tui by default, so the whole list lands in Skillshare without a picker per plugin; the recipient ticks Agents on the Plugins page afterwards. An option keeps the per-plugin Agent picker instead. The adds are joined with && on one line because, pasted on separate lines, the first picker would read the rest as keystrokes. Plugins from a local directory are left out, since the path only exists on the sharer's machine. Validation: vitest for plugins API, PluginsPage and i18n (29 tests), tsc --noEmit, eslint, and ai-context check. |
||
|
|
73c4a8d27e |
feat(ui): resolve Git pull conflicts across computers
Guide diverged repositories through pull-and-merge or commit-and-pull before pushing. Compare conflicting file versions in the dashboard and require explicit choices tied to the reviewed revisions, while preserving both histories and automatic metadata merging. Cover previews, modify/delete conflicts, stale and invalid choices, binary and large files, and dry-run behavior. Add an isolated preview fixture, verification runbook, translations, and documentation. Validated with devcontainer make check, targeted Git API and UI tests, UI lint/build, website build, React Doctor, and a real isolated UI pull-resolution-push flow across all four themes. |
||
|
|
6fbb5e109b |
feat(ui): add Git Sync discard changes
Let users discard uncommitted source changes after confirmation, with dry-run support. Restore tracked files to HEAD and remove untracked files while preserving ignored files, nested repositories, and root-scope config.yaml. Guard against ancestor repositories and repositories without a first commit. Cover the API and confirmation flow with regression tests and sync all UI locales and Git Sync documentation. |
||
|
|
c327a26e30 |
feat: native hooks, MCP tool policy and Pi built-in MCP (v0.23.0) (#304)
* feat(hooks): manage native hooks across agents
Add global and project hook management for ten coding agents with native
format adapters, explicit ownership, revision-guarded synchronization and
selective backup/restore. Preserve unrelated native configuration and leave
hook execution and trust decisions with each agent.
Expose CLI commands and completions alongside dashboard import, editing,
native preview, target/project views, synchronization and backups. Localize
messages and document the workflows across supported locales.
Validation: devcontainer make check, full dashboard Vitest suite,
TypeScript/Vite build, scoped ESLint, isolated CLI lifecycle and real UI
acceptance. Native agent hook execution was not tested.
* feat(mcp)!: sync Pi only through its built-in MCP
Pi could be synced through three different mechanisms (built-in MCP,
pi-mcp-adapter, or the extension file), chosen per server. Mixing them
inside one scope was an error users hit easily, and the adapter and
extension files drifted from what Pi itself reads. Pi's built-in MCP
now covers what the other modes offered, so every Pi server is written
to ~/.pi/agent/mcp.json or <project>/.pi/mcp.json.
Existing setups migrate on the next sync: entries Skillshare wrote to
mcp-adapter.json are removed through the ownership ledger, extension
entries are rewritten in place, and hand-written entries stay put.
piExtension and piOptionsPrune still load (with a notice) so old
configs keep working, and are dropped on the next save. directTools is
kept but no longer rendered, since only the adapter reads it.
Pruning unchanged fields Skillshare wrote earlier is now always on,
the per-project off switch no longer applies to Pi, and the removed
--pi-extension and --pi-options-prune flags explain the change instead
of failing as unknown. Import still reads mcp-adapter.json read-only so
servers kept only there can be brought over.
BREAKING CHANGE: --pi-extension and --pi-options-prune were removed;
Pi servers are always synced to Pi's built-in MCP file.
* fix(mcp): load Pi switches and adapter options left from before 0.23.0
Phase 1 made Pi sync only through its built-in MCP, which left two
upgrade paths broken or misleading:
- A project entry with disabled: true that selected Pi used to work in
adapter mode, but now fails every sync with "pi cannot turn off".
Loading now takes pi (and Pi accounts) out of such an entry with a
notice; an entry left with no targets stays and turns nothing off, so
an explicit empty list is now valid for a switch. Saving a new switch
for pi still fails.
- piOptions keys that only pi-mcp-adapter reads (lifecycle, idleTimeout,
approveTools, ...) were copied into Pi's built-in mcp.json, where
nothing reads them. Loading drops them with a notice naming each key,
and saving new ones is refused. Keys neither Pi nor the adapter
documents still pass through. includeTools/excludeTools are left for
the tool policy change, which converts them.
Both changes rewrite the YAML node on load, like the phase 1 legacy
fields, so the next save persists them.
* feat(mcp): portable tool policy per server
Users need one place to say which of a server's tools the model sees,
instead of Pi-only adapter options that Pi's built-in MCP no longer
reads. A server's tools{expose, allow, deny} is rendered per Agent:
Pi gets exposure and an ordered toolExposure, Codex gets
enabled_tools/disabled_tools, Copilot gets its tools list. Parts an
Agent cannot hold (OpenCode and Kilo have no per-server field) are
named in the plan and by mcp check rather than dropped silently.
directTools and the adapter's includeTools/excludeTools are converted
on load and on import, so existing configs keep their behavior; the
--direct-tools flag is removed with a pointer to the new flags.
check --live now reports tool names so the dashboard can suggest them.
Refs #140
* feat(ui): drop the Pi mode, prune switch and Direct tools from MCP
Since 0.23.0 Pi syncs only through its built-in MCP and the API no longer
returns piExtension, so the server dialog showed an empty "Pi MCP mode"
select, links to pi-mcp-adapter and pi-mcp-extension, a prune switch the
backend ignores and adapter-only Direct tools. Toggling Pi also opened a
mode setup that no longer exists, and Pi was still offered as an Agent
that can turn a global server off per project, which the backend refuses.
Pi now shows only tool exposure, its other settings and one link to
Pi's MCP docs. The import dialog still sends piExtension, but only to
pick between Pi's mcp.json and the legacy mcp-adapter.json, which the
listed path already tells apart. Settings the config still carries from
before 0.23.0 are explained once on the MCP page from the source's
notices, worded in the dashboard's language.
* fix(ui): clarify hook takeover and localize MCP actions
Identify global and project hooks in sync previews, show full takeover guidance, and link project conflicts to their Hooks tab. Translate MCP pending actions using the existing locale keys.
* feat(mcp): name unapplied tool policy parts in the render preview
The dashboard's server editor needs to say which Agents cannot follow
part of a tool policy before the server is saved. The plan's notices
only cover saved servers, so each rendered target now carries the gaps
from toolPolicyGaps instead of the UI re-implementing the per-Agent rules.
Refs #140
* feat(ui): edit the portable MCP tool policy in the dashboard
Saving a server from the edit dialog rebuilt it from the form and
dropped its tools policy. The draft now carries tools, and a Tools
section edits exposure, allow and deny for every Agent at once. Tool
names can be loaded on demand from the saved server through the live
check, and each selected Agent that does not apply a part is named from
the backend's render preview.
Pi's other settings flag the adapter-only keys and the exposure fields
that Tools now owns, so the form refuses what the backend refuses with
a message that points to Tools. Rows show a short policy marker, and the
plan's tool policy notices are localized on the MCP page.
Refs #140
* feat(mcp): save the config without retired settings on sync
Notices about settings 0.23.0 retired (piExtension, piOptionsPrune,
adapter-only piOptions, Pi switch entries, directTools/includeTools/
excludeTools) only went away when the user happened to save MCP settings.
Sync never rewrote the source, so most users kept seeing them.
Loading already converts those settings in memory, so a sync now writes
the converted config back (global, per project, external source, CLI and
dashboard), after keeping the previous content in the file history.
Dry runs write nothing, and a failed save is reported after the Agent
files are applied. The plan carries `migrates`, so the dashboard's sync
runs MCP even when no Agent file changes.
The CLI notices are one short line per kind with each server named
once, and a sync prints the file it updated with its backup. The
dashboard no longer shows these notices: sync handles them with nothing
for the user to do, and tool policy gaps stay in the server dialog.
* fix(ui): catch MCP tool policy mistakes before saving
The empty "Other Pi settings" box showed a toolExposure example even
while Tools had a setting. That example is exactly what the dialog
refuses in that state, so it read as a saved value that went unflagged.
The example now leaves toolExposure out while Tools is set.
A Deny list that removes every tool Allow keeps was only refused by the
server, in English with raw field names. The Tools section now says so
in the user's language and disables Save; the server check stays.
* fix(ui): move Pi settings help into info tooltips
The Pi block stacked four lines of help under the exposure select, one
of them in raw config words (entry, toolExposure), which pushed the
fields apart. The help now sits behind keyboard-focusable info icons:
one on a new "Pi settings" heading, which keeps the official docs link
beside it since a tooltip cannot hold a link, and one on the exposure
label with a shorter, plain explanation. The line saying Tools sets the
exposure stays, because it explains why the select is locked.
* docs(mcp): describe Pi built-in only and the tool policy
0.23.0 dropped the Pi modes, the prune switch and directTools, and added a
portable tools policy (#140, #143). The MCP reference still told users to
pick pi-mcp-adapter and pass flags that now fail, and said nothing about
what the first sync does to an old config or which Agents apply which part
of a tool policy.
The reference now covers the tools field and flags with a per-Agent table
linked to each Agent's docs, the dashboard Tools section, Pi's built-in
files and options, and an upgrade section: what the first sync converts,
which adapter entries it removes, the config save with its migrate backup,
and what replaces each removed flag. The how-to, dashboard and backup pages
follow.
* docs(skill): teach the built-in skill the Pi and tool policy changes
Agents using the skill would still pass --pi-extension and --direct-tools,
which fail since 0.23.0, and would not know the tools policy or what a sync
does to a 0.22 Pi config. The MCP reference now matches the CLI; the
description is unchanged and stays within its size limit.
* test(mcp): cover Pi migration and the tool policy in the runbook
The runbook still exercised pi-mcp-extension, pi-mcp-adapter and
--pi-options-prune, all removed in 0.23.0. New steps check Pi built-in
cleanup, the first-sync conversion of a 0.22 config with its migrate
backup and untouched hand-written adapter entries, the removed-flag
messages, and what each Agent receives from one tool policy.
* docs(wiki): record the 0.23.0 MCP Pi and tool policy milestone
Keeps the design decisions and evidence limits of #140 and #143 (the
ledger-driven migration, the migrate backup, per-Agent translation rules)
where later work can find them without reading five phase reports.
* docs(i18n): mirror the Pi built-in and tool policy docs in four locales
The zh-Hant, zh-Hans, ja and ko MCP pages still described the removed Pi
modes and flags, and linked to anchors that no longer exist in English.
They now carry the tool policy, Pi, and upgrade sections with the English
anchors and dashboard labels taken from each locale's UI strings.
* feat(mcp): probe an unsaved server definition for the dashboard
Loading tools in the server dialog could only probe the saved config, so
editing a URL and clicking load tested the old address and surfaced a raw
"connection refused" for a server the user was already fixing. A new server
could not load tools at all until saved.
POST /api/mcp/probe runs the existing live probe on the definition in the
request, resolving env and header references as the saved-server check does,
and never saves or syncs. Failures carry an error kind (connect, timeout,
auth, protocol, command, unknown) so the dashboard can explain them in the
user's language and keep the raw text as detail.
* fix(ui): load MCP tools with the dialog's current settings
The Tools section now probes the connection as the form describes it, so
an edited URL or command is what gets tested and a new server can load its
tools before saving. Probe failures read as short localized messages with
the raw error behind Details instead of the probe's English text.
Loaded names are dropped when the connection fields change, since they may
no longer be this server's tools; editing Allow or Deny keeps them.
* docs(mcp): say Load tools probes the dialog's current settings
The MCP and UI references said the button starts the saved server and that
a new server must be saved first, which is no longer true.
* feat(ui): pick MCP tools from a loaded checklist
Typing exact tool names into allow/deny chip inputs made users guess
names the server already knows. The Tools section now loads the
server's tool list and lets users tick which tools the model gets;
unticking writes the exact name to deny, re-ticking removes it (and
adds it to a non-empty allow list), and rows removed by a deny
wildcard are locked with the rule named in a tooltip.
Wildcard and unlisted rules stay editable as chips in the same box,
and an outcome summary tells users which agents honor the list,
which honor it only partly, and which cannot filter tools at all, so
nobody assumes a filter applies where it does not.
* refactor(mcp): drop tools.expose in favor of Pi's own exposure
tools.expose only ever meant something to Pi, yet it sat in the
cross-Agent tool policy, locked Pi's exposure select whenever a policy
was set, and produced an "expose" gap for every other Agent. Pi's
exposure mode now lives only in piOptions.exposure: it can sit next to
a tool policy (only toolExposure still conflicts, since the policy
writes it), allowed tools inherit it, and pi-mcp-adapter's directTools
migrates to it. The flag and field were never released, so they are
removed without a shim.
The dashboard now describes a policy in plain words ("2 tools
excluded") instead of the old "2 denied" shorthand, shows Pi's
exposure on the server list in words, hints that Enter adds a rule,
and no longer leaves "{}" behind when an exposure is set and then
cleared.
* fix(hooks): make import a takeover and plans say what changes
A hands-on trial showed several rough edges in hooks management:
- Importing one per-event candidate such as claude-stop merged every event
of the file into the entry, so unrelated hooks became managed.
- An imported hook then conflicted on the next sync as an "identical
unmanaged hook" until --replace, although importing it was the takeover.
- Narrowing an entry was reported as "remove" of the whole file although
only one event left it, and plans gave no event-level detail.
- A misspelled event such as Stopp was accepted silently and would never run.
- Rewriting a compact settings.json produced half compact, half indented
JSON and left an empty hooks key Skillshare itself had added.
A name that matches a candidate now picks only that candidate. Saving an
import (Mutation.adopt) records the identical native registrations as the
entry's own even without sync, so the next sync adopts them in place; edits
made outside Skillshare afterwards still conflict. Changes carry added,
updated and removed events, and "remove" is reserved for an entry that leaves
the file. A per-Agent catalog of documented events, from each Agent's
official hooks reference, drives advisory plan warnings and is served at
GET /api/hooks/catalog. JSON edits keep the file's compact or indented style
and drop a hooks key once Skillshare empties the one it created.
* style(ui): keep clean theme switches and picked cards black and white
The clean theme is black-and-white only, so its on switches and picked
cards use ink instead of the green ok and blue accent colors. The playful
theme keeps its own colors.
* feat(hooks): return full file texts from the hooks preview
The dashboard can only show which Agent files a hooks change touches, not
what changes inside them. POST /api/hooks/preview now also returns files[]:
each native file the plan would change, with its current text and the exact
text sync would write, taken from the same plan apply writes from. Other
plan responses stay unchanged, and the route keeps the localhost-only guard.
* feat(hooks): manage Antigravity and Antigravity CLI hooks
Antigravity and its CLI (agy) are skills targets, but their hooks could
not be managed. Both read the same files, ~/.gemini/config/hooks.json and a
project's .agents/hooks.json, so they are one hooks Agent with
antigravity-cli and agy as aliases.
Antigravity's hooks.json maps hook names to blocks of events rather than
one event map. Each Skillshare hook becomes one block named after it, held
as a single owned element, so ownership, adoption, conflicts and restore
work as for the other Agents. Keeping the block's own name lets an import
take the block over in place; a same-named block Skillshare does not own is
a conflict until it is imported or replaced. Disabled blocks are not offered
for import, and edits keep the file's compact or indented style.
The event catalog lists the documented events (seconds timeouts), import
problems are no longer cleared before validation, and the schema and docs
cover the new Agent.
* fix(hooks): replace an edited registration in place
Acceptance found that --replace on a registration Skillshare owned but
someone edited outside appended a second copy: the edited one stayed in the
file, now unmanaged, next to the replacement. When the element at the
record's last written position is owned by no one, replace now overwrites it
there, for both an edit with --replace and 'hooks sync NAME --replace'.
Writing into a one-line array such as "Stop": [{...}] also mixed one-line
and indented layouts; elements written there now stay on that line. Import
candidate lists print an explanation shared by several rows once instead of
on every row.
* feat(ui): rebuild the hooks page around targets, the catalog and real diffs
Editing a hook meant typing event names from memory, repeating each
target by hand and saving JSON the dashboard could not check, and the
preview only listed actions without showing what would change in a
file. The backend now publishes each target's documented events and the
full before/after text of every file a preview touches, so the UI can
guide the whole flow instead of trusting free text.
- Event fields pick from the catalog with descriptions, and show the
tool filter and timeout unit only where the target has them.
- An empty target tab offers to copy another target's commands, mapping
events to their closest equivalent and converting timeout units, and
says when an event has no counterpart.
- Native JSON gets completion, formatting and linting with the line and
a suggested event, and never drops invalid text when switching back to
fields; Cmd/Ctrl+S saves without syncing and Esc asks before
discarding edits.
- The preview shows one card per file with event-level changes and a
folded line diff that marks the user's own hooks as untouched.
- Import preloads each target's unmanaged hooks, saves only the checked
ones with adopt so sync does not duplicate them, and keeps pasting as
a secondary path.
- Antigravity joins the managed targets, the wording says targets
throughout, and the remove dialog no longer contradicts itself.
* fix(hooks): keep key order and separators when replacing an element
Replacing a registration in place re-encoded it from a Go map, so its keys
came out sorted, and on a one-line array it was minimized without the
spaces the line used: [{"hooks": [{"type": "command", ...}]}] turned into
[{"hooks":[{"command":...,"type":"command"}]}]. The whole line then showed
as changed and read as a rewrite of the user's style.
A replaced element now keeps the replaced one's key order at every depth,
with new keys at the end, and elements written on a one-line array use the
line's own spacing after colons and commas.
* feat(hooks): stop managing a hook while keeping its entries
Removing a hook from the source always queued the removal of its native
entries on the next sync, so there was no way to hand a synced or adopted
hook back to the user. MCP already has this as `remove --keep-files`.
`hooks remove NAME --keep-files` (and `unmanage` in the API mutation)
removes the entry and forgets its ownership records in that scope, so sync
neither removes nor updates what it wrote; the entries show up as unmanaged
and importable again. It is rejected with --sync, like MCP.
The dashboard remove dialog adds "Stop managing" and now says what each
choice does to the target files, including that "Remove from source only"
still deletes the entries on the next sync. Its backup note is neutral and
the dialog is wider to fit the diff.
* fix(mcp): warn that Pi's built-in MCP needs Pi 0.99.0 and no old extension
The first sync after upgrading moves Pi servers off pi-mcp-adapter and
pi-mcp-extension into Pi's mcp.json. A user still on Pi before 0.99.0
silently loses every server, because older Pi does not read that file, and
Pi's docs say an installed extension that registers /mcp replaces the
built-in MCP. Nothing told them either.
The plan now adds one notice, shown by preview, sync and --json, when it
removes an entry Skillshare wrote to mcp-adapter.json, rewrites an owned
entry in pi-mcp-extension's format (the transport field), or the config
still has settings only the extensions read. The ledger check covers a
config that owns adapter entries without saying piExtension.
* docs(mcp): say what Pi needs before the first 0.23.0 sync
The upgrade section described how the config changes but not the two
things a user must do in Pi: run Pi 0.99.0 or later, and remove
pi-mcp-adapter or pi-mcp-extension, which Pi's docs say replace the
built-in MCP. It now shows the sync warning, lists every dropped adapter
option, and says a disabled entry no longer turns a server off for Pi in
that project. The import paragraph claimed sync never changes
mcp-adapter.json; it removes the entries it wrote there.
* fix(ui): make hook diffs, editors and the hooks rail readable
Supervisor and user trial of the rebuilt hooks page found diffs that
read as "we will touch your hook", an editor too small for real hooks,
and text cut short in the rail.
- Diffs: removed lines red and added lines green through new diff theme
tokens (the one colour exception in the clean theme), removals before
additions, lines differing only by a trailing comma or whitespace kept
as context, long lines wrapped, and the "left as is" marker on its own
line. An adopt-only card says the file is unchanged.
- Editors: native JSON and code editors expand over the dialog and back
as the same editor, so lint, completion, format, the error count and
Cmd/Ctrl+S keep working; Esc closes completion first. The invalid-JSON
explanation sits above the editor.
- Dialogs are 880px like MCP's.
- Main page: full target paths wrap under the name with no inner scroll
box, the sync card shows the target file, empty descriptions are
hidden, the unmanaged note avoids an orphaned character, and the row
menu uses a hooks-specific "each target" label.
- Import names follow the CLI (<target>-<event>) or a script's basename.
* feat(ui): show MCP plan notices before a sync
The API returned the plan's notices, but no dashboard view showed them, so
dashboard users never saw that the 0.23.0 sync rewrites their config or
that Pi's built-in MCP needs Pi 0.99.0 and no old extension. The MCP sync
dialog and the Sync page now list them, translated through mcp.notice.*
keys; a notice the UI does not know is shown as the server sent it.
* fix(install): default CLI installs to the user-local bin directory
Use ~/.local/bin so ordinary script installs and upgrades do not require administrator access. Preserve INSTALL_DIR overrides and existing installations, verify the installed binary directly, and show PATH setup only when needed.
Add offline installer regressions and align installation guidance across all five documentation locales, including automation PATH setup.
Validation: seven offline installer cases, make check in the devcontainer, all five website locale builds, and AI context checks passed.
* fix(ui): let stop managing succeed and open the source config from the header
Stop managing sent a mutation whose plan differs from the removal preview the
dialog had loaded, because the server forgets the ownership records first, so
the revision never matched and every attempt failed as stale. Both the hooks
and MCP remove dialogs now preview that mutation before saving it; it writes no
target file, so there is no diff to review. Its toast also says the entries
stay in the files instead of "Removed".
The source path line under the lists took space most people never read. A
config.yaml button in the page header now shows the full path on hover and
opens the Config page editor; a separate sources.mcp file has no editor there,
so that case copies the path instead.
The Pi chip on a server row no longer mentions other Pi settings.
* test(server): replay the dashboard's hooks and MCP requests against the handlers
UI tests mock the API with one fixed revision, so a dialog that saves with a
revision from the wrong preview passed every vitest while "Stop managing"
failed in real use. These tests send the exact mutation JSON and preview
revision each dialog uses (remove, stop managing, edit, toggle, takeover,
import/adopt, restore, global and project sync) in global, hooks.projects
or mcp.projects, and project-mode scopes, and pin that hooks refuses an
unmanage saved with the removal preview's revision.
* fix(ui): show comma-only line changes in the hooks diff
A line that only gained or lost a trailing comma was shown as unchanged
with its new text, so the preview hid a real byte change to the file.
Lines still align ignoring the comma, so an added sibling does not shift
unrelated lines, but a differing pair now shows as removed and added,
removals first within each change. The user's own event keeps its
"left as is" note on the new line.
* fix(hooks): name the events a Copilot hook file changes
Copilot keeps each hook in its own file, so its plan changes carried no
events and the preview card showed only the action while every other
Agent listed "+ SessionStart" and the like. The planner now compares the
file's hooks map before and after the write and reports added, updated
and removed events the same way shared files do.
* feat(ui): open config.yaml at the section the header button came from
The config.yaml button on the Hooks and MCP pages opened the editor at
the top, leaving the user to scroll for the part that page manages. It
now links to /config?section=hooks or ?section=mcp, and the Config page
puts the cursor on that top-level key and scrolls it into view once the
file is loaded. A config without the key opens at the top as before.
* fix(ui): say what hooks and MCP dialogs will really do
Trying hooks across eight targets showed several places where the
dashboard hid or misstated the outcome:
- Remove and sync writes every pending change of the scope, but the
hooks and MCP remove dialogs only named the removed entry; they now
name the other hooks or servers that go out with it.
- With more than three targets, each remove choice spelled out every
target; it now gives the count.
- Preview cards shrank to their header in a long list and hid the diff.
- A hook's summary listed SessionStart and sessionStart as separate rows
with no hint of which target runs which; rows now merge case-only
differences and show their targets' icons.
- Save and sync used the same toast as a plain save.
- The copy panel promised the closest events even when a target had
none; it now says those events must be picked by hand.
- The Hooks rail's expandable target rows had no accessible name.
* fix(ui): pair hooks diff lines only at the same indentation
Diff lines were aligned ignoring leading whitespace, so appending an
event paired the file's closing braces with braces inside the new block.
Once differing pairs show as removed and added, that turned one comma
change into a run of removed closing braces. Only the trailing comma is
ignored now, so the diff shows the comma pair and the added lines.
* fix(ui): explain each hook removal choice on its own button
The three consequence lines sat in the dialog body, away from the buttons
they describe, and made the dialog long when a hook reached many targets.
Each explanation now shows as a tooltip on its footer button, on hover and
keyboard focus, and is wired through aria-describedby for screen readers.
Tooltip placed button-anchored tips that did not fit below using the
cursor offset, so a two-line tip covered the buttons; it now flips above
the anchor. It also shows nothing without content, which lets the dialog
keep its buttons mounted while the preview loads.
The CJK strings dropped the space between the target text and the
particle, which read as "8 個目標 的".
* fix(hooks): delete the files and folders a removed hook leaves empty
Syncing a hook to an Agent whose hooks file did not exist, then removing
it, left shells behind: `{}` in Claude, Codex, Gemini, Qwen, Droid and
Antigravity files, `{"version":1}` for Cursor, and empty folders such as
~/.copilot/hooks and ~/.pi/agent/extensions. They look like user
configuration and confuse the next import or review.
The ledger now records the shared files Skillshare created and the
folders it made for its outputs. When removal leaves a created file with
nothing but that skeleton, the plan deletes it and says so, and the file
diff shows the deletion. Files and folders that existed before, settings
or comments the user added, and non-empty folders all stay. Apply checks
the skeleton again, so settings added after the preview keep the file.
* fix(hooks): note Copilot's folder trust and use Pi's current package
Running Copilot CLI against a synced project showed that .github/hooks
is skipped until the folder is in trustedFolders, while COPILOT_HOME
hooks run anyway; the Copilot note was the only command Agent note that
did not mention trust. Pi's extension docs now import ExtensionAPI from
@earendil-works/pi-coding-agent, so the hook template follows them. The
old name still loads because the import is type-only, but editors no
longer resolve its types.
* test(hooks): run synced hooks in real Agent CLIs
Unit tests only prove Skillshare writes the native files we believe are
right. This runbook syncs a marker-writing hook for each Agent, starts
the real CLI once per scope with a throwaway HOME and fake credentials,
and checks the markers, so a format or location mistake shows up as a
missing marker. Antigravity and Cursor check credentials before any hook
runs; the runbook lists how to confirm them by hand.
* fix(hooks): write the hooks section in block style
yaml.v3 encodes an empty mapping as flow `{}`, and entries added to it
inherit that style, so the first hook saved after the section was emptied
landed on one unreadable line in config.yaml. The section is now expanded
before it is written, like the MCP section, which also unfolds entries an
earlier save left on one line.
* fix(ui): let Beautify unfold nested one-line YAML
Beautify kept flow collections as written, so a hooks or MCP section
squeezed onto one line stayed that way and the button reported nothing to
change. It now expands flow collections that nest others, and everything
inside them, while short lists such as `targets: [claude, codex]` stay on
one line. Saving still keeps the user's flow style.
* fix(ui): show hook targets once and light them up per event
Each event line repeated its own row of target icons under the header's
icons, and two rows of logos stacked on the right read as clutter. The
header now shows the targets as one overlapping stack, and hovering an
event line fades the targets it does not run on. Screen readers still hear
each line's targets.
* fix(ui): document the hooks section in the config editor
The field panel labelled every key under hooks as an unknown field, which
suggested the section was a mistake. It now explains hooks, its entries,
bindings, events, code, files and projects like the MCP keys.
* docs(hooks): describe the config editor and Copilot folder trust
The hooks page now writes its section in block style, opens the config
editor at hooks:, and the field panel and Beautify understand the
section; none of that was documented. Running Copilot CLI also showed that
project hooks in .github/hooks load only in a trusted folder, which the
destinations section did not say.
* docs(changelog): add 0.23.0 entry
Records native hooks, the MCP tool policy, the dashboard work around both,
and the Pi built-in MCP breaking changes, so users upgrading from 0.22.2
know what moves on their first sync.
* fix(server): validate hooks when the config editor saves
The config editor kept the hooks section as an opaque node and never ran
the hooks checks, so a malformed binding saved successfully and then broke
the Hooks page and `sync --all` until the YAML was repaired by hand. A
project config could also gain `hooks.projects`, which only the global
config may hold. Saving now rejects both with the same message sync gives.
* fix(hooks): keep an Antigravity block's name when importing it
An Antigravity hook is the named block in hooks.json. Importing one under
another name, through `hooks import --from agy NAME` or a renamed row in the
dashboard, planned a new block and left the original unmanaged, so both
ran. Such a takeover is now a conflict that asks for the block's own name,
and the import dialog keeps that name fixed for Antigravity rows.
|
||
|
|
445ace98ca |
docs(hub): describe the current Hubs page flow
The hub-index guide and the ui reference still described the old Browse / My hubs tabs with New Hub, Save draft and Download index, and an in-dialog Hub manager, none of which exist anymore. Readers following them could not find the controls. Rewrite the Web Dashboard section in all five locales around Add or create a Hub, Add skill, Save, Share -> Download skillshare-hub.json and the hub add command, using each locale's dashboard labels. Drop the stale hub-builder-draft.png screenshot, which shows the removed UI. |
||
|
|
ab183449ea |
docs(mcp): describe the reorganized MCP dashboard
The MCP page moved Check and Backups and restore into the Sync box under Sync MCP, and the "Turn off a global server" button now sits beside the Servers heading in project mode. Project MCP tabs gained their own Check, and a Pi server's dialog now starts on the built-in MCP mode. The docs still named the old places, so readers looked for buttons that had moved. |
||
|
|
cefa7c50ee |
fix(server): report a sync where every target fails instead of a 500
When every skills target failed, including when every target's settings were invalid, the dashboard sync returned 500 with only the first error. The page lost the failed list and its explanations, agents were never synced, and the dashboard's extras and MCP steps did not run. The sync now finishes like any partial failure: it returns 200 with every target in `failed`, and the operation log still records it as `error`. |
||
|
|
4b0fbe680e |
feat(ui): explain common sync failures in plain words
A failed target showed only the raw error, such as "mkdir ...: not a directory", which says what the OS refused but not what to do. The result panel now adds a one-line explanation for the common causes: a symlink pointing elsewhere, permission denied (including Windows' "Access is denied"), a read-only file system, a file where a folder belongs, a missing path, and a target skipped for invalid settings (the new "config" part). Unknown errors keep the raw text only. |