Gitlink paths and .gitmodules URLs come from an untrusted repo, so quote them with %q to keep newlines and terminal escapes out of CLI output. Compare each ancestor of the subdir with the gitlink directory by os.SameFile instead of a byte-length prefix, so case and Unicode-normalization variants that open the same directory are caught.
On Windows and macOS a case variant such as Vendor/Up opens the empty submodule checkout, so compare gitlink paths with EqualFold. Search results that install straight from discovery now show its warnings too.
Redact query, fragment and userinfo from relative, scp-style and malformed .gitmodules URLs too, clean the subdir before matching gitlinks so vendor//up is caught, and return discovery warnings from /api/discover so the install dialog shows skipped submodules.
The bar is position: fixed with left: 50%, so its shrink-to-fit width is
capped at the space right of its left edge, half the viewport. Content
wider than that wrapped inside the fixed 46px height, as seen on the Pi
and OMP pending-changes bars. Size it to its content and cap it at the
viewport instead.
DELETE /api/repos/{name} now refuses a repo with uncommitted changes or
unreadable git status, and the Dashboard page never sent force, so those
repos could not be removed from it at all.
The two refusals force overrides now carry their own error code. The
page still sends the first request without force; on either code the
confirmation says why and retries with force only when the user
confirms. Other refusals, such as a linked folder that is itself a
skill, keep the plain error because force does not change them.
Refs #442
Review showed three ways a missing key still passed:
- t('sync.changes') passed because the counted base was accepted for
any string; a string passed straight to t() must now be a key itself.
- plural('typo.key', n) was only seen when its first word was a known
namespace; strings passed straight to plural() are now checked for
both forms.
- The Go test listed the values that complete "plugins.problem." by
hand, so a new case in automationProblem passed; the values now come
from that function's switch.
The files of config paths were also skipped by every check; they are
now skipped only where config paths look like keys, so their t() calls
are checked again.
Refs #448
Two places still wrote out 'translate the backend key, else show its
text' by hand next to keyedText, so the rule had three copies. The Pi
package test also rebuilt the set of Pi targets for every package on
every render; it is now built once per inventory, as before the flow
moved out of the page.
Refs #446
The audit query of a skill is keyed by name and kind, and its cache is
cleared by the ['audit', 'skill'] prefix. The name-only key lost its last
caller when the key literals moved into queryKeys.ts, and read as the real
query key while matching none exactly.
Refs #445
The source view of a target's file showed the block markers as plain
comments, so which lines skillshare manages, and which block had been
edited by hand, took reading the markers. Each managed block is now
tinted, a block the target reports as modified in the warning tone, and
the dialog says what the block is or offers Collect and Reapply for the
edited one, as the row does.
Refs #436
The i18n module guaranteed parity between locales and left the rest to
callers. `t` takes any string, so a mistyped key rendered as the key and
nothing caught it; internal/plugin sends translation keys that nothing
compared with en.json; and about 130 call sites chose between `.one` and
`.other` by hand.
- keys.test.ts reads the dashboard source and fails on a key that is not
in en.json. A key built at run time is checked by its fixed head, and a
string that only looks like a key is named in a short documented list.
- internal/plugin/i18n_keys_test.go fails when a "plugins." literal the
package emits is missing from en.json; the one key completed at run
time lists its values.
- plural(key, count) in the i18n module picks the form, with the same
"exactly 1" split the call sites used, so every rendered string is
unchanged. No locale file changed.
Refs #448
A target row showed only the path of the file the tool reads, so seeing
what a prepend or append block actually did to that file meant leaving
the tab for the target page. The path now opens a read-only dialog with
the same preview and source views, and a link to the target page for
editing. Riders keep a plain path: they have no file of their own.
Refs #436
PluginsPage held the whole flow in one component: the busy, working,
failure, review, result and updates state, the rule that apply sends the
revision its preview returned, and the lists derived from the inventory.
Those rules could only be tested by rendering the page with five mocks,
so the test file changed whenever the page did.
components/plugins/pluginsFlow.ts now owns the state and the derived
lists (todo, active, idle, changed, Pi packages), and the page renders
what it returns. The rules are tested there with only pluginsApi faked;
the page test keeps rendering and wiring, and loses the four cases that
only checked a rule through the DOM.
The "use the backend key if present, else the text as sent" helper
existed three times; keyedText in outcomeText.ts is now the only one.
No text or markup changed.
Refs #446
The Pi and Oh My Pi extension tabs each carried a ReviewDialog with the
same flow, nearly line for line: preview once, apply only that plan's
revision, show busy and stale refusals, and offer "review again" when the
server reports the plan stale. A third target of this kind would have
added a third copy.
ExtensionsReviewDialog now owns that flow and the dialog frame. Each
target supplies its plan rows, texts and endpoints, so the two protocols
stay as they were: Pi previews without a revision, OMP previews against
the view's revision, and both apply the previewed plan's revision.
Hooks, MCP and Plugins use different protocols and are left alone.
Refs #447
The AGENTS.md tab and the instructions API only knew import, symlink
and copy, so a tool without @import could hold one shared file and had
to give up its own instruction file to do it.
The mode picker now lists prepend and append first among the modes that
keep the tool's own file, with import; symlink and copy stay blocked
once a target holds another shared file in a managed part. A target
whose file already holds a block defaults the next shared file to
prepend; the first connection keeps the link default the existing
tests and the memory guidance rely on. The row hint says the target
also uses the other files instead of claiming one replaces the other,
and the modified-state note, Collect and Reapply name the block rather
than the whole file, since only the block is read back or rewritten.
The connect and restore previews describe what a block does to the
target file.
Refs #436
Tools without an @import directive (codex, gemini, cursor) could only
take a shared instruction file as a symlink or copy, which replaces the
target's own file. Teams that want one shared AGENTS.md plus the user's
own notes in the same file had no way to express that.
prepend and append write the source into the target file as a managed
block fenced by skillshare:extra markers that carry the source path and
a content hash. Sync inserts the block once and then rewrites it in
place, status reports modified when the block body no longer matches
its hash, Collect copies the edited body back to the source, Reapply
rewrites the block from the source, and restore removes only the
block. Lines outside the block, and markers inside code fences, are
never touched. Several managed blocks (and an import line) may share
one target file; the connection validator only rejects a file when a
replacing mode (symlink, copy, merge) is involved.
Refs #436
Which queries a mutation makes stale was knowledge each caller carried:
139 invalidateQueries calls in 48 files listed keys by hand, the lists
differed, and some used hand-written prefix keys such as ['sync-matrix']
that queryKeys could not express.
The key list of every event now lives once in lib/queryEvents.ts and call
sites say what happened: invalidate(queryClient, 'skillsUninstalled').
The three existing helpers (invalidateAfterSync, refreshTargets,
refreshInstructions) became events too. queryKeys gained the prefix keys
(syncMatrixAll, diffAll, logAll, logStatsAll) and every query key that was
written inline, so no key literal remains outside queryKeys.ts.
No call site's invalidated set changed. Each event is tested once against
a real QueryClient, including which queries it reaches by prefix.
Refs #445
Keep bundled CommonJS converters working inside ESM projects. Show concise sync failures with expandable original diagnostics and clarify that the last-sync card covers skills and agents only.
Changing the served target rebuilt the command from the dashboard scope,
so editing `skillshare mcp serve -p --target old` in the global
dashboard silently dropped -p; the command now keeps its own flag.
Skill names were trimmed before validation, so a name and directory
padded with the same spaces passed. Names are no longer trimmed, and the
spaces fail the character rule.
A managed project's name may hold spaces, so the Skillshare tab built
`--target my app@claude`, which the save path split into two words and
serve rejected as an unknown target. The command is now joined from
quoted words.
The Agent Skills format caps a description at 1,024 characters, and
hosts validating entries reject longer ones, so serve skips such a skill
with a warning instead of advertising it. The docs list every skip reason.
A root under mcp.projects is served from the global config, where its
project targets (app@claude) live, so the Skillshare tab now offers that
project's targets beside the global ones and saves no -p, which would
fail in a folder with no .skillshare/.
A nested skill skipped for any reason, not only one left unselected, now
skips its parents too: they were settled before the child was validated
and published its files as their own.
Also from review: a skill whose frontmatter JSON cannot carry (a
non-string key) is skipped instead of failing the whole skills/list page;
a listed file with a backslash in its name can be read; and stdio serve
exits 0 on SIGINT/SIGTERM without writing to stdout after the session.
Serving skills over MCP is meant for people who do not want to type the
command, so Add server gets a Skillshare tab next to the fields and the paste
tabs. It asks only for a name, which skills (all enabled ones, or one skills
target's selection) and the Agents, and shows the command it will run. It
marks the Agents that already get skills by sync, including through another
target's folder such as ~/.agents/skills, and warns when one is ticked,
because that Agent would see each skill twice.
Editing a server that runs skillshare mcp serve opens the same tab, in the
global page and under mcp.projects. The tab is named after Skillshare rather
than skills so it can hold more of what skillshare serves later.
Reject unsupported client registration values and CIMD client or callback conflicts before syncing invalid settings to Pi. Keep dcr and custom Pi options supported, identify the legacy codemode alias, and document current Pi launch behavior.
Update checks compare the source digest, not the version, so a repo that
pushes commits without bumping its manifest (ponytail ships dozens a day)
showed "4.12.0" with an Update button and looked like a stuck update.
Check now returns the source commit, and the version tag adds
"old → new" commits when the version itself did not move.
Standalone source links were added to every grouping regardless of the
active search or filters, so a query that matched nothing rendered the
links as zero-skill groups instead of the no-match state with its Clear
filters action. Links have no skills to match, so they are shown only
while no filter is active.
A loading Button inserted its spinner in front of the children, so buttons
with a leading icon (such as Check for updates) showed the spinner beside
the icon instead of in its place. Hiding the svg that directly follows the
spinner fixes every such button at once.
Source links disappeared from the dashboard when discovery found no skills, leaving empty or unavailable folders without an Unlink action. Return first-level links independently with their follow-policy availability and preserve their groups in every skills view, including empty unlink confirmations.
Cover empty and dangling inventory, disabled following, and empty-link removal in list, cards, and tree views; document the API field and rendering.
* feat(omp): add native Oh My Pi support
Support OMP skills, instructions, MCP, code hooks and guarded extension selection using its verified native contracts rather than Pi aliases.
Add reviewed marketplace plugin installation, cache-preserving scoped removal and fresh-cache reinstall. Align Pi/OMP extension cards and localize inventory guidance while keeping native ownership and read-only constraints.
Include regression coverage, isolated E2E runbooks, documentation and verification policies. Native plugin updates and unverified runtime platforms remain guarded.
Refs #409
* fix(omp): guard runtime ownership and localize inventory guidance
Native install recursively replaces its runtime destination, and a missing cache manifest could leave the real runtime link installed after removal. Bind and recheck an absent reviewed destination, and recover removal names only from verified scope-local links.
Localize fixed backend reasons and warnings across dashboard locales while preserving paths and external diagnostics. Restore the reviewed source in the existing reinstall fixture and record real native verification.
* fix(omp): allow forgetting natively removed plugins
A different plugin can retain node_modules after native uninstall deletes this installation. When its cache, registration and known runtime state are absent, forget only the stale Skillshare binding instead of demanding runtime-name proof for unrelated files.
Extend the existing removal recovery test with a failing-before-fix case that verifies the binding is dropped and unrelated native lock bytes and plugin files are preserved. make check passes.
Share policy-based link identity enrichment between skill list and detail responses. Use that identity in the detail action menu and shared uninstall dialog so followed checkout members keep single-skill confirmation and submit their own flat name.
The link icon and the muted target path already say that a group is a
followed link, so the extra `linked` tag only repeated the same fact on
the row. Remove it from the list and card headers, the tree row and the
detail pane, and delete the now unused locale key.
The unlink icon at rest read as a broken link, not as the linked folder
it marks. Show the link icon and swap to the unlink icon in the danger
color only on hover or keyboard focus, so the row says what it is and
the action appears where the pointer is.
Keep followed checkout updates in the Updates tab and expose unlink as a single quiet icon in group headers. Remove unused checkout metadata and linked-group menus while preserving the confirmation and single-skill uninstall flows.
Match tracked repository affordances without offering whole-repo uninstall for followed user checkouts. Resolve checkout identity for Update repo, keep linked skill uninstall scoped to the selected skill, and explain target preservation, sync impact, and trash recovery before destructive requests.
Expose policy-resolved first-level link identity on listed skills so linked groups can be distinguished from ordinary folders without another request. Add a confirmation that preserves the target folder and explains trash recovery, then refresh the dashboard after unlinking.
Let dashboard users add local skill folders through the shared source-link guards without creating links by hand. Keep follow_source_links opt-in in the current mode and expose link removal through the API with recoverable trash semantics.
Cover handler behavior, request shapes, dialog errors, and all dashboard locales, and document the endpoints in the API audit topic.
Separate user-owned followed Git checkouts into linked_repos in check and resources responses so the Updates tab renders information instead of tracked errors or retry actions. Refuse dashboard updates before Git runs, including force retries and descendant skills, while leaving managed repositories unchanged.
Keep one follow policy per list and status operation and report its skipped links without hiding healthy inventory. Send JSON diagnostics to stderr and expose sourceLinkWarnings in the dashboard resources response, reusing the sync warning formatter.
The sticky band stacked the title and the filters on two rows and padded
both ends by 24px, which left a large empty strip above and below the
filters. Merging them into one row removes the gap.
Refresh reloads every memory query (the note list and note contents), not
just the sidebar, so it belongs with the page-level actions next to
"New note". Next to the search box it crowded the sidebar and pushed past
the note tree's edge.
The Syncing column described what a target gets as one line of text,
and the whole row led to the Skills tab, so reaching a target's MCP,
Hooks or instruction file took an extra click and a search for the
tab. Each part is now its own link into that tab, and the connected
shared AGENTS.md shows up by its file name, so the list says at a
glance which targets are not connected yet.
* feat(memory): add a refresh button and keep short facts in INDEX.md
Agents write shared memory notes from outside the dashboard, so the note
list and content went stale until the page was reloaded. A refresh button
in the note header refetches both.
The active guidance also told agents to create a separate file for every
durable fact, which produced one-sentence files. Short facts now go
directly under Notes in INDEX.md; only multi-paragraph notes get a file.
* fix(ui): keep the memory refresh button available without a selected note
The button lived in the note header, so a search with no matches hid it
and the list could not be refreshed to pick up a note an agent had just
written. It now sits next to the search box.
The pending-changes bar was a full-width sticky box, unlike the floating
toolbar used for bulk selection elsewhere in the dashboard. Reusing
.ss-bulk keeps both bars consistent across Clean, Playful, and dark themes.
Codex review on #400: the previous fix preferred Pi's installed version
only for npm packages. Pi reads the package.json of every installed
package, git and local ones too, and plugin import records the version it
saw, which a later pi update does not rewrite. An imported git package
moved from 1.0.0 to 1.1.0 kept showing 1.0.0. On a Pi target the page now
prefers what Pi reports for any package, and falls back to the recorded
version.