Commit Graph
543 Commits
Author SHA1 Message Date
Willie c760206b0e feat(list): show branch in CLI list TUI detail panel 2026-04-01 00:32:49 +08:00
Willie db69638e30 feat(install): project mode --branch support and branch display in check
- Set source.Branch in project install path
- Sync branch in project reconcile
- Add Branch to checkRepoResult and RepoCheckOutput for JSON/display
- Read current branch from tracked repos in check

Ref: #90
2026-04-01 00:32:49 +08:00
Willie 354db51928 feat(check): branch-aware remote ref comparison and registry rebuild
- Add GetRemoteRefHash/WithAuth/WithEnv to internal/git/info.go:
  uses git ls-remote with refs/heads/<branch> when branch is set,
  falls back to HEAD when branch is empty
- Add Branch field to URLCheckInput and URLCheckOutput in check/parallel.go;
  ParallelCheckURLs dispatches to GetRemoteRefHashWithAuth when Branch is set
- check.go: group skills by RepoURL@branch composite key so skills on
  different branches of the same repo are checked against the correct ref;
  urlHashMap keyed by same composite key for correct broadcast
- install_config.go (InstallFromConfig): propagate SkillEntryDTO.Branch
  into Source.Branch for both plain and tracked skill phases so registry
  rebuild (install --from-config) respects the recorded branch
2026-04-01 00:32:49 +08:00
Willie 428eb11120 feat(install): persist branch to metadata and registry, read in update
- NewMetaFromSource: set meta.Branch from source.Branch
- installFromDiscoveryImpl: forward discovery.Source.Branch when building
  per-skill Source struct for metadata
- installFromGitSubdir: pass source.Branch to sparseCloneSubdir (was
  hardcoded empty string, causing subdir installs to ignore --branch)
- ReconcileGlobalSkills: sync meta.Branch to registry on both new and
  existing entries
- toSkillEntryDTOs: include Branch field in DTO conversion
- updateRegularSkill / updateSkillFromMeta: restore source.Branch from
  meta before reinstalling, so updates pull from the originally-specified
  branch

Tests: TestInstallBranch_MetadataPersistence, TestInstallBranch_UpdatePreservesBranch
2026-04-01 00:32:49 +08:00
Willie 55ce0fb89e feat(install): pass --branch to discovery clone for regular installs
Source.Branch threads the branch parameter through discovery.
cloneRepo() passes --branch to git clone when set.
source.Branch is set from parsed.opts.Branch in cmdInstall.

Ref: #90
2026-04-01 00:32:49 +08:00
Willie 1c4aeff4e5 feat(install): parse --branch / -b flag
Add --branch / -b flag to install command:
- Flag parsing with value-required and non-empty validation
- Mutual exclusion: --branch rejected for non-git (local path) sources
- Help text added to printInstallHelp()
- Integration tests covering all three error paths
2026-04-01 00:32:49 +08:00
Willie ccdafd3293 feat(sync): add target_naming config option (flat/standard)
Add per-target target_naming setting that controls how skill directories
are named in sync targets. 'flat' (default) preserves the existing
flattened __ separator behavior. 'standard' uses the SKILL.md name field
directly, following the Agent Skills specification.

Standard mode:
- Validates SKILL.md names match directory basenames
- Detects and skips name collisions with warnings
- Auto-migrates managed entries when switching from flat to standard
- Preserves legacy entries when bare name is already occupied

Also includes:
- Per-target toggle via CLI (--target-naming), TUI (N key), and Web UI
- Collision output redesigned as deduplicated compact summary
- Config inheritance: global target_naming → per-target override
- JSON schema + UI validation for the new field

Closes #110
2026-04-01 00:32:49 +08:00
Willie 8c65881ad4 fix(upgrade): split unix-only sudo code behind build tags for Windows compat
Move needsSudo, execFunc, and reexecWithSudo to upgrade_unix.go with
//go:build !windows. Add upgrade_windows.go with no-op stubs.
Fixes GoReleaser Windows build failure (undefined: unix.Access).
2026-03-29 05:14:35 +08:00
Willie 1016a155db fix(diff): filter out skills with SKILL.md targets mismatch
diff (CLI, TUI, Web UI) now applies FilterSkillsByTarget before
computing differences, matching the behavior of sync/status/doctor.
Previously, skills with unsupported targets values (e.g. targets: ["*"])
appeared as false 'source only' pending items that sync could never resolve.
2026-03-29 04:59:23 +08:00
Willie e0d0313b0d refactor: simplify enable/disable after code review
- AddPattern returns (bool, error) — single file read, no TOCTOU
- Remove external HasPattern guard in CLI (AddPattern handles it)
- Merge handleDisableSkill/handleEnableSkill into handleToggleSkill
- Fix locking: RLock for discovery, Lock only for file write
- Handle errors from AddPattern/RemovePattern in TUI toggle
- Only write oplog when changes actually occurred
- Inline capitalizeFirst with strings.ToUpper
2026-03-29 04:59:23 +08:00
Willie 18fac69e56 fix(collect): resolve inherited mode and stale manifest on copy→merge switch 2026-03-29 04:59:23 +08:00
Willie cc2f0ee516 feat(list-tui): show disabled skills with E key toggle 2026-03-29 04:59:23 +08:00
Willie a3459f4cd7 feat: add enable/disable CLI commands
Friendly interface for .skillignore. Supports skill names and glob
patterns. Dual-mode (--project/--global). Dry-run support.
Does not auto-sync — prompts user to run sync.
2026-03-29 04:59:23 +08:00
Willie 41dd81b7f2 refactor: migrate all callers to SkillsConfig() / EnsureSkills()
44 files across CLI commands, sync engine, and server handlers now use
SkillsConfig() for reads and EnsureSkills() for writes instead of
accessing flat TargetConfig fields directly.

Key changes:
- sync engine (SyncTargetMerge/Copy/Symlink): reads sc := target.SkillsConfig()
- target commands: filter add/remove and mode set use EnsureSkills()
- target TUI: mode picker, filter ops, detail panel all via SkillsConfig()
- server handlers: backup, restore, targets, sync, diff, collect, analyze
- init/init_project: new target creation uses Skills sub-key
- doctor, status, diff: target display reads from SkillsConfig()
- computeTargetDiff: accepts config.TargetConfig directly (was anon struct)
2026-03-29 04:59:23 +08:00
Willie 7125a251d9 feat(upgrade): auto-detect sudo requirement for CLI upgrade
When the binary is installed in a non-writable directory (e.g. /usr/local/bin),
upgrade now automatically re-executes with sudo instead of failing with a
permission error.

Uses unix.Access() to check directory writability and unix.Exec() to replace
the process with sudo. Skipped on Windows.

Ref: #105
2026-03-29 02:52:46 +08:00
Pulkit Kathuria 43f99e770a fix(pull): update info message from git stash to git stash -u
Include untracked files in stash suggestion, matching git status --porcelain scope.

Co-authored-by: Pulkit Kathuria <kevincobain2000@gmail.com>
Closes #104
2026-03-29 02:52:46 +08:00
Willie 6523363337 refactor(analyze): extract skillMatchesFilter, cache filtered sums
- Extract skillMatchesFilter() helper to deduplicate relPath matching
  logic between filterAnalyzeSkills() and TUI applyFilter()
- Cache filteredDescChars/filteredBodyChars in applyFilter() so
  renderStatsLine() reads cached values instead of iterating on
  every render (also fixes incorrect sums when list is paginated)
- Use filterAnalyzeSkills summary in plain-text path instead of
  manually re-summing chars
2026-03-27 00:40:59 +08:00
Willie 2ba561f667 feat(analyze): dynamic token sums in TUI stats line
renderStatsLine() now computes always-loaded, on-demand, and total
token sums from the currently filtered items instead of showing
fixed target totals. Shows N/M format when filter is active.
Filter now matches on relPath (supports group paths like frontend/).
--filter flag pre-populates the TUI filter input.
2026-03-26 23:51:03 +08:00
Willie ffdded311f feat(analyze): add --filter flag with filtered_summary in JSON output
Support case-insensitive substring filter on skill relPath.
When --filter is set, JSON output includes filtered_summary with
always_loaded, on_demand, and total token counts for matched skills.

Ref: Discussion #99
2026-03-26 23:47:28 +08:00
Willie eabb556cc6 refactor(config): cache SourceRoot in Config.RegistryDir
Eliminates redundant .git/ directory walks on every LoadRegistry call.
SourceRoot() is now computed once in config.Load() and cached in
cfg.RegistryDir. All 11 call sites use the cached value.
2026-03-26 23:32:15 +08:00
Willie a7de6a3a69 feat(registry): move registry.yaml to source dir for git sync (#103)
- Add SourceRoot() helper to find git repo root from cfg.Source
- Add MigrateRegistryToSource() for one-time migration
- Update all 11 global-mode LoadRegistry/Save call sites
- registry.yaml now lives in skills/ dir and is tracked by git
2026-03-26 22:42:00 +08:00
Willie 3a978e17d2 fix(init): skip skill prompt when remote has skills (#102)
setupGitRemote now returns bool indicating remote had skills.
When true, skip installSkillIfNeeded — user will get skills
via 'skillshare pull' instead of being prompted.
2026-03-26 22:31:35 +08:00
Willie 64ed9b046e feat(analyze): add malformed-frontmatter lint rule and polish UI/TUI
- Surface YAML parse errors from calcContextFromContent as a new
  "malformed-frontmatter" lint issue instead of silently ignoring them
- Fix help text to say "Top 10" (was "Top 5") matching actual constant
- Shorten TUI list title to target name only; move skill count to
  stats line so the header no longer wraps on narrow terminals
- Truncate long skill names in TUI to keep token counts visible
- Change "All Skills" icon block to green (matches Skills summary card)
2026-03-26 19:20:52 +08:00
Willie f7e04f1961 docs: add v0.18.0 changelog, release notes, and analyze docs
Add CHANGELOG and website changelog entries for v0.18.0 covering
the new analyze command, skill quality lint, TUI, Web UI Analyze
page, and Update page improvements.

Update analyze.md with lint rules table, quality section, and
updated JSON output example. Add analyze to built-in skill
description and Quick Lookup table. Bump skill version to v0.18.0.

Fix TUI list title to show skill count in stats line instead of
title, and truncate long skill names to keep token count visible.
2026-03-26 19:20:52 +08:00
Willie d377e6bbf6 refactor(analyze): simplify lint engine and fix review findings
- Eliminate double YAML parse: extend calcContextFromContent to return
  name, remove parseFrontmatterName helper
- Pre-compute lint icons (lintIconError/lintIconWarning) to avoid
  lipgloss.NewStyle() allocation per render frame
- Use tc.Red/tc.Yellow for Quality section icons (consistency)
- Extract check type string constants (checkFieldEmpty, etc.)
- Panic on embedded rule load failure instead of silent nil return
- Rename "Targets: all" to "Restricted to" (only shown when set)
- Fix struct field alignment (gofmt)
2026-03-26 19:20:52 +08:00
Willie 10415a72f7 feat(analyze): add Quality section and lint icons to TUI 2026-03-26 19:20:52 +08:00
Willie deb834ce99 refactor(analyze): remove Context category bar from TUI 2026-03-26 19:20:52 +08:00
Willie 57ce3f507f feat(analyze): wire lint into discovery and analyze data flow
Populate LintIssues during skill discovery (collectContext path) and
propagate them through analyzeSkillEntry so JSON output includes lint
findings per skill.
2026-03-26 19:20:52 +08:00
Willie bb30924e05 refactor(analyze): merge identical targets into groups in TUI
Targets with no include/exclude filters share the same skill set, so
showing them individually is redundant and causes layout overflow.

Group targets by (SkillCount, AlwaysLoaded, OnDemandMax) into
analyzeTargetGroup entries. Title shows "N targets" instead of listing
all names. Target bar is hidden when only one group exists.
2026-03-26 19:20:52 +08:00
Willie 78ba5c7282 refactor(analyze): polish TUI rendering and add docs
- Fix nil pointer panic when WindowSizeMsg arrives before data loaded
- Fix TestAnalyze_Verbose: create 12 skills to match analyzeTopN=10
- Unify left panel with shared renderPrefixRow (▌ prefix bar style)
- Right-align token counts in skill list rows
- Pre-compute colored dots to avoid per-render lipgloss allocations
- Add category tab bar at top for future analysis categories
- Improve target bar separator (│ → ·) and footer spacing
- Extract renderFooter to eliminate viewSplit/viewVertical duplication
- Add analyze command reference page and sidebar/index entries
2026-03-26 19:20:52 +08:00
Willie 42dd4e4882 test(analyze): add sort cycling and target switch unit tests 2026-03-26 19:20:52 +08:00
Willie e88c32bcbc feat(analyze): implement interactive TUI with target switching and detail panel 2026-03-26 19:20:52 +08:00
Willie 439abbdea1 feat(analyze): add TUI list delegate with color dots and bar chart 2026-03-26 19:20:52 +08:00
Willie a636fc6f85 feat(analyze): add --no-tui flag and TUI dispatch 2026-03-26 19:20:52 +08:00
Willie 956a719c32 feat(analyze): add TUI-only fields to analyzeSkillEntry 2026-03-26 19:20:52 +08:00
Willie 620141af2b feat(analyze): add context analysis command
Analyze context window usage per target, showing always-loaded
(description) vs on-demand (body) token costs.

- Single-pass discovery with frontmatter-aware char/token counting
- Per-target filtering (include/exclude/symlink mode)
- Unified output when all targets have identical skills
- Verbose mode shows top 10 largest descriptions
- Project mode (-p) support
- JSON output (--json)
- Integration tests
2026-03-26 19:20:52 +08:00
Willie 580ad58dd3 fix(extras): remove leading whitespace from extras list output 2026-03-25 21:14:16 +08:00
Willie 6d0ba75e72 feat(extras): --flatten/--no-flatten applies to all targets when --target is omitted
For multi-target extras, ss extras agents --flatten now sets flatten
on all targets at once instead of requiring --target. Mode changes
still require --target for multi-target extras.
2026-03-25 21:14:16 +08:00
Willie 1d50d95459 feat(extras): add F flatten toggle to extras list TUI
Press F to toggle flatten on/off for a target. Single-target extras
toggle directly; multi-target extras show a target picker first.
Shows "Flatten enabled/disabled" confirmation message.
2026-03-25 21:14:16 +08:00
Willie bda34d27af docs(cli): mention flatten in extras help text 2026-03-25 21:14:16 +08:00
Willie 59675b3a3b fix(extras): shorthand dispatch recognizes --flatten/--no-flatten
extras <name> --flatten and extras <name> --no-flatten were rejected
as "unknown subcommand" because the shorthand dispatch only checked
for --mode. Now recognizes all three flags.

Ref: #97
2026-03-25 21:14:16 +08:00
Willie 2ce1544dd1 docs: add flatten documentation, changelog, and contributor
Extras command docs, config reference, built-in skill, website
changelog, release notes. Add mk-imagine to README contributors.

Ref: #97
2026-03-25 21:14:16 +08:00
Willie 41ffe1dfc1 feat(extras): add --flatten to CLI commands and TUI wizard
extras init --flatten, extras mode --flatten/--no-flatten, extras list
flatten indicator. TUI wizard adds flatten toggle phase after mode
selection (skipped for symlink). Back-navigation updated.

Ref: #97
2026-03-25 21:14:16 +08:00
Willie 5d9dd0cdbb feat(extras): add flatten option to extras sync engine
When flatten=true, SyncExtra maps subdirectory files to target root
using filepath.Base(). First file wins on collision, subsequent are
skipped with warnings. Includes config validation, sync-time guard,
CheckSyncStatus collision handling, and CollectExtraFiles support.

Ref: #97
2026-03-25 21:14:16 +08:00
Willie 5a0a8753d0 fix(test): update extras source-not-exist test for auto-create behavior
Sync now auto-creates missing extras source directories instead of
failing with "does not exist". Update the assertion to match.
2026-03-20 02:36:50 +08:00
Willie 34819c664b fix(ui): fix TypeScript build errors for tsc -b strict mode
- Add explicit undefined initial value to all useRef<setTimeout>
  calls (5 hooks) — tsc -b requires initial argument
- Remove unused ValidationError import in test file
2026-03-20 02:36:50 +08:00
Willie e276c95a04 fix(cli): add --source flag to extras init help text
The --source flag was functional but missing from the help output.
Also add source directory resolution priority to the main extras
help for discoverability.
2026-03-20 02:36:50 +08:00
Willie 5aa6ee8450 feat: configurable extras source with 3-level priority
Add extras_source (global default) and per-extra source (override)
to config.yaml. Resolution: per-extra > extras_source > default.

- Config: add ExtrasSource and ExtraConfig.Source fields with tilde expansion
- New ResolveExtrasSourceDir() replaces hardcoded ExtrasSourceDir()
- Migrate all 18 caller files to new resolver and sourceFunc signature
- CLI: extras init --source flag, help text
- TUI: source input phase in init wizard, narrower list panel
- extras list: source_type field in JSON, label in TUI detail
- Sync auto-creates missing source dirs instead of skipping
- extras init and server auto-backfill extras_source when missing
- doctor/status/diff/collect all use resolved source path
2026-03-20 02:36:50 +08:00
Willie 8c0e97ac13 feat: add remove action (R key) to target list TUI
Press R on a selected target to show a confirmation overlay.
Confirming exits the TUI and dispatches the full target remove
flow (backup + unlink + config update), matching the existing
exit-with-action pattern used by the skill list TUI.

Supports both global and project modes.
2026-03-19 16:33:24 +08:00
Willie dc82b93d05 fix: address code review findings for auto-create target dirs
- Remove early return in dry-run so linked/copied counts are populated
  correctly (P1: UI preview no longer hides Sync Now button)
- Use local quietDryRun flag instead of mutating global DiagOutput
  to suppress per-skill messages (P2: safe under parallel sync)
- Use "Will create" for dry-run, "Created" for actual sync (P3)
- Include dir_created in allUpToDate check so empty source + missing
  dir still shows Sync Now in the preview modal
2026-03-19 04:16:36 +08:00