Commit Graph
10 Commits
Author SHA1 Message Date
Willie 04b3808ada docs(e2e): improve cli-e2e-test skill and add registry runbook
- Add flag validation step and quality checklist to runbook generation
- Add retrospective step after test execution for continuous improvement
- Document --init interaction, registry.yaml assertion rules, common flag mistakes
- Distinguish runbook bugs from real bugs in FAIL analysis
- Fix stale config.yaml skill assertions in uninstall_all_glob runbook
- Add registry_yaml_split runbook (7-step E2E for the registry.yaml refactor)
2026-02-25 07:02:54 +08:00
Willie ce8608a6b1 fix(check): normalize leading slash in subdir for tree hash comparison
The // subdir syntax (e.g., repo//skills/foo) stores meta.Subdir with
a leading "/". git rev-parse and ls-tree paths never have leading
slashes, causing tree hash lookups to fail silently.

Strip leading "/" in getSubdirTreeHash(), resolveSkillStatuses(), and
handler_check.go. Add LeadingSlash unit test and E2E runbook.
2026-02-25 07:02:54 +08:00
Willie c321db5d9c test(audit): add E2E runbook and online test for batch audit output
Add audit_output_antigravity_runbook.md covering install --all and
update --all audit output verification against sickn33/antigravity-
awesome-skills (7 steps, all passing).

Fix audit_output_online_test.go: batch install exits 0 when some
skills succeed (blocked count is a warning, not an error), so
AssertFailure should be AssertSuccess.
2026-02-25 07:02:54 +08:00
Willie 3012061649 fix(update): use caller-provided dest paths in batch update to prevent path duplication
UpdateSkillsFromRepo was using filepath.Join(sourceDir, meta.Subdir) to
derive the local destination, but meta.Subdir is the repo-internal path
(e.g. "skills/foo") which may differ from the local install path ("foo/").
This created leaked copies at sourceDir/skills/foo/ alongside the correct
sourceDir/foo/, doubling the skill count on subsequent scans.

Change skillTargets from []string to map[string]string where key is the
repo subdir (for discovery lookup) and value is the local absolute path
(provided by the caller who already knows where the skill is installed).
2026-02-25 07:02:54 +08:00
Willie b4c6c39437 fix(install): support subdir extraction for file:// URLs via // separator
file:// URLs with subdirectory paths (e.g., file:///repo/skills/alpha)
were passed whole to git clone, which fails because the full path isn't
a git repo. Add // separator support matching the existing SSH convention:
file:///path/to/repo//skills/alpha → CloneURL=file:///path/to/repo, Subdir=skills/alpha

Also updates E2E runbook Steps 10-11 to use the // syntax and improves
cli-e2e-test skill with cleanup prompt, cd /workspace note, and Go test template.
2026-02-25 07:02:54 +08:00
Willie 792d236485 feat: optimize tracked subdir installs and devcontainer isolation
Implement remaining Issue 46 optimizations and developer experience fixes.

Install and update optimization:
- optimize install --track for subdirectory sources by attempting sparse checkout first while preserving git metadata
- fallback to existing tracked clone strategy on sparse capability or sparse path errors
- clean sparse created destination before fallback clone to avoid destination already exists failures
- improve tracked install spinner wording for subdir sources
- add tracked subdir unit tests for sparse success and sparse to full clone fallback

Progress user experience:
- normalize git progress lines by stripping volatile transfer rate suffix
- dedupe and throttle spinner and tree spinner update frequency to reduce tty flicker
- add unit tests for spinner progress normalization and throttling behavior

GitHub API messaging:
- improve rate limit guidance to suggest setting token env vars or using gh auth login

Devcontainer isolation:
- make ssenv enter command mode run from isolated environment cwd
- fix setup global init detection to use skillshare status global mode
- add auto mode hint in devcontainer wrapper when workspace project config takes precedence

E2E and tests:
- expand Issue 46 runbook with install, install track, update, no token fallback, sparse paths, and isolation checks
- update compact warning output test expectations to match current grouped warning rendering

Verification:
- go test internal install package
- go test internal install sparse and tracked subdir tests
- go test internal ui package
- go test cmd skillshare package
- go build skillshare binary and run integration TestInstall_Subdir
- run tracked subdir tests inside devcontainer
2026-02-25 07:02:54 +08:00
Willie 2ee8033171 feat: migrate contributor skills to .skillshare/skills/ for project-mode sharing
Move 5 skills from .claude/commands/ to .skillshare/skills/ so contributors
can share them via `skillshare sync -p`. Each skill has clear responsibility:
- cli-e2e-test: run isolated E2E tests in devcontainer
- codebase-audit: read-only cross-validation of code/docs/tests
- implement-feature: TDD workflow with E2E runbook generation
- update-docs: sync website docs with code changes
- changelog: generate CHANGELOG entries (RELEASE_NOTES maintainer-only)

Also:
- .gitignore: allow .skillshare/skills/, config.yaml, .gitignore to be tracked
- .skillignore: block .skillshare/skills/* from external install discovery
- ai_docs/tests/README.md: content merged into cli-e2e-test skill
2026-02-25 07:02:54 +08:00
Willie 93aa257292 feat(uninstall): add --all flag to remove all skills from source
Support bulk uninstall via 'skillshare uninstall --all' in both global
and project modes. Uses glob-based discovery to find all skills and
tracked repos, with --dry-run preview and --force to skip confirmation.

- Parse --all with mutual exclusion vs skill names and --group
- Global: discover skills + tracked repos from source directory
- Project: discover from .skillshare/skills/ directory
- Prune orphan symlinks from targets after removal
- Integration tests for --all, --all --dry-run, and conflict errors
- Update uninstall docs with --all examples
- Add AI runbook for uninstall --all glob testing
2026-02-24 01:47:38 +08:00
Willie 3721d69b54 fix: prune orphaned real directories in merge mode via manifest (#45)
- Extend .skillshare-manifest.json tracking from copy mode to merge mode.
- Update PruneOrphanLinks to prioritize manifest records over naming patterns.
- Ensure SyncTargetMerge writes to manifest for all linked/updated skills.
- Add integration tests for uninstall + sync orphan directory cleanup.
- Maintain backward compatibility for targets without existing manifests.
2026-02-24 01:47:38 +08:00
Willie 4c628e9dc9 Add devcontainer ssenv workflow and AI test guide 2026-02-24 01:47:38 +08:00