Commit Graph
28 Commits
Author SHA1 Message Date
Willie aee75b69d6 fix(audit): distinguish SDK examples from prompt injection
Avoid blocking legitimate Markdown SDK parameters and ambiguous disclosure advice by default while retaining visible HIGH findings and strict-policy gating. Preserve explicit concealment, custom severity overrides, and shell dataflow coverage in HTML and comments. Add regression coverage and document rule-ID compatibility.
2026-10-07 22:35:50 +08:00
Willie 5eb6d496ec docs(source-links): cover command pages, the built-in skill, and all four translations
The follow_source_links feature touched doctor, update, uninstall,
trash, install and audit behavior without their command pages saying
so, and the ja, ko, zh-Hans and zh-Hant site translations had none of
the new content. Translate every changed page and align the built-in
skill's doctor and troubleshooting references.
2026-10-05 16:03:47 +08:00
Willie 355b42ee57 feat(cli): one frame and keymap for every TUI, inline prompts, file viewer (#370)
* chore(devcontainer): add a TUI screenshot kit

Recreating the devcontainer wipes vhs and the browser it drives, so
every TUI review started with a manual reinstall. The start script now
installs the recording tools when they are missing and skips straight
through when they are present.

record-tui.sh screenshots each full-screen TUI in its own fresh ssenv,
filled by tui-fixture.sh through real commands, so the TUI redesign can
compare before and after on the same data.

Refs #200

* feat(cli): ask small choices inline instead of full screen

The restore source, new-skill wizard, install skill picker and the
other checklist prompts each took over the whole screen for a handful
of options, and the answer vanished once chosen. They now use the same
inline prompt as init: the question appears in place, collapses into a
"✓ label value" line, and stays in the scrollback.

Lists longer than the visible rows can be narrowed with /, and esc
inside the filter only leaves the filter. Every inline prompt shows
one key line in the wording the full-screen TUIs will share. The new
wizard drops its esc-goes-back steps: esc cancels, as in init.

Refs #200

* feat(cli): give the list TUI the shared frame and keymap

The full-screen TUIs each had their own header, footer and key letters,
so the same action used different keys per screen and the help line
listed everything at once. list is the first screen on a shared frame:
one title line with scope, counts and tabs, the list and details side
by side without dividers, and one key line with the common keys and
the position. Everything else moves under ?, and confirmations ask on
the key line so the list stays visible.

Keys follow one lowercase letter per action (u update, d uninstall,
t enable/disable, m manual only, ! audit). The All tab and the s
status cycle are gone: tab switches skills and agents, and status:
in the filter or --status covers enabled/disabled. Rows drop the
group prefix that the heading above them already shows.

Refs #200

* docs: drop key-by-key TUI instructions from command pages

The command pages carried key tables, screen mock-ups and one bullet
per key for every full-screen TUI, in five languages. The TUIs now show
their keys on screen, so these pages repeated what the screen says and
went stale with every key change (several already listed keys that no
longer exist). Each TUI section is now one paragraph on what the screen
shows and what it can do. What the screen does not explain stays: the
filter tag syntax, what manual only does to SKILL.md, the analyze color
thresholds, when audit opens its TUI, and that target changes are saved
to config immediately.

Refs #200

* feat(cli): move the trash TUI onto the shared frame

The trash TUI replaced the whole screen with a confirmation and a
spinner, so you lost sight of what you had selected, and r/d did
nothing until something was ticked. It now uses the shared frame:
checkbox rows with size and age, details beside them, and the
confirmation, the names it covers, the running operation and its
result on the bottom lines. With nothing selected, r and d act on the
row under the cursor.

Refs #200

* feat(cli): move the log TUI onto the shared frame

Log rows were two-line "[date] COMMAND — status" blocks, stats lived
behind s as a separate screen, and delete swapped the help bar for a
prompt you could miss. Rows are now one line with time, command and a
status mark; Entries and Stats are tabs on the title line next to the
count and success rate; and the delete confirmation takes over the key
line. With nothing selected, d deletes the entry under the cursor.

Row delegates no longer force a 40-column minimum, which wrapped every
row in lists narrower than that.

Refs #200

* feat(cli): move the audit TUI onto the shared frame

The audit TUI had its own tab bar, a divider column and a two-line
summary footer, and esc quit even with a filter typed. It now uses the
shared frame: scan counts and the Skills / Agents tabs on the title
line, the worst severity at the right of each row, the scan-wide
severity, threat and policy summary on the note line, and esc clears
the filter before quitting. Rows under a group no longer repeat the
group's name.

Colored title facts keep their color instead of being dimmed.

Refs #200

* feat(cli): move the audit rules TUI onto the shared frame

The rules browser used keys no other screen shared: s for severity,
space to toggle and R pressed twice to reset. It now follows the
shared keymap: t turns a rule or pattern on or off, e asks for the new
severity on the key line, and R asks yes/no before deleting
audit-rules.yaml. The severity tabs sit on the title line, rows show
the rule count or "off" at the right, and rule rows drop the pattern
prefix the group row already shows. Space still toggles.

When the title line is too narrow for every tab, it shows only the
active one instead of clipping them.

Refs #200

* feat(cli): move the analyze TUI onto the shared frame

Analyze put the target switcher, a stats line and the help text in a
three-line footer and sorted with s, which means sync everywhere else.
It now uses the shared frame: skill count and always-loaded and
on-demand tokens on the title line, one tab per target group, o to
sort with the current order on the key line, and esc clears the
filter before quitting. The details follow the list layout, and lint
warnings use the ! mark the CLI uses.

renderDetailSection and renderFactRow had no other callers and are
removed.

Refs #200

* feat(cli): move the diff TUI onto the shared frame

The diff browser drew ruled separators, "── Next Steps ──" banners and
an arrow before every suggested command, and esc quit with a filter
typed. It now uses the shared frame: target, extra and difference
counts on the title line, what differs at the right of each row, group
rows like the list's, plain headings in the details, and esc clears
the filter before quitting.

Refs #200

* feat(cli): move the restore TUI onto the shared frame

Restore replaced the whole screen for the confirmation, the running
operation and the result, rendered two-line rows, and esc quit even
with a filter typed. It now uses the shared frame: the target or the
chosen target and its backup count on the title line, one-line rows
with backup count and age or skill count and size at the right, and
the confirmation, what it covers, the spinner and the result on the
bottom lines. Esc clears the filter, then goes back, then quits.

Refs #200

* feat(cli): move the MCP manager onto the shared frame and keymap

The MCP manager used its own letters (a add, x remove, b backups, r
refresh), hid the details behind Enter, and printed two help bars.
It now uses the shared frame and the keys every other TUI uses: n
add, i import, e edit, d remove, s sync, r restore, with the details
of the selected server beside the list and ? for all keys. Refresh is
gone because the manager reloads after every action. Command docs drop
the key table, and the how-to page and built-in skill name the new
keys.

Refs #200

* feat(cli): move the search selector onto the shared frame

The search selector rendered two-line checkbox rows, put the details
under the list, used s for "search again" although s means sync
everywhere else, and Enter with nothing selected silently cancelled.
It now uses the shared frame with the keyword and counts on the title
line, one-line rows with stars or risk at the right, and the details
beside the list. Esc clears the filter, then goes back to the keyword
prompt; Enter with nothing selected installs the row under the cursor,
as r and d do in other TUIs. The command page drops its screen mock-up
and key list, and no longer claims the search restarts after an
install.

Refs #200

* feat(cli): move the target TUI onto the shared frame and keymap

The target TUI had five uppercase keys (M, N, I, E, R), a separate
skills-or-agents picker before three of them, and full-screen pickers
and remove confirmation. e now opens one menu of every setting the
target has (skills mode, naming, include, exclude; agents mode,
include, exclude, with agent filters marked as ignored in symlink
mode), and the pickers and pattern editor open beside the list. d asks
on the key line with the command it will run and what removal does.
Patterns are added with n, as everywhere else. Also drops the filter
style helper the MCP change left unused.

Refs #200

* feat(cli): move the extras TUI onto the shared frame and keymap

The extras TUI used six uppercase keys (N, X, S, C, M, F), each with
its own full-screen menu, and a full-screen confirmation. It now uses
the shared frame and keys: n new, d remove, s sync, c collect, and e
for one menu with the mode and flatten setting of every target. The
target menu and mode picker open beside the list, and confirmations
ask on the key line with what the action does. The picker row helper
moves to the shared frame, and the split and scroll-hint helpers no
TUI uses any more are removed.

Refs #200

* feat(cli): share one framed file viewer between list and extras

The list and extras file viewers were two copies of the same layout
with the old look: an indented title, a │ column between the tree and
the file, and a hard-coded yellow cursor. Both now draw through one
renderer in the shared frame: the skill or extra and the open file on
the title line, the tree beside the file without a divider, and the
scroll position at the end of the key line.

Refs #200

* feat(cli): ask for a large repo's folder inline

Installing from a repo with 50+ skills opened a full-screen folder
browser with its own filter bar and key line, then dropped back to an
inline skill checklist. The folder question is now an inline select
like every other install prompt: the first choice installs everything
below the current folder, esc goes up one level, and the chosen folder
collapses into a "✓ folder" line before the skill list appears.

The screenshot fixture gains a 60-skill repo so the picker can be
recorded, and the filter-bar and page-info helpers that only the old
picker used are removed.

Refs #200

* feat(cli): ask for MCP and plugin values inline

MCP and plugin values were typed into a separate textarea program that
submitted on ctrl+d, a key no other prompt uses. They now go through a
new ui.Text prompt drawn like the other inline questions: enter
submits, alt+enter starts a new line, and the box grows with the value.
The MCP name is a single line, so it uses ui.Input. Answers are not
echoed afterwards because a value can hold a secret.

Refs #200

* feat(cli): drop the full-screen MCP change preview

Every MCP add, edit, remove, restore and sync already prints its plan
inline and then asks whether to apply it. The full-screen preview in
between showed the same changes again and needed one more enter, so it
is removed along with the review step of the prompts interface. The
confirm question loses its "Review complete" prefix, and a blank line
now separates it from the plan.

Refs #200

* feat(cli): ask extras init questions inline

`extras init` without arguments ran its own full-screen wizard with a
hand-drawn cursor and a different key line on every step. It now asks
the same questions inline, like `init`: each answer collapses into a
"✓" line, the target line shows where the file lands, and esc cancels
with "Nothing was created".

A new ui.InputValid keeps a question open and shows the error under it
until the answer passes, which the name, file name and per-target file
name questions need.

Refs #200

* fix(cli): drop stale key hints from MCP prompts and help

`mcp --help` still listed the manager keys from before its redesign
(a add, x remove, b backups, r refresh), and several MCP and plugin
questions repeated "Esc cancels" or claimed `a` selects all, while the
key line under every prompt already shows the real keys (ctrl+a for
all). The help now just says where the keys are, and the questions keep
only what the key line cannot say. The MCP command page drops the same
key list in all five locales.

Refs #200

* feat(cli): open a skill's files at its audit findings

The audit TUI listed each finding's file, line and one-line snippet, but
judging whether a finding is real needs the lines around it, and that
meant leaving the TUI to open the file by hand. Enter now opens the
selected skill's files at its most severe finding, with the raw text
numbered and the flagged line marked; n/N steps through the findings in
the order the details number them, and the line above the keys says
which finding is shown.

The viewer state lives in a new fileBrowser so analyze and trash can
open skills the same way. Long lines wrap under their text instead of
being cut, since the evidence is often at the end of a line.

Refs #200

* feat(cli): open a skill's files from analyze

Analyze flags lint issues such as a description that is too short, but
the screen only showed the description text, so fixing a skill meant
finding its folder first. Enter now opens the selected skill's files,
including local ones that live only in a target, as raw numbered text
with the front matter, and the line above the keys repeats the first
lint issue so it can be checked against what is written.

Refs #200

* feat(cli): open a trashed item's files before restoring

The trash TUI showed only the first fifteen lines of SKILL.md, which is
not enough to tell two trashed versions apart or to see a skill's other
files. Enter now opens the item's files in the same viewer as list and
analyze, rendered as Markdown, and esc returns to the trash.

Refs #200

* fix(cli): leave front matter out of the agent viewer in list

Opening an agent in the list TUI rendered its whole file as Markdown,
so the front matter came out as a horizontal rule and a "## name: ..."
heading. Skills already drop it because the details panel shows the
name and description; agents now read their body the same way.

Refs #200

* test(cli): compare trash restore destinations home-relative

The trash TUI shows restore destinations through shortenPath, so with
HOME=/tmp, as in the offline Docker sandbox job, /tmp/skills prints as
~/skills and the tests that expected the absolute path failed. They now
expect whatever shortenPath gives for the same path.

Refs #200

* fix(cli): show control characters in viewed files as symbols

The file viewers in list, extras, audit, analyze and trash wrote a
file's bytes to the terminal as they were. Audit and analyze exist to
inspect skills that may not be trusted, and a SKILL.md with an ESC or
OSC sequence could rewrite the screen or the window title instead of
being shown. Control characters are now replaced with same-width
symbols such as ␛ before rendering, which keeps line numbers and the
marked finding line in place; newlines and tabs are kept and CRLF is
read as LF.

Refs #200

* fix(cli): open audit findings in files the tree leaves out

The file tree skips dotfiles and stops at three levels and 200 entries,
but the audit scan reads root dotfiles and goes deeper. A finding in
such a file, like a root .env, left the viewer on the previous file
with the new finding's note above unrelated text. Opening a finding now
adds its file to the top of the tree under its full relative path when
it is missing, so the marked line is always the one reported.

Refs #200

* fix(devcontainer): exit nonzero when a TUI screenshot fails to record

record-tui.sh printed FAIL for a screen whose vhs run failed but still
exited 0, so an unattended run looked like every screenshot was taken.
It now remembers a failure, keeps cleaning up and recording the other
screens, and exits 1 at the end.

Refs #200

* fix(cli): keep other files' front matter and fit text to the pane

Two problems in the shared file viewer:

- It dropped YAML front matter from every Markdown file, so a trashed
  skill's README or template lost its metadata, which nothing else in
  the trash view shows. Only SKILL.md and a single-file agent drop it
  now, since their name and description appear in the details.
- The open file was wrapped to at least 40 columns. In a narrow
  terminal that is wider than the right pane, so the layout wrapped
  each row a second time, breaking lines apart and moving the marked
  finding line. Text now wraps to the pane's real width.

Refs #200

* fix(cli): keep frame lines within the terminal width

joinEnds padded the title, confirm and filter lines but never cut them,
so a long search query, path or command made the line wrap. Every TUI
sizes its body for a fixed four lines of frame, so the wrap pushed the
bottom of the body off the screen. Long text is now cut from the left
side, keeping the status or tabs on the right. Lines are left alone
until the terminal has reported its width.

Refs #200

* fix(cli): show a nested skill's folder when no group heading names it

List rows dropped the first path segment for every skill on the grounds
that the group heading above shows it. With a single group, or a filter
that leaves one, there is no heading, so frontend/react showed as just
react and same-named skills from two folders looked alike. Rows now
drop it only under a heading; a tracked skill's repo dir is still
dropped as before.

Refs #200

* fix(ui): let esc leave a prompt's filter after enter found nothing

The inline prompt guessed the filter state from key presses and treated
enter as leaving the filter. huh's Select stays in the filter when enter
has no match, so the next esc, meant to leave the filter, cancelled the
question instead: one folder level back in the large-repo picker, or the
whole install at the top. The prompt now asks the field whether it is
filtering.

Refs #200

* fix(cli): show control characters in the trash preview as symbols

The trash details panel prints the first lines of a trashed SKILL.md,
and it wrote them to the terminal as they were. The file viewers already
pass text through printableText so an ESC or OSC sequence in a skill is
shown instead of acted on; the preview now does the same.

Refs #200

* fix(cli): scroll an agent's text with the wheel anywhere in list

An open agent has no file tree, but the wheel still treated the left
quarter of the screen as the tree, so scrolling there did nothing. The
whole screen now scrolls the agent's text.

Refs #200

* fix(ui): read prompt answers after the prompt has run

The prompt helpers returned "value, runPrompt(..., &value)". The Go spec
leaves the order between reading value and the call unspecified, so a
compiler may return the value from before the user answered. gc 1.25
runs the call first, so answers arrive today, but nothing guarantees it.
Each helper now runs the prompt into err and then returns the value.

Refs #200

* fix(cli): name hidden Unicode and skip oversized files in the viewer

Two gaps in the file viewer used to inspect untrusted skills:

- Zero-width and bidirectional characters passed through unchanged,
  although the audit reports them as HIGH (Trojan Source). Opening such
  a finding reordered or hid the text instead of showing the cause.
  They now appear as <U+202E> and the like.
- Moving onto a file read all of it, then copied it again while
  numbering and wrapping, with no size limit. The audit skips files
  over 1 MB; the viewer now does too and says the file is too large.

Refs #200

* fix(cli): show control characters in viewed file names as symbols

File contents in the viewer already pass through printableText, but the
tree and the title printed file and skill names as they were. A file
named with an ESC sequence, a newline or a bidirectional character in a
skill under review could still reach the terminal, or break the frame
across lines. Names now go through printableName, which also shows a
newline or tab as a symbol so the name stays on one line.

Refs #200
2026-10-04 04:14:47 +08:00
Willie d78e7ce09a feat(cli): redesign init and give every command one output style (#360)
* fix(install): omit the empty audit section in dry-run

A dry-run skips the security audit, yet the single-skill path still printed
the "Audit Findings" heading with nothing under it, which reads as if the
audit ran and found an empty result.

* feat(init): ask first, confirm a summary, then write

The old init asked nine questions in three input styles and wrote files as
it went, so cancelling midway left a half-built setup, and detection created
tool folders even under --dry-run. Connecting a second machine to an
existing repo was only offered at the very end, and the built-in skill
defaulted to "no", which read as "not recommended" (#200).

init now collects every answer into a plan, shows a summary with Yes /
Change settings / Cancel, and writes nothing until confirmed. Esc cancels
cleanly. A "Connect my existing skillshare repo" path checks the repo
before writing, detects its layout, prefers the repo version of same-name
skills and keeps local-only ones for the next push. The built-in skill is
installed by default, and the first sync runs at the end so the tools work
right away. Prompts use one inline huh-based component with theme colors.

Without a terminal (CI, scripts, AI agents) init now applies the same
defaults as pressing Enter and prints each decision with the flag that
changes it, instead of silently doing less; init -p and --discover add the
detected tools. Output that is not a terminal is plain text.

BREAKING CHANGE: non-interactive `init` now enables git, installs the
built-in skill and selects every detected tool; pass --no-git, --no-skill,
--no-targets or --no-copy for the previous minimal setup. Piped or
redirected output no longer contains ANSI colors; use --json where offered
for machine-readable output.

Refs #200

* docs(init): show the new init flow and the connect-a-repo path

The getting-started page still described the old four-question wizard with
a screenshot of it, the second-machine guide never mentioned the new
"Connect my existing skillshare repo" choice, and the recipe told users to
run pull and sync after init even though init now does both.

Replace the screenshot with ones from the new flow, describe the questions,
summary and cancel behavior, and explain what connecting a repo does before
and after confirmation. The devcontainer example gains --no-git because
init without a terminal now turns git on by default.

Refs #200

* feat(devcontainer): seed fake tools and a repo with ssenv --seed

Trying init by hand needed several manual steps to fake installed AI tools
and a skills repo to connect. `ssenv create --seed` (and `ssnew --seed`)
now creates claude/codex/cursor directories with a few skills and a local
bare repo at ~/remote/skills.git, so both init paths can be tried at once.

Refs #200

* fix(ui): skip the logo on 16-color terminals and hide the cursor while it plays

`docker exec -it` sets only TERM=xterm, which reads as 16 colors: the logo
was mapped onto the terminal's own palette and its fade-in collapsed into a
few flickering cells. Below 256 colors the banner now prints only its text,
and the devcontainer sets COLORTERM=truecolor.

The visible cursor also jumped along the logo's left edge while frames
redrew in place. It is hidden during the animation and restored on exit,
including Ctrl+C.

Refs #200

* style(ui): color the question mark in prompts

The uncolored "?" before each question read like a stray character. It
now uses the accent color of the "›" cursor.

Refs #200

* fix(init): name the root git scope by what it versions

"everything" suggested plugins, MCP servers and hooks were versioned too,
but they live in config.yaml, which the root scope gitignores. The option
and summary now say "skills, agents, extras" and note that those settings
stay in each machine's config.yaml.

Refs #200

* feat(init): show --discover in the new init style

--discover still printed the old header, "agent(s)" counts and "+ name"
lists next to the new prompt. Global and project discover now share
init's answered rows (Tools, Config) and a Next line, and call the
targets "AI tools" as init's banner does.

Refs #200

* feat(init): replace the pixel logo with a SKILLSHARE wordmark

The half-block logo looked stretched on terminals with tall line height
and turned to mush when shrunk to fit. init now opens with a three-line
pixel wordmark, SKILL in blue and SHARE in gold, that lights up from left
to right, followed by the version and tagline on one dim line. The
generated logo data and its generator script are gone.

Without a terminal, without color, below 256 colors or on a narrow
terminal, the banner still prints a plain "skillshare vX" line.

Refs #200

* refactor(init): label the chosen tools "Targets"

init called them "Tools" while the rest of the CLI, the config file and
the `target` command call them targets. The answered rows and the summary
now say "Targets", the same label the other commands will use. Sentences
that describe what was detected ("Found 3 AI tools") stay as they are.

The docs tables, the First Sync steps and both init screenshots are
updated to match.

Refs #200

* feat(cli): ask yes/no questions with the inline prompt

uninstall, trash empty, extras remove, target add, collect, update,
upgrade and audit each printed their own "[y/N]:" line and parsed the
answer by hand, while init already used the inline Yes/No prompt. They
now share it: esc answers no, and a declined question prints one dim
"Cancelled. Nothing was …" line, as init's cancel now does too.

Without a terminal the prompt reads one line from stdin instead, so
piped answers such as `echo y | skillshare uninstall x` keep working.
It reads byte by byte so a second question still gets its own answer.

Refs #200

* feat(sync): report each target on one aligned row

Sync printed a ruled header, a "Backing up" block and a "name: merged
(43 linked, 0 local, 0 updated, 0 pruned)" line per target, so the
counts that changed were hard to find among zeros. It now follows the
init style: one row per target with only the non-zero counts, a single
Backup row, and a closing line with the duration. `sync --all` names
its Skills, Agents and Extras blocks and no longer explains how to set
up extras when none are configured.

The non-TTY text changes with it; `--json` stays the stable interface
for scripts. Tests match rows through the new AssertRowContains helper.

Refs #200

* feat(status): show targets as one table

Status printed each target as a header with indented skills and agents
lines full of bracketed modes and zero counts, and the audit policy as
four lines of uppercase labels. Comparing targets meant reading every
block. Each target is now one row with a skills and an agents column,
a single line names the modes in use, and audit and version take one
line each. Global and project mode share the renderer, so project
paths read relative to the project root.

Refs #200

* feat(install): report each step on one aligned row

Install printed a logo, a box-drawn tree, "Next Steps" bullets and a
separate "Audit Findings" block, so the result was hard to find. It now
uses the same rows as sync and status: Source, Audit and Install with
the destination folded to ~, then a closing line and a Next block.

Spinners write through a gate that Stop closes before clearing the line.
pterm's render goroutine checks IsActive and then writes, so a fast step
such as install --dry-run left "Copying files..." stuck in front of the
next line.

Refs #200

* feat(uninstall): confirm against one line and point at undo

Uninstall opened with a boxed header and Name/Path lines, and closed
with the trash folder path and a "Next Steps" bullet. Now one line names
the target, its folder and what it holds; the result is a single
"Uninstall x → trash, kept 7 days" row; and Next offers sync, the trash
restore command that undoes it, and the reinstall command when the
skill came from a remote source.

A batch run with --force or --dry-run no longer lists the targets twice,
since there is no question for the list to support. Mixed batches are
counted as items, not targets, which already names the AI tools.

Refs #200

* feat(update): report each skill or repo on one Update row

Update opened with an "Updating" header, the full source path and a
"0 tracked repo(s), 1 skill(s)" line, then printed a Changes box and two
success lines before "Next Steps". A single update is now an Update row
(source or commit count, time), the commits it pulled in dim text, the
Audit row, and Next. A batch ends with the audit result and one closing
line that leaves out zero counts.

Progress bars now clear themselves when they stop, like spinners, so a
finished batch no longer leaves "[3/3] ... 100% Done" behind.

Refs #200

* feat(check): list what needs attention and close with one line

Check opened with a header, the full source path and an item count,
counted skills with updates without naming them, and ended with two
"Run ..." hints. It now prints one row per repo, skill or agent that
needs attention (behind, update available, stale, failed), a closing
line that leaves out zero counts, and the update command under Next. A
single-name check is one row, like update.

Refs #200

* feat(push,pull): report commit, push and pull as aligned rows

Push and pull opened with a header and closed with "Push complete" or
"Pull complete", so they never said what they committed, where they
pushed, or what a pull brought in. Push now prints a Commit row (file
count and message) and a Push row naming the upstream branch, never the
remote URL since it can carry credentials. Pull prints a Pull row with
the commit and file counts and the commits themselves, as update does
for a tracked repository, before the sync output. Dry runs list the
changed files as ~ + - instead of raw porcelain codes, and error hints
are dim notes instead of info lines.

Refs #200

* feat(upgrade): report the CLI and the skill on one row each

Upgrade opened with the logo and printed a tree of steps per part
(current version, latest version, status) ending in "Already up to date
✓". Each part is now one row, such as "✓ CLI  v0.22.0 → v0.23.0 · 3.1s"
or "✓ Skill  v0.23.0, already up to date", with spinners that clear.
Sync is offered under Next only when the skill changed, and the star
request is a dim line at the end.

Refs #200

* feat(new): report the created skill on one row

New printed a "New Skill Created" header, the full path, and numbered
"Next steps" that told the user to edit the file and run sync. It now
prints "✓ Created  ~/…/SKILL.md", the folders a pattern added, and sync
under Next. A dry run shows the same row, a Preview section with the
template, and the dry-run line.

Refs #200

* feat(trash): list items and restores as aligned rows

The plain trash list printed each item as an info line with its size and
age in parentheses under a "Trash" header, and restore printed two
success/info lines plus a "Next Steps" label. The list is now rows of
name, size and age with one closing count, and restore is one row
naming where the item went back, with sync under Next. An item trashed
under a minute ago reads "just now" instead of "just now ago".

Refs #200

* feat(collect): list local items and results as aligned rows

Collect opened with a header, listed local items as "[target] path"
list items under a second header, then printed a third header before
the per-item results and a metric summary line. It now lists each local
item as a row (name, target, path), asks the inline confirm, prints one
row per result and closes with "Collected N skills" plus sync and,
when the source is a git repository, commit under Next.

Refs #200

* feat(hooks): show hooks and their changes as aligned rows

Hooks printed "Hooks source: <path>" as an info line, statuses through
the fixed-width Status helper, and results as sentences ending in
"Run 'skillshare hooks sync' when ready." Hooks and Agent file changes
are now rows, with conflicts marked as failures and inactive outputs as
warnings, saves and applies close with one line, and the next command
sits under Next. The list's "Pending sync" section no longer shows
entries that are already in place.

Refs #200

* feat(mcp): show servers, changes and checks as aligned rows

MCP printed "MCP source: <path>" as an info line, plan changes through
the fixed-width Status helper, results as sentences that named the next
command inline, and check summaries as "2 server(s) checked: 1
error(s)". Changes and parked servers are now rows with conflicts
marked as failures, saves and applies close with one line and Next, and
check marks each server with its findings beneath and closes with
"Checked 2 servers: 1 error". The Status helper had no callers left and
is removed.

Refs #200

* feat(plugin): show packages, plans and results as aligned rows

Plugin text output was raw "name · target · id · state" lines with
"Warning:", "Includes:" and "Revision:" prefixes, and the list walked a
map so packages came out in a different order each run. Packages,
discovered candidates, planned changes and results are now rows sorted
by name, marked by state (registered, not installed, pending, blocked,
failed), with details as dim notes and the dry-run line after a
preview. JSON output is unchanged.

Refs #200

* feat(audit): replace header and summary boxes with rows

Audit framed its context in a header box (mode, path, block rule,
policy), numbered batch results "[1/2]", printed per-skill verdicts as
"→ Aggregate risk / Block decision" lines, and closed with a Summary box
that listed every count including zeros. The context is now one title
line with a dim note, flagged skills are aligned rows with their highest
severity, the summary leaves out zero counts, and the run closes with
one line saying whether anything was blocked and by which severity,
followed by the command to see the first blocked skill's findings.

The progress bar no longer writes its final frame when stdout is not a
terminal; that frame had no newline and ran into the next line.

Refs #200

* feat(audit): show audit rules as aligned rows

The rules list was a fixed-width table framed by 90-character dividers
with a "(N rules: N enabled, N disabled)" footer, and rule changes were
sentences like "Set severity for X → HIGH". Rules are now rows keyed by
ID with a colored severity and the pattern dimmed, disabled rules dim
as a whole, the list closes with a count that names disabled rules only
when there are some, and each change is one row.

Refs #200

* feat(search): drop the logo and tree, show results as rows

Search opened with the ASCII logo, drew its progress as a ├─/└─ tree,
listed results under a column header with dividers, and ended installs
with "Run 'skillshare sync' to distribute to all targets". Results are
now aligned rows with the source, stars or risk, and the description
and tags beneath; a single install reports the same Install row as
`skillshare install`; batch installs list only failures before one Done
line; and sync and audit sit under Next. Login and rate-limit problems
name the command that fixes them. Non-terminal output no longer prints
a "name: installing..." line per skill.

Refs #200

* feat(backup): show backups and restores as rows with one closing line

Backup and restore opened with headers, announced dry runs with a
warning before doing anything, summarized with an operation box, and
followed a backup with a "Recent backups" list. Targets now back up in
name order as rows with folded paths, runs close with one Done line
(and Next restore), listings are rows keyed by timestamp or path with a
total, and dry runs end with the shared dry-run line. Cleanup reports
how many backups remain instead of a separate "Current" line.

Refs #200

* feat(help): one line per command, subcommands in each command's help

The top-level help opened with the ASCII logo and listed about 70 lines
across ten uppercase sections plus 15 examples, so it did not fit a
screen, yet it left out analyze and the common options. It now lists
each command once in six groups with the common options, and points to
`<command> --help` for subcommands. The mcp, plugin, hooks and extras
pages use the same layout and keep all their content.

A mistyped command prints one error with the closest command instead
of the whole help, a lone option such as --no-tui shows the help, and
`skillshare version` prints one line.

Refs #200

* feat(extras): show extras and their changes as rows with Next

Extras printed a header, "→ name" lines with ad-hoc colored marks
(including ✗ for targets that were only waiting for a sync), and ended
each change with a sentence naming the next command. The list now shows
each extra as a bold name over aligned target rows (! for drift or not
synced) and closes with a count and, when something is pending, Next
sync extras. Init, collect, add/remove target, mode and source changes
close with one Done line, details become notes, and dry-run collect
ends with the shared dry-run line.

Refs #200

* feat(target): show targets as sections and rows with Next

Target info and the plain list printed "Key:" lines at two indent
levels, with "(none)" for every unset filter, and remove printed
"Backing up" / "Unlinking" headers with one line per step. Info now
shows the name over Skills and Agents sections with aligned rows, the
list gives each target one row per resource with details dimmed, and
empty filters are left out. Remove reports one row per target (plus
its backups) and closes with a Done count; dry runs say what would
happen per target and end with the shared dry-run line. Skills on/off,
add and mode/naming/filter changes close with Done and Next.

Refs #200

* feat(doctor): report checks as aligned rows and end with Next

Doctor opened with the ASCII logo, split its report under divider
headers, mixed ✓/→/! lines with full paths and "(s)" counts, listed
targets in random map order, and ended with a bare warning count that
left the fix to scattered "Run:" hints. Checks now print as aligned
rows under bold sections (Environment, Targets, Extras, MCP/hooks/
plugins, Storage, Version), paths fold to ~, targets are sorted with
one row per resource, and the report closes with a Done line plus up
to three Next commands collected from the checks (sync, sync agents,
sync hooks, upgrade, ...). The --json output is unchanged.

Refs #200

* feat(hub): drop the logo and report hub changes with Done

hub index opened with the ASCII logo and a tree of spinner steps, then
repeated the result as "→ Mode / Skills / Output" lines with the full
path. It now shows one spinner that clears itself and a Done line
naming the folded output path, skill count and duration, with the
index contents as a note. hub list shows aligned rows with the default
and built-in hubs marked in dim text instead of a "*" column, and the
add, remove and default commands close with a Done line.

Refs #200

* test(install): match the shared dry-run line in online tests

The online-tagged install tests still looked for the old "dry-run"
banner, which install no longer prints since the restyle. They are
skipped by default, so the mismatch only showed under -tags online.

Refs #200

* fix(target): align remove rows on target names only

The label column was sized for "<name>-agents" so an agents backup
could fit, which left a wide gap on every row when no agents were
backed up. The agents backup row now uses the target name too and says
"agents backed up", so the column fits the names.

Refs #200

* fix(update): list each item in a batch dry run

A batch dry run only said "Would update N skills". Off a terminal the
names leaked out through the progress bar's title lines, but on a
terminal those lines clear, so the dry run never said which skills or
repos it would touch. It now prints one Update row per item, as the
single-item dry run does.

Refs #200

* fix(ui): keep the progress bar silent off a terminal

Off a terminal the bar printed "Title (0/N)", every title change and
every phase header as permanent lines, which a terminal shows only as
a frame that clears itself. Audit left a stale "Scanning skills (0/7)"
line, and scripts saw different content than a terminal. The bar now
prints nothing off a terminal, like the spinner.

Refs #200

* fix(audit): avoid a double blank line before Summary

The audit header ends with a blank line and Summary added its own, so
a clean scan with no result rows showed two blank lines in a row. The
Summary title no longer adds one; the result rows add it when present.

Refs #200

* fix(mcp): drop the blank line above "Saved the MCP source"

A save with no backup or migration notes printed a blank line with
nothing above it, so mcp add and mcp edit opened on an empty line.

Refs #200

* fix(doctor): stop repeating the extra's name in its findings

Extras findings printed "rules  rules → /home/me/.claude/rules: 1
file(s) out of sync": the row label already names the extra, the path
was not folded to ~, and the count used "file(s)". The rows now start
at the arrow, fold the path and pluralize the count. JSON details keep
the extra's name so each line still stands alone.

Refs #200

* fix(doctor): show integrity issues as rows under Integrity

Tampered skills and missing hashes printed as free "! Skill integrity:
N skill(s) ..." lines after the verified row, breaking the aligned
Environment rows. They now sit under a single Integrity row, which
turns to ! when any skill has an issue.

Refs #200

* fix(doctor): pluralize the Skillignore and Trash rows

The rows read "1 patterns, 1 skills ignored" and "1 item(s) (50 B),
oldest <1 day". They now read "1 pattern, 1 skill ignored" and "1 item,
50 B · oldest under a day". The JSON messages keep their wording, since
scripts may match on them.

Refs #200

* docs: show the restyled output of batch 3 commands

The reference pages still showed the old output of upgrade, new, trash,
collect, audit, search, backup, restore, extras, hub, target and doctor:
divider headers, arrow-prefixed lines and "(s)" plurals. The examples
now match what the commands print, in all five locales, and the doctor
check table uses the new row labels.

Refs #200

* feat(trash): let trash empty skip its confirmation with --force

Scripts had no way to empty the trash: off a terminal the confirmation
reads stdin and cancels on EOF. --force (-f) skips it, as it does for
uninstall and extras remove.

Refs #200

* fix(doctor): show source, link and target problems as rows

Missing sources, unsupported links, folders without SKILL.md, unknown
skill targets, bad include/exclude patterns and broken symlinks printed
as free "✗ Source not found: …" lines between the aligned rows. They
now use the row of the check they belong to, and broken symlinks or a
missing source add a Next suggestion.

Refs #200

* fix(ui): leave out durations that would read 0.0s

Fast commands ended with "· 0.0s", which says nothing. Every result line
now formats its time through ui.Took, which init already used for its
steps: durations under 0.05s are left out.

Refs #200

* fix(ui): print dev builds without a v prefix

Version labels were built as "v" + version everywhere, so a dev
build printed "vdev". VersionLabel adds the prefix only when the
version starts with a digit, and the logo, help header, version
command and upgrade output share it.

Refs #200

* fix: pluralize category and drop "just now ago"

The checklist status bar appended "s" to its item name and printed
"categorys". The trash TUI formatted ages with its own helper that
added "ago" after "just now". plural now handles consonant + y,
and the trash TUI uses the shared timeAgo, which makes formatAge
unused.

Refs #200

* fix(target): drop the parenthesized counts in the plain list

The plain target list printed "merged (43 shared, 0 local)" while
target info and doctor print "merged · 43 shared" with zero counts
left out. The sync summary now returns both forms from one scan, so
the TUI and --json keep their existing text and the plain list
matches the other commands.

Refs #200

* test(backup): make the agents backup test back something up

The test only synced agents, which become symlinks into the source
and are skipped by backup, so it passed without any backup being
written. It now adds a target-local agent and checks that the file
lands in the backup.

Refs #200

* refactor(cli): render every command's --help with printHelp

About forty help pages were hand-aligned raw strings with "Usage:",
"Options:" and "Examples:" headings, while hooks, mcp, plugin, extras
and the top-level help already used printHelp. They now share it, so
headings, option order (short flag first) and alignment match across
commands. Examples align on their own column so long commands no
longer push option descriptions to the right, and "--help, -h" rows
are dropped as on the converted pages.

Refs #200

* feat(enable): print enable and disable results as rows

enable/disable still used the old "Disabled: x (added to .skillignore)"
line plus a "Run skillshare sync" sentence. They now print one row per
pattern, a Next hint after a change, and the dry-run closing line,
like the other restyled commands.

Refs #200

* fix(sync): pluralize the leftover cleanup note

Project sync printed "Cleaned 1 leftover skill(s)". The note now
uses the singular or plural noun, and the sync docs show it as the
dim note it is instead of an arrow line.

Refs #200

* fix(cli): drop the arrow info lines left in install, update and sync

These commands were restyled, but about fifty messages still went
through ui.Info, which prints a leading arrow, and several said
"skill(s)" or "item(s)". Hints now print as dim notes, empty results
("No agents found") as closing lines, follow-up commands as Next,
and counts use the singular or plural noun.

Refs #200

* fix(cli): tidy small leftovers found in the recorded output

doctor printed "0 minutes ago" for a fresh backup and an ASCII arrow in
the Update row, unlike trash and upgrade, which say "just now" and
"v1.2.0 → v1.3.0". The "bring the Targets up to date" hint capitalized
a word mid-sentence, and search --list showed hub sources under the
home directory as a cut-off absolute path instead of folding it to ~.
JSON messages keep their wording.

Refs #200

* fix(search): fit a home-folded source path in the list

Folding the home directory to ~ was not enough: a typical local hub
path such as ~/.config/skillshare/skills/frontend/react is 42
characters, so the 40-character cap still cut it. Fifty characters
next to the 24-character name column stays within 80 columns.

Refs #200

* feat(list): print the plain list with rows and a closing count

The --no-tui list still used the old header with a divider and an arrow
on every skill, so it looked unlike every other restyled command. Skills
now line up in one column under their group, tracked repos use the
✓ / ! marks, and the list closes with a count split by tracked, remote
and local (zero counts left out). Project mode keeps its scope as a dim
"· project" after the title.

Global and project had copied the same plain-output code; both now call
printSkillList. The loading spinner clears itself instead of leaving a
"Loaded N skills" line.

Refs #200

* fix(cli): show help for subcommand --help instead of running it

target add/remove/list, trash list/empty and hub list/remove passed
--help through as an argument, so they ran the command, failed on a
target or hub named "--help", or rejected the flag. tui on --help even
switched the TUI on. Each now prints its command's help page.

The tui status and toggle lines also move to the row and Done style.

Refs #200

* feat(diff): print differences as rows and close with next steps

The plain diff still printed a Summary line, divider headers, arrow
hints and per-target "scanning" lines when output was not a terminal.
Each group of targets now lists one row per kind of change ("New  a,
b"), targets in sync share a single ✓ row, extras use the same rows,
and diff closes with a count and up to three commands. The suggested
sync command follows what differs: sync, sync agents, sync extras or
sync --all.

Agents no longer show as "New 1 skill", because rows name the change
rather than counting skills. "skillshare diff all", listed in the help,
failed with "target 'all' not found"; it now diffs everything, the
same as no argument.

Refs #200

* test: sync the install warning summary and gofmt two status tests

The "6 findings" wording changed in an earlier commit, but the unit
test under cmd/ still expected "6 finding(s)": scripts/test.sh and
make check only run ./internal and ./tests, so the cmd tests never ran.
Two status tests also had comment alignment gofmt rejects, which fails
make check's fmt-check.

Refs #200

* test: run the cmd unit tests in scripts/test.sh

CI runs go test ./cmd/skillshare/... ./internal/..., but the local
runner behind make test and make check only ran ./internal/..., so a
stale assertion in cmd/skillshare passed locally and would only fail
in CI.

Refs #200

* feat(cli): restyle commit and analyze output

commit and analyze were the last git and inspection commands still
printing the old header and table layouts. They now use the same rows,
Done line, and Next hints as push and pull, so a commit reads like the
commit row of push, and analyze shows each target group as a bold name
with aligned token rows instead of a boxed table.

Refs #200

* feat(log): show entries as rows and fold the log path

The plain log view still opened each section with a boxed header that
printed the absolute log path, then a TIME | CMD | STATUS table. Entries
now read like every other command: a status mark, the command, when it
ran and how long it took, with details indented beneath. The log path is
folded to ~ and moves to a dim footnote.

log --stats drops its divider and ends with one summary line. It and
the TUI stats panel said "just now ago" for a fresh entry; both now use
timeAgo, which already handles that case.

Refs #200

* feat(cli): restyle completion, ui and leftover arrow lines

completion --install, ui start/stop and a few notices still printed
arrow info lines with absolute paths. They now end with a Done line,
fold paths to ~, and give config-file lines their own bold heading so
the lines to paste read apart from the hints. The empty extras TUI now
says the same thing as extras list.

Refs #200

* feat(init): report git changes on an existing setup as rows

init --remote and init --git-root on an existing setup still printed
arrow lines with absolute paths and spinner results in a different
voice. They now print aligned Git, Remote, Pull and Git root rows like
a fresh init, end a dry run with the shared Dry run line, and give the
choices after a remote check as Next commands.

A source repo the user created before init had no fallback identity,
so on a machine without git config the follow-up commit failed and
dumped git's whole "Please tell me who you are" message. The existing
repo now gets the same local fallback a new one does.

Refs #200

* feat(doctor): warn when a newer built-in skill is published

status already compared the skillshare skill with the published one,
but doctor only printed the local version, so a run meant to find
problems called an old skill healthy. doctor now fetches the published
version alongside the CLI update check and suggests upgrade --skill.

Both commands share a semver comparison. status compared with !=, so a
skill ahead of main (a dev build) was reported as having an update.

Refs #200

* fix(cli): count batch audit warnings in words and clear progress spinners

The batch install and update audit summary still printed "2 skill(s)"
and "warning(s)" after the rest of the output switched to "1 skill" /
"2 skills". uninstall and agent update also left "Found N skills" and
"Check complete" behind, progress messages the restyle clears.

Refs #200

* fix(cli): say so when diff or analyze has no targets

With no targets configured, diff reported "No differences" and analyze
printed only its "Add -v" hint, both reading like a healthy result.
They now say no targets are configured and suggest target add, as
target list does.

Refs #200

* fix(diff): align values across target sections

Each target section sized its labels on its own, so a section with
"Local only" started its values two columns later than one with only
"New", and the list read ragged. All sections now share one width.

Refs #200

* fix(doctor): count built-in skill warnings in the summary

The skill rows (not found, missing version, newer version available)
were marked as warnings and counted by --json, but never reached the
text summary, so doctor could print "! Skill not found" and close with
"All checks passed". The all-good integration test only passed because
of this; it now installs the built-in skill it needs.

Refs #200

* fix(init): stop writing a git identity into existing repos

On a repo the user created, init stored skillshare@local in the repo
config so its one commit would work. That setting outranks --global,
so the advice we printed never took effect and later pushes went out
as skillshare@local. The commit now gets the fallback through env
vars only. The note for repos init creates names the repo-level
command that actually overrides it.

Dry runs also wrote .gitignore into existing repos while closing with
"nothing was written", and warned about --no-git when it was not
passed; both now only describe what would happen.

Refs #200

* fix(cli): tell "no targets" apart from "nothing reaches them"

diff and analyze said "No targets configured" and suggested adding one
whenever there was nothing to show, including when targets exist but
have skills turned off or no skill is meant for them.

Refs #200

* fix(log): drop the trailing separator on instant entries

Entries with no recorded duration ended in a dangling " · ". Also
removes the formatRelativeTime alias the stats restyle left unused;
its test now covers formatDurationShort directly.

Refs #200

* docs: match tui, project list and log examples to the real output

The tui and project list examples used label widths the CLI does not
print, and the plain log example claimed to show non-TTY output, which
joins each entry's details on one line.

Refs #200

* perf(version): cache the published skill version for a day

doctor and status asked GitHub for the latest skill version on every
run, adding up to 3 s when offline. They now reuse the answer for 24
hours, the same interval the CLI update check caches for. upgrade
--skill still fetches fresh and records what it got.

Refs #200

* perf(server): reuse the cached skill version on the dashboard

The version endpoint fetched the published skill version on every
call, like doctor and status did, so it now shares their 24-hour
cache. It also treated any difference as an update, offering a
"newer" skill to anyone running a local build ahead of main.

Refs #200

* test(redteam): match the restyled update --diff heading

update --diff now titles its file list "Files changed" in sentence case,
like every other section, so the check for the list looked for the old
"Files Changed" box title and failed although the list was there.

Refs #200

* test(cli): keep /tmp fixtures unfolded where HOME is /tmp

scripts/test.sh now runs the cmd unit tests, so the docker sandbox runs
them too, with HOME=/tmp. shortenPath then folds the /tmp fixtures in
four tests to ~ and their exact-path checks fail. The tests now point
the cached home elsewhere while they run.

Refs #200

* fix(init): find skills/ in a repo that holds nothing else

The check for a skills/ folder ran only when the repo root had no skill
folders, but it counted skills/ itself as one, so it never ran. A repo
with only skills/ became the source as a whole, one level too high.

Refs #200

* fix(init): keep the skills git scope for a custom source

With a remote that has no skills yet, init defaulted to versioning the
whole skillshare folder. For a --source outside that folder it holds
none of the user's skills, so the commit and every later push carried
nothing while init reported the remote as linked.

Refs #200

* test(sync): check only the Agents section for updated agents

The restyle turned the old "0 updated" check on the agent summary into
"no 'updated' anywhere", which also covered the Skills section. On
macOS the first project sync reports the skill as updated there, so
the test failed on something it was never meant to check.

Refs #200
2026-10-03 21:43:35 +08:00
Willie cf36965cea feat(website): add zh-Hant/zh-Hans/ja/ko locales with initial docs translation
Sets up Docusaurus i18n for Traditional Chinese, Simplified Chinese,
Japanese, and Korean: locale config, navbar/footer/sidebar UI chrome,
and translated content for intro, getting-started, understand, and
reference/commands. Untranslated pages fall back to English.

Pins explicit heading anchors ({#id}) on English source pages that are
linked to by fragment, so translated headings don't change the anchor
id and break cross-page links. Converts a handful of relative .md
links that crossed from an untranslated page into a now-translated
one, since Docusaurus resolves those per-locale and they'd otherwise
404 outside English.
2026-09-20 11:08:48 +08:00
Willie 4bcd569e25 feat: MCP connections, plugins and a redesigned dashboard (v0.21.0) (#285)
* feat(mcp): sync portable server configuration across six clients

Add inline and external MCP sources with guided CLI and dashboard setup, native imports, conflict previews, ownership tracking, backups, and restore. Support Claude Code, Codex, Cursor, VS Code, OpenCode, and Grok CLI in global and project scopes.

Format YAML on save, document MCP fields in the config assistant, and keep its layout stable for scalar list items. Include schemas, localized UI copy, documentation, and regression and end-to-end coverage.

* fix(config): keep loading config when the MCP section is invalid

A mistake in the mcp section (an unknown key, a targets value that is
not a list, an invalid server field) made config.Load, LoadProject,
Save, SaveIn and ValidateConfig fail. Every command that reads config,
including skills sync, install, list and the dashboard, stopped working
because of settings it never uses.

MCPConfig now keeps a section that does not parse exactly as written and
records the error instead of returning it, so commands unrelated to MCP
load and save the config without touching that section. MCP commands
still validate their source on every run, and the dashboard config
editor calls the new ValidateMCP, so saving an invalid MCP section there
is still rejected.

Also correct the ProjectSources comment: sources.mcp resolves from the
directory containing config.yaml, not from the project root.

* fix(mcp): protect Agent files during concurrent edits and recovery

A release review of the MCP sync engine found ways it could lock users
out, report false conflicts, or change entries it does not own.

Recovery
- A failed write left pending.json behind, and every later MCP command
  refused to run. Failed writes now remove their journal, and a journal
  whose Agent file changed again is discarded, because ownership hashes
  still flag entries that no longer match.
- Preview no longer writes. It reads the ownership that recovery will
  record, byte for byte, so a preview stays valid across the recovery
  that the next write performs under the lock.

Concurrent Agent writes
- Claude Code rewrites ~/.claude.json on its own, so hashing whole files
  expired previews and failed applies. Revisions and pre-write checks
  now cover only the MCP entries, and apply rereads each file and applies
  the previewed entry edits to its current content, keeping settings the
  Agent wrote after the preview.

Comparison and ownership
- Only fields Skillshare renders are hashed, after dropping defaults
  Agents add or omit (type stdio/http, empty env, args or headers,
  enabled: true) and header name case, so equivalent entries are not
  reported as drift. enabled and disabled are compared, so turning off a
  managed server is a conflict instead of being overwritten.
- An unmanaged entry that already matches the source is reported as
  unchanged but no longer claimed, so removing the server never deletes
  an entry the user wrote. Import adopts it explicitly, and without
  --replace refuses to rewrite a differing entry, such as a literal token
  that import turned into an environment reference.
- Sync keeps Agent-only fields such as timeouts in existing entries.

Import
- Agent-only fields become warnings instead of blocking the import.
- streamable-http is accepted, and enabled/disabled flags are checked
  for every client.
- Values carrying a URL password, such as database DSNs, become
  environment references, and credential-like arguments are flagged.

Writes and state
- Save only renders the definition first, so a server that could never
  sync, such as one without targets, is rejected before it is saved.
- A symlinked config.yaml is written through to its target.
- TOML entries are updated in place, keep CRLF line endings, and repeated
  add/remove cycles no longer grow blank lines.
- JSON edits no longer HTML-escape characters such as &.
- GROK_HOME is honored.
- Backups keep the newest 20 per Agent file, pruned by file name, and
  damaged backup files are skipped instead of failing the list.
- GET /api/mcp no longer fails when an Agent that no server uses has an
  unresolvable path.

* feat(mcp): detect the client format of pasted JSON

Import without --from, the add wizard and the dashboard import API
assumed Claude's mcpServers shape unless a client was named, so VS Code
"servers" and OpenCode "mcp" snippets copied from server docs failed to
import. The client is now chosen by the top-level key, and a bare server
object still reads as Claude's single-entry shape.

TOML stays explicit because Codex and Grok share the format; a .toml
file without --from is still read as Codex.

* refactor(mcp): print CLI results through internal/ui

MCP commands wrote plain fmt output and duplicated statusFromErr, unlike
every other command. Plans, backup IDs and save/apply messages now use
the shared ui helpers, so they get the standard status prefixes and
colors; each change line shows the server name, action and target. The
operation log uses statusFromErr. --json output is unchanged.

* fix(server): serve MCP settings only to localhost or IP hosts

MCP settings include stdio commands that Agents execute, so a web page
must not be able to read or change them. The existing Origin check does
not stop DNS rebinding: once an attacker's domain resolves to 127.0.0.1,
the browser sends that domain as both Origin and Host from a loopback
address, and the dashboard also binds 0.0.0.0 in Docker.

Rebinding always needs a domain name, so every MCP route now also
requires a Host that is localhost or an IP literal, whatever the bind
address. Other dashboard routes are unaffected. Opening the dashboard
through a domain name, including a reverse proxy, therefore returns 403
for MCP settings; the message says to use localhost or an IP address,
because rewriting Host at the proxy would still fail the Origin check
and would reopen the hole.

Remove the unused POST /api/mcp/sync endpoint. Configuring with sync
covers it, and the guard wraps every remaining MCP route.

* fix(sync): make sync --all report MCP results reliably

- "sync -g mcp" and "sync --dry-run mcp" ran skills sync, because mcp
  was only recognized as the first argument. It now matches in any
  position.
- sync --all --json printed plain-text errors when the MCP preflight
  failed, and only an error on conflicts. Preflight errors now use the
  JSON error shape, and conflicts also return the credential-free plan so
  scripts can see which entries conflict.
- When resource sync failed, MCP was skipped without notice. Text output
  now warns that MCP settings were not applied; JSON output omits the mcp
  field, which --all otherwise always includes.
- MCP was applied with the preflight revision, which failed whenever the
  resource sync changed config or state in between. It is now planned
  again under the MCP lock, and conflicts found then still stop the
  write.

* fix(sync): recognize agents and extras after flags

sync only checked the first argument for a resource kind, so
"sync --dry-run agents" and "sync -g extras" silently synchronized
skills instead. Sync flags take no values, so the kind now matches in
any position.

The shared parseKindArg keeps its first-argument rule: uninstall, update
and similar commands accept resource names, and a name such as "agents"
must not be read as a kind.

* feat(ui): redesign the MCP dashboard around a server-by-agent matrix

The MCP page listed servers and planned changes as flat text, which made
it hard to see where each server is written and what needs attention.

- A matrix shows each server's status per Agent, summarizes pending
  changes and conflicts, and can hide synced entries. Agents whose MCP
  file or config directory exists are marked as detected; GET /api/mcp
  now returns the detected clients.
- Setup is a two-step dialog: add a remote URL, paste JSON or TOML, or
  import from an Agent, then preview which Agent files change. Importing
  an entry the Agent already has adopts it, Replace overrides only that
  entry, and a target selection equal to the inherited mcp.targets is
  saved without pinning targets on the server.
- Conflicts explain their cause and offer Import from <agent> or
  Replace. Removal lists the affected Agent files and offers removing
  from the source only or removing and syncing. Backups are grouped by
  day, with a preview before restoring a file.
- Agent icons appear on the MCP and Targets pages, and the universal
  target is marked as a path shared across agents. Brand icons come from
  @lobehub/icons-static-svg, with bundled SVGs for Warp and Zed.
- Segmented controls wrap instead of overflowing narrow containers.
- New copy is translated for every supported locale.

* fix(ui): let Sync all apply MCP after syncing resources

Sync all previewed MCP, synced skills, agents and extras, then applied
MCP with the revision from the first preview. When the resource sync
changed config or state, that revision was stale and MCP failed with
"preview again" after everything else had already been synced.

MCP is now rechecked before and after the resource sync by comparing the
reviewed changes (target, name and action) instead of the revision, and
applied with the fresh revision. A different set of changes still stops
before any MCP file is written.

* fix(ui): keep flow-style YAML collections when saving config

Formatting on save forced every collection into block style, so a
hand-written "targets: [claude, codex]" was expanded into a list each
time the config was saved. Each collection now keeps its flow or block
style, indentation is still normalized and comments are preserved, and
flow collections are not padded with spaces.

* docs(mcp): document ownership, normalization and dashboard host rules

- Explain that matching entries stay unmanaged until imported, so
  removing a server leaves them in place, and that import adopts an
  identical entry while --replace rewrites a differing one.
- Note that Agent defaults and header case are not treated as changes,
  that disabling a managed server is a conflict, and that previews stay
  valid while an Agent rewrites unrelated settings.
- Describe Agent-specific fields, streamable-http, GROK_HOME, backup
  retention, recovery by the next MCP write, and the VS Code limitation
  on environment references in headers.
- Document that MCP settings require opening the dashboard by localhost
  or an IP address, with SSH port forwarding for remote machines.
- Update the built-in skill for all six clients and the adoption rule,
  and the MCP runbook for import refusal, Agent-specific fields and
  pulled changes.

* docs(skill): streamline guidance and refresh resource workflows

Keep the built-in skill entrypoint focused and route agent and MCP details to dedicated references. Correct scope, audit, automation, and recovery guidance against the current CLI.

* feat(ui): redesign the dashboard around two styles and a flatter layout

The dashboard had grown page by page, so the same idea looked different
depending on where you met it and pages held controls with nothing to act on.
This rebuilds it on one token set that drives both the Clean and Playful styles
in light and dark, and reshapes the pages around what a person actually does.

Notable changes:

- MCP: replace the server-by-agent matrix with one row per server. The agents a
  server writes to are chips inside the row, so the list grows downwards as more
  CLIs gain MCP support instead of scrolling sideways.
- Settings: collect General, Backup, Log, Health, Extensions and Files into one
  page. The Files tab keeps a panel beside the editor showing what the field
  under the cursor does, the file's shape, or the unsaved changes.
- Audit rules: the YAML editor gets the same panel, plus a Test tab that runs a
  rule's regex against pasted lines.
- Skills and Agents become separate pages; install, search, updates and trash
  move into them. Old routes redirect.
- Tour: rewrite every step's copy, add MCP and Install steps, and anchor each
  step to a control that is always rendered so no step silently times out.
- Give every button a pointer cursor; the browser default does not say a button
  is clickable and each component class had to opt in by hand.

Docs follow the new Settings tabs and the MCP list.

* chore(devcontainer): move dev servers to uncommon ports

5173, 19420 and 8888 are defaults that other projects on the same
machine already hold, so `make devc` failed to bind and the container
never started. Use 45173, 49420 and 48888 instead, identical inside and
outside the container so every banner, log and doc prints the URL that
actually works.

* feat(ui): link dashboard source counts to their pages

The counts in the playful dashboard's source note named a number but led
nowhere, so reaching Skills or MCP from there meant going back to the
sidebar. Each row is now a link to its own page.

The hover fill uses currentColor because .ss-pinnote.src overrides the ink
tokens for the yellow note.

* feat(ui): build and browse hubs from the dashboard

A hub is a JSON index that lists skills, and until now the web UI could
only consume one someone else had already hosted. Writing the index by
hand was the only way to produce one, and the two halves never met: the
dialog that searched hubs and the page that would have built one shared a
config file but nothing else.

The new /hubs page holds both halves behind two tabs:

  Browse   pick a hub, filter its contents by tag or text, install from it
           without leaving the page
  My hubs  assemble an index from installed skills, validate it, export it

A draft is offered as a source in Browse straight away, read from the
draft API rather than a file, so you can see what a recipient sees before
deciding whether to host anything. Where the index is hosted is stored on
the draft and stripped from the exported document, so a reopened hub
remembers where it was published and the published file stays clean.

Hub management moves out of the install dialog, which keeps only the
search-source dropdown and links here.

Routing switches to createBrowserRouter for useBlocker, which guards the
builder against navigating away from unsaved entries.

* docs(extras): add shared instructions recipe for AGENTS.md across agents

Answers a recurring question about sharing one instruction file between AI
agents: extras already covers it, since each agent keeps its user-level
copy in its own directory and one extra can target all of them.

Naming the source file AGENTS.md rather than something neutral matters —
Codex concatenates AGENTS.md files and has no import syntax, so it only
recognises the file by name. Claude Code and Antigravity read a fixed
filename of their own but resolve @-imports, so a one-line CLAUDE.md or
GEMINI.md picks up the synced file.

Says plainly that this is not agent memory. Agents keep their own
learnings in private stores — a Markdown directory for Claude Code, a
database for Codex, non-file storage for Cursor — so that side is a
migration problem, not something syncing files can solve.

* feat(ui): filter skills and agents by target

The Targets column showed which targets a resource reaches, but there was
no way to narrow the list down to one. The filter reads the sync matrix —
the same source that column renders — so a result always matches the icons
the rows show.

Options and counts are derived from the matrix, so no target is offered
that would filter to nothing, and the control stays hidden until at least
two targets have something. A selected target that disappears on a kind
switch or an uninstall falls back to All rather than emptying the list.

The toolbar had 24px to spare at 1440px, so the new control wrapped the
row. Source moves from a 325px segmented control to a dropdown like its
neighbours, and every filter now sizes to its label instead of a fixed
width that truncated the longer values.

* fix(ui): tighten page headers and reach hubs from skills

PageHeader carried mb-7 while .ss-wrap already separates its children with a
28px flex gap. Margins and flex gaps add up rather than collapse, so every
page inside the wrapper opened with a 56px hole under its title. Move the
default onto .ss-pgh so the wrapper can zero it, keeping the 28px for pages
that lay out their own children.

Hubs is a source you install from and a catalog you publish, not inventory
you own, so it no longer sits in the Library group next to Skills, Agents and
Plugins. The Skills page header already links to it and the page already
carries a back link there. Skills stays highlighted while the hub page is
open. Plugins takes the Package icon its own page identifies with, so the
sidebar no longer shows two identical puzzle pieces.

* fix(skill): stop implement-feature from running --no-tui as a command

The dispatch-order note wrote "not --no-tui" as !`--no-tui`. In a skill file
that is the syntax for running a shell command at load time, so the skill died
with "command not found: --no-tui" before any of it could be read. Spell the
condition out in words instead.

* feat(list): toggle model invocation for a skill with M

The only cheap gesture in the list TUI was E, which hides a skill from every
harness. Wanting a skill installed but not auto-loaded meant leaving the TUI
to edit SKILL.md, so people disabled skills they only meant to make
manual-only. M flips disable-model-invocation in place and the detail panel
shows a "manual only" badge so the state is never a blind toggle.

Unlike E this edits the skill file, which upstream may own: update skips
tracked repos with local changes, and reinstalling a skill drops the edit. M
says so and asks before writing in those cases. The flag is written as a
single-line edit rather than a YAML round-trip, and turning it back off
removes the line, so two presses return the file byte for byte and a tracked
repo is clean again. Agents are left alone; their harnesses do not read the key.

Refs #283

* feat(plugin): manage complete plugins across agent tools

Add CLI, TUI, and web flows for discovery, adoption, sync selection, updates, and removal while preserving native package formats and unrelated installations.

Support Claude, Codex, Cursor, Antigravity desktop, Pi, and OpenCode. Update help, completions, built-in skill, and documentation; keep plugins outside sync --all.

* docs(skill): describe the redesigned dashboard in the style skill

The style skill still documented the pre-redesign hand-drawn system, so
pages written with it came out on legacy tokens and outside the ss-*
classes; the new Plugins page was the first casualty.

The rewrite names tokens and classes and points to components.css for
their values, because copied values are what went stale last time. The
ui command docs described Playful by the old look as well.

* fix(ui): keep Playful ghost buttons free of stray shadows

The hover and disabled rules outranked the ghost variant's
box-shadow: none, so a frameless button grew a lone shadow arc in
Playful. Bulk toolbar and toast buttons shared the problem.

Ghost also gets a soft outline in Playful: beside 2px ink frames a bare
label such as Cancel did not read as a button.

* refactor(ui): lay out the Plugins page like the MCP page

The page was built on legacy tokens and plain markup, so it missed the
Playful frames and drifted from every other page. A per-agent column
layout would not have scaled either: each agent that gains plugin
support would add a column.

Plugins now follow the MCP server list: one row per plugin with its
agents as toggles inside the row, so the list only grows downwards.
Per-agent sync and update move to package-level actions in the row
menu, and the dialogs use the standard header, body and footer.

* feat(ui): give plugins a kind colour and per-agent actions

Plugins borrowed a neutral grey tile because no kind colour existed,
which made them the one resource without an identity on the page.
Magenta sits furthest from the five hues already taken.

Laying plugins out as rows had dropped the per-agent sync and update.
Retrying one agent after a partial failure should not re-run the rest,
so each agent in the expanded row gets its own menu. Update is left out
for a deselected agent, which has nothing installed to update.

* feat(ui): count plugins on the Dashboard

The source summary listed every resource kind except plugins, so the
Dashboard under-reported what a source holds. The Playful source note
grows to fit a fifth row.

MCP now sits above Plugins in the sidebar to match that order, and its
Dashboard label reuses the sidebar's "MCP" instead of a longer string
of its own.

* feat(scripts): add a host verification environment

Plugin and MCP work talks to the real Agent CLIs, and those live on the
host, not in the devcontainer, where every target reports "not installed".
Verifying by hand meant either pointing a build at real config or
assembling a dozen environment variables each time.

`make verify` builds a host binary and runs it against .verify-home/ in
the repo, redirecting HOME, the XDG dirs and each agent's own config
variable. The environment starts from `env -i`, so a stray
SKILLSHARE_CONFIG in the caller's shell cannot pull the run back to real
paths. Living inside the repo is safe because project-mode detection
only inspects the working directory and never walks up to a parent.

It also seeds the dashboard cache from ui/dist. A dev build serves a
placeholder rather than the working tree, because runtime download only
applies to numbered versions, so the UI was previously unverifiable
without a release.

* fix(ui): show progress while a plugin selection is applied

Toggling an agent shells out to that agent's own CLI, which takes
seconds. The row gave no sign of it: the toggle only greyed out, and
the confirmation badge is hidden while a target is deselected, so
turning one on looked like nothing happened at all.

The toggle being applied now lifts out of the greyed state and spins in
its badge. Agent versions also get room for their real strings, since
"2.1.276 (Claude Code)" was truncated to a width chosen for a bare
version number.

verify.sh gains a 'run' subcommand, so the same throwaway environment
can be driven from a script rather than only an interactive shell.

* fix(ui): spin the control that started a plugin action

Reading the inventory shells out to six agent CLIs and takes about two
and a half seconds, and every action refreshes it afterwards. Nothing on
the page said so: a menu action closed the menu and left the page still,
so the wait read as a freeze.

Each control now tracks its own work. Check, sync and import spin in
place, a menu action spins the row it acts on, and the agents refresh
follows the query itself rather than the mutation flag.

* feat(ui): split MCP add and import by where the configuration comes from

"Import from a target" opened a dialog whose second tab pasted a snippet,
which is not a target and usually comes from a provider's setup page rather
than a tool the user already configured. Pasting is a way to add a server,
so it moves under "Add server" beside the form, and importing now means one
thing: read what an installed Agent already has.

The paste side gains a file picker, matching `mcp import --file`; the API
only ever took content, so the browser reads the file and fills the editor.

The target picker no longer waits for a successful parse, and a footer that
said "writes 0 config files" next to a greyed-out button now names what is
missing instead.

* fix(ui): label the plugins result strip as the last action

The strip and the plugin inventory below it used the same list styling with
no heading on either, so two rows carrying the same plugin name read as one
list. The status word made it worse: "imported" is one of the outcomes
lifecycle.go returns for an action, but it sat where an inventory row shows
state, so it looked like a property of the plugin.

Give it the section heading the Agents list already has, plus a count and a
dismiss button, so it reads as the report it is.

* feat(plugins): expand compatibility and clarify setup guidance

Support additional native targets, safe source links, Git refs, and explicit OpenCode entries while exposing per-target capabilities across CLI, TUI, and UI.

Separate unsupported integrations from environment errors, explain next steps in plain language, and link official documentation. Update built-in guidance, website docs, completions, and regression coverage.

* feat(plugin): serve a plugin's files and translatable discovery problems

The dashboard could only show a plugin's name and targets, so reviewing
what a plugin ships meant opening the snapshot by hand. Files and
ReadFile expose the reviewed local copy read-only through os.OpenRoot,
which keeps reads inside the snapshot even across symlinks.

Discovery problems now carry a key and arguments next to the English
sentence, so the dashboard can translate them while the CLI keeps its
wording. Inventory asks every Agent CLI in parallel and Packages answers
from config alone, so the plugin list no longer waits on the slowest CLI.

* feat(mcp): sync to Pi, show native config, and lay out written entries

Pi has no built-in MCP support, so a server targeting it must name the
third-party extension that will read the file. `--pi-extension` and the
`piExtension` source field record that choice, and sync writes the file
format of the chosen package instead of guessing.

RenderNative and POST /api/mcp/render return what each Agent would
receive for a definition, with secrets kept as references, so the
dashboard can show the result before anything is written.

Sync used to insert entries on a single line and never revisit them. A
managed entry that still sits on one line is now reported as an update
and rewritten one field per line; entries formatted by hand are left
alone.

* feat(ui): choose plugin Agents like MCP, browse plugin files, view MCP config

The plugin fold listed bound Agents with a per-Agent menu, while MCP let
you simply tick the Agents you want. Plugins now work the same way: the
fold discovers where the source can also go, shows those Agents as
unticked toggles, and a tick previews an install. The per-Agent menu is
gone, and updating a plugin targets only the Agents that support it
instead of hiding the action when one of them does not.

A plugin with a local copy can be browsed in a read-only files dialog,
using the same tree as a skill's Files tab. The MCP "view config" moved
out of a fold in the server form into its own view, reachable from the
server menu, so the native result has room to be read. The MCP dialogs
also ask for the Pi extension when Pi is selected.

Playful tile names drop from 25px to 22px: "brainstorming" was 1px wider
than the tile and lost its last letter to the next line.

* docs: reshoot dashboard screenshots for the redesigned UI

The README and website still showed the pre-redesign dashboard, which no longer matches what users see after upgrading.

* docs: describe MCP, plugins and the new dashboard for v0.21.0

The README still announced v0.20.0 and never mentioned plugins, and its
MCP section listed four clients. The built-in skill and the docs pick up
the Pi extension setup, the formatting-only MCP update, and the plugin
fold and files dialog, so agents and users are not surprised by them.
2026-09-19 03:14:03 +08:00
Willie d759a7e8ee docs: add agent support to all command reference and getting-started pages
Command pages updated (7 files):
- list: 'skillshare list agents', [A] badge
- install: --kind agent, -a flag, auto-detection
- sync: agent sync with all three modes, supported targets
- check: 'skillshare check agents' drift detection
- audit: 'skillshare audit agents'
- enable: --kind agent routes to .agentignore
- uninstall: --kind agent flag

Getting started updated:
- first-sync: link to agents concepts in What's Next
- quick-reference: agent management command table + agents source path

Commands index: added agents row to What do you want to do table.
2026-04-07 18:05:40 +08:00
Willie 2af44f1d3f chore(skills): strengthen built-in skill descriptions and content
Improve all 5 active skills with pushy descriptions for better
triggering accuracy, following devcontainer as the gold standard.

- changelog: add trigger scenarios (release notes, version prep)
- cli-e2e-test: add trigger scenarios (runbook, E2E validation)
- codebase-audit: add 3 new audit dimensions (handler split, oplog
  coverage, web API consistency) and trigger scenarios
- implement-feature: add project patterns reference (handler split,
  dual-mode, TUI, web API, oplog) and trigger scenarios
- update-docs: expand scope to all 7 doc categories with code-to-doc
  mapping guide and trigger scenarios

Also remove empty .skillshare/skills/frontend/ directory.
2026-03-05 02:13:21 +08:00
Willie 6caf73faf0 docs(audit): split monolith audit.md into focused pages
The 1294-line audit.md mixed command reference, conceptual teaching,
rule management, and CI/CD recipes. Split into:

- understand/audit-engine.md — threat model, detection rules, risk
  scoring, command tiering, cross-skill analysis
- reference/commands/audit-rules.md — rule management, custom rules,
  built-in rule IDs table (adds 4 cross-skill finding IDs)
- how-to/recipes/ci-cd-skill-validation.md — absorb output format
  docs (SARIF, Markdown, JSON+jq, exit codes)
- reference/commands/audit.md — slim to ~370 lines, link to new pages

Also fixes:
- Replace ghost rule `system-writes-0` with `insecure-http-0` in all
  docs (the old ID no longer exists in rules.yaml)
- Update 3 cross-page links in security.md
- Update 1 rule ID in configuration.md
- Add sidebar entries for both new pages
2026-03-04 12:16:32 +08:00
Willie ef26da2280 chore: update docs 2026-03-03 16:08:11 +08:00
Willie 6d9545cb04 fix(audit): populate policy fields before TUI launch and update docs
applyPolicyToSummary was called in cmdAudit after auditInstalled/
auditFiltered returned, but both functions call presentAuditResults
(which launches the TUI) internally — so summary.PolicyProfile was
empty when the TUI rendered. Move applyPolicyToSummary before
presentAuditResults in both functions.

Also fix dedupe default label (global is now the default, not legacy)
and update audit/status docs to reflect current output format.
2026-03-03 16:08:11 +08:00
Willie d1e7f6558a feat(audit): wire --analyzer CLI flag, config field, and update docs
- Add EnabledAnalyzers []string to AuditConfig struct
- Add enabled_analyzers to both JSON schemas (config + project)
- Parse --analyzer repeatable flag in audit command
- Wire config → PolicyInputs → Registry for all scan paths
  (ParallelScan, single skill, single path, filtered)
- Add PolicyAnalyzers to JSON summary output
- Server handler also reads config enabled_analyzers
- Update audit.md: Policy & Profiles section, Finding Schema table,
  --profile/--dedupe/--analyzer in Options table and examples
- Update configuration.md: expanded audit section with all new fields,
  profile table, analyzer IDs, precedence rules
2026-03-03 16:08:11 +08:00
Willie bcbbaaf34d refactor(audit): remove noisy rules, recalibrate credential severities
Remove rules that generated excessive false positives:
- source-repository-link (HIGH): legitimate docs links flagged too often;
  external-link (LOW) already covers the same URLs
- env-access (MEDIUM): process.env references are ubiquitous in JS skills
- obfuscation-1 (long base64): caught README badges and binary data

Recalibrate credential-access severity levels to reduce alert fatigue:
- etc-passwd/sudoers: HIGH → MEDIUM (read-only system files, not secrets)
- shell-history, openvpn: MEDIUM → LOW (low-impact reconnaissance)
- auth-log: LOW → INFO (log files, no direct credential exposure)

Update all affected unit tests, integration tests, red team assertions,
skill references, and website docs to match.
2026-03-03 16:08:11 +08:00
Willie dbe759ecfe feat(audit): add CLI rules subcommand, severity override, reset, and redesign Web UI
- Add `audit rules` CLI subcommand with list, enable, disable, severity,
  and reset commands for managing audit rules without editing YAML
- Add SetSeverity/SetPatternSeverity/ResetRules mutations in audit package
- Redesign TUI with severity tabs, two-level pattern→rule navigation,
  inline severity picker (1-5 keys), and reset-all support
- Add compiled rules API endpoints (GET /api/audit/compiled, PATCH toggle)
- Redesign AuditRulesPage with severity-colored stripes, stat cards,
  expand/collapse, toggle switches, and dark-mode-aware CSS variables
- Redesign LogPage with status-colored row stripes, reusable PillButton,
  improved stats cards with left border stripes, default 10 entries/page
- Remove system-writes audit pattern (noisy, low value)
- Fix dark mode contrast across both pages by replacing hardcoded
  design.ts colors with var(--color-*) CSS variable references
2026-03-03 16:08:11 +08:00
Willie 885f072d16 feat(audit): add table-driven credential detection and 12 new security rules
Replace hardcoded credential-access YAML rules with a Go data table
(credentials.go) covering 30+ sensitive paths × 5 access methods, with
$HOME variant support, descriptive rule IDs, and an INFO-level heuristic
catch-all for unknown home dotdirs.

Add 12 new detection rules from security gap analysis:
- invisible-payload (CRITICAL): Unicode tag chars U+E0001–E007F
- prompt-injection-4 (CRITICAL): output suppression directives
- hidden-unicode-2 (HIGH): bidi control chars (Trojan Source)
- config-manipulation-0 (HIGH): AI config/memory file poisoning
- hidden-comment-injection-1 (HIGH): markdown reference-link injection
- data-exfiltration-3 (HIGH): DNS exfiltration via dig/nslookup
- self-propagation-0 (HIGH): repository worm instructions
- untrusted-install-0/1 (MEDIUM): npx -y, pip install from URL
- hidden-unicode-3 (MEDIUM): soft hyphens, directional marks

The invisible-payload pattern intentionally bypasses tutorial suppression
so CRITICAL findings are never silenced in educational contexts.
2026-03-03 16:08:11 +08:00
Willie 72b53ba697 docs: add v0.16.9 changelog, release notes, and audit docs update
Update CHANGELOG.md and website changelog with v0.16.9 entry covering
interpreter tier (T6), expanded prompt injection/credential access
detection, and regex bypass fixes. Sync audit.md with new rule IDs
and detection descriptions. Add contributor reneleonhardt to README.
2026-03-03 16:08:11 +08:00
Willie 5d9565098e fix(audit): close regex bypass vulnerabilities and improve code reuse
Security fixes from red-team review of audit rules:
- Prompt injection: add \s* after ^ anchor to prevent whitespace bypass,
  add (?i) for case-insensitive matching, use [^>]* for HTML attributes,
  expand to cover DEV MODE / DEVELOPER_MODE variants
- Credential access: add rules for ln/cp symlink, input redirection,
  dd if=/etc/shadow (previously mislabeled as destructive-commands)
- Data exfiltration: remove exclude pattern that allowed .png?stolen_data
- Interpreter tier: add bun, deno, npx, tsx, pwsh, powershell; add
  version-suffix stripping (python3.11 → python3); handle env prefix

Code quality (from /simplify review):
- Rename crossFinding → syntheticFinding and reuse in TierCombinationFindings
  to eliminate 5 inline Finding literals
- Extract hasFinding() test helper to reduce tier test boilerplate
- Remove unnecessary (?i) from credential-access-3/4 (Unix commands are
  always lowercase)
2026-03-03 16:08:11 +08:00
Willie 7a6ba4546d feat(audit): expand prompt injection detection, add interpreter tier and credential rules
Strengthen the audit engine with new detection capabilities inspired by
skilld's sanitization research and Snyk ToxicSkills findings:

- Expand prompt-injection-1 to detect OVERRIDE:/IGNORE:/ADMIN:/ROOT: prefixes
- Add prompt-injection-2: agent directive XML tags (<system>, <instructions>, etc.)
- Add prompt-injection-3: DEVELOPER MODE, JAILBREAK, DAN MODE directives
- Add data-exfiltration-2: external images with query params (exfil vector)
- Add credential-access-3/4: /etc/shadow, /etc/passwd and related system files
- Add TierInterpreter (T6): classify python/node/ruby/perl/lua/php as
  Turing-complete runtimes separate from build tools
- Add tier-interpreter and tier-interpreter-network combination findings
- Add cross-skill-cred-interpreter rule for credential × interpreter pairs
- Update docs to reflect 38 rules and new tier/cross-skill patterns
2026-03-03 16:08:11 +08:00
Willie 89c3586da6 feat(audit): add markdown output format and improve terminal layout
- Add --format markdown for self-contained audit reports (GitHub Issues/PRs)
- Simplify pterm box rendering: replace DefaultBox with separator-line style
- Remove unused SkillBox, SummaryBox, SkillDisplay, wrapText helpers
- Color Box titles cyan (consistent with HeaderBox)
- Add breathing room: blank lines around progress bar and after summary
- Show "skillshare audit (project)" header title in project mode
- Append elapsed time to cross-skill synthetic results to fix slice mismatch
2026-03-02 23:01:30 +08:00
Willie 87268d3098 feat(audit): add cross-skill interaction detection
Two individually harmless skills can form an attack chain when installed
together (e.g., one reads credentials, another has network access).

After per-skill scans complete, the audit engine now extracts a capability
profile from each Result and checks for dangerous cross-skill combinations:

- cross-skill-exfiltration (HIGH): credential reader + network sender
- cross-skill-privilege-network (MEDIUM): privilege commands + network
- cross-skill-stealth (HIGH): stealth skill alongside high-risk skill

Rules only fire for complementary pairs (each skill lacks the other's
capability) to avoid duplicating per-skill findings. Results appear as
synthetic "_cross-skill" entry in all output formats (text, JSON, SARIF, TUI).
2026-03-02 23:01:30 +08:00
Willie 85508dcea8 docs(audit): add analyzability score section and missing rule IDs
The analyzability score feature (committed in ae7bd21) was missing
dedicated documentation. Also backfills content-oversize (from 3ad814d)
which was never added to the docs.

- Add "Analyzability Score" section explaining score meaning, threshold,
  exclusions, and CLI/JSON output format
- Add content-oversize to Content Integrity table
- Add low-analyzability to LOW/INFO severity listing
- Add low-analyzability (INFO) and content-oversize (MEDIUM) to
  Built-in Rule IDs table
- Update :::note block to mention new structural/analyzability checks
2026-03-02 23:01:30 +08:00
Willie b6652f11a0 feat(audit): add command safety tiering (T0–T5) for behavioral classification
Classify every shell command in skill files into 6 behavioral tiers
(read-only, mutating, destructive, network, privilege, stealth) as an
orthogonal dimension to pattern-based severity. This lets audit report
"what kind of actions" a skill performs, not just "which known patterns
it matches."

- Add tier engine with 80+ command mappings and stealth regex patterns
- Detect tiers in scripts and Markdown fenced code blocks separately
- Generate combination findings: T2+T3→HIGH, T5→CRITICAL, T3>5→MEDIUM
- Display tier profile in CLI text, TUI detail panel, and JSON/API output
- Exclude .skillshare-meta.json from totalBytes to fix analyzability ratio
- Document tier definitions, profile output, and combination findings
2026-03-02 23:01:30 +08:00
Willie 8e83495200 feat(audit): add analyzability score and pre-commit hook
Analyzability score measures what percentage of a skill's content is
auditable plaintext vs binary/non-scannable. Surfaces in CLI text
output, JSON, SARIF, and Web UI API responses.

- Add TotalBytes, AuditableBytes, Analyzability fields to audit.Result
- Emit INFO-level low-analyzability finding when score < 70%
- Show "Auditable: X%" in per-skill and summary text output
- Expose analyzability in server API (auditResultResponse + auditSummary)
- Add .pre-commit-hooks.yaml for pre-commit framework integration
- Add pre-commit hook recipe docs and audit.md cross-references
2026-03-02 23:01:30 +08:00
Willie 3af76ff4b9 docs(audit): add SARIF output format and --format flag documentation
- Add --format flag to Options table, mark --json as deprecated
- Add SARIF output section with severity mapping table
- Add GitHub Actions Code Scanning example with SARIF upload
- Update usage examples and recommended workflow
2026-03-02 23:01:30 +08:00
Willie 429e67a88c fix(audit): downgrade data-uri severity to MEDIUM 2026-02-28 03:44:02 +08:00
Willie 1a207e6d2c feat(audit): add fetch-with-pipe, ip-address-url, and data-uri rules
Add 5 new audit rules (31 → 36 total) to close detection gaps:

- fetch-with-pipe (HIGH ×3): curl/wget piped to sh/bash/python/node/etc.
  Previously only double-pipe (||) was caught by shell-chain; single
  pipe (|) to interpreters — the classic RCE vector — was undetected.
- ip-address-url (MEDIUM): URLs with raw IP addresses that bypass DNS
  security controls; excludes RFC 1918 and loopback ranges.
- data-uri (HIGH): data: URIs in markdown links that may embed
  executable content.

fetch-with-pipe is suppressed inside markdown code fences (tutorial
context), matching existing behavior for destructive-commands et al.

Includes unit tests (25 cases), code fence suppression test, red team
TC-18 through TC-21, and audit.md documentation updates.
2026-02-28 03:44:02 +08:00
Willie defff26147 feat(audit): add interactive TUI, progress bar, and large-scan UX improvements
- Add bubbletea TUI for multi-skill audit results (side-by-side layout
  with skill list + detail panel, severity sorting, fuzzy filter)
- Add progress bar during parallel scan via onDone callback
- Add --quiet/-q flag to suppress clean skill lines
- Add --yes/-y flag to skip large-scan confirmation prompt (>1000 skills)
- Add --no-tui flag to force plain text output
- Scale parallel workers to NumCPU (bounded 2–32) instead of fixed 8
- Use file cache in content-integrity check to avoid redundant disk reads
- Replace line splitting with streaming scan (avoid full []string alloc)
- Remove snippet truncation (preserve full trimmed line)
- Differentiate LOW (bright blue) and INFO (medium gray) severity colors
- Centralize log TUI color styles into `lc` struct
- Export DisplayWidth and add BoxWithMinWidth/HeaderBoxWithMinWidth for
  aligned header + summary box widths
- Update docs with TUI controls, new flags, and CI/CD auto-skip behavior
2026-02-26 22:27:23 +08:00
Willie caa525b8aa feat(website): complete website revamp — Diátaxis IA, blog, recipes, quickstarts
Restructure the entire documentation site following the Diátaxis framework
(Learn / How-to / Understand / Reference) with new content across 110 files.

## Information Architecture (M1)
- Move all docs to Diátaxis directory structure (learn/, how-to/, understand/, reference/)
- Add client-redirects plugin for old URL compatibility
- Rewrite sidebar, navbar, and footer to match new IA
- Update all internal cross-references

## Homepage + Quickstarts (M2)
- Add scenario entry cards to homepage with hand-drawn design
- 5 quickstart pages: Claude Code, GitHub Copilot (with copy mode recommendation),
  Codex, Multiple Tools, Dev Containers, Playground

## Blog + Changelog (M3)
- Enable Docusaurus blog plugin with authors.yml
- 5 blog posts: 5-min tutorial, managing 50+ skills, skillshare vs vercel/skills
  comparison, team sharing patterns, write your first skill
- Static /changelog page from CHANGELOG.md

## Recipes + Philosophy (M4)
- 5 recipe pages: CI/CD validation, enterprise skills, project setup,
  cross-machine sync, team onboarding
- 3 philosophy pages: why-local-first, security-first, sync-modes-explained

## Content Polish
- Cross-validate all content against CLI source (19 inaccuracies fixed)
- Lowercase "skillshare" throughout (avoid brand conflict with Skillshare Inc.)
- Add registry.yaml to file structure and Key Paths docs
- Highlight multi-platform git support (GitHub, GitLab, Bitbucket, Gitea,
  Azure DevOps, AtomGit, Codeberg)
- Standardize brew install command
- Add AsciinemaPlayer component (cast recordings pending)
2026-02-26 22:27:23 +08:00