Commit Graph
127 Commits
Author SHA1 Message Date
Willie bb3745b8f5 fix: reject source/target path overlap and fail closed in check
ValidateProjectConfig now resolves each target's skills/agents path
and rejects configs where a source aliases or nests with any target
path. Without this guard, sources.skills: .claude/skills with a
claude target makes sync --force delete the source.

check -p now returns an error on LoadProject failure instead of
falling back to .skillshare/skills.
2026-05-20 18:24:41 +08:00
Willie 9a30a90366 fix: handle sources.skills: .skillshare producing invalid ./ gitignore pattern
Apply the same rel=="." guard to the skillshareDir branch of
ProjectGitignoreTarget, so sourcePath==.skillshare returns empty
prefix instead of dot.
2026-05-20 16:57:13 +08:00
Willie 14402dc6a5 fix: handle sources.skills: . producing invalid ./ gitignore pattern
When sourcePath equals projectRoot, filepath.Rel returns ".",
causing callers to write "./<name>/" patterns that git ignores.
Return empty entryPrefix so callers produce "/<name>" instead,
which is a valid root-anchored gitignore pattern.
2026-05-20 16:49:52 +08:00
Willie 5b7ca8ba3d fix: trash before gitignore cleanup and skip gitignore for external sources
Reorder handleUninstallRepo to move repo to trash before removing the
.gitignore entry, preventing accidental exposure of tracked content
when trashing fails.

ProjectGitignoreTarget now returns empty strings for source paths
outside projectRoot, since parent-relative patterns (../) are invalid
in .gitignore. All six callers guard on empty gitignoreDir and skip
gitignore management for external sources.
2026-05-20 16:34:02 +08:00
Willie 0c010c55f4 fix: wire custom sources into server reload and gitignore paths
reloadConfig now updates s.cfg.Source and s.cfg.AgentsSource from the
refreshed ProjectConfig so project UI handlers see the latest source
directories after a config edit.

Add ProjectGitignoreTarget helper that computes the correct .gitignore
directory and entry prefix based on whether the source path is inside
.skillshare/ or a custom location. All gitignore write and remove
operations (reconcile, install, uninstall, server handlers) now use
this helper instead of hardcoded 'skills/' prefix.

Fix nil projectCfg panics in three server tests that simulate project
mode by setting projectRoot without projectCfg.
2026-05-20 16:12:02 +08:00
Willie 68d5eadc0b feat: support custom project source directories via sources map
Add ProjectSources struct to ProjectConfig with optional skills, agents,
and extras fields. When set, project-mode commands resolve source paths
from these values instead of hardcoded .skillshare/{skills,agents,extras}/.

Config example:
  sources:
    skills: ./docs/skills
    agents: ./docs/agents

Three EffectiveXxxSource(projectRoot) methods provide the central
resolution logic with fallback to defaults. The projectRuntime gateway
and server layer route through these methods, so most commands get
custom source support automatically.

Closes #153
2026-05-20 15:42:53 +08:00
Willie 3345fd677e refactor: unify gemini and antigravity targets under antigravity
- Update antigravity global path to shared ~/.gemini/skills
- Update antigravity project path from .agent to .agents
- Add aliases: gemini, gemini-cli, antigravity-cli
- Remove standalone gemini target (now an alias)
- Update testutil.CreateTarget to match new path
2026-05-20 13:44:40 +08:00
Willie 9307fc521c chore: release v0.19.12 2026-05-14 23:43:43 +08:00
iFwu 5403595120 feat(config): preserve ~ in saved config paths (opt-in)
Add PreserveTildeOnSave config flag (default false). When enabled, the
Save path folds $HOME prefixes back to ~ when serializing the in-memory
Config to YAML so the on-disk config stays portable across machines
(e.g. when shared via dotfiles).

The in-memory Config is left untouched; cloneForSave() produces a
shallow copy with path fields rewritten. Mirrors the existing
expandPath() calls performed in Load():
  - cfg.Source, cfg.ExtrasSource
  - cfg.Targets[*].Path / Skills.Path / Agents.Path
  - cfg.Extras[*].Source and Extras[*].Targets[*].Path

Adds:
  - utils.FoldHomePath() helper with unit tests (exact-home, child,
    sibling-non-home, unrelated-abs, relative, Windows case-insensitive)
  - 3 Save-path tests covering default-off, fold-on, and Load→Save
    idempotency.

Default off keeps the change backward compatible: existing users see no
behavior difference. Users who share their config via dotfiles can opt
in with:

    preserve_tilde_on_save: true
2026-05-14 13:09:56 +08:00
Willie 56007efa5c chore: fix lint error 2026-05-11 23:46:43 +08:00
Willie a945b3c0c5 feat(config): add ContextBudgetConfig for token budget warnings 2026-05-11 21:34:38 +08:00
Willie e48a301623 feat: add azure_hosts config for Azure DevOps Server on-premises
Add azure_hosts config parameter (analogous to gitlab_hosts) that allows
users to register self-hosted Azure DevOps Server hostnames so they
receive proper URL parsing without appending .git to clone URLs.

- Add AzureHosts field to Config and ProjectConfig structs
- Add SKILLSHARE_AZURE_HOSTS env var support with merge semantics
- Generalize hostname validation into shared normalizeHostList/mergeHostsFromEnv
- Add azureOnPremPattern regex and parseAzureOnPrem for /_git/ URL routing
- Add isAzureHost for config-based host detection (no auto-detect)
- Update TrackName to handle on-prem Azure DevOps clone URLs
- Wire AzureHosts through InstallContext, ParseOptions, and Server
- Add JSON Schema, UI fieldDocs, and website documentation
- Add 19 new tests covering config, source parsing, and server

Closes #147
2026-05-05 18:33:07 +08:00
Willie 57b0649d20 feat(targets): add 8 new agent targets and update cursor project path
Add AiderDesk, CodeArts Agent (Huawei), Code Studio (Syncfusion),
Devin for Terminal (Cognition), Dexto, ForgeCode, Rovo Dev (Atlassian),
and Tabnine CLI as built-in targets (56 → 64).

Update Cursor's project-level skill path from .cursor/skills to
.agents/skills to match Cursor's official documentation, which now
lists both paths as supported with .agents/skills as the ecosystem
standard convention. Global path (~/.cursor/skills) and agents paths
are unchanged.

All paths verified against official documentation or source code.
Codemaker excluded — no official docs confirm SKILL.md support.
2026-05-05 11:55:26 +08:00
Willie 5836a8802f feat: add agent filter support to Filter Studio, targets CLI, and overview API
Backend:
- PATCH /api/targets/:name accepts agent_include/agent_exclude fields
- POST /api/sync-matrix/preview returns agent entries with kind=agent
- GET /api/overview returns agentsSource and extrasSource paths
- Fix ResolveProjectTargets to resolve Agents sub-key (path + filters)
- Add agent filter CLI flags: --add-agent-include, --add-agent-exclude,
  --remove-agent-include, --remove-agent-exclude, --agent-mode
- Unify target list JSON/TUI to show agent info and filters

Frontend:
- FilterStudioPage: kind-driven single-context view (?kind=skill|agent)
- KindBadge: use design system tokens (ss-badge + wobble in playful)
- TargetsPage: link to Filter Studio with ?kind= param
- ResourceDetailPage: capitalize type labels (Local, GitHub)
- ResourcesPage: sync activeTab from URL searchParams on navigation
- DashboardPage: show agents/extras source dirs, link skills card
  with ?tab=skills for reliable tab switching
- API client: extend updateTarget and previewSyncMatrix for agent filters

Tests:
- Agent include/exclude round-trip persistence
- Invalid agent pattern returns 400
- Preview with agent entries and kind field
- No agent entries for targets without agent path
- CLI target agent filter integration tests
2026-04-09 03:50:28 +08:00
Willie 0244abb4ce refactor: consolidate reconcile walk logic into shared core
Extract the identical walk-and-reconcile logic from ReconcileGlobalSkills
and ReconcileProjectSkills into reconcileSkillsWalk() in a new
reconcile_core.go file. Both callers are now thin wrappers.

- Move git helpers (isGitRepo, gitCurrentBranch, gitRemoteOrigin) to core
- Add pruneStaleEntries() shared helper
- Project version injects gitignore collection via onFound callback
- ~140 lines of duplication eliminated
2026-04-08 17:43:09 +08:00
Willie 7290884977 fix: use full-path metadata keys to prevent grouped skill collisions
Metadata store entries for grouped skills (e.g. frontend/foo, backend/foo)
were keyed by basename only, causing the second install to overwrite the
first. This changes the key to the full relative path.

Key changes:
- WriteMetaToStore: use full rel path as key, clean up legacy basename key
- Add KeyToRelPath() helper and MigrateLegacyKey() method for backward compat
- Reconcile: migrate legacy basename keys to full-path keys on load
- install_queries: guard against double-prefixing with KeyToRelPath
- LoadMetadata: auto-run sidecar cleanup on every load (idempotent)
- migrateAgentSidecars: recurse into subdirectories
- mergeSkillSidecar: use full-path keys, detect tracked repos
2026-04-08 16:35:19 +08:00
Willie 34b6c2a9e0 test: fix remaining unit tests for centralized metadata store keys
- Reconcile tests use bare name as store key (not group/name)
- updatable_test uses MetadataStore directly instead of WriteMeta dual-write
- Tracked repos marked with Tracked: true in store
- All unit + integration tests pass (make check green)
2026-04-08 14:38:25 +08:00
Willie e91890d2b0 test: fix all integration tests for centralized .metadata.json format
- Dual-write in WriteMeta: also writes to .metadata.json for backward compat
- Migration looks in parent dir for registry.yaml
- Group uninstall matches entries by Group field + full path
- Sync test uses MetadataStore instead of registry.yaml
- All integration tests pass (0 FAIL)
2026-04-08 14:28:57 +08:00
Willie 1f1790b6be refactor: replace Registry with MetadataStore in reconcile, server, install context
Phase 1 of caller migration:
- projectRuntime: registry → skillsStore + agentsStore
- globalInstallContext: reg → store
- ReconcileGlobalSkills/ProjectSkills/ProjectAgents: take *MetadataStore
- Server struct: registry → skillsStore + agentsStore
- handler_install, handler_skills, handler_uninstall: use MetadataStore
- install.go, search.go: post-install reconciliation via MetadataStore
2026-04-08 10:59:13 +08:00
Willie ca73b40e0f feat: warn when agents installed/synced but no targets support agents
Add Config.HasAgentTarget() helper that checks if any configured target
has an agents path set.

handler_install: append warning to install summary when agents are
installed but no targets support them.

handler_sync: after sync completes, check if agents exist in source
but no targets have agent paths — add warning to response.
2026-04-07 18:05:40 +08:00
Willie 4c43506df3 feat: agent detail endpoint, project reconcile, and TrashPage badge
handler_skills: skill detail endpoint falls back to agents source when
skill not found. Returns agent .md file content and kind='agent'.

project_reconcile: add ReconcileProjectAgents() to scan agents source,
update registry with kind='agent' entries, and batch-update
.skillshare/.gitignore for agent files and metadata.

TrashPage: add KindBadge next to trashed item names with 'skill'
fallback for old trash items without kind field.
2026-04-07 18:05:40 +08:00
Willie ea055de8e5 refactor(registry): rename SkillEntry to ResourceEntry and add unified registry load/save
Rename SkillEntry to ResourceEntry with type alias for backward compat.
All 56 call sites continue to compile without changes.

Add LoadUnifiedRegistry() to merge separate skills and agents registry
files for global mode (skills/registry.yaml + agents/registry.yaml).
Agent entries automatically get Kind="agent" during merge.

Add SaveSplitByKind() to split a unified registry back by kind for
persisting to the correct source directory. Skips writing agents
registry file when no agent entries exist.
2026-04-07 18:05:40 +08:00
Willie c049ccdae0 feat(config): add agents_source field and create agents directory on init
Add AgentsSource field to Config struct with EffectiveAgentsSource()
method that defaults to ~/.config/skillshare/agents when not set.

Global init now creates agents source directory alongside skills source.
Project init creates .skillshare/agents/ alongside .skillshare/skills/.
projectRuntime gains agentsSourcePath field for project-mode agent ops.

Update config.schema.json with agents_source property definition.
2026-04-07 18:05:40 +08:00
Willie a570670a92 fix: registry cleanup after uninstall and sync, UI polish
- Fix UI batch uninstall not removing nested skill registry entries:
  handler used flat names (__) but registry stores path names (/),
  now tracks exact RelPath from discovered skills for matching

- Add stale entry pruning to ReconcileGlobalSkills and
  ReconcileProjectSkills using a live set built during disk walk,
  so skills deleted from source are removed from registry

- Trigger registry reconcile after sync in both UI handler (via defer
  for early-return safety) and CLI (global + project mode), writing
  warnings to stderr to avoid corrupting --json output

- UI: fix BatchUninstallPage search treating plain text as exact-match
  glob (now substring search when no * or ? present), display nested
  skill paths with / instead of __ in confirm and result dialogs

- UI: hide redundant 'X repo(s) and Y skill(s) already up to date'
  line on UpdatePage when everything is already current

- Fix test isolation: set XDG_CONFIG_HOME in server test helpers to
  prevent host agents dir leaking into test results, skip chmod-based
  oplog test when running as root

- Add README badge for Awesome Codex CLI
2026-04-01 22:30:39 +08:00
Willie 24b7b4d5b2 fix(reconcile): write tracked repo branch to registry.yaml
Tracked repos have no .skillshare-meta.json, so reconcile could not
read branch from metadata. Now falls back to git rev-parse --abbrev-ref
HEAD for tracked repos, ensuring branch is written to registry.yaml
for cross-device rebuild.

Added gitCurrentBranch() helper in config package (cannot import
internal/git due to circular dependency).

Added registry assertion to TestInstallBranch_TrackedRepo.
2026-04-01 00:32:49 +08:00
Willie 178462dcfe fix: three branch-related bugs found in review
P1: check.go '@' separator broke SSH URLs (git@github.com:org/repo)
    — splitURLBranch would split at the '@' in the URL itself
    — Fix: use tab character as separator (cannot appear in URLs)
    — Added unit test for SSH URL round-trip

P1: install_config.go grouped same-repo different-branch skills together
    — groupConfigSkillsByRepo keyed by CloneURL only, ignoring Branch
    — Fix: include branch in grouping key so each branch clones separately

P2: reconcile never cleared stale branch from registry
    — Only updated when meta.Branch was non-empty, never cleared it
    — Fix: sync branch unconditionally when meta is available
2026-04-01 00:32:49 +08:00
Willie db69638e30 feat(install): project mode --branch support and branch display in check
- Set source.Branch in project install path
- Sync branch in project reconcile
- Add Branch to checkRepoResult and RepoCheckOutput for JSON/display
- Read current branch from tracked repos in check

Ref: #90
2026-04-01 00:32:49 +08:00
Willie 428eb11120 feat(install): persist branch to metadata and registry, read in update
- NewMetaFromSource: set meta.Branch from source.Branch
- installFromDiscoveryImpl: forward discovery.Source.Branch when building
  per-skill Source struct for metadata
- installFromGitSubdir: pass source.Branch to sparseCloneSubdir (was
  hardcoded empty string, causing subdir installs to ignore --branch)
- ReconcileGlobalSkills: sync meta.Branch to registry on both new and
  existing entries
- toSkillEntryDTOs: include Branch field in DTO conversion
- updateRegularSkill / updateSkillFromMeta: restore source.Branch from
  meta before reinstalling, so updates pull from the originally-specified
  branch

Tests: TestInstallBranch_MetadataPersistence, TestInstallBranch_UpdatePreservesBranch
2026-04-01 00:32:49 +08:00
Willie 8def337c05 feat(install): add Branch field to InstallOptions, SkillMeta, SkillEntry, SkillEntryDTO 2026-04-01 00:32:49 +08:00
Willie ccdafd3293 feat(sync): add target_naming config option (flat/standard)
Add per-target target_naming setting that controls how skill directories
are named in sync targets. 'flat' (default) preserves the existing
flattened __ separator behavior. 'standard' uses the SKILL.md name field
directly, following the Agent Skills specification.

Standard mode:
- Validates SKILL.md names match directory basenames
- Detects and skips name collisions with warnings
- Auto-migrates managed entries when switching from flat to standard
- Preserves legacy entries when bare name is already occupied

Also includes:
- Per-target toggle via CLI (--target-naming), TUI (N key), and Web UI
- Collision output redesigned as deduplicated compact summary
- Config inheritance: global target_naming → per-target override
- JSON schema + UI validation for the new field

Closes #110
2026-04-01 00:32:49 +08:00
Willie f0f15ce15a refactor(targets): restructure targets.yaml to nested per-kind format
Unify global_name/project_name into single name field and move flat
paths into skills: { global, project } nested block. All 56 targets
converted with zero public API signature changes.

Add targetPathPair sub-struct and agents: block for v1 agent targets
(claude, cursor, opencode, augment). New DefaultAgentTargets() and
ProjectAgentTargets() functions return only targets with agent paths.

Update all internal consumers: DefaultTargets, ProjectTargets,
LookupProjectTarget, GroupedProjectTargets, MatchesTargetName,
KnownTargetNames, resolveTargetPaths, ProjectTargetDotDirs.

ProjectTargetDotDirs now collects dot-dirs from both skill and agent
project paths to prevent discovery from scanning agent target copies.
2026-03-30 18:32:33 +08:00
Willie 3b5571f4be refactor(config): use 2-space YAML indentation for all config output
Replace yaml.Marshal (4-space default) with marshalYAML helper using
yaml.Encoder.SetIndent(2) across config, project config, and registry.
Matches industry standard (Kubernetes, Docker Compose, GitHub Actions)
and reduces excessive nesting depth in targets with skills sub-keys.
2026-03-29 05:00:42 +08:00
Willie fe44ffa7b1 fix(config): use atomic write-to-temp + rename for migration persistence
Prevents config file corruption if os.WriteFile fails mid-write
(e.g., disk full). Writes to .tmp first, then renames atomically.

Addresses review feedback from #106.
2026-03-29 04:59:23 +08:00
Willie f4d35af80f test: comprehensive migration compat and validation tests
- config_resource_test.go: global TargetConfig new format, old format
  migration, empty object, SkillsConfig/AgentsConfig accessors,
  mixed-format merge + no-overwrite
- project_resource_test.go: project target new format, old format,
  string form, MarshalYAML variants, accessors, mixed-format merge
- registry_kind_test.go: Kind field, EffectiveKind default/explicit,
  persistence round-trip, old format without kind
- migration_compat_test.go: 50+ cases covering all old config patterns:
  global Load() path (persist, ~ expansion, built-in backfill),
  project LoadProject + ResolveProjectTargets (string, flat, alias,
  custom), round-trip no-flat-keys assertion, mixed-format merge edges
- config_validate_test.go: pathless custom target rejection for both
  global and project mode, built-in target acceptance
2026-03-29 04:59:23 +08:00
Willie 9d38216246 refactor(config): update project filter test to use SkillsConfig()
Existing test asserted flat Include/Exclude fields which are now empty
after migration. Updated to read from SkillsConfig() and resolved
target's SkillsConfig().
2026-03-29 04:59:23 +08:00
Willie 8258f8b27b feat(config): add skills/agents sub-keys to TargetConfig with auto-migration
Add ResourceTargetConfig struct for per-resource-kind target settings.
Both global TargetConfig and project ProjectTargetEntry gain Skills and
Agents sub-keys alongside legacy flat fields.

Migration:
- migrateTargetConfigs() (global) and UnmarshalYAML (project) move flat
  path/mode/include/exclude into skills: sub-key on load
- Mixed format (flat + skills) merges without overwriting existing values
- EnsureSkills() clears flat fields after promotion
- Auto-persists migrated format on first Load/LoadProject

Validation:
- Known built-in targets can omit skills.path (backfilled from defaults)
- Custom targets must specify skills.path explicitly
- Load() backfills built-in default paths for known targets

Accessors: SkillsConfig(), AgentsConfig(), EnsureSkills(), IsEmpty()
2026-03-29 04:59:23 +08:00
Willie eabb556cc6 refactor(config): cache SourceRoot in Config.RegistryDir
Eliminates redundant .git/ directory walks on every LoadRegistry call.
SourceRoot() is now computed once in config.Load() and cached in
cfg.RegistryDir. All 11 call sites use the cached value.
2026-03-26 23:32:15 +08:00
Willie a7de6a3a69 feat(registry): move registry.yaml to source dir for git sync (#103)
- Add SourceRoot() helper to find git repo root from cfg.Source
- Add MigrateRegistryToSource() for one-time migration
- Update all 11 global-mode LoadRegistry/Save call sites
- registry.yaml now lives in skills/ dir and is tracked by git
2026-03-26 22:42:00 +08:00
Willie 5d9dd0cdbb feat(extras): add flatten option to extras sync engine
When flatten=true, SyncExtra maps subdirectory files to target root
using filepath.Base(). First file wins on collision, subsequent are
skipped with warnings. Includes config validation, sync-time guard,
CheckSyncStatus collision handling, and CollectExtraFiles support.

Ref: #97
2026-03-25 21:14:16 +08:00
Willie 14823027b5 test: comprehensive extras source config coverage
Unit tests:
- ResolveExtrasSourceDir 3-level priority + empty fallbacks
- ResolveExtrasSourceType per-extra/extras_source/default
- Config Load() tilde expansion for ExtrasSource and per-extra Source

Server tests:
- GET /api/extras includes source_type
- POST /api/extras with/without source field
- Project mode returns default source_type
- Create backfills extras_source

Integration tests:
- extras_source config, per-extra --source flag
- source_type in JSON, priority chain
- sync/collect/doctor/status with custom source
- sync auto-creates missing source dirs
- init backfills extras_source

E2E runbook (24 steps, mdproof verified):
- All three sync modes with content verification
- Tilde expansion, backward compatibility
2026-03-20 02:36:50 +08:00
Willie 5aa6ee8450 feat: configurable extras source with 3-level priority
Add extras_source (global default) and per-extra source (override)
to config.yaml. Resolution: per-extra > extras_source > default.

- Config: add ExtrasSource and ExtraConfig.Source fields with tilde expansion
- New ResolveExtrasSourceDir() replaces hardcoded ExtrasSourceDir()
- Migrate all 18 caller files to new resolver and sourceFunc signature
- CLI: extras init --source flag, help text
- TUI: source input phase in init wizard, narrower list panel
- extras list: source_type field in JSON, label in TUI detail
- Sync auto-creates missing source dirs instead of skipping
- extras init and server auto-backfill extras_source when missing
- doctor/status/diff/collect all use resolved source path
2026-03-20 02:36:50 +08:00
Willie 643e3c5c07 fix: auto-create missing target directories with notification (#87)
v0.17.5 blocked sync when target directories didn't exist, which
prevented first-time users on fresh CLI installs from syncing.

Sync now auto-creates missing directories and reports what it did
in CLI output, dry-run preview, and the Web UI. Init also creates
target directories when it detects an installed CLI tool.

Web UI: Sync Preview modal stays open after sync with a success
banner instead of immediately closing, so users can review results.

Closes #87
2026-03-19 03:57:08 +08:00
Willie c57391ea39 feat: add Hermes Agent (Nous Research) target support
Hermes Agent is a CLI tool by Nous Research with skills support.
Paths: ~/.hermes/skills (global), .hermes/skills (project).
Ref: https://hermes-agent.nousresearch.com/docs/reference/optional-skills-catalog

Also updates target count from 55+ to 56+ across docs and homepage.
2026-03-19 03:57:08 +08:00
Willie 92603f5be6 feat: add config save validation and sync safety checks
Validate config semantics (source path, sync modes, target paths) at
save time (API + CLI) instead of failing at sync time with cryptic
errors. Sync no longer auto-creates missing target directories — fails
fast to catch typos like ~/.cusor/skills. Dry-run also validates paths.

- ValidateConfig / ValidateProjectConfig with warnings + errors
- handlePutConfig returns 400 for invalid configs, 200 + warnings
- handleSync pre-checks via ValidateConfig
- ensureRealTargetDir shared helper (replaces duplicated blocks)
- UI: warning toast on config save, warning banners on sync/preview
- Dashboard shows full absolute source path
2026-03-18 22:35:02 +08:00
Willie 23e43fc976 style: apply gofmt formatting 2026-03-17 04:48:42 +08:00
Willie 405a2f907a feat(extras): add mode command for CLI, TUI, and Web UI
Add ability to change sync mode of an extra's target across all three
interfaces: CLI (`extras mode`/shorthand `extras <name> --mode`),
TUI (`M` key with mode picker overlay), and Web UI (inline Select
dropdown per target with PATCH /api/extras/{name}/mode endpoint).

Fix sync behavior so symlinks from a previous mode are auto-replaced
without --force, while regular files still require explicit --force.

Consolidate sync mode list into config.ExtraSyncModes single source
of truth. Fix Select component missing disabled prop and add viewport
collision detection with useLayoutEffect.

Includes 8 integration tests covering mode command happy path, error
cases, shorthand syntax, and mode-switch sync behavior.
2026-03-12 16:45:02 +08:00
Willie cc93c4f0a4 fix(extras): add y/N confirm prompt to remove, clean up empty dirs
- extras remove: replace silent-exit warning with interactive [y/N]
  prompt; --force skips the prompt as before
- extras remove: after removing config entry, delete the source
  directory if empty and the parent extras/ directory if empty
- sync extras: clean up empty extras/ directory when no extras are
  configured (both global and project mode)
- Add removeEmptyDir helper and ExtrasParentDirProject path function
2026-03-12 16:45:02 +08:00
Willie 09ccd14266 fix(extras): resolve tilde expansion, unify headers, add doctor target warnings
Extras commands had multiple issues with tilde (~) path handling — Go
doesn't expand ~ (that's shell behavior), so paths like ~/.claude/rules
were treated as literal relative paths, creating bogus ~/  directories.

Key fixes:
- Export config.ExpandPath() and call it before os.Stat / sync operations
  in extras_list, sync_extras, extras_collect, and doctor
- Unify extras output headers to match target list style (single "Extras"
  header instead of per-extra headers, fix double-icon bug in list)
- Add per-target reachability warning in doctor for unreachable extras
  targets with expanded path display

Update all 3 E2E runbooks to use extras/<name>/ path layout, add /tmp
cleanup for idempotent re-runs, add migration test step, and create new
comprehensive extras_commands_runbook (18 steps covering init/list/remove/
collect/doctor/tilde/project-mode).

Improve cli-e2e-test skill with 4 new checklist items and 2 rules learned
from test friction (/tmp isolation, symlink write-through, cat>>
idempotency, extras path layout).
2026-03-12 16:45:02 +08:00
Willie 5369595bc1 fix(install): skip target dotdirs during skill discovery
Repos like pbakaus/impeccable commit .claude/skills/ alongside their
source skills, causing discoverSkills to find every skill twice (36
instead of 18). Fix by deriving known target dotdir names (.claude,
.cursor, .skillshare, etc.) from targets.yaml project_path values and
skipping them during filepath.Walk.

Non-target hidden dirs (.curated, .system — used by openai/skills) are
still discovered as before. Injection pattern avoids circular import
between config and install packages.
2026-03-12 16:45:02 +08:00
Willie d97e5a7c33 refactor(extras): consolidate duplicate logic and fix sync --all --json output
- Move checkExtrasSyncStatus to sync.CheckSyncStatus (shared)
- Add sync.EffectiveMode helper to replace inline mode defaults
- Add config.ValidateExtraMode to centralize mode validation
- Fix sync --all --json outputting two separate JSON objects
  by merging extras into the skills JSON output
- Fix swallowed JSON decode error in handleExtrasSync
- Remove dead symlink check in CollectExtraFiles (filepath.Walk
  follows symlinks so the check was unreachable)
- Fix integration test extras paths to use extras/<name>/ layout
2026-03-12 16:45:02 +08:00