Commit Graph
15 Commits
Author SHA1 Message Date
Rusty ShacklefordandClaude Opus 5.5 83d4d0ac19 docs(proposal): collect audit and supply-chain ideas into one list (#746)
Replace the separate audit and install proposal PRs with one selection
list: an index table, a one-line summary and decision per item, and the
full original proposal under each item.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 12:54:40 +08:00
Rusty ShacklefordandWillie 85bcf589a7 feat(sync): recognize and route agent-specific skill variants (#649)
* docs(proposals): propose agent-specific skill variants

Tracked repositories can ship different files for the same skill across
agents. Counting and syncing each copy independently sends incompatible
instructions to every target unless users maintain routing filters.

Propose repository-scoped logical identity and exact variant routing while
preserving source files, explicit controls, and existing naming behavior.
Leave activation and compatibility decisions for maintainer review.

Refs #648

* docs(proposals): clarify variant routing compatibility

Explain how recognition affects universal-only targets and how existing
per-variant overrides preserve the desired routing. Fix the precedence
between variant identity and generic host-style path inference.

Include analyze, move, and catalog consumers while preserving physical
identifiers and actual context-cost accounting.

Refs #648

* docs(proposals): clarify activation assumptions and scope

Make acceptance cases conditional on maintainer-approved recognition being
enabled for the tracked source. Separate the provisional implementation
estimate from this proposal-only PR so its size is clear.

Refs #648

* docs(proposals): qualify naming and opt-in assumptions

State that the reproduced routing behavior uses default flat target
naming. Leave any opt-in surface with the maintainer's activation decision
without ruling out future CLI or config fields.

Refs #648

* feat: recognize and route tracked agent skill variants

Count tracked variants as logical skills in source and repository summaries,
while preserving physical paths, sync operations, and context costs. Select
matching canonical agent variants, including account targets, through shared
discovery and selection with existing explicit routing precedence.

Refs #648

* fix: count logical skills in sync inventory summaries

Use shared logical and physical inventory counts in global and project sync
closing lines while preserving each target's operation totals.

Refs #648

* fix: preserve variant routing diagnostics across previews

Resolve target selections once so CLI and server previews keep ambiguity
reasons and physical skip counts. Explain managed variants removed by
automatic agent routing, and report logical inventory in doctor.

Keep warning rows read-only, document upgrade recovery in translated
filtering references, and remove the optional README-only addition.

Refs #648

* fix: align sync matrix previews with shared variant selection

Classify the full source selection once per target so matrix previews honor
canonical aliases, account identity, exact-agent routing, and ambiguous
variant skips. Preserve each rejected physical path's existing diagnostic
and draft filter disambiguation; skipped preview rows remain read-only.

Refs #648

* test: expect singular skill wording in doctor source checks

Keep the undiscovered-link count assertion aligned with logical source
inventory formatting for one skill in global and project mode.

Refs #648

* fix: retain selection diagnostics in catalog and diff verdicts

Report warning-only diff targets as requiring attention while preserving
local-only folder semantics. Reuse shared per-path selection diagnostics
in target-scoped catalogs without applying target naming to served paths.

Compute source counts once in summary callers and require variant counts
in the source status formatter.

Refs #648

* test: tighten tracked variant preview fixtures

Use a real committed tracked repository for status counts, verify sync
preview banners retain server warnings, and use emitted ambiguity reason
text in target preview fixtures.

Refs #648

* fix(sync): keep agent variants in shared target folders

Compatible targets sharing a skills folder need a combined selection so
Codex and universal do not prune one another in merge or copy mode.
Carry every shared reader through selection, pruning and previews,
including project targets, account identities and path aliases.

Require a matching skill suffix under two distinct agents before
inferring variants, keeping ordinary agent-named categories unrestricted.
Separate naming warnings from ambiguous selection in diff and explain
ambiguous removals. Add global/project regression coverage for repeated
sync, target-only sync, status JSON, diff and API consumers.

* fix(variants): align consumer counts, hints and diagnostics

Use logical source counts in list, tracked install and init summaries while matching audit caches against physical variants. Restore localized dashboard skip hints and explain symlink routing limits in status and doctor, including project and JSON output.

Document paired-agent detection and compatible shared-folder selection in the proposal, built-in skill and English plus translated command pages. Add focused regressions for the affected consumers.

* fix(sync): cover initial sync and ignored variant diagnostics

Init syncs a fresh in-memory config, so resolve shared target identities
before its first sync as well as when loading saved configuration.

A whole-directory symlink exposes ignored skills too. Diagnose agent
variants using physical inventory when active discovery has none, while
keeping logical counts and merge/copy selection restricted to enabled
skills. Cover global/project JSON status and doctor with regressions.

Reuse sourcewalk directory and canonical-path helpers so traversal guards
remain enforced and path resolution has a single existing owner.

* fix(variants): address conversion, counts and selection diagnostics

Ignore runtime agent identities when comparing convertible project targets and count logical skills during init. Keep selection warnings separate from naming warnings and preserve agent-named parent skills as ordinary skills.

Cover account sync/prune, project ambiguity and overrides in merge/copy modes, and init/status agreement. Focused verification ran in an isolated Linux Codex container, not the devcontainer, as authorized.

* refactor(variants): remove obsolete selection helpers

Remove the unused FilterSkillsByTarget wrapper and prune agent parameter, cache canonical target aliases once, and restore catalog skip ordering to avoid an unrelated behavior change. Completes the optional cleanup from PR 649 review.

* fix(ui): expose localized variant selection diagnostics

Show target warnings with source paths, localize ambiguity across preview and detail consumers, and let skipped preview rows add a physical exclude pattern. Show tracked repository variant counts alongside logical skills.

Drop display-only rendered cases while retaining mutation protection and plain TypeScript logic coverage. Inspect target states in Clean/Playful light/dark and Traditional Chinese.

* docs(variants): explain diagnostics and add sync runbook

Document doctor variant_routing and logical/physical counts, diff selection skips, and the nested parent-skill boundary. Keep all four command translations aligned and add isolated account/project E2E scenarios.

Both runbook steps passed in the authorized Linux Codex container with separate HOME/XDG/TMPDIR fixtures. Website typecheck and all five locale builds passed.

* test(config): use native paths in project conversion fixture

The shared-agent regression fixture appended slash-separated suffixes to Windows temporary paths, so project path matching returned no candidates. Build each path with filepath.Join and preserve all conversion assertions.

Focused project configuration tests passed in the authorized isolated Linux Codex container, not the devcontainer. Windows CI verifies the platform-specific fixture correction.

* fix(ui): recompute shared skill routing for filter previews

Evaluate edited include/exclude settings in the complete target map before
classifying the draft, so a formerly shared folder no longer keeps its old
union when the filters differ. Preserve the saved target configuration.

* fix(mcp): keep parent skills when peer variants route elsewhere

Do not treat an otherwise eligible variant for another agent as an unserved
nested skill. Continue blocking parent publication for explicitly filtered,
disabled, ambiguous, or invalid children so filters still hide their files.

* fix(ui): distinguish agent selection from naming skips

Expose separate naming and selection skip counts on target summaries.
Show each applicable remedy in target details and sync previews so ambiguity
keeps its filter/override guidance alongside naming and collision hints.

* fix(list): include disabled rows in tracked repository counts

Count the complete inventory that list displays, including ignored skills
and physical variants, without changing the enabled counts used by status,
install, or sync. Clone rows before counting to preserve disabled state.

* docs: align variant counts and routing recovery guidance

Show logical skill and physical variant counts in list/install documentation
and keep the four translations aligned with the filtering examples. Explain
that agent-named skill parents keep ordinary nested skills and retain the
devcontainer-only runbook environment. Removal warnings now recommend a
source-local override, since include filters cannot undo agent routing.

* fix(mcp): preserve explicit target restrictions on nested variants

Limit the differently routed child exemption to automatic layout inference.
Frontmatter targets and dashboard source-local overrides must still prevent
a parent from publishing files explicitly restricted to another target.

* fix(ui): fill target name in naming warning guidance

Pass the current target name when rendering localized warning hints so the
same naming guidance shown beside the controls does not expose a placeholder
in the warning banner. Verified in the populated target preview.

---------

Co-authored-by: Willie <egg358358@gmail.com>
2026-10-29 16:47:38 +08:00
7ed64d431b docs(proposal): audit tracked updates before publication (#646)
* docs(proposal): isolate tracked update audits before publication

Concurrent readers can observe rejected revisions before rollback. Propose candidate auditing and exact-revision publication across tracked update entry points without prescribing the staging mechanism. Related to #645.

* docs(proposal): record completed tracked update isolation

Link the implementation in #647 and record private clone staging and exact-revision in-place publication without a multi-file atomicity guarantee. Preserve the proposal as a historical record rather than describing the pre-fix behavior as current.

---------

Co-authored-by: suainam <18585322+suainam@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-10-26 16:10:34 +08:00
trojanwk fafbe957d4 docs(proposals): show skill descriptions in the installed list (#631)
Record the independently requested local use case from #627 for maintainer discussion. Keep adoption optional and leave runtime behavior and the hierarchy-first scope unchanged.
2026-10-24 18:27:21 +08:00
trojanwk 017dfab88f docs(proposals): organize large skill lists with expandable package rows (#625)
* docs(proposals): describe expandable skill package rows

Large skill libraries flatten package roots and nested skills into peers. Propose path-based list hierarchy and outline optional list context controls while preserving install and sync semantics.

* docs(proposals): narrow skill hierarchy to maintainer feedback

Keep the first implementation focused on real directory ancestry, defer other list ideas, and define root-entry pagination so expanding a package does not split its children across pages. Prefix the proposal filename with its tracking issue.
2026-10-24 18:24:37 +08:00
Rusty ShacklefordandWillie 4f61689542 docs(proposals): define global project CLI scope (#592)
Co-authored-by: Willie <egg358358@gmail.com>
2026-10-23 01:04:42 +08:00
Willie fc1785673b docs: review-round limits and move-skill proposal (#510) (#516)
* docs(wiki): cap Codex review rounds and require a state matrix before review

PR #513 reached 7+ Codex rounds because each round surfaced one more
state dimension (project mode, tracked installs, followed links, legacy
keys, lock pins) that the change had never listed. Every round costs the
maintainer a review cycle.

Require a state matrix and a consumer sweep before the first review,
separate findings worth code from unrealistic combinations, and stop at
three rounds unless a finding shows data loss or a broken supported
workflow.

* docs(proposals): add move installed skill proposal for #510

Moving an installed skill with mv strands its install record, and the
documented workaround (uninstall + install --into) re-downloads and
drops audit acceptances and lock pins. Propose one explicit move
operation shared by the CLI, the Web API and the dashboard.

Records the maintainer decisions: no auto-sync, followed links refused,
target filters warn only, whole-folder move in v1, --force limited to
name collisions.

* fix(proposals): cover nested skills, bare tracked checkouts and duplicate destinations

Codex review of the move proposal found three gaps in the folder-move
design:

- A skill directory that contains nested skills was planned as one
  skill, so descendants would move on disk but keep their old records,
  pins and audit acceptances. Plan now expands descendants too.
- Refusals were derived from discovered skills only, so a tracked
  checkout with no discoverable skill would move along with its folder.
  Preflight now walks the whole tree for checkouts and links.
- Two inputs converging on one destination path were treated as a
  forceable flat-name collision and left the batch half-moved. They are
  now a separate, non-forceable duplicate_dest refusal.

* fix(proposals): keep nested records through reconcile, warn both filter directions, refuse overlapping roots

Second Codex round on the move proposal found three more gaps:

- The reconcile walk stops at an installed parent and then prunes every
  record it did not see, so a moved nested skill would lose its record
  and audit acceptances. Reconcile must keep records below a live
  installed record.
- Target filter warnings only covered rules that stop matching. A move
  into a folder that an exclude pattern covers (or an include newly
  adds) changes sync output too, so compare the effective filter result
  before and after.
- Batches such as `move foo foo/sub archive` planned the same subtree
  twice. Overlapping source roots are now refused before any rename.
2026-10-10 23:36:33 +08:00
Willie 61c366b391 docs(proposals): opt-in .skillfollow for declared source links (#369)
Adds proposals/274-skillfollow.md: an opt-in .skillfollow file that lets discovery follow declared first-level links in the skills source, so a tracked repo can live in the user projects directory. Without a .skillfollow, behavior does not change. The proposal answers the three requirements set in #274: a single source walker with a ratchet test, a three-part link ownership contract, and git staging and update rules for followed repos. Writes to the source go through an os.Root handle. Windows junction behavior was verified on a real machine.

Refs #274
2026-10-04 13:52:53 +08:00
Willie 1fe668ec54 ci(release): add reviewed version PRs and manual publication
Create Release Please PRs, synchronize release metadata, and test the exact merge commit before tagging and building an unpublished draft.

Verify release artifacts before manual publication and keep Homebrew and Docker distribution tied to the approved version. Document explicit version overrides and squash-merge behavior in the release skills and runbook.

Validation: make check, 12 release helper tests, actionlint, and an isolated six-platform GoReleaser build with artifact verification.
2026-10-02 01:53:47 +08:00
hhh2210 092f6a9fc8 proposal: add non-interactive list status filter 2026-07-29 22:15:12 +08:00
Rhys McNeill 6a0d1b7d03 ci(release): add proposal for release-please automation 2026-06-09 22:29:03 +08:00
김봉섭 62e571fe92 docs(proposals): propose extras in git integration (#171)
skillshare's git integration covers only the skills source today, so
extras (hooks, rules, commands, prompts) sit outside the commit/push/pull
workflow. This proposal asks that extras become a first-class git target.
2026-05-29 16:41:33 +08:00
Willie aba6f0c787 docs(proposal): mark #153 as shipped in v0.19.15
Adds Status block documenting what actually shipped (sources map only,
no source shorthand) and resolves the two Open Questions (external
gitignore: leave to repo; init -p --source flag: deferred).
2026-05-20 19:06:56 +08:00
wangyuhao 38317a1999 proposal: custom project source directories 2026-05-20 15:05:31 +08:00
Willie 1c0528ccf6 docs: revamp CONTRIBUTING.md with proposal workflow and PR template
Restructure contribution guidelines to clarify expectations:
- Issues are the primary entry point for all contributions
- PRs are for small fixes; features require issue + proposal first
- Implementation is handled by maintainer after proposal approval
- All development must use devcontainer (make devc)

Add PR template to surface checklist when contributors open PRs.
Add proposals/ directory with TEMPLATE.md for feature proposals.
2026-04-13 16:05:00 +08:00