Commit Graph
139 Commits
Author SHA1 Message Date
Willie 47dc9495fe fix: enforce install flag validation and project uninstall preflight 2026-02-18 22:23:50 +08:00
Willie b1ede8d918 fix: handle errors from ReconcileGlobalSkills, filepath.Walk, and remove redundant applyExclude
Address PR #29 review feedback:
- Log warnings on ReconcileGlobalSkills/ReconcileProjectSkills failures
  instead of silently discarding errors
- Propagate filepath.Walk callback errors in uninstall group/nested resolution
- Remove redundant applyExclude call in selectSkills (callers already filter)
2026-02-18 22:23:50 +08:00
Willie 95e7ee24a6 feat: auto-detect group in uninstall and update v0.14.0 docs
- Show "Uninstalling group (N skills)" with sub-skill listing when
  uninstalling a directory that contains sub-skills
- Update CHANGELOG, website uninstall docs with group detection example
- Update built-in skill references for v0.14.0: version bump,
  .skillignore, --exclude, license display, multi-skill uninstall,
  audit detection patterns table, Firebender target
2026-02-18 22:23:50 +08:00
Willie f99a29ac06 fix: show license in SkillBox for subdir single-skill install
handleGitSubdirInstall was missing the ui.SkillBox display that
handleGitDiscovery already had, so license frontmatter was silently
skipped when installing via a subdir URL with exactly one skill.
2026-02-18 22:23:50 +08:00
Willie 86d6134c58 feat: support multi-skill and group uninstall
Allow `skillshare uninstall` to accept multiple skill names and a
repeatable `--group`/`-G` flag for batch removal. Groups use prefix
matching so `--group frontend` removes `frontend/*` recursively.
Problematic skills are skipped with warnings (skip & continue).
Names and groups can be mixed; duplicates are deduplicated by path.
Single-skill invocation preserves backward-compatible output.
2026-02-18 22:23:50 +08:00
Willie 1ff2fe6881 feat: add group field to SkillEntry for organized skill placement
The --into flag information was previously encoded only in the name
field (e.g. name: frontend/pdf), causing config-based install to fail
because validate.SkillName() rejects slashes. Add an explicit group
field to separate placement from identity, with automatic migration
of legacy slash-in-name entries.

- Add Group field, FullName(), and EffectiveParts() to SkillEntry
- Update reconcilers to write new format and migrate legacy entries
- Fix installFromGlobalConfig/installFromProjectConfig to use
  EffectiveParts() for validation and FullName() for path construction
- Fix uninstall config cleanup to match via FullName()
- Add unit tests for SkillEntry helpers and reconciler group behavior
- Add 5 integration tests for group field end-to-end flows
- Document group field in declarative-manifest.md
2026-02-18 22:23:50 +08:00
Willie 001fff0c77 feat: add .skillignore, --exclude flag, and license display for install
Implement three install features with full documentation:

- .skillignore: repo-level file to hide skills from discovery (exact
  match + trailing wildcard). Applied during git repo discovery before
  any selection prompt.
- --exclude: CLI flag to skip specific skills during multi-skill install.
  Filters before the interactive prompt so excluded skills never appear.
  Warns when used with direct local-path installs (not applicable).
- License display: shows SKILL.md license frontmatter in selection
  prompts and single-skill confirmation screen.

Add 7 integration tests, 2 new doc pages (declarative-manifest,
url-formats), and cross-reference updates across 6 existing doc pages.
2026-02-18 22:23:50 +08:00
Willie 7abe17cc2c feat: add declarative skill manifest for global mode
Port the project-mode skill manifest pattern to global mode so
`config.yaml` supports a `skills:` section and `skillshare install`
(no args) installs all listed remote skills.

- Rename ProjectSkill → SkillEntry (shared by both modes)
- Add Skills []SkillEntry to global Config with validation
- Add ReconcileGlobalSkills() to auto-sync manifest after install
- Wire no-arg install, auto-reconcile on all install paths
  (including search → install), and uninstall cleanup
- Update server handlers for global reconciliation
- Update docs, tests, and CHANGELOG
2026-02-18 22:23:50 +08:00
Willie 0d9acb2594 fix: use official formula name in brew upgrade command
Drop the explicit `runkids/tap/` prefix so `brew upgrade` resolves
the formula the same way `brew install skillshare` does, avoiding
the spurious "Failed to load cask" error from a stale Casks entry.
2026-02-16 15:48:04 +08:00
Willie 76e1f6e3a9 fix: prune broken external symlinks after data migration (#28)
After data migration (e.g. XDG path change), target symlinks still
point to old source path. PruneOrphanLinks treated these as "external"
and always preserved them, even with --force.

- Auto-remove broken external symlinks (target no longer exists)
- Pass force flag to PruneOrphanLinks; force removes valid external symlinks
- Use utils.PathHasPrefix for Windows case-insensitive path comparison
2026-02-16 15:23:03 +08:00
Willie 684cd5b59d fix: compare skill version instead of file existence in upgrade
upgradeSkillshareSkill() previously only checked whether SKILL.md
existed, always reporting "Already up to date" regardless of actual
version. Now reads the frontmatter version field and compares against
the remote version, auto-updating when outdated.
2026-02-16 14:51:13 +08:00
Willie 9c51630b85 fix: bind port before opening browser to avoid connecting to stale server
Split ListenAndServe into Listen + Serve so port conflicts are detected
before the browser is opened.  Previously, openBrowser ran first and
could connect to an old skillshare ui process on the same port.
2026-02-16 12:28:03 +08:00
Willie 0b832f1d8c refactor: deduplicate skill target validation and project list display
- Extract findUnknownSkillTargets() into target_helpers.go, shared by
  check and doctor commands
- Reuse buildSkillEntries() + displaySkillsCompact() in project list,
  removing duplicate projectSkillEntry type and display functions
- Silence MigrationSkippedDestinationExists warning that fired on every
  run after a successful migration
2026-02-16 12:16:15 +08:00
Willie eed0bdaa24 fix: report migration outcomes and rewrite source after windows move 2026-02-16 11:20:31 +08:00
Willie 0bf84493cc feat: split XDG data/state dirs and add Windows legacy migration
Separate backups/trash into XDG_DATA_HOME and logs into XDG_STATE_HOME
instead of keeping everything under XDG_CONFIG_HOME. Add automatic
migration at startup to move existing data to the new locations.

Fix Windows path resolution: DataDir() and StateDir() now fall back to
%AppData% on Windows (matching BaseDir()), preventing incorrect use of
~/.local/share and ~/.local/state paths.

Add MigrateWindowsLegacyDir() to move pre-v0.13.0 data from
~\.config\skillshare\ to %AppData%\skillshare\ on Windows.

Update doctor, oplog, backup, trash, and all tests/docs accordingly.
2026-02-16 10:41:14 +08:00
Willie 41e822d979 feat: remove go:embed, serve UI exclusively via runtime download
Replace the embedded SPA (go:embed + build tags) with runtime download
from GitHub Releases. The binary no longer bundles UI assets — they are
downloaded on first `skillshare ui` launch and cached at
~/.cache/skillshare/ui/<version>/.

- Delete embed.go / embed_dev.go; add spa_disk.go with placeholder handler
- Simplify ensureUIAvailable(): cache check before dev-mode fallback
- Pre-download UI assets in `skillshare upgrade` (best-effort)
- Remove Node stages from production and CI Dockerfiles
- Keep Node stage in sandbox for playground UI cache pre-population
- Remove ui-embed-check CI job and -tags dev build flag
- Update Makefile, mise.toml, GoReleaser, release workflow
2026-02-16 02:58:22 +08:00
Willie 80c2d52fef feat: respect XDG Base Directory Specification (#26)
Add config.BaseDir() as single source of truth for base directory
resolution. Replace all hardcoded ~/.config/skillshare paths.

Path resolution priority:
  1. SKILLSHARE_CONFIG env var (unchanged)
  2. $XDG_CONFIG_HOME/skillshare (any platform)
  3. %AppData%/skillshare (Windows only)
  4. ~/.config/skillshare (Linux, macOS fallback)

- Add config.BaseDir() with XDG_CONFIG_HOME + Windows %AppData% support
- Update BackupDir(), TrashDir(), init default source to use BaseDir()
- Show resolved base directory in doctor output
- Add unit tests and integration tests for XDG override
- Document XDG_CONFIG_HOME and update Windows paths in docs
2026-02-16 01:23:36 +08:00
Willie 2dfe57a213 chore: improve list skills UX 2026-02-16 00:41:24 +08:00
Willie 403aafb254 feat: unify project target names with global names, add aliases for backward compat
Project targets now use the same short names as global targets (e.g.,
"claude" instead of "claude-code"). Old project_name values are preserved
as aliases so existing configs continue to work.

- Add Aliases field to targetSpec (deprecated, remove once safe)
- Update 11 targets in targets.yaml: project_name = global_name
- LookupProjectTarget falls back to alias lookup
- Fix 3 callers that bypassed LookupProjectTarget
- Extend MatchesTargetName and KnownTargetNames with alias support
- Add TestLookupProjectTarget_Alias
- Update all integration tests, docs, CLI help, and FAQ
2026-02-16 00:08:59 +08:00
Willie a29e198725 feat: add target filter CLI, skill-level targets field, and Web UI support
- CLI: `target <name> --add-include/--add-exclude/--remove-include/--remove-exclude`
- SKILL.md `targets` frontmatter restricts sync to specified targets
- Cross-mode matching (e.g. "claude" matches "claude-code" project target)
- Web UI: inline filter editor on Targets page, target badges on Skills pages
- API: PATCH /api/targets/{name} for filter updates
- Fix drift detection in doctor/status/handler to account for skill-level targets
- `check` warns about unknown target names in skill-level targets field
- Docs: update skill-format, target command, configuration, creating-skills
2026-02-15 23:29:30 +08:00
Willie d30d90af76 feat: update Homebrew install to homebrew-core and detect missing UI
- Update Homebrew command from tap (runkids/tap/skillshare) to
  homebrew-core (brew install skillshare) in README, website homepage,
  and getting-started docs
- Add note that Homebrew build is CLI-only (no web dashboard)
- Add IsUIBuilt() detection in embed.go/embed_dev.go to check for
  placeholder UI at startup
- Show CLI warning with install instructions when skillshare ui is
  run on a build without the frontend
- Add Homebrew Note section to commands/ui.md with migration steps
2026-02-15 16:18:26 +08:00
Willie d64e3b18f5 feat: add project mode and filter display to diff command
Support -p/--project flag with auto-detection, matching other
dual-mode commands. Show include/exclude filters in diff output
so users understand why certain skills are absent from results.
2026-02-14 21:59:40 +08:00
Willie db760b5f17 fix: suppress irrelevant doctor warnings in project mode
Skip git-not-initialized warning in project mode since the project
itself has version control and backups aren't used. Skip tracked repo
directories (_prefix) in SKILL.md validity check since they are
container directories for nested skills by design.
2026-02-14 21:46:31 +08:00
Willie 43d12b11c1 feat: per-target collision detection with filter-aware reporting
Collision checks previously ran on all skills before target filters,
producing false positive warnings when users route same-named skills
to different targets via include/exclude. Now collision detection
runs per-target after filtering, downgrading to info when filters
correctly isolate duplicates.

- Add CheckNameCollisionsForTargets() to internal/sync
- Replace collision blocks in sync.go and sync_project.go
- Show human-readable filter summary per merge target
- Add unit tests (5 cases) and integration test
- Update docs with new two-tier collision output examples
2026-02-14 18:35:21 +08:00
Willie 3d6de369a9 feat: add project mode support for doctor 2026-02-14 00:42:38 +08:00
Willie bd75ef8939 feat: support target include/exclude filters across sync, UI, and docs 2026-02-14 00:21:48 +08:00
Willie ffd9d43589 fix: target remove now properly cleans up merge mode symlinks
CLI unlinkMergeMode() used exact name matching (sourcePath + entryName)
to identify managed symlinks, which failed for nested skills (flat name
like _team__frontend__ui doesn't match source path _team/frontend/ui)
and orphaned symlinks. Changed to PathHasPrefix-based detection that
checks if a symlink points anywhere under the source directory.

Server handleRemoveTarget() only handled symlink mode (entire dir is a
symlink). Added merge mode branch with unlinkMergeSymlinks() that
iterates target entries and removes symlinks pointing under source.
2026-02-13 22:35:41 +08:00
Willie e5da171976 feat: add reminders and hub PR CTA 2026-02-13 14:57:18 +08:00
Willie 0b03a4e2fc fix(search): remove 20-result cap for hub search and add scroll-to-load
Hub search was capped at 20 results because it shared the same
normalizeLimit() path as GitHub search. Hub indexes are static JSON
(~100 entries), so returning all results is expected.

- Remove normalizeLimit() from hub search path; limit=0 means no limit
- Backend defaults to limit=0 for hub requests, 20 for GitHub
- CLI uses limit=0 when --hub is set without explicit --limit
- Frontend searchHub() no longer sends a limit parameter
- Replace IIFE rendering with useMemo for stable filter results
- Add IntersectionObserver-based scroll-to-load (20 items per batch)
2026-02-13 14:21:37 +08:00
Willie 0bd79a438e feat: add hub persistence to config for CLI and Web UI
Hub sources are now saved in config.yaml (both global and project),
replacing the Web UI's localStorage-based approach. This allows CLI
and UI to share the same hub list.

- Add HubConfig/HubEntry types and helper methods (resolve, add, remove)
- Add CLI subcommands: hub add/list/remove/default
- Search --hub now resolves saved labels (e.g. --hub team)
- Add REST API endpoints for hub CRUD (GET/PUT/POST/DELETE /api/hub/saved)
- Migrate SearchPage from localStorage to server API calls
2026-02-13 14:21:37 +08:00
Willie af8eae9005 fix: skip config loading for audit path mode
When `skillshare audit <path>` targets an existing file or directory,
config is not needed. Previously config.Load() ran unconditionally,
causing "config not found" errors in CI environments without a
skillshare config. Now path mode bypasses config loading entirely.
2026-02-13 14:21:37 +08:00
Willie b8e85874f3 feat: add fuzzy filter and tag display to search results
- Fuzzy match on skill name, substring match on description and tags
- Display tags (#tag) in both list mode and interactive selector
- Always show "Search again" option when filtering
2026-02-13 14:21:37 +08:00
Willie d0a1a8f890 feat: default --hub flag to community skillshare-hub when no URL given
`skillshare search --hub` now defaults to the community skillshare-hub
index instead of requiring a URL, making hub search more convenient.
2026-02-13 14:21:37 +08:00
Willie 6253099d7d fix: correct hub help text, gofmt alignment, and missing tags type
- Fix --index-url → --hub in hub index help text
- Fix gofmt struct field alignment in SearchResult after adding Tags
- Add missing tags field to frontend SearchResult TypeScript interface
2026-02-13 14:21:37 +08:00
Willie 88847ea3ae feat: add skill field to hub schema for multi-skill repo support
Hub JSON entries can now specify a `skill` field to target a specific
skill within a multi-skill repo. CLI auto-passes -s flag, Web UI
skips the picker modal when skill is specified.

Also adds Community Hub section to search docs with link to
runkids/skillshare-hub.
2026-02-13 14:21:37 +08:00
Willie cd81a01f99 docs: add hub index guide, command reference, and rename to skillshare-hub.json
Rename default output from index.json to skillshare-hub.json for
uniqueness. Add website docs for hub command and hub index guide.
Update search command docs with --index-url section. Add hub and
hub-index to sidebar.
2026-02-13 14:21:37 +08:00
Willie e44a727c4f feat(hub): add hub index CLI command and integration tests
Add `skillshare hub index` subcommand with --full, --source, --output
flags and mode-aware source resolution. Register hub in command map
and usage help.

Integration tests cover: index generation, custom output path, empty
source, full mode, minimal metadata suppression, help text, and
search --index-url with local files (including equals syntax and
browse-all).
2026-02-13 14:21:37 +08:00
Willie 0ff683167a feat(search): add --index-url for private index search
SearchFromIndexURL consumes hub-generated index.json (local or HTTP),
with sourcePath resolution, relative path detection (including Windows),
and limit enforcement. The search CLI routes to index search when
--index-url is provided, with conditional spinner text and scoped
GitHub-specific error handling.
2026-02-13 14:21:37 +08:00
Willie d8699762ad fix: use deep skill count in init and prevent null files in git status API
- init: replace shallow os.ReadDir count with DiscoverSourceSkills()
  to correctly count nested skills by SKILL.md presence
- handler_git: guard against nil slice from GetDirtyFiles() overwriting
  the initialized empty slice, which serialized as JSON null
- GitSyncPage: add optional chaining on status.files for defense
2026-02-13 14:21:36 +08:00
Willie 11e18dce00 fix: use git reset for clean history on init --remote, skip project auto-detect for global flags
- tryPullAfterRemoteSetup: replace git pull/merge with git reset --hard
  to avoid merge commits and ff-only/conflict issues when pulling from
  remote into a freshly initialized repo
- Add hasGlobalOnlyInitFlags() so init --remote works correctly even
  when cwd has .skillshare/config.yaml (project mode auto-detection)
- Update cross-machine-sync doc to reflect reset behavior
2026-02-13 14:21:36 +08:00
Willie f4be50bdd7 fix: shorten target multi-select labels for readability
Move path display to detection phase output. Multi-select options
now show only name + status instead of name + full path + status,
preventing an unreadable long line when all targets are selected.
2026-02-13 14:21:36 +08:00
Willie 3830543309 feat: auto-commit and auto-pull on init, improve git UX
Init now creates an initial commit (including .gitignore) so that
push/pull work immediately after setup. When a remote is configured,
init fetches and auto-pulls existing skills from the remote.

- Always create initial commit in doGitInit (fixes stale untracked
  .gitignore blocking pull)
- Add ensureGitIdentity: set repo-local fallback when git user.name
  is not configured, with hint to set global config
- Add tryPullAfterRemoteSetup: fetch remote after adding origin,
  auto-pull if remote has content and local is empty
- Add hintGitRemoteError: context-aware hints for SSH, URL, and
  network errors in push/pull
- Show Pro tip only when built-in skill is installed
- Sandbox: add --bare mode (skip auto-init), --volumes for down
  (full reset), and sandbox-reset / sandbox:reset targets
- Docs: update init flow diagram, cross-machine-sync guide,
  push/pull prerequisites, getting-started, troubleshooting
2026-02-13 14:21:36 +08:00
Willie 9ee5324689 feat: enhance security audit thresholds, logging, and UI 2026-02-13 14:21:36 +08:00
Willie aa43f94892 feat: add --into flag for skill install command
Allow installing skills into subdirectories for organized folder
structures. Works with all install modes (direct, discovery, tracked)
in both global and project mode.

- Add Into field to InstallOptions and IntoPath() validation
- Update 4 dest-path construction points in CLI with destWithInto()
- Update InstallTrackedRepo for --into prefix in dest and gitignore
- Rewrite ReconcileProjectSkills to use filepath.WalkDir (recursive)
- Add --into to Web UI install handler, API client, and form
- Add 5 integration tests covering local, multi-level, validation,
  project mode, and no-source rejection
2026-02-13 14:21:36 +08:00
Willie 3873960d84 feat: support nested skills in uninstall command
Previously `skillshare uninstall vue-best-practices` failed when the
skill lived under an organizational folder (e.g. frontend/vue/).
Now both global and project mode fall back to a basename search across
nested directories, matching the behavior already in check/update.

- Add resolveNestedSkillDir() with ambiguity detection
- Use as fallback in resolveUninstallTarget (global) and
  cmdUninstallProject (project)
- Also matches _name variant for nested tracked repos
- Add integration tests for basename and full-path uninstall
2026-02-13 14:21:36 +08:00
Willie 57e7b68131 feat: group shared-path agents in project init UI
Multiple agents (Amp, Codex, Copilot, Gemini, Goose, Kimi, OpenCode,
Replit) all map to .agents/skills in project mode. Previously init -p
showed each as a separate selectable entry pointing to the same directory,
which was redundant and confusing.

Now targets sharing a project path are collapsed into a single group entry
(e.g. "agents") with member names shown in parentheses. Discover uses
path-based dedup so an existing "amp" entry correctly prevents the
"agents" group from appearing as new. --select accepts both canonical
and member names for backward compatibility.

- Add project_name/project_path to agents meta-target in targets.yaml
- Add GroupedProjectTargets() in config package with unit tests
- Rewrite detect/list/prompt/discover in init_project.go
- Add agents target to playground demo project
2026-02-13 14:21:36 +08:00
Willie f50847eb6c feat: support nested skills in check/update and add organizing guide
GetTrackedRepos() and GetUpdatableSkills() now walk subdirectories
recursively so skills organized in folders (e.g. frontend/vue/) are
detected by check and update commands. Previously only direct children
of the source directory were scanned.

Also adds:
- Short name resolution for `update` (e.g. `update vue-best-practices`
  resolves to `frontend/vue/vue-best-practices`)
- Fix ReadMeta nil check in updateSkillOrRepo to ensure fallback fires
- Remove logo from `check`, replace with mode-aware header
- New docs guide: Organizing Skills with Folders
- Rename screenshot to organizing-skills-comparison.png
2026-02-13 14:21:36 +08:00
Willie 2c982848c5 feat: classify HIGH audit findings as warnings and refresh docs/playground 2026-02-11 10:10:09 +08:00
Willie 927bad707e feat: add audit rules Web UI page with create/edit support
Add REST API (GET/PUT/POST /api/audit/rules) for managing custom
audit-rules.yaml through the web dashboard. Extract template and
validation logic from CLI into reusable audit package functions
(ValidateRulesYAML, InitRulesFile, DefaultRulesTemplate). Frontend
provides CodeMirror YAML editor with dirty tracking, file creation
flow, and mode-aware path display. Sidebar nav gains overflow scroll.
2026-02-11 04:36:58 +08:00
Willie fbcec80788 feat: externalize audit rules to YAML with user customization
Move 17 hardcoded audit rules from Go structs to embedded rules.yaml,
enabling community PRs on rule definitions without recompilation.

Add user-customizable audit rules at two levels:
- Global: ~/.config/skillshare/audit-rules.yaml
- Project: .skillshare/audit-rules.yaml

Merge semantics: built-in → global → project. Users can append new
rules, override existing ones by id, or disable them (enabled: false).

Replace hardcoded localhostURL check with generic exclude regex field
on rules. Add --init-rules flag to scaffold a starter rules file.

Public API (ScanSkill, ScanContent, Finding, Result) unchanged —
callers require zero modifications.
2026-02-11 03:40:54 +08:00