Code quality fixes from review:
- Extract RemoveByNames() to eliminate copy-paste in uninstall Phase 7
- Add MetadataKindSkill/MetadataKindAgent constants
- Remove dual-write shim (findSkillsRoot + writeMetaToCentralized)
- install_apply.go uses WriteMetaToStore with SourceDir (no sidecar)
- Move LoadMetadata out of walk loops (P0 efficiency fix)
- isGroupDir accepts store parameter to avoid redundant loads
- Add SourceDir to InstallOptions for --into group support
- Dual-write in WriteMeta: also writes to .metadata.json for backward compat
- Migration looks in parent dir for registry.yaml
- Group uninstall matches entries by Group field + full path
- Sync test uses MetadataStore instead of registry.yaml
- All integration tests pass (0 FAIL)
Replace every remaining call to the old per-skill metadata API
(ReadMeta, RefreshMetaHashes, config.LoadRegistry) with the centralized
MetadataStore across 10 files:
Server handlers:
- handler_check.go: use s.skillsStore.Get() instead of ReadMeta
- handler_check_stream.go: same pattern as handler_check.go
- handler_skills_batch.go: use s.skillsStore.RefreshHashes() + Save()
CLI commands:
- check.go: load store once in collectCheckItems, use MetadataEntry
- doctor.go: load store once in checkSkillIntegrity
- list.go: load store once in buildSkillEntries (replaces parallel ReadMeta)
- uninstall.go: use skillsStore for display/dry-run/finalize
- uninstall_project.go: same pattern, remove config.LoadRegistry
- update_batch.go: pruneRegistry now uses MetadataStore
Hub:
- hub/index.go: load store once in BuildIndex
The only remaining ReadMeta call is in a test file
(search_batch_meta_roundtrip_test.go) which tests the shim itself.
- CheckAgents uses recursive discovery via resource.AgentKind{}.Discover()
so nested agents (e.g. demo/code-reviewer.md) are found correctly
- Add --group/-G flag to update, check, and uninstall agents commands
with shared validateAgentGroups/matchesAnyGroup helpers
- Fix TUI project-mode dispatch: call cmdUpdateAgentsProject and
cmdUninstallAgents directly instead of passing 'agents' keyword to
handlers that don't understand it
- TUI confirmation overlay shows correct command with 'agents' keyword
and confirmKind field tracks skill vs agent
- TUI toggleDisabled (E key) writes to .agentignore for agents instead
of .skillignore
- Agent Discover now marks .agentignore matches as Disabled=true instead
of skipping them, so disabled agents appear in list with [disabled] tag
- Sync filters out disabled agents via resource.ActiveAgents()
- auditSkillByName uses scanPathTarget to support single-file agent audit
- Uninstall agents display uses RelPath (e.g. demo/tutor) instead of
frontmatter name (e.g. Python Tutor Expert)
When extras has an entry named 'agents' whose target paths overlap with
the resolved agent target paths from targets.yaml, the extras targets
are skipped with a warning — the agents sync system takes priority.
Detection uses dual conditions: extras name == 'agents' AND resolved
path overlap. Non-'agents' extras targeting agent paths are unaffected.
Agents source must exist with actual files; empty/missing source means
no overlap (extras sync normally).
Also fixes:
- CheckAgents now recurses into subdirectories via resource.AgentKind
- update agents resolves nested agent names via filepath.Base
- filterAgentCheckResults matches both full path and basename
- Add Tab/Shift+Tab to cycle All/Skills/Agents tabs with count badges
- Tab bar renders at top with bold+underline cyan active, dim inactive
- Tab acts as pre-filter composing with text filter via AND logic
- Cache tab-filtered items in applyFilter() to avoid per-frame recomputation
- Add tabNoun() method to consolidate noun switches across title/filter bar
Agent install --into support:
- Support --into flag for agent install (CLI, server, project mode)
- Support --into=value syntax in addition to --into value
- Server handler_skills uses recursive AgentKind.Discover() for nested agents
- Fix agent metadata read path: use file basename instead of frontmatter name
- Sync --all flag now includes agent sync (not just extras)
Agent content viewer:
- Agents render full-width without sidebar (single .md file, no tree needed)
- Simplified help text and keyboard handling for agent content view
Agent uninstall fixes:
- Use discovery-based resolution instead of hardcoded name+.md path lookup
- Support matching by Name, FlatName, RelPath, or trimmed RelPath
- Compressed confirmation display (list format, max 20 shown)
UI polish:
- Help bar keys highlighted in dim cyan, descriptions in dim gray
- Align 'No items.' text with list title via PaddingLeft(2)
Without this, installDiscoveredAgents in project mode falls back to
the global agents path (~/.config/skillshare/agents/) instead of the
project agents path (.skillshare/agents/).
Both syncAgentsGlobal and syncAgentsProject now collect target names
where agentPath is empty and print a summary warning after the sync
summary line. This makes it visible to users which targets were
silently skipped, helping them configure agents paths if desired.
Mixed repos containing both skills/ and agents/ directories previously
only installed skills, silently ignoring agents. Now after every skill
install exit point, discovered agents are also installed to the agents
source directory.
- Add installDiscoveredAgents helper that installs agents post-skills
- Update 'Found' message to show agent count in mixed repos
- Call helper at all 4 skill install exit points in handleGitInstall
- Add integration test for mixed-repo install scenario
Pure-agent repos now show a checklist TUI for selecting which agents
to install (matching the skill install flow). Supports:
- Single agent: direct install (no TUI)
- Multi-agent: interactive checklist TUI (space/a/enter)
- --all/--yes: install all without prompt
- -a name1,name2: filter by name without prompt
- --dry-run: preview list
- Non-TTY: error with hint to use flags
- Batch progress: spinner (<=20) or progress bar (>20)
- Results display: installed/failed/skipped sections
When a repo has no SKILL.md files but contains .md agents (discovered
via Rule 4 fallback in discovery layer), the CLI now installs them
instead of showing 'No skills found'.
Adds handleAgentInstall() which:
- Respects --agent name filter
- Uses InstallAgentFromDiscovery() (same as UI flow)
- Supports --dry-run and --force
- Shows next-steps hint to run 'sync agents'
Merge agent diffs into skill diff results so both appear together
in the diff TUI. Agent entries display a cyan [A] badge prefix
in the detail panel's category listings.
Changes:
- Add mergeAgentDiffsGlobal/mergeAgentDiffsProject helpers that
compute agent diffs and merge them into per-target skill results
- Call merge helpers in cmdDiffGlobal and cmdDiffProject before
TUI/output rendering
- Build agent name set in buildDiffDetail and render [A] badge
for agent entries in category expansion
- Fix categorizeItems to handle agent-specific reasons
('not in target' → New, 'local file' → Local Only)
Add [A] badge to agent backup entries in the target list, and resolve
the correct agent target path when restoring. Agent backups (entries
ending with -agents) now look up AgentsConfig or fall back to builtin
DefaultAgentTargets for path resolution, both in the restore action
and in the detail/diff panels.
Agents are single .md files, not directories. The content viewer now:
- Detects agent vs skill via contentKind field on the model
- Renders agent .md content directly (no directory walk)
- Shows a single-file tree entry for the agent
- Resolves file paths from agentsSourcePath for agents
Add -p/--project support to 'backup agents' and 'restore agents' commands.
Project-mode backups are stored under .skillshare/backups/ (parallel to
.skillshare/trash/).
Backup engine changes:
- Add ProjectBackupDir(), CreateInDir(), ListInDir() to internal/backup
- Add RestoreLatestInDir(), FindBackupsForTargetInDir(),
GetBackupByTimestampInDir() to restore.go
- Existing global functions become thin wrappers (zero caller churn)
Command layer changes:
- Allow project mode through for kind=agents in cmdBackup/cmdRestore
- Auto-detect project mode when .skillshare/config.yaml exists
- Refactor backup_agents.go with resolveAgentBackupContext() to
resolve backup dir + agent targets per mode
Skills backup in project mode remains unsupported (error unchanged).
From 3-agent review (reuse, quality, efficiency):
Bug fix:
- syncAgentsProject: use resolveProjectAgentTargetPath instead of
inline path resolution (~ was not expanded for absolute paths)
Deduplication:
- Extract syncAgentTarget() shared by global + project sync loops
(eliminates 30-line copy-paste)
- Extract renderAgentCheck() shared by project + global check
(eliminates duplicate rendering block)
- Consolidate countLinkedAgents → delegates to countAgentLinksAndBroken
Efficiency:
- Use DirEntry.Type() instead of os.Lstat in diff_agents.go and
doctor_agents.go (saves one syscall per .md file)
Cleanup:
- Remove dead start param from cmdCollectAgents
- Remove unused imports
Net: -76 lines.
Remove all "not yet supported in project mode" errors. Every command
that supports agents in global mode now also supports project mode:
- status -p agents: shows project agent source + per-target status
- status -p all: shows both skills and agents
- check -p agents: checks agent status from .skillshare/agents/
- diff -p agents: computes agent diffs (missing/orphan per target)
- diff agents (global): also now fully implemented via diffGlobalAgents
- collect -p agents: collects local agents from project targets
- audit -p agents: scans .skillshare/agents/ for security patterns
New file: diff_agents.go — shared agent diff logic for both modes
(computeAgentDiff, diffProjectAgents, diffGlobalAgents).
11 new integration tests covering all 5 commands in project mode.
Total agent tests: 56.
7 new integration tests covering:
- trash agents empty / delete
- uninstall agents in project mode (fix: wire kind into project dispatch)
- check all (combined skill + agent)
- sync agents skips targets without agent path
- list all --json verifies kind field on every entry
- status agents --json with target details
Total agent tests: 45 (38 + 7).
list_tui_item: show [A] badge prefix for agents in terminal list view.
list.go: add Kind field to skillEntry and skillJSON structs.
SyncPage: add kind badge to diff items using DiffTarget.items.kind.
AuditPage: add kind badge to audit result cards.
UpdatePage: add kind badge to update result items.
SkillPickerModal: add kind badge in skill picker.
client.ts: add kind to DiffTarget items and AuditResult types.
check: add parseKindArg() for 'skillshare check agents'. When agents
kind selected, runs CheckAgents() on agents source dir and displays
per-agent status (up_to_date/drifted/local/error). Supports --json.
uninstall: add --kind flag to parseUninstallArgs and parseKindFlag()
in cmdUninstall dispatch. Kind stored in uninstallOptions for
agent-specific uninstall routing.
SkillDetailPage: import KindBadge, show kind badge (S/A) next to skill
name in the detail header.
audit: add parseKindArg() for 'skillshare audit agents' syntax. Kind
filter parsing ready, actual agent-only filtering to be wired.
enable.go: support --kind agent flag to route enable/disable operations
to .agentignore instead of .skillignore. Works in both global and project
modes. Oplog entries now include kind field.
TargetsPage.tsx: show agent path below skill path when target has
agentPath. Display agent linked count alongside skill counts.
status: show agents source path and agent count alongside skills source.
doctor: add checkAgentsSource() health check verifying agents source
directory exists, is a directory, and reports agent count. Non-existent
dir is info (not error) since agents are optional.
handler_trash: add kind field to trashItemJSON for frontend badge.
Add kind_filter.go with two parsing strategies:
- parseKindArg(): positional syntax (list agents, sync skills)
- parseKindFlag(): flag syntax (uninstall --kind agent tutor)
resourceKindFilter type with IncludesSkills()/IncludesAgents() helpers
for handler-level routing. Supports singular and plural forms
(skill/skills, agent/agents).
16 test cases covering both parsers and filter logic.
Add AgentsSource field to Config struct with EffectiveAgentsSource()
method that defaults to ~/.config/skillshare/agents when not set.
Global init now creates agents source directory alongside skills source.
Project init creates .skillshare/agents/ alongside .skillshare/skills/.
projectRuntime gains agentsSourcePath field for project-mode agent ops.
Update config.schema.json with agents_source property definition.
status command used a legacy local parser that only looked for a
top-level version: key in SKILL.md frontmatter, always returning empty
since version now lives under metadata.version.
Replace local readSkillVersion() and fetchRemoteSkillVersion() with
the shared versioncheck.ReadLocalSkillVersion() and
FetchRemoteSkillVersion() from internal/version, matching what doctor
and upgrade already use.
Remove now-unused skillshareSkillURL constant from init.go.
Closes#121
Replace direct os.Symlink calls in extras.go with createLink, gaining:
- Relative symlink support in project mode
- Windows junction fallback for extras (previously missing)
Thread projectRoot through SyncExtra, CollectExtraFiles, and all callers.
Ref: #120
Project-mode sync now passes the project root directory through to
createLink, enabling relative symlinks for all paths under the project.
Server handlers use s.projectRoot for project-mode dashboards.
Ref: #120
SyncTargetMerge, SyncTargetMergeWithSkills, CreateSymlink, and SyncTarget
now accept projectRoot. When non-empty, createLink uses relative symlinks
for paths under the project root.
All existing callers pass empty string (global mode, no behavior change).
Ref: #120
Sync's registry prune logic removed entries for installed skills whose
files were missing from disk. This was wrong: the registry is the
authoritative record of installations managed by install/uninstall.
Remove PruneStaleSkills calls from sync (CLI global, CLI project, and
web UI handler). Reconcile (called during install) still uses prune
with full metadata context, which is correct.
Fixes: running 'sync' after 'install' would clear registry.yaml when
the installed skill's source files were not yet on disk.
- doctor: replace inline frontmatter parser with version.ReadLocalSkillVersion
which correctly reads nested metadata.version (fixes#119)
- frontmatter_write: use TrimRight instead of TrimSpace for --- delimiter
so indented --- inside YAML block scalars is not mistaken for end marker
- Update changelog and website changelog for v0.18.7
- Fix UI batch uninstall not removing nested skill registry entries:
handler used flat names (__) but registry stores path names (/),
now tracks exact RelPath from discovered skills for matching
- Add stale entry pruning to ReconcileGlobalSkills and
ReconcileProjectSkills using a live set built during disk walk,
so skills deleted from source are removed from registry
- Trigger registry reconcile after sync in both UI handler (via defer
for early-return safety) and CLI (global + project mode), writing
warnings to stderr to avoid corrupting --json output
- UI: fix BatchUninstallPage search treating plain text as exact-match
glob (now substring search when no * or ? present), display nested
skill paths with / instead of __ in confirm and result dialogs
- UI: hide redundant 'X repo(s) and Y skill(s) already up to date'
line on UpdatePage when everything is already current
- Fix test isolation: set XDG_CONFIG_HOME in server test helpers to
prevent host agents dir leaking into test results, skip chmod-based
oplog test when running as root
- Add README badge for Awesome Codex CLI
Add --help/-h flag handling to 7 commands that were missing it:
sync, status, collect, pull, push, doctor, ui.
Previously, running e.g. 'skillshare push --help' would execute
the push instead of showing help. Now all commands safely show
usage info when --help is passed.
Also adds wantsHelp() helper to reduce duplication across commands.
Closes#113
P1: check.go '@' separator broke SSH URLs (git@github.com:org/repo)
— splitURLBranch would split at the '@' in the URL itself
— Fix: use tab character as separator (cannot appear in URLs)
— Added unit test for SSH URL round-trip
P1: install_config.go grouped same-repo different-branch skills together
— groupConfigSkillsByRepo keyed by CloneURL only, ignoring Branch
— Fix: include branch in grouping key so each branch clones separately
P2: reconcile never cleared stale branch from registry
— Only updated when meta.Branch was non-empty, never cleared it
— Fix: sync branch unconditionally when meta is available