- Global update: use SectionLabel for Summary/Next Steps when >10 skills
- Project batch update: add HeaderBox, track skipped count, show
summary box with updated/skipped/security-failed/total counts
Support bulk uninstall via 'skillshare uninstall --all' in both global
and project modes. Uses glob-based discovery to find all skills and
tracked repos, with --dry-run preview and --force to skip confirmation.
- Parse --all with mutual exclusion vs skill names and --group
- Global: discover skills + tracked repos from source directory
- Project: discover from .skillshare/skills/ directory
- Prune orphan symlinks from targets after removal
- Integration tests for --all, --all --dry-run, and conflict errors
- Update uninstall docs with --all examples
- Add AI runbook for uninstall --all glob testing
Large repos (900+ skills) produced overwhelming output in three areas:
1. Dry-run skill list: 4 loops replaced with printSkillListCompact()
- ≤20: show all (unchanged); >20: first 10 + "... and N more"
2. --audit-verbose batch warnings (displayInstallResults):
- ≤20 skills with warnings: full verbose (unchanged)
- >20: compact summary + HIGH/CRITICAL findings only from top 20
skills; LOW/MEDIUM/INFO summarized as "also: LOW=N"
3. --audit-verbose blocked failures:
- ≤20 blocked: full message (unchanged)
- >20: first 20 verbose, rest compact
New helpers: printSkillListCompact, renderInstallWarningsHighCriticalOnly,
sortResultsByHighCritical, countSkillsWithWarnings, hasHighCriticalWarnings.
- Extend .skillshare-manifest.json tracking from copy mode to merge mode.
- Update PruneOrphanLinks to prioritize manifest records over naming patterns.
- Ensure SyncTargetMerge writes to manifest for all linked/updated skills.
- Add integration tests for uninstall + sync orphan directory cleanup.
- Maintain backward compatibility for targets without existing manifests.
Closes#42
Some AI CLIs (Cursor, Antigravity, Copilot, OpenCode) skip symlinks
when scanning skill directories, causing symlinked skills to be
silently ignored during auto-discovery.
Changes:
- `init --mode <merge|copy|symlink>` / `-m`: set default sync mode at
init time (global and project); interactive prompt when TTY detected
- `init --discover --mode`: applies mode only to newly added targets,
leaving existing targets unchanged
- Per-target mode hint after `sync` and `doctor`: suggests `copy` for
known compatibility-sensitive targets (cursor → antigravity →
copilot → opencode); suppressed when only claude/codex configured
- Neutral decision matrix in sync-modes.md for constraint-based choice
- By-target override examples in target.md, sync.md, first-sync.md
- Integration tests for mode flag, discover+mode, hint presence/absence
InstallTrackedRepo and updateTrackedRepo had no security audit,
allowing --track to bypass all supply-chain checks. This adds
auditTrackedRepo (removes repo on block for fresh installs) and
auditTrackedRepoUpdate (git reset rollback for updates), plus
input validation, testable removeAll, and hardened error handling
across audit/install/uninstall paths.
Merge auditGateAfterPull and auditGateAfterPullProject into a single
function by accepting an auditScanFunc callback. Callers pass either
audit.ScanSkill directly or a closure capturing projectRoot for
project-mode scans. Removes ~50 lines of duplicated security logic.
Addresses PR #43 review feedback (code duplication in audit gate).
Regular skills (non-git, metadata-based) now support --diff flag using
hash-based file comparison, display audit results after update, and
properly enforce the audit gate by not passing Force to inner Install.
- cmd/skillshare/update_test.go: table-driven test covering all
isSecurityError keywords (security audit, post-update audit,
rolled back, rollback failed) and negative cases
- internal/server/handler_update_test.go: three tests for
auditGateTrackedRepo: rollback failure warning on HIGH findings,
rollback failure warning on scan error, and clean repo returns nil
- handler_update.go: check git.ResetHard return value; if rollback
fails, append explicit warning to blocked message instead of
silently claiming rolled back
- update.go: add "post-update audit" to isSecurityError keywords
so install.Install audit failures are correctly classified as
security blocks in batch exit code
When a group directory (e.g. `fix-review`) was uninstalled as a whole,
only the directory name was checked against config entries. But skills
in the manifest use FullName format (`group/skill`), so the exact match
never hit. Now uses prefix matching to also remove member skill entries.
- P1: Batch/all update now returns non-zero when repos are blocked by
security audit (fail-closed for CI pipelines)
- P2: Pass --skip-audit to regular skill update via InstallOptions
- P2: Add path containment check in content integrity to prevent
directory traversal via crafted file_hashes keys
- P3: Switch git diff parsing to NUL-delimited (-z) for safe handling
of special filenames
Supply-chain hardening Phase 2:
- Add post-pull audit gate: HIGH/CRITICAL findings auto-rollback in
non-interactive mode (fail-closed), prompt in TTY mode
- Use full 40-char commit hashes for reliable rollback (avoids short-hash ambiguity)
- Add --skip-audit flag to bypass the gate when risk is accepted
- Add --diff flag to show file-level change summary after tracked repo update
- Add GetChangedFiles() and ResetHard() git helpers
- Add audit gate in install --update git-pull path to prevent bypass
Supply-chain hardening Phase 1:
- Add source-repository-link-0 rule (HIGH) to detect [source repository](url) patterns
- Exclude source-repo labels from external-link-0 to prevent double-reporting
- Introduce risk floor: RiskLabel = max(score-label, severity-floor) so a
single HIGH finding produces "high" risk instead of "low"
- Apply severity floor to CLI summary, server API summary, and per-result risk
Inspired by #39 — batch lines, summary box, severity counts, and
single-skill risk all use a consistent color ramp:
CRITICAL → red, HIGH → orange, MEDIUM → yellow, LOW/INFO → gray.
Also hide elapsed time when < 1s for cleaner batch output.
Deduplicate bounded-concurrency worker pool that was repeated in
auditInstalled(), auditFiltered(), and handleAuditAll(). The new
audit.ParallelScan() centralises the pattern with index-aligned
results, reducing ~90 lines to a single reusable function.
- firstPull: attempt merge instead of blocking when both local and
remote have skills; override merge.ff=only with -c merge.ff=false
- auditSkillByName: fall back to collectInstalledSkillPaths for
short-name resolution of nested skills (e.g. security/audit-demo-*)
- Add external-link and dangling-link demo skills to sandbox content
Allow `skillshare audit a b c` and `--group`/`-G` flags to filter
which skills are scanned, matching the existing check/update pattern.
Single-name audit preserves detailed output; multi-target uses batch
format with parallel scanning.
Use bounded goroutine pool (max 8 workers) for audit.ScanSkill calls
in both auditInstalled (CLI) and handleAuditAll (API). Scan results
are collected into a pre-allocated slice, then processed sequentially
for deterministic output ordering and summary accumulation.
Add LC_ALL=C to git command environments in push, init commit, and
remote fetch to prevent locale-dependent output from breaking string
matching (e.g. "nothing to commit" in non-English locales).
Parallelize audit.ScanSkill in BuildIndex using goroutines with a
bounded semaphore (max 8 workers) to reduce index generation time
for large skill collections.
doGitInit() previously committed immediately (only .gitignore), but
installSkillIfNeeded() runs later — leaving skill files uncommitted.
This caused "Local changes detected" on first pull.
Move commit to a single commitSourceFiles() call at the end of init,
after all files are in place. Covers all scenarios:
performFreshInit (first-time init):
- No remote, no skill → 1 commit: "Initial commit" (.gitignore)
- No remote, with skill → 1 commit: "Initial skills" (.gitignore + skill)
- Remote empty → same as above, remote fetch is no-op
- Remote has skills → reset --hard to remote; commitSourceFiles is no-op
- Remote unreachable → same as no-remote (fetch fails gracefully)
handleExistingInit (init --remote on existing config):
- Git exists → commitSourceFiles is no-op (already committed)
- Git not exists, remote reachable → commit before setupGitRemote so
HEAD exists for reset --hard
- Git not exists, remote unreachable → commit .gitignore so push/pull
don't see "Local changes detected"
- CLI auth hint now shows PowerShell syntax on Windows, export on Unix
- Docs: add Windows PowerShell examples for GITLAB_TOKEN, BITBUCKET_TOKEN,
SKILLSHARE_GIT_TOKEN in environment-variables.md
- Docs: rewrite auth error section in common-errors.md with token env var
options, Windows syntax, and GitLab token type warning
Auth errors (Authentication failed, Access denied) were not detected by
hintGitRemoteError, causing push to misleadingly suggest "skillshare
pull" as a remedy. Now detects auth errors and shows actionable options
(SSH URL, token env vars, credential helper). Pull also benefits since
it shares hintGitRemoteError.
Fixes multiple issues with the cross-machine sync workflow reported
in runkids/skillshare#35:
- push/pull auto-detect missing upstream and set it on first use
(push uses -u, pull uses fetch + reset + set-upstream-to)
- First pull checks local/remote skill directories before resetting;
refuses to overwrite local skills unless --force is passed
- init --remote auto-initializes git when config exists but .git does not
- HTTPS token auth (GITHUB_TOKEN, GITLAB_TOKEN, etc.) injected into
push, pull, and init remote fetch
- init --help shows init-specific flags and examples
- Remote repos with only files (README) no longer misdetected as
having skills (uses git ls-tree -d)
- Error hints suggest skillshare init --remote instead of raw git
- SyncTargetCopy replaces non-directory managed entries with proper
skill directories; skips local non-directory entries unless --force
- CheckStatusCopy only counts managed entries that are actual
directories on disk
- diff and server diff handlers report "target entry is not a
directory" for both managed and unmanaged non-directory entries
- Add tests for non-directory edge cases in sync, diff, and target info
- P1: diff now checks target skill directory exists before comparing
checksums; deleted directories are reported as "missing" instead of
being silently treated as synced
- P2: CheckStatusCopy counts only managed entries that exist on disk,
so target info shows accurate managed count
- Add tests for deleted target dir detection and manifest/disk mismatch
- P1: diff now compares checksums to detect content drift in copy mode
- P2: diff routes on config mode instead of manifest presence
- P2: project target remove cleans up manifest file
- P3: target info uses mode-appropriate status check (copy/merge/symlink)
- Export DirChecksum for use by diff and server handlers
- Add 4 integration tests covering all fixed scenarios
Add a third sync mode (`copy`) that copies skills as real files instead
of symlinks, with a `.skillshare-manifest.json` tracking managed skills
and SHA256 checksums for incremental updates.
- Manifest-based tracking: skip unchanged, update modified, --force all
- Pruning: remove managed copies no longer in source
- Mode conversion: bidirectional merge↔copy and symlink↔copy
- Full command support: sync, status, doctor, diff, target, collect
- Server API + Web UI: targets list, drift detection, filter editing
- include/exclude filters work in both merge and copy modes
- 12 integration tests covering all acceptance criteria
- Documentation updated across 13 pages
Closes#31
Allow `check` to target specific skills/repos instead of always scanning
everything. Adds parseCheckArgs, runCheckFiltered with spinner, and
positional group auto-detection — reusing resolve logic from update.
No args = check all (existing behavior preserved).
Allow `update` to accept multiple positional names and a repeatable
`--group/-G` flag, matching the UX already available in `uninstall`.
- Add `updateOptions` struct and `parseUpdateArgs` (mirrors `parseUninstallArgs`)
- Add `resolveGroupUpdatable` to walk a group dir for updatable items only
(tracked repos or skills with metadata; local skills silently skipped)
- Add `isGroupDir` to auto-detect positional args that are group directories
(checked before basename resolution so "feature-radar" expands the group
rather than matching the nested "feature-radar/feature-radar" by basename)
- Refactor `cmdUpdate` (global) and `cmdUpdateProject` (project) to use the
shared parser and support batch updates
- `--all` is mutually exclusive with names/groups
- Project mode preserves default `--all` when no args given
- 10 new integration tests (8 global + 2 project)
- Update docs with multi-name, --group examples and options table
- Show "Uninstalling group (N skills)" with sub-skill listing when
uninstalling a directory that contains sub-skills
- Update CHANGELOG, website uninstall docs with group detection example
- Update built-in skill references for v0.14.0: version bump,
.skillignore, --exclude, license display, multi-skill uninstall,
audit detection patterns table, Firebender target
handleGitSubdirInstall was missing the ui.SkillBox display that
handleGitDiscovery already had, so license frontmatter was silently
skipped when installing via a subdir URL with exactly one skill.
Allow `skillshare uninstall` to accept multiple skill names and a
repeatable `--group`/`-G` flag for batch removal. Groups use prefix
matching so `--group frontend` removes `frontend/*` recursively.
Problematic skills are skipped with warnings (skip & continue).
Names and groups can be mixed; duplicates are deduplicated by path.
Single-skill invocation preserves backward-compatible output.
The --into flag information was previously encoded only in the name
field (e.g. name: frontend/pdf), causing config-based install to fail
because validate.SkillName() rejects slashes. Add an explicit group
field to separate placement from identity, with automatic migration
of legacy slash-in-name entries.
- Add Group field, FullName(), and EffectiveParts() to SkillEntry
- Update reconcilers to write new format and migrate legacy entries
- Fix installFromGlobalConfig/installFromProjectConfig to use
EffectiveParts() for validation and FullName() for path construction
- Fix uninstall config cleanup to match via FullName()
- Add unit tests for SkillEntry helpers and reconciler group behavior
- Add 5 integration tests for group field end-to-end flows
- Document group field in declarative-manifest.md