Previously, `skillshare upgrade` via Homebrew only showed "Upgraded" with
no version info, and skill downloads had the same issue. Now all upgrade
paths display clear version transitions:
- Homebrew: "Upgraded v0.16.3 → v0.16.5" or "Already up to date ✓"
- Direct download: "Upgraded v0.16.3 → v0.16.5" (was "Upgraded to v0.16.5")
- Skill install: "Installed v0.16.5" (new) or "Upgraded v0.1.0 → v0.16.5"
Also records toVersion in oplog for Homebrew upgrades.
status: single DiscoverSourceSkills pass shared across printSourceStatus,
printTrackedReposStatus, and printTargetsStatus; extractTrackedRepos
replaces GetTrackedRepos Walk; targetStatusResult carries syncedCount
so drift check reuses getMerge/CopyStatusDetail results.
doctor: single DiscoverSourceSkills pass shared across 5 check functions
(checkSource, checkSkillsValidity, checkSkillTargetsField, checkSyncDrift,
checkDuplicateSkills); cachedTargetStatus map lets checkSyncDrift reuse
checkTargets results; checkForUpdates network request runs in goroutine
overlapping local I/O.
Both commands show a spinner during discovery to avoid appearing frozen
on large skill sets.
Remove 2-space indent from spinner Success/Fail/Warn and
SuccessMsg/ErrorMsg so they align with other ui.Success output.
Move backup after discovery in sync so it is skipped when there
are 0 skills to sync — no point backing up if nothing will change.
- Fix non-TTY progress bar not incrementing for grouped skills in Phase 2
- Fix Unicode truncation in UpdateTitle using runewidth instead of len()
- Fix IP address regex missing end-of-line bare IPs (add $ anchor)
- Fix gofmt alignment in updateTarget struct comments
- Extract sliceHasName[T] generic helper to deduplicate universal detection
- Add nil meta defensive warning with skipped count in grouped updates
- Replace hand-rolled contains/containsStr with strings.Contains in tests
- Add red team TC-20b for inline code fetch-with-pipe detection
Optimize grouped repo updates by skipping reinstall when installed metadata already matches remote state (commit match, or subdir tree-hash match when HEAD moved).
Emit per-skill grouped progress events so the batch progress bar advances continuously instead of appearing stuck at 0%.
When skipping by tree-hash match, best-effort refresh meta.Version to latest commit to keep status/version output current.
Add unit tests covering commit/tree-hash skip behavior and metadata version refresh.
Drop the fixed 50ms sleep in the grouped batch update iteration. On very large update --all runs this sleep dominates runtime (for example ~90 minutes at ~108k skills) without improving correctness.
This keeps progress updates intact while eliminating artificial throttling in TTY mode.
- Add PhaseHeader UI helper for "[1/3] Pulling N tracked repos..." labels
- Show phase headers between batch update phases when 2+ phases exist
- Skip phase headers when only 1 phase (avoids meaningless "[1/1]")
- Lazily start progress bar after first phase header to fix ordering
- Add scanning spinner during filepath.Walk for large skill sets
- Cache metadata in updateTarget to avoid redundant ReadMeta calls
UpdateGitIgnore/RemoveFromGitIgnore were called per-skill inside loops,
re-reading the entire .gitignore each time. With large files (100K+ lines
in project mode), this caused O(N×M) complexity and process hangs.
- Add UpdateGitIgnoreBatch and RemoveFromGitIgnoreBatch (single read/write)
- ReconcileProjectSkills: collect entries during walk, batch-update once
- uninstall (global + project): batch-remove after loop, not per-iteration
- Fix spinner WithRemoveWhenDone in StartSpinnerWithSteps
- Add E2E runbook for gitignore batch performance validation
When pull calls cmdSync with empty args in a directory containing
.skillshare/config.yaml, auto-detection incorrectly switches to
project mode. Pass --global explicitly since pull always operates
on the global source.
A/U/X shortcuts now show a confirmation overlay (→ skillshare <action>
<flag> <skill>, Proceed? [Y/n]) before executing. This prevents
accidental actions and lets users see the exact command.
Global mode dispatch now passes -g to audit/update/uninstall, fixing
auto-detect misidentifying as project mode when .skillshare/ exists
in cwd. Uninstall adds --force to skip double confirmation since
the TUI already confirmed.
Add generic OperationSummary() with Metric struct for consistent
batch output. Refactor SyncSummary/UpdateSummary as thin wrappers.
Apply unified patterns to collect, uninstall, backup:
- Spinner for scanning phases
- StepDone/StepSkip/StepFail semantic indicators
- OperationSummary for batch results
- Header before collect scanning for context
- Spacing before backup "Recent backups" section
Fix pterm spinner RemoveWhenDone bug: Success/Fail/Warn messages
were silently eaten because Stop() clears the line after printing.
Use Stop() + lightweight symbols (✓/✗/!) instead of pterm badges.
Also replace SuccessMsg/ErrorMsg pterm.Success/Error badges.
- Change universal description from "(recommended)" to "(shared agent directory)"
in detect, checklist, and discover flows
- Add FAQ section on using universal alongside npx skills: merge vs copy mode
differences, name collision caveats, lock file visibility
- Add universal info admonition to supported-targets page
- Add E2E runbook for universal target path verification
- Update CHANGELOG and release notes for v0.16.4
Add 5 new audit rules (31 → 36 total) to close detection gaps:
- fetch-with-pipe (HIGH ×3): curl/wget piped to sh/bash/python/node/etc.
Previously only double-pipe (||) was caught by shell-chain; single
pipe (|) to interpreters — the classic RCE vector — was undetected.
- ip-address-url (MEDIUM): URLs with raw IP addresses that bypass DNS
security controls; excludes RFC 1918 and loopback ranges.
- data-uri (HIGH): data: URIs in markdown links that may embed
executable content.
fetch-with-pipe is suppressed inside markdown code fences (tutorial
context), matching existing behavior for destructive-commands et al.
Includes unit tests (25 cases), code fence suppression test, red team
TC-18 through TC-21, and audit.md documentation updates.
The universal target pointed to ~/.config/agents/skills (wrong) instead
of ~/.agents/skills, causing `npx skills list` to miss synced skills.
Also auto-recommend universal as a target whenever any CLI is detected
during `init` and `init --discover`, since ~/.agents/ won't exist on
disk until skillshare creates it.
Closes#54
Prevent accidental duplicate installs when the same repo is already
installed at a different path (e.g., --into vs root). Same-repo
reinstalls now show a friendly skip indicator instead of an error.
- Add CheckCrossPathDuplicate() with URL normalization (HTTPS/SSH)
- Add ErrSkipSameRepo sentinel for graceful skip flow control
- Add checkExistingConflict() with repo URL comparison
- Fix --force hint to use repo URL (not per-skill subpath) and
include --into when applicable
- Add dedup check to Web UI install endpoints (HTTP 409)
- Group skipped skills by directory with repo label in summary
Root-level skills (SKILL.md at repo root) have meta.Subdir="" but
discoverSkills() returns Path=".". The mismatch caused lookup failure
in batch update, falsely reporting these skills as stale/deleted.
When list or log TUI loads zero items asynchronously, exit the TUI
immediately and print a plain-text hint instead of showing an empty
interactive screen. Uses an emptyResult flag on the TUI model to
signal the caller after tea.Quit.
After pre-flight filters out dirty tracked repos, recalculate summary
so spinner and confirm prompt use correct noun type. Print skip count
when repos are skipped. Replace all "(s)" patterns with pluralS() for
natural English output ("2 groups" not "2 group(s)"). Add isMixed()
method to avoid magic string comparison on noun().
Switch config install and search install UI from plain spinner to
TreeSpinner with StepResult summary showing installed/skipped/failed
counts and elapsed time. Add git clone progress callback to spinners
so users see real-time cloning status.
- Add Quiet field to InstallOptions for suppressing per-skill output
- Add Skipped field to ConfigInstallResult for accurate summary
- Update integration test assertion to match new summary format
Use a repo-root source in grouped search installs by normalizing from CloneURL instead of carrying subdir Raw values. This prevents malformed metadata sources (for example duplicated subdir paths) and keeps provider-agnostic behavior for GitHub/GitLab/Bitbucket/Azure and SSH URLs.
Also centralize discovery source formatting for metadata so whole-repo SSH installs use //subdir syntax consistently.
Add regression coverage:
- cmd unit tests for grouped clone source normalization across providers
- install unit tests for discovery source formatting (including SSH)
- integration test in tests/integration that verifies grouped install metadata source round-trips through ParseSource.
Replace GitHub-specific GitHubOwner()/GitHubRepo() calls with a
value copy of the parsed source, clearing only Subdir. Fixes empty
Raw/Name for GitLab, Bitbucket, and Azure DevOps batch installs.
Replace plain-text risk badges with lipgloss-styled colored versions
in the search TUI list and detail panel, matching the severity color
palette used elsewhere. Add CHANGELOG entry for v0.16.3.
Classify failure details by type (security/ambiguous/not found) with
distinct icons and colors. Truncate long ambiguous path lists and audit
findings to 3 lines + "(+N more)" to prevent screen flooding. Add
breathing room between multi-line entries. Highlight skill names in
bright white for better scanability.
Also includes repo-grouping refactor: skills from the same git repo
are cloned once and installed from the shared clone, with extracted
helpers (groupByRepo, installFromDiscoveryResult, logSkillInstallOp).
- Show detailed git clone status (cloning 45%, resolving 67%) instead of
static "installing..." by wiring up install.OnProgress callback
- Only show actively installing skills in progress area (skip queued/done)
- Move per-skill reconcile to single batch-level reconcile at end, fixing
O(n²) directory walks that caused batch installs to appear stuck
The custom thread-safe progress bar (progress.go) had width overflow
issues. Revert to pterm's built-in ProgressbarPrinter which handles
terminal width calculation internally. Remove StartProgressWithMaxWidth
in favor of the simpler StartProgress API.
Add vertical spacing between panels, stats, and help bar in list and
log TUIs to match the audit TUI layout. Adjust panel heights to
compensate for the added lines.
pterm's ProgressbarPrinter has no internal mutex, causing race conditions
when multiple goroutines call Increment() concurrently — the final render
could show a stale count (e.g. 954/955 instead of 955/955). Additionally,
pterm's auto-stop (triggered when Current >= Total) made external Stop()
a no-op, preventing us from controlling the final display.
New progress.go implementation:
- Uses sync/atomic for thread-safe counter updates
- Stop() forces current=total and renders a final frame
- Adds StartProgressWithMaxWidth() to constrain bar width
Also in this commit:
- audit: hide per-skill scan list when TUI is active (summary only)
- audit: extract presentAuditResults() to deduplicate output logic
- audit: align progress bar width with header/summary box
- audit TUI: add breathing room between panels, stats, and help bar
- Add colorSkillPath() for progressive luminance on nested skill paths
(cyan group → gray sub-dirs → white skill name) in list and audit TUIs
- Move filter bar below panels in audit and log TUIs for consistent layout
- Align log TUI left panel width (25%, max 45) with audit TUI proportions
- Show elapsed time on pull/push completion messages
- Use relative paths in audit results for group hierarchy display
- Render license field in green, adjust content overlay spacing
Glamour tables and long lines can exceed the panel's text width.
Scroll calculations are based on logical line count, but lipgloss
wraps overflowing lines into extra visual rows, clipping the bottom.
Hard-wrap all content with ansi.Hardwrap before storing it, so
logical lines = visual lines and scrolling reaches the end.
Also bump contentViewHeight to termHeight-5 for breathing room.
contentPanelWidth() returned the lipgloss panel Width which includes
padding, but renderMarkdown used it as the text wrap width. Lines
rendered 1 char too wide would wrap inside the panel, causing the
bottom content to be clipped by MaxHeight — making it impossible to
scroll to the end. Also fixes visual artifacts on table pipe chars
caused by mid-character line wrapping.
runLogStats() only checked the --audit flag to pick the log file,
ignoring filter.Cmd. This caused `log --stats --cmd audit` to read
operations.log and report "No log entries" even when audit data existed.
Align with runLog() by also checking f.Cmd == "audit".
P1: sync_parallel grouped targets by raw path string, so the same
physical directory with different representations (trailing slash,
relative segments, symlink aliases) could be placed in separate groups
and written concurrently. Resolve paths via filepath.Clean → Abs →
EvalSymlinks (walking up to the nearest existing ancestor when the
leaf doesn't exist yet) before using them as group keys.
P2: LogConfig.MaxEntries was int, making 0 (explicit unlimited)
indistinguishable from "not set". Changed to *int so nil = default
(1000), 0 = unlimited, >0 = user value, <0 = fall back to default.
Replace cryptic internal terminology (+/~/- source only, local copy, etc.)
with action-oriented messages that tell users what to do next (→ sync will
add, ⚠ local copies, ← collect will import). Add overall summary line at
top ("N targets need sync, N fully synced"). Show conditional hints that
only mention --force when local copies actually exist. Use full command
names (skillshare sync) in hints.
Consolidate 30+ scattered lipgloss.NewStyle() calls across 6 TUI files
into a single tc (TUI colors) struct in tui_colors.go. Add configureDelegate()
helper to replace repetitive ~8-line delegate setup blocks with one call.
- ac/lc structs now reference tc base colors (Title, Dim, Green, Yellow, Red)
- list_tui detail panel: tracked repo and source URL now use tc.Cyan
- skillItem.Title(): inline color for name (bright white) and badge (green/gray)
- search_tui: enable description row (source + tags visible in list)
- Remove unused lipgloss imports from 4 files
- Add bubbletea TUI for multi-skill audit results (side-by-side layout
with skill list + detail panel, severity sorting, fuzzy filter)
- Add progress bar during parallel scan via onDone callback
- Add --quiet/-q flag to suppress clean skill lines
- Add --yes/-y flag to skip large-scan confirmation prompt (>1000 skills)
- Add --no-tui flag to force plain text output
- Scale parallel workers to NumCPU (bounded 2–32) instead of fixed 8
- Use file cache in content-integrity check to avoid redundant disk reads
- Replace line splitting with streaming scan (avoid full []string alloc)
- Remove snippet truncation (preserve full trimmed line)
- Differentiate LOW (bright blue) and INFO (medium gray) severity colors
- Centralize log TUI color styles into `lc` struct
- Export DisplayWidth and add BoxWithMinWidth/HeaderBoxWithMinWidth for
aligned header + summary box widths
- Update docs with TUI controls, new flags, and CI/CD auto-skip behavior
- list_tui_item_test: Title() now includes [local] badge, Description()
returns "" for local skills (badge moved to Title)
- log_stats_test: renderStatsCLI wraps empty message with ANSI color codes
- install_subdir_license_test: license shown via StepContinue (spaced)
instead of colon-delimited format
When selecting 2+ skills from `search --hub`, replace verbose per-skill
output with a pterm AreaPrinter progress display and final summary.
Single-skill selection retains the existing verbose path (StepStart +
TreeSpinner). The progress display follows the syncProgress/diffProgress
pattern: animated spinner, per-skill status, progress bar, and a
StepResult tree closure.
New file: search_batch.go (collect functions, progress driver, summary)
Modified: search.go (routing), search_tui.go (compact list for batch)
When skill count is large (thousands), per-skill diff lines are
unreadable. Group items by (action, reason) instead:
- "local copy" shows count only (too numerous to list)
- Other reasons (content changed, source only, etc.) show count + names
- Sort: add → modify → remove
- Action hints (Run 'sync'...) printed once after all groups
Also:
- Hide progress bar for merge/symlink-only targets (instant diffs)
- Collapse isolated duplicate skill names to single summary line in sync
Show all targets at once (spinner for active, queued for waiting,
checkmark for done) with an overall progress bar at the bottom
tracking total skills across all targets. Uses AreaPrinter for
the combined display, matching the pterm progress bar visual style.
Replace custom AreaPrinter + goroutine spinner with the same
ui.StartProgress/Increment progress bar used by install, update,
and check commands. Bar tracks total skills across all targets,
with UpdateTitle showing the current target and skill name.
Show an overall target progress bar (━━━──── 1/3 targets) at the
bottom of the multi-target progress display instead of per-target
progress bars. Only shown when there are multiple targets.