In project mode the committed config.yaml is what teammates install from, but
it could disagree with what a machine actually has (#858):
- `uninstall -p` and the dashboard's single-skill and tracked-repo removal
left the skill's entry in config.yaml, so a later `install -p` brought it
back. They now drop the entry and the lock pin through one shared
config.ForgetProjectSkills, as the uninstall docs already promised.
- Installing a skill again from another source or branch (after an uninstall,
or over the copy with --force) updated only the gitignored .metadata.json.
config.yaml kept the old source and skills.lock.json ended with the old
source and the new commit. Installs from a named source (CLI install,
search, dashboard) now compare the records from before and after the
command and let the config entry follow the skills it actually reinstalled.
Install from config never rewrites an entry from local records, so a
teammate's edit survives on a machine that has not updated yet.
- Reconcile removed every config entry that had no folder and no record. On a
fresh clone nothing is installed yet, so `install <source> -p` deleted all
the other declared skills. An entry now goes only when the skill was
installed here and its folder is gone, when it was moved, or when a command
removed it; `move` passes the old paths and `update --prune` cleans the
config itself.
Preserve the complete Layout while adding a standalone Mod named skillshare. Generate both packages from one canonical mod and protect custom layouts and usage meters during installation and updates. Keep release versions aligned and route native Herdr instructions separately within existing context budgets.
* fix(git): keep a caller's GIT_DIR out of skillshare's git commands
Git exports GIT_DIR, GIT_WORK_TREE, GIT_INDEX_FILE and related variables
to hooks that run in a linked worktree. Every git process skillshare
started inherited them, and those variables override the directory the
command runs in. Run from a post-checkout or post-merge hook, skillshare
therefore acted on the hook's repository instead of its own: install's
sparse clone turned on sparse checkout there (a later merge removed every
file outside the skill's path), the remote tree check's `git init --bare`
made it a bare repository, install's reconcile recorded its origin and
branch, and push staged and committed into it.
internal/gitenv builds git commands without the variables that
`git rev-parse --local-env-vars` lists for choosing a repository, work
tree, index, object store or config file. GIT_CONFIG_COUNT and
GIT_CONFIG_PARAMETERS stay, because users pass credentials through them
and install's token auth appends to the existing count. Every git call in
cmd/skillshare, internal/install, internal/git, internal/check and
internal/config now goes through it, and plugin runCommand starts native
CLIs from the same environment because they run git as well. The hooks
service keeps its own stricter filter.
Closes#852
* test(gitenv): fail on new git commands that bypass gitenv
Each git call site converted for #852 is safe only because it goes
through gitenv.Command, and about half have no test of their own. A
future exec.Command("git", ...) would silently bring the bug back, so a
syntactic guard now rejects one outside gitenv, hooks and testutil,
mirroring the sourcefs and sourcewalk ratchets.
The Environ test also checks a lowercase name, since Windows environment
names are case-insensitive, and compares against literal keys so that
removing one from repoVars fails it. The wiki records the rule.
The panel had no version and no way to update: a user had to copy the mod folder again by hand and could not tell when a newer one existed.
The panel now carries version.js, the skillshare release it shipped with, which Release Please rewrites in every release. While shown it asks once an hour where GitHub's "latest release" link lands and offers "Update panel" when that release is newer. It compares against the published release, not main, because the panel parses the CLI's --json output and a panel from main may need an unreleased CLI.
The update clones only the mod's folder at that tag and copies it over the installed one. It first checks the folder holds the running panel's version, keeps the replaced files once in .bak-update-<version>, and holds every machine's lock until the reloaded panel returns it, because Herdr's reload ends every running task.
* feat(herdr): answer "what needs me" first and preview every row
The panel listed every resource in one long tab and put the detail of a
row in text under it, so the first screen never said whether anything
needed a sync, and a 400px column filled with wrapped lines.
Overview now leads with one headline, one Sync button and a map from the
source to every target, and lists only what needs attention. Library
holds the full lists. A row carries a name and one short state; clicking
it opens a preview dialog with its document, its targets and its
details, so nothing is crammed into the list. MCP previews show the
names of env, header and token entries, never their values.
Target names come from `status` as well as `diff`, because `diff` leaves
out targets that share another target's folder. A machine with
uncommitted or unpushed work offers Sync both ways, since a plain pull
would refuse there. Warnings and errors now clear after 8 s instead of
staying until closed. Dialogs draw their own card and fade in and out.
The map's lines, the target list and the machine's action live in
model.js with tests; rowSub and the hideDisabled filter had no caller
left and are removed.
* fix(herdr): list only the targets a previewed item can reach
The preview's Targets tab was wrong in two cases.
A skill already on some targets but new to one has the state "missing",
and the preview treated that state as "waits everywhere", so targets
already in sync were marked as needing a sync. Only the targets the
item's drift names wait now.
An agent's preview listed every configured target, including ones that
take no agents, as in sync. The loader now keeps the targets that take
skills and the ones `status` reports for agents apart, and the preview
uses the list for the item's kind.
* feat(herdr): sync from Library's waiting group
The redesign left Sync only on Overview, so someone reading the Library
list had to switch tabs to act on the rows in front of them. The
"NEEDS SYNC" header carries Sync again, for the scopes its rows wait in;
when only a hook notice has native changes, its header carries it.
* fix(herdr): keep Sync in Library's toolbar and stop the panel shrinking past its tabs
Sync on the "NEEDS SYNC" header only existed while something waited, so
with everything in sync Library had no way to sync at all. It now sits
in the toolbar beside the filter, primary while something waits.
The panel could be dragged down to 320px, where the tab row no longer
fits beside the scope switch and the switch is cut off. The column's
minimum is 380px, and the tab row is a little tighter.
* fix(herdr): sync every scope a target still waits in from Library
Library's Sync chose its scopes from the waiting rows alone. A target can
wait with no row left, as after uninstalling a project skill that a
copy-mode target still holds, so with All shown and one global row
waiting, Sync ran in the global scope only and left the project copy in
place. Overview already added the scopes with a waiting target.
Both now take their scopes from one model helper, syncScopes, which
covers waiting rows, waiting targets and the nothing-waiting fallback.
* refactor(herdr): finish the review's open findings on the panel
The first review left confirmed findings listed but unfixed, and the
commits after it were never reviewed. This closes both.
The map now counts a waiting MCP server, plugin or hook on the targets
it waits on, so its lines no longer stay green under a headline that
says something waits. A skill's Targets tab takes its targets from
status when status names them: diff also lists targets that take agents
alone. Library's Sync stays disabled until a scope has been read;
before that it sent an empty scope list and reported a sync that never
ran.
The map's trunk and lanes, the two pill switches, the placeholder block
and its pulse each had two or more copies in main.js and now have one.
The Overview headline, a machine's remote line and its waiting targets
move to model.js with tests. README's layout snippet names the 380px
minimum the layout file already has.
Every page faded in over 200ms while sliding up 8px. Moving between
pages in the sidebar is the most frequent action in the dashboard, so
the slide made each click feel slow and shifted the content the user
was comparing. Pages now use animate-page-in, a 120ms opacity-only
fade, which softens the swap without delaying it or moving anything.
The shared fade, dropdown and dialog entrances also ignored
prefers-reduced-motion and kept sliding or scaling. Under reduced
motion they now keep only their fade; a dialog changing step still
swaps without animation, as before.
The frontend wiki and the UI style skill told contributors to put
animate-fade-in on page roots; they now name animate-page-in and keep
animate-fade-in for in-page reveals.
Release-As: 0.30.2
* fix(projects): save new projects in config.yaml again
v0.29.0 wrote every project add, edit and remove to a machine-local
registry, so a project added on one machine never reached config.yaml
or the other machines that share it (#792). Most people share one
config.yaml and expect a new project to follow it.
config.yaml is the default again. Machine-local storage stays as an
explicit choice: --machine-local on add, or projects_storage:
machine-local for every new project, with --shared to override it.
The new share command moves a local project into config.yaml, and
localize still copies one to this machine. Edits and removals stay in
the layer that owns the project; removing a local copy of a
config.yaml project keeps config.yaml's version unless --shared asks
to remove both, so one machine cannot silently drop a project for
the others. Exclusions written by v0.29.0 are left as they are.
The dashboard picks storage once, in the Add project dialog, and
offers the two removal choices only where both copies exist. Moving a
project between layers stays a CLI command, so the detail page keeps
one job.
Closes#792
* fix(projects): recheck both layers after a confirmation, sync the saved key
remove and share ask before taking the config lock, then compared only
the merged entry after locking. A share or localize from another
terminal moves a project between layers without changing that entry, so
a remove confirmed for this machine's copy could then delete config.yaml's
declaration for every machine, and a confirmed share could overwrite
config.yaml settings changed meanwhile. The recheck now compares the
owning layer and config.yaml's declaration too (ProjectLayerState).
Re-adding a project that v0.29.0 hid restores config.yaml's own key,
which can be spelled differently from the folder given to add (~/app
versus an absolute path). add --sync looked the project up by the given
spelling and failed with "project not found" after saving it; it now
syncs the key that was saved.
* test(projects): make the layer tests hold on Windows
The mutation-sequence test looked the shared project up by
filepath.Join, but the fixture spells config.yaml's key $ROOT/app;
on Windows the two spellings differ, so the lookup found nothing.
It now asks the config for the key it uses.
The remove save-failure test blocked the local registry, but removing a
config.yaml project now writes config.yaml. On Linux the registry check
still failed with ENOTDIR first, which hid the mismatch; on Windows that
reads as a missing file and the save went through. The test now blocks
config.yaml, as the edit save-failure test does, and its hook no longer
shadows the config path with the target path.
---------
Co-authored-by: sim <sim@example.invalid>
Keep machine-specific project changes out of shared configuration while preserving shared registrations and making their origin visible. Handle missing replicated roots and preserve startup maintenance for mutating commands.
* feat(herdr): add Hooks tab with confirmed entry actions
Show hook declarations and planned changes alongside the other resource kinds, reusing sync --all. Keep nested roots and cleanup status read-only, and confirm enable, disable and remove before saving.
Cover inventory states and scoped action arguments with fixtures; update panel documentation and translated kind lists.
* fix(herdr): preserve hook diagnostics and cleanup failures
Keep inactive reasons and plan warnings visible independently of file actions. Retain an inventory status row when cleanup preview fails after the final declaration is removed, and format root conflicts without an empty target prefix.
Add producer-shaped regression fixtures and document confirmed actions and CLI/dashboard conflict recovery across the panel guides.
* fix(herdr): separate hook notices from named resources
Keep diagnostic notices visible and filtered without inflating entry counts or groups. Propagate root-wide conflicts to affected entries and preserve inactive reasons independently of file alignment.
Show full nested root identities and offer scoped Sync for unnamed native writes. Cover projection and scoped snapshot reads with fixture-only tests, and align panel guides and translations.
* fix(herdr): distinguish unknown hook status from pending sync
Show entries with missing previews outside sync groups and report each scope error once. Preserve disabled state beside runtime diagnostics and omit unchanged targets from pending summaries while retaining expanded details.
Regress the confirmed presentation failures before fixing them, consolidate overlapping fixtures without dropping distinct checks, and align panel guides and translations. Keep source action eligibility because the CLI previews each changed draft.
Herdr users run several agents side by side and had to leave it to see
which skills need an update or a sync. The panel brings that view, plus
install, update, uninstall, audit hand-off and source repository sync,
into a Herdr layout node so it survives space switches.
Install audits its own shallow clone first, because install --json names
a blocked skill without its findings; a block shows them before anything
is written. Pull conflicts show both versions side by side, and
.metadata.json merges per entry with the same rule as MergeMetadata so
installs from both machines are kept.
model.js has no Herdr imports, so make test-herdr covers it in make check
and CI. Docs gain a learn/with-herdr page with translations and a README
highlight, and the context router loads herdr/AGENTS.md with frontend.
* feat: add Nix flake and stop self-upgrade of Nix-store installs
Add flake.nix with packages, overlays.default, checks and a formatter,
building nix/package.nix with the unit tests in the Nix sandbox. The
version comes from the Release Please manifest, so releases need no Nix
edit. A Nix workflow runs `nix flake check` on non-docs changes.
`skillshare upgrade` now detects binaries under /nix/store/ and prints
`nix profile upgrade skillshare` instead of replacing a read-only store
path; update notices and doctor suggest the same command.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(upgrade): give Nix installs the right update path everywhere
The first flake commit sent every /nix/store binary to `nix profile
upgrade`, failed a plain `skillshare upgrade` with exit 1 even when the
CLI was current, and left the dashboard with a generic 500.
- Tell `nix profile` installs (the profile manifest lists the store path)
from NixOS, Home Manager and overlay installs, which are told to update
their configuration and rebuild. Detection lives in one helper shared by
the update notice, doctor, upgrade and the dashboard.
- `upgrade` on Nix reports "already up to date" or prints the hint and
exits 0; the built-in skill still updates.
- The dashboard runs the upgrade so the skill updates, then answers
409 `upgrade.nix` with the command when a newer CLI waits on Nix. The
UI shows localized text for it in all 11 locales.
- Installs skip the unit tests; the flake's checks enable them. postPatch
lowers only the go directive's patch version and fails evaluation with
a clear message when go.mod needs a newer Go minor. CI also builds the
package on macOS.
- Docs, translations, the built-in skill reference and the release topic
describe the new behaviour.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(trash): keep install metadata when restoring from the trash
Uninstall pruned a skill's, tracked repo's or agent's entry from the
central .metadata.json, and only the files went to the trash, so a
restore brought back a remote install as a local one: update and check
no longer knew its source (#679).
Uninstall now saves the entries it prunes, with their audit acceptances
and target overrides, beside the trash entry, re-keyed to the trash
name so they match where restore puts the item. uninstall.Restore and
RestoreAgent merge them back after the files return, and every restore
path (CLI, trash TUI, dashboard) goes through them; the dashboard
passes its cached store so it does not go stale. The saved copy is
taken with the same rule RemoveByNames uses and copies each entry, so
legacy repo-group entries are kept and re-keying never touches the
live store.
In project mode uninstall also drops the skill's .gitignore rule and
lock pin, so a skill restore reconciles the project skills afterwards.
trash.Delete removes an entry with its saved metadata, and replaces the
direct RemoveAll calls in delete, empty and the 7-day cleanup. Items
trashed before this change have no saved metadata and still restore as
local.
* fix(trash): keep live records of another path when restoring metadata
A legacy store keys a grouped skill by its basename, so the saved copy of
frontend/foo was keyed "foo". If a different skill was installed as
root-level foo while frontend/foo sat in the trash, restoring it replaced
the root skill's record and lost its source.
Extract now writes full source-relative keys (legacy repo-group entries
keep theirs, since their Group is not their path), and Merge keeps a live
entry whose key names a different path instead of overwriting it. Merge
is shared by skill and agent restore, so both are covered.
The testing topic was 8 bytes under its 16 KB cap, so any edit would
fail the router check. Move the E2E runbook, quality checklist and
Windows verification sections verbatim into a new e2e-runbooks topic
instead of raising the cap.
Also upgrade scripts/ai-context.py to 0.2.0, which adds link checking,
skipDirs and glob-based unrouted exceptions; the existing docs pass.
Two dashboards (or a dashboard and the CLI) serving the same source ran
"Update all" at once. The server mutex only covers one process, so both
pulled into the same checkouts: one saw the other's half-applied merge as
"local changes would be overwritten", and concurrent fetches into a
blob:none clone failed with "fetch-pack: invalid index-pack output".
update.TrackedRepo, install --track --update, and the in-place pull of a
git-installed skill now hold a flock in the checkout's git directory; a
second process waits up to a minute, then fails with a clear message.
Force on a git-installed skill only skipped the local-modification check
and then ran a plain pull, which refused to merge over the edits the docs
say --force discards. It now fetches and resets to upstream, so a failed
fetch still keeps the edits. Followed checkouts keep pulling, since they
must be clean and may hold the user's unpushed commits.
The pull error dropped the file list git indents under it, and the
finished-update subtitle said everything was up to date even when items
had failed.
* fix(update): audit tracked candidates before publication
Prevent rejected tracked-update bytes from becoming readable through published target links by staging and auditing a private candidate before updating the active checkout. Publish the exact approved revision without a second upstream pull.
Preserve sparse state, audit metadata, followed checkouts, and compatible edits. Recover staged and unstaged changes after failed forced publication, including deletions, renames, and sparse exclusions. Cover the boundary deterministically and align error messages and localized documentation.
* fix(update): preserve local bytes across Git line-ending conversion
Overlay dirty worktree bytes after staging candidate patches so core.autocrlf does not silently rewrite local edits. Cover staged, unstaged, and cancelled worktree changes while retaining their index state.
Make permission-failure coverage explicitly POSIX-only and compare private checkout contents to their original bytes. Align red-team assertions with candidate rejection and register private temporary cleanup with the raw-write guard.
* test(install): normalize checkout after configuring line endings
Windows fixtures initially inherit core.autocrlf=true. Reset the isolated checkout after selecting the subtest setting so changing it to false does not turn untouched upstream files into local edits.
Use the existing YAML parser and serializer so folded descriptions, quoted text, and nested metadata survive repeated editor saves without accumulating escapes or losing structure. Keep legacy headers editable and render nested object fields as read-only JSON.
Add regression coverage for the MinerU workflow reported in #637 and document editor behavior. Verified UI tests, lint, build, make check, and an isolated browser save/reopen flow.
Keep local-edit statuses wide enough so they do not collide with update actions. Wrap update rows on narrow screens and show row actions on touch devices.\n\nReuse the shared dialog for mobile navigation, close it before blocked or successful keyboard navigation, and keep the language picker and tour within the visible mobile UI. Include locale labels, responsive layout documentation, and tour-step regression coverage.\n\nFixes #638.
* feat(check): show what changed in a skill since install
#622 made a hand-edited skill visible as modified and kept update from
overwriting it, but there was still no way to see the edits before
deciding to keep or discard them (#621).
LocalChanges compares the skill's files with the hashes recorded at
install, fetches the source at the recorded commit only when a recorded
file changed, and diffs each file against it, so the diff shows the
user's edits even after upstream moves on. A skill without a recorded
commit is refused rather than diffed against HEAD, which would show
upstream changes as the user's.
It backs `check <name> --diff`, GET /api/resources/{name}/local-changes,
and the dashboard: the Modified locally dialog on the skill page lists
the diffs, and the Updates tab links a modified skill to it. update's
skip hints now point at --diff. The route looks up the exact record and
refuses non-local names, so a nested or ../ path cannot borrow a
top-level skill's record or read outside the source. The file diff
helper moved to textdiff so the CLI and server share it.
* fix(install): diff local changes against the full installed commit
entry.Version holds the short SHA from `rev-parse --short`. A targeted
fetch needs the full SHA, so checkoutCommit fell back to fetching every
branch and tag with --unshallow: viewing one edited skill could download
the repository's whole history, and fail when the commit is only
reachable by its full SHA.
Use entry.Commit, the full SHA install records, when it is the same
commit as Version; a Commit left from an older install, or a legacy
record without one, falls back to Version.
* test(install): keep checkout line endings when editing in LocalChanges test
On Windows git checks the installed copy out with CRLF, so overwriting
SKILL.md with LF content made every line differ and the expected diff
failed. Edit the installed file in place, as an editor would, and compare
the diff without carriage returns.
* fix(update): honor accepted findings in dashboard tracked updates
The dashboard ignored findings accepted through the CLI, so a tracked repo
that `update --force` let through was blocked again on the next dashboard
update, and every dashboard Force Retry had to be repeated. Regular skill
updates in the dashboard already honored and recorded acceptances, so only
tracked repos differed.
Tracked-repo updates now always honor accepted findings and record the ones
an override lets through, for both callers. The opt-in option and the
AuditGate flag it fed are removed, since no caller turns them off.
Dashboard agent tracked repos passed an empty source dir, so a nested repo
kept acceptances in its group folder under a different key than the CLI.
They now pass the agents source, as the CLI does.
* fix(update): reload the agents store after agent repo refresh
Dashboard agent tracked repos now refresh metadata in the agents source,
but a metadata change reloaded the skills store, leaving the agents store
as it was until the next request. Reload the store that matches the source.
Every caller of update.TrackedRepo now passes a source dir, so the
empty-dir guard and its doc no longer describe a supported mode. The new
agent test reuses the tracked fixture instead of rebuilding it.
A pull with dozens of conflicting files meant clicking "Keep this
version" once per file. Two buttons now set every file to the same
side; individual files can still be switched afterwards.
Codex reviews often took four to six rounds because each round found
one more place where the same bug class was unhandled, and it re-raised
cases outside the supported workflows that only our internal wiki ruled
out. AGENTS.md now carries code review rules Codex reads: supported
scope, one finding per bug class with every location, and re-reviews
limited to new commits. The pull request workflow now fixes every
instance of a confirmed class at once and, after three rounds, explains
why findings keep coming instead of only stopping.
* feat(memory): add host-owned review and verification workflows
Share scoped memory tools between Dashboard and Memory, and route retrospective and Dreaming requests through the built-in skill. Keep agent execution in the host, require approval for reviewed edits, and preserve versioned CLI write safeguards.
Confirm scope before exposing prompts and include the resolved root in recent memory responses. Update provenance guidance and localized documentation, with regressions for unavailable scope and protected review prompts.
* fix(memory): distinguish trial copy controls for screen readers
Include the localized step title in each trial copy control accessible name while keeping the short visible label. Update the existing clipboard test selector for the distinct names; no new test or local test rerun was requested for this label-only fix.
* fix(memory): point connection hints to the trial tools
Replace stale verification-prompt directions in all eleven locales with the current Memory tools and Try across sessions labels. Interpolate the existing localized labels so future naming changes remain aligned.
No new tests or local test reruns for this copy-only correction, as requested by the maintainer.
* feat(ui): surface existing shared memory on the dashboard
Make shared notes visible through recent updates and direct links, with file timestamps and an introductory state for untouched starters. Keep the dashboard quiet until memory is configured, and preserve access to existing notes when starter files are missing.
* fix(memory): bound dashboard reads and remember preview expansion
Count vault entries from metadata and read at most the two starters and four recent candidates instead of hashing the full vault on dashboard load. Keep incomplete starter states accessible and refresh the overview after source and instruction changes. Remember preview expansion in browser storage and raise the collapsed height to 360px.
The move command page broke the locale builds because its relative
links and anchors only resolve against translated siblings; the
verification list now names the rule that avoids it.
* docs(wiki): cap Codex review rounds and require a state matrix before review
PR #513 reached 7+ Codex rounds because each round surfaced one more
state dimension (project mode, tracked installs, followed links, legacy
keys, lock pins) that the change had never listed. Every round costs the
maintainer a review cycle.
Require a state matrix and a consumer sweep before the first review,
separate findings worth code from unrealistic combinations, and stop at
three rounds unless a finding shows data loss or a broken supported
workflow.
* docs(proposals): add move installed skill proposal for #510
Moving an installed skill with mv strands its install record, and the
documented workaround (uninstall + install --into) re-downloads and
drops audit acceptances and lock pins. Propose one explicit move
operation shared by the CLI, the Web API and the dashboard.
Records the maintainer decisions: no auto-sync, followed links refused,
target filters warn only, whole-folder move in v1, --force limited to
name collisions.
* fix(proposals): cover nested skills, bare tracked checkouts and duplicate destinations
Codex review of the move proposal found three gaps in the folder-move
design:
- A skill directory that contains nested skills was planned as one
skill, so descendants would move on disk but keep their old records,
pins and audit acceptances. Plan now expands descendants too.
- Refusals were derived from discovered skills only, so a tracked
checkout with no discoverable skill would move along with its folder.
Preflight now walks the whole tree for checkouts and links.
- Two inputs converging on one destination path were treated as a
forceable flat-name collision and left the batch half-moved. They are
now a separate, non-forceable duplicate_dest refusal.
* fix(proposals): keep nested records through reconcile, warn both filter directions, refuse overlapping roots
Second Codex round on the move proposal found three more gaps:
- The reconcile walk stops at an installed parent and then prunes every
record it did not see, so a moved nested skill would lose its record
and audit acceptances. Reconcile must keep records below a live
installed record.
- Target filter warnings only covered rules that stop matching. A move
into a folder that an exclude pattern covers (or an include newly
adds) changes sync output too, so compare the effective filter result
before and after.
- Batches such as `move foo foo/sub archive` planned the same subtree
twice. Overlapping source roots are now refused before any rename.
Without written rules, new work kept adding entry-point tests that
repeat package rules and rendered UI tests for cosmetic behavior. State
where a rule is tested, what handler/CLI/integration tests cover, and
which dashboard tests to write.
DELETE /api/repos/{name} now refuses a repo with uncommitted changes or
unreadable git status, and the Dashboard page never sent force, so those
repos could not be removed from it at all.
The two refusals force overrides now carry their own error code. The
page still sends the first request without force; on either code the
confirmation says why and retries with force only when the user
confirms. Other refusals, such as a linked folder that is itself a
skill, keep the plain error because force does not change them.
Refs #442
Review of the guidance move found no defect, but three things made the new
seam harder to read than it has to be:
- The plan and apply handlers nested the success path inside `if err == nil`
with one shared error write. They return early again, like the handlers
next to them.
- The handler derived the scope from IsProjectMode() while GuidanceInput
derived the same value from ProjectRoot. Scope() is exported so the status
response and the block inspection read one value.
- (*Server).memoryInstructions had become a one-line passthrough with a
single caller, so it is inlined.
GuidanceReader is now exported, so its doc states what the server always
guaranteed: at least one source, and Dest indexing one of them. The
ApplyGuidance and Config comments say what callers need to know, and the
architecture paragraph is rewrapped.
No behaviour change.
Refs #450
The uninstall sequence (move-out check, dirty check, move to trash,
.gitignore cleanup, metadata prune) lived in the CLI and in three
dashboard handlers, and the copies had drifted: three different prune
rule sets, no dirty check on DELETE /api/repos, and no metadata prune
at all on DELETE /api/resources, which left the removed skill's entry
and target overrides in .metadata.json.
internal/uninstall now owns the sequence for resolved items. Callers
keep name resolution, prompts, output, HTTP status and oplog.
MetadataStore.RemoveByNames is the single prune rule set: an entry goes
when it is a removed path or lies below one, by key or by Group, plus
the tracked legacy group of a top-level repo.
Behaviour changes, all intended:
- DELETE /api/repos/{name} refuses a dirty tracked repo, or one whose
git status cannot be read, with 409 unless ?force=true.
- DELETE /api/repos/{name} refuses a followed link whose folder is
itself a skill, like every other uninstall path.
- DELETE /api/resources/{name} prunes the skill's metadata.
- Removing top-level "foo" no longer prunes "frontend/foo" (CLI), and
removing repo "_team" no longer prunes the untracked group "team"
(dashboard batch); both dropped metadata of skills still installed.
Refs #442
The i18n module guaranteed parity between locales and left the rest to
callers. `t` takes any string, so a mistyped key rendered as the key and
nothing caught it; internal/plugin sends translation keys that nothing
compared with en.json; and about 130 call sites chose between `.one` and
`.other` by hand.
- keys.test.ts reads the dashboard source and fails on a key that is not
in en.json. A key built at run time is checked by its fixed head, and a
string that only looks like a key is named in a short documented list.
- internal/plugin/i18n_keys_test.go fails when a "plugins." literal the
package emits is missing from en.json; the one key completed at run
time lists its values.
- plural(key, count) in the i18n module picks the form, with the same
"exactly 1" split the call sites used, so every rendered string is
unchanged. No locale file changed.
Refs #448
Updating a tracked repo is a fail-closed sequence: check for uncommitted
changes, pull, audit what was pulled, reset to the pre-pull commit when the
audit blocks. The CLI had two copies of the pull flow, the dashboard a third,
and the audit gate existed four times (CLI, dashboard, and two in install).
The copies had drifted: the dashboard ignored a failed git status and never
refreshed root-skill metadata, and each copy worded a failed rollback on its
own.
update.TrackedRepo now owns the sequence and returns a structured result;
install.AuditGate is the only gate. internal/update is a new package because
internal/git already imports internal/install. The CLI keeps its spinner,
rows and the "Apply anyway?" prompt, passed in as one Confirm callback; the
dashboard turns the result into its JSON item.
Behaviour changes, all towards the stricter copy:
- the dashboard reports a failed git status as an error instead of pulling;
- the dashboard refreshes root-skill metadata after an update, like the CLI;
- a prompt that fails rolls the update back instead of leaving it applied;
- the rollback-failed and rollback-unavailable texts come from one place.
Accepted findings stay as they were (CLI honours and records them, the
dashboard does neither), now as the explicit AcceptedFindings input. The
"blocked and rolled back" texts are unchanged per caller because the
dashboard matches on them.
Refs #443
The guidance rules (status ranking, mixed_modes, multiple_blocks, the plan
token, and check -> backup -> recheck -> write) were methods on *Server, so
they could only be exercised over HTTP with a configured server, and the
recheck after backup depended on callers using the right helper.
internal/memory now owns status, plan, and apply behind GuidanceStatus,
PlanGuidance, and ApplyGuidance. The server resolves targets, assignments,
shared extras, and project reach into a GuidanceInput, syncs shared copies
through a callback after each written file, and maps results to JSON. Only
ApplyGuidance reaches the write steps, so the recheck cannot be skipped.
Note creation and guidance creation shared a copied O_EXCL create with
delete-on-failure; both now use createExclusive. Each keeps its own
behaviour: notes still chmod to 0644, guidance still creates parents.
HTTP routes, shapes, status codes, and error codes are unchanged. The raw
write allowances follow the calls to their new functions.
Refs #450
Which queries a mutation makes stale was knowledge each caller carried:
139 invalidateQueries calls in 48 files listed keys by hand, the lists
differed, and some used hand-written prefix keys such as ['sync-matrix']
that queryKeys could not express.
The key list of every event now lives once in lib/queryEvents.ts and call
sites say what happened: invalidate(queryClient, 'skillsUninstalled').
The three existing helpers (invalidateAfterSync, refreshTargets,
refreshInstructions) became events too. queryKeys gained the prefix keys
(syncMatrixAll, diffAll, logAll, logStatsAll) and every query key that was
written inline, so no key literal remains outside queryKeys.ts.
No call site's invalidated set changed. Each event is tested once against
a real QueryClient, including which queries it reaches by prefix.
Refs #445
Pass value-taking options to the shared mode parser so command values cannot select a scope or create false mode conflicts. Preserve the end-of-options delimiter and reuse it for MCP command arguments.
Cover existing CLI entry points, including audit rules, enable/disable, and backup deletion, with regression tests and document the parser contract.
Source links disappeared from the dashboard when discovery found no skills, leaving empty or unavailable folders without an Unlink action. Return first-level links independently with their follow-policy availability and preserve their groups in every skills view, including empty unlink confirmations.
Cover empty and dangling inventory, disabled following, and empty-link removal in list, cards, and tree views; document the API field and rendering.
* feat(omp): add native Oh My Pi support
Support OMP skills, instructions, MCP, code hooks and guarded extension selection using its verified native contracts rather than Pi aliases.
Add reviewed marketplace plugin installation, cache-preserving scoped removal and fresh-cache reinstall. Align Pi/OMP extension cards and localize inventory guidance while keeping native ownership and read-only constraints.
Include regression coverage, isolated E2E runbooks, documentation and verification policies. Native plugin updates and unverified runtime platforms remain guarded.
Refs #409
* fix(omp): guard runtime ownership and localize inventory guidance
Native install recursively replaces its runtime destination, and a missing cache manifest could leave the real runtime link installed after removal. Bind and recheck an absent reviewed destination, and recover removal names only from verified scope-local links.
Localize fixed backend reasons and warnings across dashboard locales while preserving paths and external diagnostics. Restore the reviewed source in the existing reinstall fixture and record real native verification.
* fix(omp): allow forgetting natively removed plugins
A different plugin can retain node_modules after native uninstall deletes this installation. When its cache, registration and known runtime state are absent, forget only the stale Skillshare binding instead of demanding runtime-name proof for unrelated files.
Extend the existing removal recovery test with a failing-before-fix case that verifies the binding is dropped and unrelated native lock bytes and plugin files are preserved. make check passes.
A root skill discovered through a followed source link occupies the link entry itself. Moving that entry to trash silently unlinks every nested skill instead of removing one skill.
Share the root-skill guard across single and batch API handlers and CLI uninstall, report the unlink action clearly, and preserve explicit unlink and nested skill removal.
Replace the removed linked badge description with the link icon, muted target path, and hover or focus unlink icon used by the dashboard. Keep the tree detail-pane behavior explicit.
Pass the current global or project follow policy to skill trash restore so the dashboard matches CLI behavior and can restore into followed link targets. Keep disabled-link refusals and agent restores unchanged, and cover both scopes and link naming styles with handler regression tests.
Resolve followed skills with the discovery policy before applying tracked-repo restrictions or prefix-based batch routing. This lets dashboard uninstall move only the selected skill from a followed checkout while retaining managed-repo protection and logical trash restore paths.
Add single and batch handler regressions for global and project modes, skipped links, and tracked-repo members; document the API behavior.
Keep followed checkout updates in the Updates tab and expose unlink as a single quiet icon in group headers. Remove unused checkout metadata and linked-group menus while preserving the confirmation and single-skill uninstall flows.
Match tracked repository affordances without offering whole-repo uninstall for followed user checkouts. Resolve checkout identity for Update repo, keep linked skill uninstall scoped to the selected skill, and explain target preservation, sync impact, and trash recovery before destructive requests.