Commit Graph
926 Commits
Author SHA1 Message Date
Willie 08ecb7afad fix(audit): report audit-rules load errors and block installs whose audit cannot run (#882)
* fix(audit): report audit-rules load errors in global scans

The global scan entry points (ScanSkill, ScanSkillWithFollow,
ScanSkillFiltered, ScanFile) dropped the error from Rules() and scanned
with no pattern rules. One bad regex in the global audit-rules.yaml
turned every pattern check off with no warning, so audits reported
fewer findings than they should have (#879). Project mode already
returned the error.

Return the error from the global path as well, and name the failing
file in it: parse errors from loadUserRules and compile errors from
Rules() and RulesWithProject now carry the path. When a project scan
fails to compile, the global file is blamed only if it fails on its
own, so a project file that disables a broken global rule still loads.
The cached markdown split now takes the rules its caller already
loaded instead of loading them again and dropping the error.

* fix(install): block installs whose audit cannot run

Once global scans return rule-load errors, install treated the error as
a warning and installed the skill with no audit at all. update already
fails closed on a scan error, and --force there accepts findings, not
an install nobody could check.

A scan error now blocks skill, agent and tracked-repo installs and
removes what was installed. --force does not override it;
--skip-audit still bypasses scanning. The error wraps the new
install.ErrAuditScanFailed rather than audit.ErrBlocked, so install
output and the dashboard do not offer a --force retry that cannot help.

upgrade reinstalls the built-in skill with --force, which deleted the
old copy before the audit ran. A typo in audit-rules.yaml would have
left users without the skill, so upgrade now stages the download
through the update path and keeps the installed copy when the audit
fails.

update --all counted the new error as a silent skip. It is now listed
under "Blocked by security audit" with its reason and makes the run
exit non-zero. The install warning summary that counted "audit scan
error" warnings is removed, since nothing emits them any more.

Fixes #879
2026-11-13 15:14:05 +08:00
Willie 0939eb9ad9 fix(plugin): verify native support only for changes that run a command (#873)
* fix(plugin): verify native support only for changes that run a command

prepareChange probed native command support before applying the
intentional skip rules. When the probe failed under update --all, the
change was marked as a failed target, so the later skip never applied.
An imported Grok plugin always hit this: Grok updates require native
trust, so every update --all exited nonzero even though Grok plugins are
documented as updated natively. #853 patched the same ordering for
imported OMP plugins only.

Run the probe after the skip rules instead, so a skipped change is never
verified, and drop the OMP-specific exemption it made redundant. Host
errors and changes that do run a native command still fail as before.

* docs(plugin): align OMP removal wording and runbook pass criteria

The translated plugin references said OMP removal requires a
scope-matching native registration. English, and the code, only require
that a registration match when one is present; a retry after native
uninstall proceeds from the retained cache. The runbook's Pass Criteria
also did not cover the two scenarios #853 added as steps 4 and 5.
2026-11-12 14:09:10 +08:00
Rusty ShacklefordandWillie caa107b880 fix(plugin): refresh stale OMP catalog and report blocked OMP updates (#853)
* fix(plugin): recover OMP stale catalog installations

Refresh owned marketplace catalogs before reuse and validate the native cache identity when removing an installation. Preserve that identity through interrupted cleanup and report blocked batch updates as failures so retries remain safe and visible.

* fix(plugin): preserve reviewed versions during OMP recovery

Keep native removal identity separate from reviewed receipts so interrupted cleanup can retry safely. Expose isolated failures in previews and dry-run exit status while allowing healthy targets to proceed.

* fix(plugin): resume interrupted OMP update cleanup

Retry matching pending removals before reinstalling after registry-first interruption, and clarify isolated failure reporting. Strengthen recovery fixtures and restore accurate installation guidance.

* test(plugin): model OMP cached catalog installs

Use the cached marketplace entry for native install version and source so the stale catalog regression exercises the real version-to-cache relationship.

* test(plugin): align OMP batch expectations with safety checks

Require catalog refresh before reinstalling from an owned marketplace and assert isolated failures when native OMP ownership cannot be verified, while healthy targets update.

* fix(plugin): skip native upgrade checks for OMP imports

Imported plugins have no reviewed source to upgrade, so requiring native upgrade capability makes a safe batch skip fail unnecessarily. Cover that case and OMP dry-run failures, and align translations and native verification runbook with the failure and removal behavior.

---------

Co-authored-by: Willie <egg358358@gmail.com>
2026-11-12 13:45:55 +08:00
Willie 9dbcd925d8 feat(audit): honor findings accepted with --force via --respect-accepted (#872)
* feat(audit): honor findings accepted with --force via --respect-accepted

install and update --force record the findings a user accepted in
audit_accepted, but audit ignored that record. A skill installed with
--force therefore kept failing `skillshare audit` in CI with no way to
let the accepted findings pass (#869).

audit --respect-accepted marks those findings as acknowledged. They stay
in every output (JSON acknowledged: true, a text/TUI note, "(accepted
earlier)" in Markdown, SARIF external suppressions), but they are counted
in summary.accepted instead of their severity and no longer fail the
audit. Without the flag nothing changes, so existing CI gates keep their
behavior. A changed file or snippet produces a new key and blocks again.

Tracked repositories record acceptances at the repo root with paths
relative to it, so ApplyAcceptedFindings walks up from each skill to
match them. The install, update and edit gates use the same function and
now honor repo-wide acceptances for skills inside tracked repos too.

The dashboard always honors accepted findings: the Audit page mutes them
and counts them apart, the skill Audit tab collapses them, and the
Dashboard attention card no longer lists a skill whose only blocking
findings were accepted. The CLI JSON summary and the server summary share
Result.CountOpenBySeverity so both count accepted findings the same way.
The oplog records the accepted count and the log views show it.

* fix(audit): match acceptances when a single file is scanned

A single-file scan names its findings by the file's base name, but the
ancestor lookup used the file's whole path as the prefix, so it hashed
SKILL.md/SKILL.md instead of the recorded SKILL.md. Auditing a skill file
directly with --respect-accepted, and auditing agents inside a tracked
repository in the CLI or the dashboard, still failed on unchanged
accepted findings. For a file target the prefix is now the file's own
directory.
2026-11-12 11:15:44 +08:00
Willie 65f3c8d1b9 fix(ui): show health checks as they finish instead of after the slowest (#870)
* fix(ui): show health checks as they finish instead of after the slowest

The Doctor page waited for the whole `doctor --json` run before showing
anything. One slow check, such as plugin checks waiting on a native CLI
that does not answer, kept the page on a skeleton for 30 seconds, and the
server's 30-second write timeout could cut the response off entirely.

`doctor --json` now prints each check as a {"check": ...} line when the
internal _SKILLSHARE_DOCTOR_STREAM variable is set, before its usual
result. The new GET /api/doctor/stream relays those lines as Server-Sent
Events and sends the full result as `done`; it has no write deadline and
stops doctor when the client leaves. The page shows checks as they
arrive and replaces them with the final result.

* fix(ui): show the server's reason when a stream fails

The audit, diff and doctor streams send an `error` event with the reason,
but the shared EventSource helper treated it like a dropped connection
and showed only a generic message. It now uses the reason the server
sent, and keeps the generic message for a real disconnect.

* fix(doctor): skip Git reads in the hooks check when no hooks are configured

The hooks check loaded the full hooks inventory, which also scans
unmanaged native and Git hooks twice: about 12 git calls even with no
hooks configured, none of which doctor reports. Doctor now reads the
hooks section first and previews a sync only when there is something to
check.
2026-11-12 10:40:15 +08:00
github-actions[bot]andWillie 1100047f9c chore(main): release 0.30.6 (#850)
* chore(main): release 0.30.6

* chore(release): synchronize release metadata

* docs(changelog): write user-facing notes for 0.30.6

The generated entry listed commit subjects only. Describe each change by what users see, add CI examples for check --exit-code, and give a migration note for self-hosted servers, which no longer receive provider tokens after #861.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-11-12 01:26:19 +08:00
Willie c7ee19535b docs: prepare the 0.30.6 check --exit-code release
Point every README release notice at check --exit-code and check --all, the headline CI changes in 0.30.6, and credit tomerzcod7 (#852) and ErykJakubik (#858), whose reports led to the git hook and project config fixes.

The security change in #861 added its provider-token paragraph twice to the install command page in all five locales; keep one copy.

The website builds for all five locales and context validation passes.
2026-11-12 00:51:55 +08:00
Willie 68a3f52c9d docs(comparison): mention check --exit-code in the Updates row
The row says skills check exits 1 on updates or local changes, while the Skillshare cell listed only check and update, which reads as if Skillshare cannot gate CI on drift. check --exit-code (#865) does that.
2026-11-12 00:37:28 +08:00
Willie 55161e44ba fix(check): keep --json output valid when a name or group does not resolve (#868)
check <name> --json printed its warnings and the group expansion note on stdout before the JSON, so the output could not be parsed. When no name or group resolved it then printed an empty result and exited 0, while text mode exits 1, so a CI gate with a mistyped name passed.

With --json, check now exits 1 with an error object when nothing resolves, lists skipped names in a warnings field when some do, and reports every other failure (bad flag combination, missing config) as the same error object. Text mode is unchanged.
2026-11-12 00:35:40 +08:00
Willie 53bac42243 fix(check): make --all check agents as well as skills (#867)
check --all is documented as checking both skills and agents, but it ran the skills check only. With --exit-code now available, a CI job using check --all --exit-code passed while an agent had drifted.

--all now runs both checks: the text output has a Skills and an Agents section, --json adds an agents array beside tracked_repos and skills, and --exit-code counts both. check --json and check agents --json keep their shapes.

--all is rejected together with names or --group. It used to be ignored there, and agents have no name filter, so honoring it would check one skill and every agent.
2026-11-11 23:50:01 +08:00
Willie 8abf3f50ed feat(check): add --exit-code to fail when anything is not up to date (#865)
check exits 1 only when an item could not be checked, so a CI job that wants to fail on pending updates or local edits had to parse --json.

--exit-code makes a check that ran cleanly exit 1 when any skill, tracked repository or agent is not up to date. Only items whose status is local are left out, and the default exit status is unchanged. The operation log still records such a run as successful. The flag is rejected with --diff.
2026-11-11 23:30:39 +08:00
Willie c040917bc7 fix(security): enforce credential and filesystem trust boundaries (#861)
Bind provider credentials to canonical or explicitly configured HTTPS origins and preserve that policy across remote consumers. Reject cross-site credentialed reads, linked fallback directories, and discovered-agent writes outside the source; audit staged content before rooted atomic publication.

Add boundary regressions, private Git update coverage, stable cross-platform fixtures, and aligned documentation. Verified the integrated main baseline with all executed CI checks passing.
2026-11-11 23:17:54 +08:00
Willie 11c2f41b80 docs(comparison): re-pin the npx skills comparison to v1.8.1 (#864)
* docs(comparison): re-pin the npx skills comparison to v1.8.1

The comparison and migration pages cited skills v1.7.6. Since v1.8.0
the restore command links restored skills into agent directories, so
the page's statement that it does not was wrong. The page also did not
say that `skills install` with no source is the same restore command,
that matching skills only get their missing agent links, or that
`skills check` exits 1 on updates or local changes.

Re-pin both pages and their four translations to the v1.8.1 tag commit
and correct those statements against its CLI reference. The lock paths
and fields the migration guide names are unchanged in v1.8.1.

* chore: ignore .feature-radar/

The feature-radar skill keeps its tracking notes, including assessments
of other tools, in .feature-radar/ at the repository root. They are
local working notes and should not be committed to the public
repository.
2026-11-11 23:10:46 +08:00
Willie 769087b882 fix(project): keep config.yaml true after reinstall, uninstall and fresh-clone installs (#860)
In project mode the committed config.yaml is what teammates install from, but
it could disagree with what a machine actually has (#858):

- `uninstall -p` and the dashboard's single-skill and tracked-repo removal
  left the skill's entry in config.yaml, so a later `install -p` brought it
  back. They now drop the entry and the lock pin through one shared
  config.ForgetProjectSkills, as the uninstall docs already promised.
- Installing a skill again from another source or branch (after an uninstall,
  or over the copy with --force) updated only the gitignored .metadata.json.
  config.yaml kept the old source and skills.lock.json ended with the old
  source and the new commit. Installs from a named source (CLI install,
  search, dashboard) now compare the records from before and after the
  command and let the config entry follow the skills it actually reinstalled.
  Install from config never rewrites an entry from local records, so a
  teammate's edit survives on a machine that has not updated yet.
- Reconcile removed every config entry that had no folder and no record. On a
  fresh clone nothing is installed yet, so `install <source> -p` deleted all
  the other declared skills. An entry now goes only when the skill was
  installed here and its folder is gone, when it was moved, or when a command
  removed it; `move` passes the old paths and `update --prune` cleans the
  config itself.
2026-11-11 22:42:03 +08:00
Willie e317483459 feat(herdr): offer skillshare as a standalone mod (#857)
Preserve the complete Layout while adding a standalone Mod named skillshare. Generate both packages from one canonical mod and protect custom layouts and usage meters during installation and updates. Keep release versions aligned and route native Herdr instructions separately within existing context budgets.
2026-11-11 21:49:34 +08:00
github-actions[bot] b78c90d03e chore(main): release 0.30.5 (#848)
Release the automatic version-check opt-out with CLI and dashboard controls, unchanged explicit checks and upgrades, and documented global configuration and environment precedence.

Synchronize the manifest, built-in skill, Herdr panel version and both user-facing changelog copies at 0.30.5. Include the reviewed release documentation from main.
2026-11-11 13:56:36 +08:00
Willie 93c12557bd docs: prepare the 0.30.5 update controls release
Refresh all README release notices and route agents to the new updates command. Clarify that desktop policy controls require a compatible App release; the CLI upgrade alone cannot change older desktop builds.

The website builds for all five locales, context validation and skill validation pass. The documentation diff passed five local review passes.
2026-11-11 13:40:45 +08:00
Willie adf6c9ecb3 feat(updates): allow opting out of automatic version checks (#847)
Add a global automatic-update preference with an environment override, CLI controls and dashboard settings. Suppress automatic release checks and cached notices while retaining explicit checks and upgrades.

Recheck policy before publishing in-flight results, preserve structured JSON errors, and reject incomplete manual checks. Include schema, completion, localization, documentation and regression coverage.

Closes #846.
2026-11-11 11:59:57 +08:00
Willie ac339b5693 docs: describe the real .metadata.json format
The docs still showed the old `{"skills": [{"name", ...}]}` layout, which
no current release writes; the file is `{"version", "entries", ...}`
keyed by path. Readers comparing the docs with their own file had no way
to tell what `audit_accepted` or `target_overrides` are for.

tracked-repositories also said project mode records `tracked: true` in
`.skillshare/.metadata.json` so teammates get it, but that path does not
exist and project mode gitignores the metadata files (#760); the flag
lives in `.skillshare/config.yaml`.

The example `type` is `github-subdir` because a subdir install records
that, and the field table omits `into`, which nothing writes.
2026-11-11 10:09:25 +08:00
github-actions[bot]andWillie 9f8935a3ca chore(main): release 0.30.4 (#832)
* chore(main): release 0.30.4

* chore(release): synchronize release metadata

* docs(changelog): describe 0.30.4 for users

The generated entry listed commit subjects. Rewrite it as what changes for someone using the Herdr panel, the CLI's --json output, plugin updates and audit, with the reporters credited.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-11-11 01:13:36 +08:00
Willie 021b371867 docs(plugin): say how Oh My Pi plugins update in the sharing guide
The per-Agent update summary in the sharing guide and the built-in skill named every Agent except OMP, which could not update before #837. Say that an OMP update removes its own installation and reinstalls the reviewed commit, as the command reference already does, in English and the four translations.
2026-11-11 01:07:18 +08:00
Willie bce18d2e19 fix(audit): resolve a nested skill's references against its own root (#845)
Auditing a parent skill checked every Markdown file's bundled references
against the scan root. A nested skill's `references/ok.md` was looked up
under the parent and reported as a dangling link, and its `../SKILL.md`
stayed inside the parent and was not reported as an escape, so a parent
audit disagreed with a direct audit of the child.

Each Markdown file now records the nested skill that holds it, and its
references are resolved and contained within that skill.

doctor scans a nested skill on its own and again inside its parent, so
it repeated the child's findings. It now reports each finding once.

Closes #834
2026-11-11 00:48:16 +08:00
Willie 709f5ce896 fix(herdr): align install discovery with CLI planning (#841)
Expose selected skill names and repository-relative paths in dry-run JSON so the panel follows CLI discovery, ignore rules, and canonical names. Refuse ambiguous plans and treat nonzero install exits as failures even with legacy JSON output.

Closes #838

Release-As: 0.30.4
2026-11-11 00:00:28 +08:00
Willie 833373f1a7 feat(herdr): enable and disable skills and agents from the panel (#843)
The Library lists disabled skills under Off, but the panel had no way
to turn one back on or to turn one off: that meant leaving Herdr for
the CLI or the dashboard.

A skill's or agent's preview now offers Disable, or Enable when it is
disabled. It asks first, then runs skillshare disable / enable with the
entry's own path, the pattern the dashboard writes, so enable removes
exactly what disable added. The next sync applies the change.

Exit 0 only means the entry's own line was written or was not there. A
glob, a folder pattern or a negation in the .local file can still
decide the other way, so the panel reads the list afterwards and
reports an entry that did not change instead of claiming success.

The confirm dialog shares the hook dialog's branch under the role
"able": "toggle" is already the tab-bar button's role, and an overlay
opened with it draws that button.
2026-11-10 23:36:10 +08:00
Willie 4be28c1258 feat(herdr): let the panel update itself from the latest release (#839)
The panel had no version and no way to update: a user had to copy the mod folder again by hand and could not tell when a newer one existed.

The panel now carries version.js, the skillshare release it shipped with, which Release Please rewrites in every release. While shown it asks once an hour where GitHub's "latest release" link lands and offers "Update panel" when that release is newer. It compares against the published release, not main, because the panel parses the CLI's --json output and a panel from main may need an unreleased CLI.

The update clones only the mod's folder at that tag and copies it over the installed one. It first checks the folder holds the running panel's version, keeps the replaced files once in .bak-update-<version>, and holds every machine's lock until the reloaded panel returns it, because Herdr's reload ends every running task.
2026-11-10 23:01:39 +08:00
Willie 819546f124 feat(herdr): answer "what needs me" first and preview every row (#836)
* feat(herdr): answer "what needs me" first and preview every row

The panel listed every resource in one long tab and put the detail of a
row in text under it, so the first screen never said whether anything
needed a sync, and a 400px column filled with wrapped lines.

Overview now leads with one headline, one Sync button and a map from the
source to every target, and lists only what needs attention. Library
holds the full lists. A row carries a name and one short state; clicking
it opens a preview dialog with its document, its targets and its
details, so nothing is crammed into the list. MCP previews show the
names of env, header and token entries, never their values.

Target names come from `status` as well as `diff`, because `diff` leaves
out targets that share another target's folder. A machine with
uncommitted or unpushed work offers Sync both ways, since a plain pull
would refuse there. Warnings and errors now clear after 8 s instead of
staying until closed. Dialogs draw their own card and fade in and out.

The map's lines, the target list and the machine's action live in
model.js with tests; rowSub and the hideDisabled filter had no caller
left and are removed.

* fix(herdr): list only the targets a previewed item can reach

The preview's Targets tab was wrong in two cases.

A skill already on some targets but new to one has the state "missing",
and the preview treated that state as "waits everywhere", so targets
already in sync were marked as needing a sync. Only the targets the
item's drift names wait now.

An agent's preview listed every configured target, including ones that
take no agents, as in sync. The loader now keeps the targets that take
skills and the ones `status` reports for agents apart, and the preview
uses the list for the item's kind.

* feat(herdr): sync from Library's waiting group

The redesign left Sync only on Overview, so someone reading the Library
list had to switch tabs to act on the rows in front of them. The
"NEEDS SYNC" header carries Sync again, for the scopes its rows wait in;
when only a hook notice has native changes, its header carries it.

* fix(herdr): keep Sync in Library's toolbar and stop the panel shrinking past its tabs

Sync on the "NEEDS SYNC" header only existed while something waited, so
with everything in sync Library had no way to sync at all. It now sits
in the toolbar beside the filter, primary while something waits.

The panel could be dragged down to 320px, where the tab row no longer
fits beside the scope switch and the switch is cut off. The column's
minimum is 380px, and the tab row is a little tighter.

* fix(herdr): sync every scope a target still waits in from Library

Library's Sync chose its scopes from the waiting rows alone. A target can
wait with no row left, as after uninstalling a project skill that a
copy-mode target still holds, so with All shown and one global row
waiting, Sync ran in the global scope only and left the project copy in
place. Overview already added the scopes with a waiting target.

Both now take their scopes from one model helper, syncScopes, which
covers waiting rows, waiting targets and the nothing-waiting fallback.

* refactor(herdr): finish the review's open findings on the panel

The first review left confirmed findings listed but unfixed, and the
commits after it were never reviewed. This closes both.

The map now counts a waiting MCP server, plugin or hook on the targets
it waits on, so its lines no longer stay green under a headline that
says something waits. A skill's Targets tab takes its targets from
status when status names them: diff also lists targets that take agents
alone. Library's Sync stays disabled until a scope has been read;
before that it sent an empty scope list and reported a sync that never
ran.

The map's trunk and lanes, the two pill switches, the placeholder block
and its pulse each had two or more copies in main.js and now have one.
The Overview headline, a machine's remote line and its waiting targets
move to model.js with tests. README's layout snippet names the 380px
minimum the layout file already has.
2026-11-10 22:25:13 +08:00
Willie 4556438575 fix(plugin): let OMP and Pi plugin updates through without uninstalling (#833) (#837)
* fix(plugin): let OMP and Pi plugin updates through without uninstalling (#833)

Every OMP update was blocked, because OMP's native upgrade replaces cache
folders that projects outside its inventory may still use. The only way to
move an OMP binding to a new commit was to uninstall first. An update now
runs the same pair a source change already uses: the scoped removal
adapter (cache kept), then an install under a fresh marketplace and cache
identity. A refresh always takes a new identity, because OMP installs from
the catalog it cached when the marketplace was added, and that catalog
still names the old version. If the removal cannot be verified, the
update is blocked; update --all still skips it with the reason.

Pi was blocked whenever the catalog plugin name differed from its
package.json name. That happens after an upstream npm rename, for example
when npm refused the original name. Pi installs by path, and Skillshare
keys the binding by the catalog name, so the npm name never reaches
either, and the check only stopped working installs.

Updating one package across several Agents stopped every Agent as soon as
one was blocked. Each failing Agent is now reported with its reason while
the others update, and the command exits non-zero. A single --target, or
a package with no other Agent to update, stays blocked as before, so a
dry-run still fails when nothing would update.

* fix(plugin): let one update --all refresh several OMP packages

Every OMP removal proves itself against a fingerprint of the whole native
registry and lock. In a single update --all plan, the first package's
removal and reinstall rewrite those shared files. The second package's
removal therefore saw "OMP native files changed", so only one OMP
package could update per run. The same applied to a sync that replaced
the sources of several OMP packages.

A removal now also fingerprints only its own installation: its registry
entry, its lock entry, its package manifest and its runtime link. After
an earlier change in the same apply has written to that OMP target, the
removal re-reads the files and runs every ownership check again. It goes
ahead only if that own fingerprint still matches the preview. A change
outside Skillshare to the package's own entries still blocks it. Without
an earlier write in the apply, the full-file check is unchanged.

The fake OMP in the tests now merges installs into the registry and lock
and lists them in a stable order, as the real one keeps other plugins.
2026-11-10 21:46:42 +08:00
Willie 816938c09c fix(cli): report why uninstall and install fail under --json (#835)
Scripts and the herdr panel could not tell why an uninstall or install
failed: uninstall --json had no error field, project mode ignored --json
(printing text and still prompting), and a multi-skill or config install
in which every skill was blocked exited 0.

- uninstall --json (skills and agents, global and -p) sets "error" with
  each failed name and reason; skills exit non-zero when all fail,
  agents when any fails. Project mode now emits pure JSON, including on
  the first run that initializes the project.
- uninstall -p agents parses its flags instead of treating --help or an
  unknown flag as an agent name, and uninstall agents --json is logged.
- install exits non-zero, naming each skill and reason, when every skill
  from a source or from config fails; installed or skipped skills make it
  a partial success that still exits 0. Config installs show each
  failure's reason, and the dashboard logs an all-failed run as an error.
- herdr asks for JSON in project scope and shows the CLI's error.
2026-11-10 20:24:44 +08:00
Willie 180190a3ec docs: update skills comparison and migration guidance
Compare npx skills v1.7.6 against verified capabilities instead of an install-only model. Position Skillshare around broader resource management and document experimental restore and npm sync limits.

Clarify migration ownership, backups, source tracking, ref preservation, and initialization safety across English and four translations.
2026-11-10 17:55:39 +08:00
Willie 2d5475ce87 docs(herdr): lead the panel's README and recipe with what skillshare is
A third of the repository's visitors arrive from herdr.dev and land on
herdr/skillshare, where the README opened with install steps and no
picture, and never said what skillshare is or linked back to it. The
recipe's first paragraph, which the Herdr gallery shows as the layout's
description, did not mention the Machines tab.

The preview was also stale: it predated the Hooks kind and the
List / By source switch. Redraw it from the design board, add a
three-view picture for the README, and refresh the copies that follow it.
2026-11-10 17:28:28 +08:00
Willie 176a236249 fix(install): report why an install failed in --json output (#831)
install --json printed empty skills and failed lists with exit code 1
when the whole install failed, for example when the security audit
blocked a tracked repository or a single skill. Scripts and the herdr
mod could see that it failed but not why, and the mod already reads an
error field that was never set.

The install JSON now carries the command error in an omitempty error
field, in global and project mode. The install docs also stop saying
--json implies --force: it only permits overwriting, and the audit gate
still applies unless --force is given.
2026-11-10 17:24:23 +08:00
github-actions[bot]andWillie 3cba0074c1 chore(main): release 0.30.3 (#824)
* chore(main): release 0.30.3

* chore(release): synchronize release metadata

* docs(changelog): describe 0.30.3 for users

The generated entry listed commit subjects; users need to know what changed for them, with an example for the new Hermes target and the audit change that can now block tracked installs.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-11-10 16:42:31 +08:00
Willie c74a35dd4b fix(audit): text-scan hidden-directory skills in tracked repo gates (#827)
Tracked install and update audit the whole repository root, and the
scanner treated every file below a hidden directory as header-only. Skills
that discovery finds in hidden directories, such as .curated/<skill> and,
since #801, a repository-root .agents/skills/<skill>, were therefore synced
to every target without a text scan.

The hidden-directory boundary is now measured inside the skill that holds
a file, so those skills get the text scan they already get when audited one
by one, while target copies such as .claude/skills and hidden folders
inside a skill stay header-only.

Release-As: 0.30.3
2026-11-10 16:21:26 +08:00
Rusty Shackleford 71ff2d9e14 fix(discovery): find repository-root .agents/skills (#801)
A repository-root .agents/skills now counts as a skill anchor only when the repository has no other SKILL.md outside .git and target directories, so tracked checkouts that author skills there are discovered, while repos that commit .agents/skills copies keep discovering only their authored skills.

Fixes #800
2026-11-10 16:04:20 +08:00
Willie cafd99e595 feat(mcp): add Hermes Agent sync and import target (#826)
Share portable MCP definitions with Hermes through its native YAML configuration while preserving unrelated settings and managed-entry safeguards.

Support explicit Hermes homes and native OAuth options without copying credential state, and expose the target consistently in the dashboard, schemas, completions and documentation.

Refs #825
2026-11-10 15:19:11 +08:00
github-actions[bot]andWillie 655a630c55 chore(main): release 0.30.2 (#818)
* chore(main): release 0.30.2

* chore(release): synchronize release metadata

* docs(changelog): describe 0.30.2 for users

Replace the generated commit list with user-facing entries for the three
fixes users can notice: the Python docstring audit severity, the dashboard
restart on Homebrew, and the root-scope nested repo check. Dashboard-only
UI polish and the test-only CI fix are left out.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-11-10 01:35:13 +08:00
Willie bb514c9432 fix(git): skip gitignored tracked repos in the root-scope nested repo check (#821)
With git_root: root, commit and push aborted on every tracked skill repo
because NestedRepos flagged any directory with its own .git. Tracked repos
are listed in the managed .gitignore block, so git add -A never stages
them, and the suggested remedy (renaming .git to .git.disabled) breaks
skillshare update for those repos.

NestedRepos now asks git check-ignore about each nested repo and leaves
out the ones git ignores and does not track. A repo already committed as
a gitlink is still reported, since staging would update it. Paths are
checked one at a time because git refuses a whole batch when one path
lies inside a gitlink, and any git error keeps the warning.

Closes #820
2026-11-10 01:00:03 +08:00
Willie 037c7943cf fix(audit): report credential paths in Python comments and docstrings as HIGH (#819)
Credential-access rules match whole lines, so a Python docstring that
named ~/.aws/credentials in a `cat` example counted as a CRITICAL read and
blocked the mcp-sentinel skill at the default threshold (#817).

In .py files, a built-in CRITICAL credential-access match on a comment-only
line, or inside a string that is a whole statement such as a docstring, is
now HIGH: it still shows, and still blocks under a HIGH threshold. A small
tokenizer decides this and keeps CRITICAL wherever it cannot be sure the
line never runs: argument, assigned and bracketed strings, f-strings and
their replacement fields, code before a trailing comment, files that read
__doc__ or use bare CR line breaks, and explicit severity overrides.

A lowered finding carries severityContext "python-inert" (JSON, SARIF,
`audit rules --format json`), and the dashboard, CLI text output, both
audit TUIs, install/update warnings and the markdown report say it was
lowered from CRITICAL, so it is not mistaken for a changed rule.

Closes #817
2026-11-09 23:30:37 +08:00
github-actions[bot]andWillie d58bc0dd4d chore(main): release 0.30.1 (#813)
* chore(main): release 0.30.1

* chore(release): synchronize release metadata

* docs(changelog): describe 0.30.1 for users

The generated entry listed the Release-As commit as a change and used
commit subjects. Replace it with what users see: the Hubs refresh button
and the parallel plugin update check.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-11-09 18:21:12 +08:00
Willie 0580bd79bd feat(ui): add a refresh button to the Hubs page (#814)
The Hubs page keeps a hub's skill list for two minutes and does not
refetch on window focus. The server reads the index fresh on every
request (git hubs are re-cloned), so after someone pushes an updated
skillshare-hub.json the only way to see it was to wait or reload the
whole page.

A refresh icon button next to the filter refetches the list on demand.
It spins and is disabled while loading; the current list stays on screen,
and a failed fetch shows the existing error note above it. Your own
(draft) Hubs are local and do not get the button.
2026-11-09 18:08:25 +08:00
Willie 2bc791ed19 perf(plugin): check every plugin at once and skip sources that did not move (#812)
* perf(plugin): check every plugin at once and skip sources that did not move

The Plugins page's update check read every Agent CLI, cloned and hashed
every source, and asked npm about every package one after another, so it
grew with each plugin added. A single Agent CLI that stopped answering
held the whole page at "Checking for updates" with no way to tell which
plugin was stuck.

The check now asks every Agent and checks every plugin at the same time.
Plugins share one read of each Agent and each source, so an Agent with
many plugins is still asked once, and a plugin waits only on its own
Agents, including when proving its own leftover installs. Before downloading a remote source with no pinned ref, the
check asks the remote which commit its default branch points at with
`git ls-remote` and reports no update when that is the installed commit.
A check of three unchanged GitHub plugins on two Agents went from 4.3s
with three clones to 0.6s with none.

The dashboard reads the check from a new stream, GET
/api/plugins/check/stream, that sends each plugin as soon as it is
checked. The page marks rows as they arrive and counts progress in the
header. The stream stops waiting after 60 seconds: a plugin bound to an
Agent that has not answered by then shows "Check failed" with the
reason, and plugins on other Agents are unaffected. There is no limit on
how many plugins run together, because plugins waiting on a hung Agent
would otherwise hold every slot and starve the rest.

A cancelled command did not return when the Agent CLI was a shim that
starts the real client, such as an npm, mise or volta wrapper: killing
the shim left the child holding its output, so the command waited until
the child exited and no timeout took effect. Commands now stop waiting
for output two seconds after they are cancelled; a command that exits on
its own while a helper keeps its output open still counts as answered.

* fix(ui): offer every update the Plugins page shows in the update dialog

The header counted updates from the per-plugin marks, but the update
dialog offered only the targets in the last completed check's plan. Two
cases left the header saying Update N with nothing to tick in the dialog:
a first check that broke off after finding an update never set the plan,
and a recheck that could not reach an Agent kept that Agent's earlier
update while the plan said blocked.

The dialog's plan is now derived from each plugin's last answer together
with the kept updates, so a kept update stands in for the blocked or
missing answer and both always agree. A broken-off check also keeps the
answers it did receive.
2026-11-09 15:06:55 +08:00
github-actions[bot]andWillie 8313c3f151 chore(main): release 0.30.0 (#807)
* chore(main): release 0.30.0

* chore(release): synchronize release metadata

* docs(changelog): describe 0.30.0 for users

The generated entry listed commit subjects. Users need the migration step for the new host rule and what each fix changes for them.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-11-09 12:40:22 +08:00
Willie e9dc4d0360 feat(server)!: answer only at localhost, IP addresses and trusted origins (#811)
DNS rebinding lets a page point its own domain at the user's machine,
which makes its requests same-origin to the dashboard, so the CSRF
guard cannot refuse them. Only the MCP, Hooks and Plugins routes
required a localhost or IP Host, so such a page could still install,
sync and push. That rule also blocked those three pages for people who
run the dashboard behind their own reverse proxy (#809).

The dashboard now answers every route only at localhost, an IP address,
the --host name, and origins given with --trusted-origin or
SKILLSHARE_UI_TRUSTED_ORIGINS. Configuration stays outside config.yaml
so the dashboard cannot widen its own trust through its config API. A
trusted origin must match the Host with its scheme, and an Origin
header, when sent, must be that origin. A refused browser gets a page
with the exact setting to copy, the API gets it in the error, and the
server log names each refused Host once.

BREAKING CHANGE: a dashboard opened by a domain name, such as a reverse
proxy, a Tailscale or mDNS name, or a Docker service name, now returns
403 on every page until that address is trusted, for example with
`skillshare ui start --trusted-origin https://skills.example.com`.

Release-As: 0.30.0
2026-11-09 11:59:50 +08:00
Willie ec9b3e688c fix(server): refuse dashboard changes sent from other sites (#810)
A web page can submit a form or a no-cors fetch to the local dashboard
without a CORS preflight, and the handlers accept a text/plain or empty
body. Only the MCP, Hooks and Plugins routes checked where a request
came from, so any site the user visited could add targets, install,
sync, commit, push or upgrade, whenever the browser let the request
reach localhost.

Every POST, PUT, PATCH and DELETE now needs Fetch Metadata, when sent,
to say same-origin, and Origin, when sent, to match the Host. A client
that sends neither, such as curl, is unchanged, because a page cannot
make a browser omit both on a cross-origin request. The update stream
runs updates over GET, as EventSource only opens GET, so it gets the
same check.

The nginx example now forwards $http_host, which keeps the port, since
a proxy that drops it would now fail every change, not only MCP.
2026-11-09 11:08:43 +08:00
Willie ac49959f83 docs(hooks): note the dashboard Hooks page needs localhost or an IP
The Hooks page uses the same DNS rebinding guard as the MCP page
(requireLocalHooks), so through a domain name or a reverse proxy its
requests return 403. The reverse proxy note only mentioned MCP, so a
user behind a proxy had no warning that Hooks would fail too.
2026-11-09 10:24:38 +08:00
Willie bfbc06a664 fix(plugin): keep Codex off packages and folders it cannot use (#808)
The Claude manifest fallback from #806 offered Codex more than it can
install:

- A Claude package whose only parts are ones Codex does not read, such
  as agents, was offered to Codex with no components, so Codex would
  install an empty plugin.
- When Codex's own catalog pointed at a folder it rejects, the whole
  candidate could be replaced by the Claude catalog's folder, which now
  carries a Codex fallback. Codex reads only its own catalog, so it
  would never install from that folder.

#806 also stopped every Agent from using a later catalog's folder when
the first one was rejected. Only Codex needs that, since only Codex
reads one catalog exclusively, so other Agents get the old behaviour
back.
2026-11-09 10:04:33 +08:00
Nathan Vale 6e1fc67d71 fix(plugin): discover Codex-compatible Claude manifests (#806)
Codex accepts Claude plugin manifests natively, but discovery omitted
Codex for packages such as Matt Pocock's skills. Select that supported
fallback without rewriting package resources or invocation policies.

Match native root and manifest precedence, retain rejected own-catalog
packages, and add discovery and snapshot regression coverage.

Refs #805
2026-11-09 09:54:01 +08:00
github-actions[bot]andWillie 60be62362c chore(main): release 0.29.2 (#797)
* chore(main): release 0.29.2

* chore(release): synchronize release metadata

* docs(changelog): write user-facing notes for 0.29.2

The generated entry listed commit subjects, including a docs-only
commit, without saying what users can now do or what the audit fix
prevents.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
2026-11-08 18:49:19 +08:00
Willie f3dec2fde9 docs(ui): describe the filter preview search
The dashboard reference walked through each Targets page control but
not the search box #799 added above the include/exclude preview, which
is also shared by project pages and the Extras Edit target dialog.

Release-As: 0.29.2
2026-11-08 14:45:06 +08:00
Willie 03f6f42aae docs(audit): clarify symlink scanning for direct-file and agent audits
The #796 wording attached "including direct-file and agent audits" to the
special-target error, so the sentence read as a repeated list and no longer
said that links to ordinary files keep text scanning in those audits. The
translations had dropped that scope entirely. Split it into two sentences
and restore the scope in every locale.
2026-11-07 23:20:47 +08:00