* fix(sync): never delete or re-point entries skillshare did not create
On Windows, a plain `init` followed by `sync` deleted things in
~/.claude/skills that skillshare never created, with no backup and no
prompt. It also re-pointed another tool's junction. Seen in a sandbox
run of v0.30.7:
- prune removed real folders whose names only look like skillshare's
flat naming (team__shared, _drafts), via the name heuristic
- prune removed a broken link that another tool or the user made
- merge sync deleted and re-created a same-name link that pointed into
another manager's store
- init's import deleted original folders that matched the source
byte for byte
The manifest already records what skillshare made, so use it:
- prune keeps a look-alike folder that is not in the manifest and warns
once per sync; --force still removes it
- prune removes a broken external link only if the manifest records it
(e.g. after the source moved); otherwise it keeps the link and warns
- merge sync re-points a link only if the manifest records it or it
already points into the source; otherwise it reports the entry as
kept local, as it already does for a real folder; --force replaces it
- init's import moves identical copies to the trash under
replaced-by-init/<target>/ instead of deleting them
Tests: ownership_test.go adds regression tests that use createLink, so
they run on Windows without Developer Mode (junctions). The 4 keep
tests fail without this change. TestSyncTargetMerge_FixesBrokenLink now
records the link in the manifest first, since a same-name link that
skillshare did not make is no longer re-pointed. Existing tests in
internal/sync, internal/trash and cmd/skillshare show the same failures
on a Windows host with and without the change (symlink privilege). The
devcontainer suite has not been run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: say what sync and init keep when skillshare did not create it
The previous commit makes sync and init leave alone entries skillshare
did not create. Update the pages that describe that behaviour:
- sync-modes: merge mode keeps a same-name link from another tool and
reports it as local; orphan cleanup keeps folders that only look like
skillshare's flat names, and broken links outside the source that the
manifest does not record. sync --force still removes them.
- init: identical folders replaced with links during the first sync go
to the trash first (replaced-by-init/<tool>/, cleaned after 7 days).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(sourcefs): drop the raw-write allowance replaceIdenticalCopies no longer needs
replaceIdenticalCopies now moves an identical copy to the trash instead
of calling os.RemoveAll, so TestRawWriteRatchet reports its allowance as
stale.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(sync): apply the ownership rule at every consumer
Review of the first commit found places that still did, or predicted,
the old behaviour. One rule now decides whether a link is skillshare's:
Manifest.OwnsLink (the manifest records a link there, or it points into
the source). It compares canonical paths, so a source reached through an
alias and a relative project link still count as skillshare's.
- copy mode kept re-pointing: it removed any same-name link and wrote a
copy. It now keeps a link it does not own, like merge mode.
- the dashboard diff predicted a prune for a folder that is only named
like skillshare's, and an update for another tool's link. It now
reports them as local and kept. The orphan-link prediction uses the
same rule as prune.
- `diff` reported a target as in sync while sync printed "kept local"
for another tool's link. It lists the link as a local override.
- doctor reported a broken link skillshare did not create as an error
and suggested `skillshare sync`, which now keeps it. It is a warning
with its own row, and `broken_symlinks` is `warning` in --json.
- `trash restore` put a folder init had replaced into the source as a
new nested skill. Restore refuses entries under replaced-by-init/ and
names the trash folder to copy from.
- init reported a folder it could not move to the trash as one that
differs from the source, and dropped the error. It is reported
separately, with the error.
- the PruneOptions.ManagedOnly comment still said broken external links
are skipped; manifest-recorded ones are removed.
Tests cover the states the review listed: a source behind an alias, a
relative project link, ManagedOnly, standard naming, dry run with
--force, and a recorded copy the user replaced with a link.
TestSync_Pruning_RemovesBrokenExternalSymlinks passed without testing
anything, because FileExists follows links; it is now two tests that
use Lstat, one per owner.
Agent merge is unchanged: agents have no link manifest.
* fix(diff): list another tool's link as kept in copy mode too
Copy mode now keeps a same-name link skillshare did not create, but both
diffs read the entry with os.Stat. A broken link showed as a skill to
add on every run, and a live one as a plain local copy, while sync kept
both and said "kept local".
`diff` and the dashboard diff check the link first and report it the way
merge mode does: a local override, kept until --force.
* test(sync): make the aliased-source link while its folder exists
TestSyncMergeRepointsUnrecordedLinkIntoAliasedSource failed on Windows:
it linked straight to a missing folder, and a junction cannot be made
to one. It now links first and removes the folder after, like the other
broken-link tests in this file.
* fix(sync): compare a broken link by where it would point
linksIntoSource resolved both paths with EvalSymlinks, which gives up on
a path that does not exist. A broken link is exactly that, so a link
into a source reached through an alias (a symlinked config folder, or a
short 8.3 path on Windows) compared an unresolved path with a resolved
one and was taken for another tool's link. Sync then kept it instead of
repairing or pruning it.
It now uses sourcewalk.Canonical, which resolves the nearest folder that
exists and keeps the missing tail. The test covers both spellings: the
alias in the link, and the alias in the configured source.
* fix(init): report what the first sync kept, and match prune in the diff
Two previews said less, or more, than sync does.
init ran its first sync quietly and printed only "Synced". Sync now keeps
a link another tool put on a skill's name, a folder that is only named
like skillshare's, and a broken link it did not create, so the skill was
reported as synced while the tool still loaded the other copy. firstSync
returns the warnings a plain sync prints, and init shows them. They
already name the folders that differ from the source, so the separate
list of those is gone.
The dashboard diff counted an orphan link as a removal whenever the
manifest recorded it. Prune keeps a recorded link that still resolves
outside the source (the source moved and the old checkout stayed), so
the Sync page showed a removal that never happened. The diff now uses
prune's own rule: a link into the source goes when broken or recorded;
any other link only when broken and recorded.
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Willie <egg358358@gmail.com>
prompt-injection-1 kept reporting ordinary source lines as CRITICAL
prompt overrides: `root: Path = Path(".")` (#921), docstring arguments
such as `root: Repository root containing the manifests.`, and typed
parameters with a name default. #376 and #750 each added value shapes
to the exclude. Measured on 5,573 real Python files and 33,006 Markdown
and config files, widening the exclude again cleared no line, and a
docstring entry cannot be told from prose by any value pattern.
In a source file a lowercase label word is a parameter, field or
docstring entry, so the built-in rule now matches only uppercase labels
there. The file extension decides, never a shebang, so a text file
cannot switch the check off. Markdown, text, config and extensionless
files, and Markdown code fences, keep the case-insensitive match. A
custom regex under the same ID is used as written.
This reverses the earlier choice that a lowercase `system: "..."` in a
non-Markdown source file stays CRITICAL.
Closes#921
The index and the draft builder read a skill's tags with different readers,
so the same SKILL.md could publish different tags depending on the path:
- The index accepted only the comma form (tags: git, workflow). A YAML list
became "[git" and "review]", and a block list produced nothing.
- Drafts accepted only a YAML list, so the documented comma form produced no
tags, and metadata.tags replaced the root field. After #901 the index
ignores metadata, which made the two disagree there as well.
Both now call readSkillTags. It reads the root field only, in either form:
a list comes from the decoded frontmatter, and the comma form from the
existing line scan. The scan also unwraps a one-line list, so a skill whose
frontmatter YAML rejects on another line (for example an unquoted colon in
the description) no longer publishes bracketed fragments.
Tags under metadata are custom data and are not read by either path. The
skill format page says so in all five locales.
Follow-up to #901.
IsRootFrontmatterLine took the caller's trimmed line only to test for blank
and comment lines, and its callers disagreed on how they trimmed it
(ParseSkillName trimmed spaces and tabs on the left, the rest trimmed all
whitespace). The helper now trims the raw line itself, so there is one
definition of a blank line and one argument fewer to get wrong.
Two tests added in #901 covered behaviour that change did not touch. The
ParseFrontmatterFields row is removed, and the ParseFrontmatterMap test is
reduced to the one case that guards what the skill format page promises:
nested metadata mappings and lists are kept.
Docs: the skill format page now recommends metadata for custom fields, but
the "Version tracking" example in creating-skills still showed top-level
version and author. It now matches. The sentence saying sync preserves
existing last_edited values is shortened, because skillshare has no such
field and the wording suggested it does. Both edits are applied to en, ja,
ko, zh-Hans and zh-Hant.
* fix(frontmatter): keep nested metadata out of skill identity
Preserve root indentation in the tolerant identity readers so nested name
and description fields cannot shadow a skill or create audit claims. Keep
each reader's locator, scalar conversion and streaming policies intact.
Prove existing structured provenance preservation and the namespace fix
with regressions, bounded fuzzing, and global/project CLI integration.
Document nested metadata and native-client compatibility in all format
page locales.
Fixes#894
* refactor(frontmatter): share root-line indentation checks
Use one root-line predicate for the tolerant identity readers and
ParseSkillName so their metadata namespace boundary has one owner.
Keep each caller's whitespace policy, locator, scalar handling and
early-stop behavior intact.
Retain the existing namespace regressions, fuzz invariant and CLI flow
coverage without adding a duplicate helper test harness.
* fix(hub): keep nested metadata out of index tags
Apply the shared root-line predicate to the hub index scalar tag reader so
custom metadata tags cannot replace root tags or create absent root tags.
Extend the existing namespace table rows to assert exact index tags while
preserving the separate structured-list metadata precedence policy.
* test(install): reproduce loss of pulled tracked records
Exercise the two-machine push and pull sequence and reconciliation states so
missing tracked clones cannot silently erase shared install intent.
* fix(reconcile): preserve tracked records missing local clones
Pull transfers tracked repository metadata but not ignored clones. Keep the
missing records during global reconciliation so another install and push cannot
erase shared intent or accepted audit findings on every machine.
* test(reconcile): isolate tracked record fixtures
Use the shared sandbox fixture for both reconciliation tests so their home
and configuration paths remain isolated from the invoking environment.
* fix(reconcile): retain all sourced tracked declarations
Legacy tracked members and unfollowed source links can hide declarations
from the local walk. Preserve sourced tracked records regardless of their
path so unrelated installs cannot erase them or their audit acceptances.
Document restoring a missing checkout before uninstalling it and cover
migration, link collisions, aliases, and explicit removal.
* test(reconcile): drop fixtures existing tests already pin
The tracked-record unit test also seeded a missing plain record and a
live plain record. TestReconcileGlobalSkills_PrunesStaleEntries already
pins both outcomes: a sourced plain record whose folder is gone is
pruned, and one on disk survives. The tracked record with no source
still catches a fix that keeps everything or skips the prune.
The two-machine test passed HOME and SKILLSHARE_CONFIG to RunCLIEnv,
which already sets both from the sandbox for each child process.
Separate homes, XDG paths, client overrides and git config remain.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(reconcile): retain tracked entry for unavailable link
Expect sourced tracked declarations to survive reconciliation with either
source-link policy, so the test matches the cross-machine retention contract.
* fix(config): prune legacy tracked members
Retain only sourced tracked repository declarations during reconciliation.
Migrated member records are not restorable as repositories and retaining them
would leave permanent misleading install requests and audit acceptances.
* fix(reconcile): preserve tracked intent across followed links
A source link can exist before a tracked repository declaration is pulled. Preserve that declaration when the linked folder is not a checkout so later reconciliation does not discard its record and audit acceptances.
* test(reconcile): cover grouped followed declarations
A followed group can contain the path of a pulled legacy repository declaration, which must retain its tracked intent while its key migrates.
* fix(test): scope collision fixture runner correctly
Keep the isolated CLI runner in the collision subtest that uses it so the integration test package can compile.
* docs(manifest): clarify tracked checkout recovery
A retained declaration cannot restore a checkout while another folder or source link occupies its destination, and restoration requires a reachable source. State those prerequisites in each manifest translation.
* fix(config): prune members under recorded repositories
A migrated underscore-named member can otherwise survive a missing checkout as a repository declaration. Check recorded ancestor paths while preserving ambiguous grouped declarations and unrelated aliases.
* docs(manifest): restore fresh-clone project guidance
Explain that project declarations without local install records remain available so teammates can install them after cloning.
* refactor(reconcile): drop the tracked-intent walker policy
Restore baseline normalization for present paths while retaining absent
repository declarations through the shared metadata predicate. Isolate the
reconcile fixtures without building a CLI and share native-client overrides
without changing the original two-machine record and audit regression.
Validation: gofmt, git diff --check and context-router check only.
Runtime, builds and tests were not executed under the source-only gate.
* fix: forget linked checkout records and declarations without checkouts
Extend the metadata and uninstall owners to remove a declaration without
reading or moving its occupant, contacting its source, or changing trash
and gitignore. A failed metadata save makes every metadata-only result fail.
Clean up global unlink records in CLI and API, preserve existing-path name
precedence, report record-only results truthfully, and list declarations in
the dashboard API with noCheckout. Keep project removal behavior unchanged.
Remove the obsolete grouped-link walker-policy assertion while preserving
grouped absent declarations and the original record/audit A/B regression.
Validation: source-only five-pass review, gofmt, git diff --check and the
context-router check. No runtime, builds, tests or frontend tooling ran.
Stop at commit 15 for the mandatory Luna checkpoint before UI and docs work.
* fix(server): reload metadata before removing declarations
Preserve CLI records and audit acceptances written while the dashboard is open. Resolve new declarations from disk and refuse stale-cache saves after a reload failure, retaining unlink success when its link already moved.
* feat(dashboard): remove a tracked repository record without a checkout
Show declaration-only rows without checkout actions or status promises. Reuse Uninstall with record-specific confirmation and feedback, keep real-checkout force handling, and refresh the missing-entry list after repository removal or unlink.
* docs: explain kept declarations and how to remove them
Document direct global declaration removal and optional restore in English and all four translations, including occupied paths and normalization after reconcile. Keep built-in guidance accurate and use the existing API removal result for dashboard success feedback after concurrent CLI changes.
* fix(dashboard): confirm restored checkouts after forceable refusals
A tracked declaration can be restored through the CLI while its dashboard
row still says there is no checkout. Treat a forceable uninstall refusal
as evidence of the current checkout and promote the existing confirmation
to its dirty or unreadable-status warning before allowing explicit force.
Author stale-row regressions for both forceable codes before the source
repair, and retain nonforceable failure and actual-result success feedback.
Validation: five serial source review passes, git diff --check, and the
context-router check. Tests, builds, runtime and frontend tooling were not
run under the source-only gate.
* test(server): persist overview declarations before routed request
The overview fixture added declarations only to the in-memory skills store,
which the real request's config reload replaced with on-disk metadata. The
hosted unit, offline, and Nix jobs consequently returned no tracked rows.
Save the complete fixture through MetadataStore before serving the request
and fail setup on a save error. Keep the middleware, assertions, and
production behavior unchanged.
* fix(server): prefer exact declarations before checkout shorthand
Removing a missing _team declaration from the dashboard could resolve the
different org/_team checkout by basename and trash it instead.
Reload metadata before declaration lookup, give exact declarations priority,
and preserve checkout resolution before non-exact declaration fallback.
Add routed absent/occupied regressions and checkout precedence guards, and
persist existing checkout fixtures so the metadata reload keeps their state.
Validation: gofmt, git diff --check, and context-router check passed.
Tests were authored but not run under the source-only fleet restriction.
* fix: preserve removal intent and report partial failures
Bind dashboard record-only removal to its canonical declaration and refuse
restored checkouts before checkout resolution or force. Refresh the row and
require another confirmation before moving a restored checkout to trash.
Keep unresolved uninstall inputs and their reasons in JSON failed results,
including all-invalid requests, partial successes and dry runs. Report unlink
metadata cleanup failures as partial results, refresh completed unlinks and
show localized warnings. Keep CLI and dashboard guidance aligned.
Regression tests were authored before source changes and remain unrun under
the source-only task restriction. Static formatting, diff and router checks
passed; no build, product runtime, frontend tooling or test suite was run.
* fix(unlink): log partial metadata cleanup failures
Write the unlink result after global metadata cleanup so load and save
failures retain their diagnostic and report partial success. Preserve the
successful link removal, warning, target and exit policy, and the existing
link, project unlink and native removal failure behavior.
Add the corrupt-metadata regression before the fix; leave it unrun under
the source-only authorization. Formatting, diff and context-router checks
pass; runtime verification remains with the coordinator.
* fix(unlink): forget records below the removed link name
Reconcile can normalize a followed link's record to untracked, and linked
collections can retain nested repository declarations. Clean the removed
namespace through the existing metadata path owner in both unlink callers,
including audit acceptances, while keeping declaration uninstall strict.
Author CLI and route regressions before the source fix for normalized and
nested records, sibling preservation, and subsequent bare install. Tests
remain unrun under the source-only task restriction; static checks only.
* fix(uninstall): refuse a restored checkout at execution
A declaration selected while absent can become a checkout before removal
runs. Recheck the resolved source-relative name in the shared metadata-only
execution owner and refuse before touching metadata, regardless of force.
Reuse the existing dashboard conflict response and refresh/reselection flow
for this refusal, preserving the earlier record-only intent guard. CLI
results already carry shared execution failures through text and JSON.
Author restoration, force, absent/occupied control and client boundary
regressions before production edits. Correct the unlink fixture name and
response-key assertion found in serial static review. All tests remain
unrun under the source-only restriction; formatting/diff/router checks pass.
* refactor(server): consolidate repository uninstall result handling
Resolve a declaration or checkout to one item and canonical name before
using the existing uninstall, conflict, log and success response tail.
Keep metadata-only removal unforced, preserve its error and cache recovery
behavior, and report movedToTrash from the selected item.
Preserve exact declaration precedence, record-only checkout refusals,
ordinary checkout errors and project behavior without changing tests.
Five serial source review passes, gofmt, diff checks and the context-router
check completed. Tests and builds remain unrun under the source-only brief.
* fix(unlink): preserve independent records and trash undo metadata
Limit unlink's legacy group matching to members so a retained declaration
such as team/_repo survives unlinking _team. Share snapshot and removal
matching while keeping generic uninstall's legacy contract unchanged.
Save the exact removed records, audit acceptances and target overrides
through uninstall's existing trash sidecar owner before pruning metadata.
Keep metadata on sidecar failure and preserve completed-unlink warnings,
fresh reloads, cache refresh and project-mode behavior.
Author owner, CLI and API regressions for namespace collisions, undo,
partial failures and project/empty controls. Source-only verification:
gofmt, diff check and context-router check passed; runtime tests, builds,
frontend checks and final make check remain unrun for root-owned gates.
* fix(install): preserve independent tracked declarations
Limit declaration-only cleanup to the precise namespace and legacy members already used by unlink. Keep independently installed prefixed repositories, their audit acceptances, and overrides when forgetting a missing checkout.
* fix(cli): explain missing tracked repository recovery by mode
Offer global record removal when restoring an unreachable source is unwanted. Keep project recovery scoped to install -p, share the hint with doctor, and align update documentation in every existing locale.
* refactor(uninstall): share declaration and unlink operations
Keep declaration resolution and unlink metadata ordering in shared owners so CLI and API preserve the same scope and recovery behavior. Consolidate domain regressions while retaining caller translation coverage.
Distinguish record-only removals in API and CLI operation logs and CLI JSON, including mixed batches and dry runs. Document outcome fields, warning semantics, and current API error codes across existing locales.
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Willie <egg358358@gmail.com>
* fix(install): require explicit force for JSON overwrites
Machine-readable output must not grant destructive consent. Preserve existing skills and agents unless force is explicit, and report existing skip decisions in the JSON result while retaining selection and audit behavior.
Cover edited copies in global and project modes, and update help, automation guidance, and translated command documentation.
Refs: #877
* fix(install): preserve previews and locked JSON copies
Read-only discovery must work before replacement consent, including existing
single skills and cross-path installs. Keep overwrite checks on write paths.
Require existing update or force intent to advance installed project copies
to a changed lock pin. Preserve ordinary CLI and dashboard lock following,
while JSON alone leaves local edits and incoming pins unchanged.
Cover existing-destination previews, edited locked copies and dashboard lock
following. Clarify translated docs and make the consent runbook step runnable.
Refs: #877
* fix(install): resolve installed names during previews
JSON previews must resolve recorded sources without requiring overwrite consent. Permit metadata lookup for dry runs and restore the original unforced preview regression in global and project modes.
* test(install): remove duplicate JSON consent runbook case
The global local-skill integration case already covers JSON overwrite refusal and explicit forced replacement. Remove the duplicate runbook step and restore its 18-step numbering while retaining the existing purity setup and assertion corrections.
* fix(audit): report audit-rules load errors in global scans
The global scan entry points (ScanSkill, ScanSkillWithFollow,
ScanSkillFiltered, ScanFile) dropped the error from Rules() and scanned
with no pattern rules. One bad regex in the global audit-rules.yaml
turned every pattern check off with no warning, so audits reported
fewer findings than they should have (#879). Project mode already
returned the error.
Return the error from the global path as well, and name the failing
file in it: parse errors from loadUserRules and compile errors from
Rules() and RulesWithProject now carry the path. When a project scan
fails to compile, the global file is blamed only if it fails on its
own, so a project file that disables a broken global rule still loads.
The cached markdown split now takes the rules its caller already
loaded instead of loading them again and dropping the error.
* fix(install): block installs whose audit cannot run
Once global scans return rule-load errors, install treated the error as
a warning and installed the skill with no audit at all. update already
fails closed on a scan error, and --force there accepts findings, not
an install nobody could check.
A scan error now blocks skill, agent and tracked-repo installs and
removes what was installed. --force does not override it;
--skip-audit still bypasses scanning. The error wraps the new
install.ErrAuditScanFailed rather than audit.ErrBlocked, so install
output and the dashboard do not offer a --force retry that cannot help.
upgrade reinstalls the built-in skill with --force, which deleted the
old copy before the audit ran. A typo in audit-rules.yaml would have
left users without the skill, so upgrade now stages the download
through the update path and keeps the installed copy when the audit
fails.
update --all counted the new error as a silent skip. It is now listed
under "Blocked by security audit" with its reason and makes the run
exit non-zero. The install warning summary that counted "audit scan
error" warnings is removed, since nothing emits them any more.
Fixes#879
* feat(audit): honor findings accepted with --force via --respect-accepted
install and update --force record the findings a user accepted in
audit_accepted, but audit ignored that record. A skill installed with
--force therefore kept failing `skillshare audit` in CI with no way to
let the accepted findings pass (#869).
audit --respect-accepted marks those findings as acknowledged. They stay
in every output (JSON acknowledged: true, a text/TUI note, "(accepted
earlier)" in Markdown, SARIF external suppressions), but they are counted
in summary.accepted instead of their severity and no longer fail the
audit. Without the flag nothing changes, so existing CI gates keep their
behavior. A changed file or snippet produces a new key and blocks again.
Tracked repositories record acceptances at the repo root with paths
relative to it, so ApplyAcceptedFindings walks up from each skill to
match them. The install, update and edit gates use the same function and
now honor repo-wide acceptances for skills inside tracked repos too.
The dashboard always honors accepted findings: the Audit page mutes them
and counts them apart, the skill Audit tab collapses them, and the
Dashboard attention card no longer lists a skill whose only blocking
findings were accepted. The CLI JSON summary and the server summary share
Result.CountOpenBySeverity so both count accepted findings the same way.
The oplog records the accepted count and the log views show it.
* fix(audit): match acceptances when a single file is scanned
A single-file scan names its findings by the file's base name, but the
ancestor lookup used the file's whole path as the prefix, so it hashed
SKILL.md/SKILL.md instead of the recorded SKILL.md. Auditing a skill file
directly with --respect-accepted, and auditing agents inside a tracked
repository in the CLI or the dashboard, still failed on unchanged
accepted findings. For a file target the prefix is now the file's own
directory.
The row says skills check exits 1 on updates or local changes, while the Skillshare cell listed only check and update, which reads as if Skillshare cannot gate CI on drift. check --exit-code (#865) does that.
* docs(comparison): re-pin the npx skills comparison to v1.8.1
The comparison and migration pages cited skills v1.7.6. Since v1.8.0
the restore command links restored skills into agent directories, so
the page's statement that it does not was wrong. The page also did not
say that `skills install` with no source is the same restore command,
that matching skills only get their missing agent links, or that
`skills check` exits 1 on updates or local changes.
Re-pin both pages and their four translations to the v1.8.1 tag commit
and correct those statements against its CLI reference. The lock paths
and fields the migration guide names are unchanged in v1.8.1.
* chore: ignore .feature-radar/
The feature-radar skill keeps its tracking notes, including assessments
of other tools, in .feature-radar/ at the repository root. They are
local working notes and should not be committed to the public
repository.
In project mode the committed config.yaml is what teammates install from, but
it could disagree with what a machine actually has (#858):
- `uninstall -p` and the dashboard's single-skill and tracked-repo removal
left the skill's entry in config.yaml, so a later `install -p` brought it
back. They now drop the entry and the lock pin through one shared
config.ForgetProjectSkills, as the uninstall docs already promised.
- Installing a skill again from another source or branch (after an uninstall,
or over the copy with --force) updated only the gitignored .metadata.json.
config.yaml kept the old source and skills.lock.json ended with the old
source and the new commit. Installs from a named source (CLI install,
search, dashboard) now compare the records from before and after the
command and let the config entry follow the skills it actually reinstalled.
Install from config never rewrites an entry from local records, so a
teammate's edit survives on a machine that has not updated yet.
- Reconcile removed every config entry that had no folder and no record. On a
fresh clone nothing is installed yet, so `install <source> -p` deleted all
the other declared skills. An entry now goes only when the skill was
installed here and its folder is gone, when it was moved, or when a command
removed it; `move` passes the old paths and `update --prune` cleans the
config itself.
The docs still showed the old `{"skills": [{"name", ...}]}` layout, which
no current release writes; the file is `{"version", "entries", ...}`
keyed by path. Readers comparing the docs with their own file had no way
to tell what `audit_accepted` or `target_overrides` are for.
tracked-repositories also said project mode records `tracked: true` in
`.skillshare/.metadata.json` so teammates get it, but that path does not
exist and project mode gitignores the metadata files (#760); the flag
lives in `.skillshare/config.yaml`.
The example `type` is `github-subdir` because a subdir install records
that, and the field table omits `into`, which nothing writes.
Auditing a parent skill checked every Markdown file's bundled references
against the scan root. A nested skill's `references/ok.md` was looked up
under the parent and reported as a dangling link, and its `../SKILL.md`
stayed inside the parent and was not reported as an escape, so a parent
audit disagreed with a direct audit of the child.
Each Markdown file now records the nested skill that holds it, and its
references are resolved and contained within that skill.
doctor scans a nested skill on its own and again inside its parent, so
it repeated the child's findings. It now reports each finding once.
Closes#834
Compare npx skills v1.7.6 against verified capabilities instead of an install-only model. Position Skillshare around broader resource management and document experimental restore and npm sync limits.
Clarify migration ownership, backups, source tracking, ref preservation, and initialization safety across English and four translations.
Tracked install and update audit the whole repository root, and the
scanner treated every file below a hidden directory as header-only. Skills
that discovery finds in hidden directories, such as .curated/<skill> and,
since #801, a repository-root .agents/skills/<skill>, were therefore synced
to every target without a text scan.
The hidden-directory boundary is now measured inside the skill that holds
a file, so those skills get the text scan they already get when audited one
by one, while target copies such as .claude/skills and hidden folders
inside a skill stay header-only.
Release-As: 0.30.3
A repository-root .agents/skills now counts as a skill anchor only when the repository has no other SKILL.md outside .git and target directories, so tracked checkouts that author skills there are discovered, while repos that commit .agents/skills copies keep discovering only their authored skills.
Fixes#800
Credential-access rules match whole lines, so a Python docstring that
named ~/.aws/credentials in a `cat` example counted as a CRITICAL read and
blocked the mcp-sentinel skill at the default threshold (#817).
In .py files, a built-in CRITICAL credential-access match on a comment-only
line, or inside a string that is a whole statement such as a docstring, is
now HIGH: it still shows, and still blocks under a HIGH threshold. A small
tokenizer decides this and keeps CRITICAL wherever it cannot be sure the
line never runs: argument, assigned and bracketed strings, f-strings and
their replacement fields, code before a trailing comment, files that read
__doc__ or use bare CR line breaks, and explicit severity overrides.
A lowered finding carries severityContext "python-inert" (JSON, SARIF,
`audit rules --format json`), and the dashboard, CLI text output, both
audit TUIs, install/update warnings and the markdown report say it was
lowered from CRITICAL, so it is not mistaken for a changed rule.
Closes#817
The #796 wording attached "including direct-file and agent audits" to the
special-target error, so the sentence read as a repeated list and no longer
said that links to ordinary files keep text scanning in those audits. The
translations had dropped that scope entirely. Split it into two sentences
and restore the scope in every locale.
A named pipe can block collection, integrity hashing or uncached skill
metadata reads indefinitely. Require resolved regular files at each read
boundary while preserving symlink accounting and integrity evidence.
Cover the paths with bounded FIFO regressions and generated filesystem
cases, and update the Nix vendor hash and integrity-rule documentation.
* fix(projects): save new projects in config.yaml again
v0.29.0 wrote every project add, edit and remove to a machine-local
registry, so a project added on one machine never reached config.yaml
or the other machines that share it (#792). Most people share one
config.yaml and expect a new project to follow it.
config.yaml is the default again. Machine-local storage stays as an
explicit choice: --machine-local on add, or projects_storage:
machine-local for every new project, with --shared to override it.
The new share command moves a local project into config.yaml, and
localize still copies one to this machine. Edits and removals stay in
the layer that owns the project; removing a local copy of a
config.yaml project keeps config.yaml's version unless --shared asks
to remove both, so one machine cannot silently drop a project for
the others. Exclusions written by v0.29.0 are left as they are.
The dashboard picks storage once, in the Add project dialog, and
offers the two removal choices only where both copies exist. Moving a
project between layers stays a CLI command, so the detail page keeps
one job.
Closes#792
* fix(projects): recheck both layers after a confirmation, sync the saved key
remove and share ask before taking the config lock, then compared only
the merged entry after locking. A share or localize from another
terminal moves a project between layers without changing that entry, so
a remove confirmed for this machine's copy could then delete config.yaml's
declaration for every machine, and a confirmed share could overwrite
config.yaml settings changed meanwhile. The recheck now compares the
owning layer and config.yaml's declaration too (ProjectLayerState).
Re-adding a project that v0.29.0 hid restores config.yaml's own key,
which can be spelled differently from the folder given to add (~/app
versus an absolute path). add --sync looked the project up by the given
spelling and failed with "project not found" after saving it; it now
syncs the key that was saved.
* test(projects): make the layer tests hold on Windows
The mutation-sequence test looked the shared project up by
filepath.Join, but the fixture spells config.yaml's key $ROOT/app;
on Windows the two spellings differ, so the lookup found nothing.
It now asks the config for the key it uses.
The remove save-failure test blocked the local registry, but removing a
config.yaml project now writes config.yaml. On Linux the registry check
still failed with ENOTDIR first, which hid the mismatch; on Windows that
reads as a missing file and the save went through. The test now blocks
config.yaml, as the edit save-failure test does, and its hook no longer
shadows the config path with the target path.
---------
Co-authored-by: sim <sim@example.invalid>
Checking every user-visible change since v0.28.4 against the docs
found these gaps:
- ui.md: GET /api/audit now returns warnings and incomplete; an
incomplete scan warns instead of reporting all clear and appears
under Needs attention; a project branch switch records the branch in
.skillshare/config.yaml. Also fixes a lowercase sentence start.
- audit-engine.md: Markdown and SARIF carry the per-resource coverage
counts added in #756.
- audit-rules.md: the files row pointed at a "File Scoping" section
that does not exist; it now links to File Applicability.
- log.md: project localize logs a localize action.
- built-in skill: how an unreadable followed source link is reported.
Translations are updated to match.
Reduce audit report noise without changing full findings, risk scores, severity gates or machine output. Reuse existing severity ordering and dashboard selection, and keep visible/hidden counts and incomplete-scan status explicit in human reports.
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Willie <egg358358@gmail.com>
* feat(audit): inspect bundled hooks and settings
Bundled declarations can schedule commands and broaden permissions outside SKILL.md, while ordinary scanning skips hidden settings. Inspect the four explicit paths with bounded root-confined reads and structured findings so existing audit policy can review their potential execution.
Keep activation conditional and redact arbitrary arguments before reports. Register rule metadata through the existing structure analyzer and cover benign twins, parse gaps, source links, policy overrides, CLI/API output and a synthetic E2E runbook.
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
* refactor(audit): parse bundled hook commands with a shell parser
The hand-written lexer for hook commands grew six similar quote and
paren scanners, and each review round found another shell form it
missed (comments after line continuations, nested backticks, `time -p`).
Parsing with mvdan.cc/sh/v3/syntax follows quoting, comments,
substitutions, loops, functions and heredocs the way bash does, so the
analyzer walks every call in the syntax tree instead. The wrapper table
(sudo, env, timeout, xargs, bash -c, git) and the POST and destination
rules are unchanged, now applied to unquoted argv words. A script fed to
a shell on stdin (`bash <<'EOF'`, `bash <<<`) is parsed like `bash -c`.
Statements before a syntax error are still inspected. bash runs some
forms the parser rejects (an array element assigned before a command),
so a rejected command also gets a word-level network check next to its
coverage gap, rather than dropping to MEDIUM.
The dependency adds about 0.26 MB to the release binary; vendorHash
follows the new go.sum.
* fix(audit): bound nested shell parsing and skip stdin data
A script nested in a substitution was inspected twice, once by reparsing
the outer shell's argument and once by walking the outer syntax tree, so
each `bash <<< "$(...)"` or `bash -c "$(...)"` level doubled the work and
a hook under 1 KB could stall an audit. Results are now remembered per
script text and depth, and one hook command may parse at most 1 MiB of
source in total, since deep nesting still costs quadratic time with the
cache alone. Past the budget the command is classified word by word and
gets a coverage gap, as a rejected command does.
Stdin was also treated as a script whenever a shell had a heredoc or
here-string, but `bash -c 'cat' <<<` or `bash ./script.sh <<<` hands it
to something else as data, which turned a lifecycle hook into a false
HIGH. Stdin is now parsed only for `-s`, or when there is neither `-c`
nor a script file operand. Option values (`-euo pipefail`, `-O extglob`,
`--rcfile f`) are not mistaken for a script file.
---------
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: sim <sim@example.invalid>
Keep machine-specific project changes out of shared configuration while preserving shared registrations and making their origin visible. Handle missing replicated roots and preserve startup maintenance for mutating commands.
Extension and size filters could hide native executables and Python bytecode
inside document, image and cache paths. Classify bounded headers before those
filters, retain source boundaries, and report opaque and oversized file counts
separately from auditable text.
Keep archive signatures and uncertain headers informational rather than claiming
runtime analysis. Honor analyzer selection for file and dashboard scans, and
cover renamed payloads and benign twins with synthetic fixtures and fuzzing.
Implements item 7 of #746.
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: sim <sim@example.invalid>
Existing URL and code-execution signatures miss cloud metadata access and
language-specific deserializers. Add scoped static evidence and inspect safe
YAML and torch options within each call so safe siblings cannot hide risks.
Validate and preserve file applicability across overrides, scans and rule
listings. Collect PHP scripts and propagate rule-load errors so malformed
filters cannot silently disable global scanning. Document the policy and
limits with paired regressions, fuzzing and an isolated CLI runbook.
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: sim <sim@example.invalid>
Co-authored-by: Willie <egg358358@gmail.com>
Required local references can currently escape a skill bundle or fail silently
when written as images and explicit code paths. Resolve them within the declared
root without reading external targets, retain dangling-link compatibility, and
share the findings and rule controls with doctor. Keep metadata and integrity
fallback reads within the same root so they cannot reopen skipped symlinks.
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Willie <egg358358@gmail.com>
Long blank spans and repeated filler can move meaningful instructions out
of view during skill review. Add four padding signals under the static
analyzer with Markdown exemptions and original-source line mapping.
Reuse rule overlays so global and project toggles and severity/confidence
overrides also govern this file-level detector. Cover threshold boundaries,
benign examples, optimized scans, reports and CLI rule controls.
Implements item 17 of #746.
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Willie <egg358358@gmail.com>
Since v0.19.12 the docs say a project's skills/.metadata.json is
gitignored, but no code ever wrote that rule, so `git add .skillshare`
picked it up (#759). The file records this machine's installs (hashes,
timestamps) for folders that are themselves ignored; teammates already
share config.yaml and skills.lock.json, so committing it only adds noise
and merge conflicts.
ReconcileProjectSkills runs after every project install (CLI, search,
dashboard, move, trash), so it now adds the rule for the skills and
agents sources, at the path ProjectGitignoreTarget computes. Projects
initialized earlier and custom sources get it on their next install.
AdoptMovedProjectSkills is untouched, so `sync -p` still leaves
.gitignore alone (#547). Global mode keeps committing its metadata.
The docs that list the project .gitignore contents now name the
metadata files, and project-skills explains the one-time
`git rm --cached` for projects that already committed it.
Closes#759
prompt-injection-1 reported a JS `ignore: ['**/*.test.vue']` option and a
Python `root: Path, lang_filter: set[str] | None = None` parameter as
CRITICAL prompt overrides, which blocked `update --all` for vuejs-ai and
dotnet skills. The #376 exclusion only covered scalars, root paths and
ignore objects.
The exclude now also accepts an inline ignore array of quoted items
without spaces, and a typed root parameter whose types are capitalized or
builtin names, followed only by further `name: Type` parameters. Both are
limited to the key whose real configs use them, so `admin: Execute`,
`system: Path, Ignore` and comma-joined word lists stay CRITICAL.
Closes#749
* feat(audit): detect narrow prose risk directives
* fix(audit): honor link confidence and narrow refusal rule
Apply configured confidence to Markdown link findings and require safety-related evidence in anti-refusal directives to avoid ordinary compliance false positives.
* fix(audit): address prose and confidence review feedback
Narrow prose matches, preserve overrides when enabling rules, and expose effective confidence to rule consumers. Expand Markdown coverage and synchronize the audit guidance.
* fix(audit): retain scheduled payload detection
Keep detecting directives that schedule a payload while excluding ordinary payload processor terminology.
* fix(audit): preserve prose detection recall
Recognize concise disclosure and safety override directives while retaining benign exclusions. Share the confidence default and cover replacement overlays.
* fix(audit): detect quantified refusal directives
Retain detection when a directive refers to any or every user request while preserving benign security discussion.
Finder writes .DS_Store into any folder it opens, and Explorer writes
Thumbs.db and desktop.ini. These counted as skill content, so opening an
installed skill in a file manager made check report it as modified, hid
update_available, and made update skip it unless run with --force, which
also lowers the audit threshold.
Skip them when hashing a skill, drop hashes earlier versions recorded for
them (from .metadata.json and from legacy sidecar migration), and keep
audit integrity from reporting them. Their content is still audited.
Closes#743
* fix(update): audit tracked candidates before publication
Prevent rejected tracked-update bytes from becoming readable through published target links by staging and auditing a private candidate before updating the active checkout. Publish the exact approved revision without a second upstream pull.
Preserve sparse state, audit metadata, followed checkouts, and compatible edits. Recover staged and unstaged changes after failed forced publication, including deletions, renames, and sparse exclusions. Cover the boundary deterministically and align error messages and localized documentation.
* fix(update): preserve local bytes across Git line-ending conversion
Overlay dirty worktree bytes after staging candidate patches so core.autocrlf does not silently rewrite local edits. Cover staged, unstaged, and cancelled worktree changes while retaining their index state.
Make permission-failure coverage explicitly POSIX-only and compare private checkout contents to their original bytes. Align red-team assertions with candidate rejection and register private temporary cleanup with the raw-write guard.
* test(install): normalize checkout after configuring line endings
Windows fixtures initially inherit core.autocrlf=true. Reset the isolated checkout after selecting the subtest setting so changing it to false does not turn untouched upstream files into local edits.
Add global project list, show, add, edit, sync and remove so setup scripts
can register repositories without editing YAML or opening the dashboard.
Keep dry runs read-only and report completed work when a target fails.
Reuse the shared project service and sync runners. Include command docs,
translations, completions and regression coverage. Quote overlap hints for
their shell and log partial project syncs consistently with ordinary sync.
A successful source update does not always require a target sync: existing symlinks already expose the updated content. Recheck the per-kind diff before offering Sync Now, refresh it when resources change, and report check failures without claiming targets are current.
Cover stale previews and post-sync dismissal with regression tests, and align the dashboard, workflow, source/target, and built-in skill documentation across locales.
Prefixed naming rewrites name: in every copy to the entry name, so the
target folder and name: always agree. Requiring name: to equal the source
folder only skipped skills it could sync: a tracked repo that is itself a
skill lives in _<repo>, so its root SKILL.md could never pass.
Only standard naming now requires the match; name format rules still
apply to both. Sync lists the skills named this way, so a user looking
for _ooux in the target finds ooux.
The dashboard's skipped-skills hint always blamed folders that end in the
same name, even when skills were skipped for their name. The diff API now
reports naming skips apart from collisions and the hint names the cause.
Refs #530
Add skillshare move and POST /api/resources/batch/move so skills and
whole folders can change folder inside the source while keeping their
.metadata.json entry, accepted audit findings, lockfile pin, config
group, .gitignore and literal .skillignore lines. Moving by hand lost
the record and made the next install start over. install --into now
refuses a folder inside a skill or a tracked checkout.
Refs #510
* fix(sync): replace copy-mode copies with links when switching back to merge
Switching a target from copy back to merge left every copy whose entry name
did not change as a real folder. Merge sync treated it as the user's own
folder, so status and doctor kept saying "run skillshare sync" while sync
changed nothing, and only `sync --force` turned it into a link.
Copy mode already replaces merge-mode links with copies on its own, so merge
sync now replaces a folder the manifest records with a checksum (a copy-mode
copy) with a link, without --force. Folders the manifest does not record, or
records as a link, stay untouched. The pre-sync target backup is unchanged.
The CLI and dashboard diffs name these entries as copies sync replaces
instead of suggesting --force, and the sync-modes docs describe the switch.
* fix(sync): keep copy-mode copies the user edited when switching to merge
The first version replaced any folder the manifest recorded as a copy-mode
copy. The manifest checksum is only a record, so a copy edited since copy
mode made it was deleted too, and `sync --json` and project-mode dashboard
sync take no pre-sync backup to restore it from.
Replace the folder only while it still hashes to the recorded checksum
(Manifest.OwnsCopy). An edited copy is kept and `sync --force` still
replaces it; diff keeps suggesting --force for it. A copy whose name: was
rewritten by prefixed naming, or that was made with custom ignore patterns,
no longer hashes to the source checksum and is kept the same way.
* fix(ui): say a copy-mode copy in a merge target is replaced by a link
The Sync page picks a row's text from the diff item's action alone. The
copy-mode copy that merge sync now replaces comes from the server as an
update, which the page worded as "Link is broken or points elsewhere. Will
be relinked" even though no link exists yet.
Match the server's reason and show "Copy made by copy mode. Will be replaced
by a link" instead, in all eleven dashboard languages.
* docs(sync): say only unedited copy-mode copies are replaced on merge sync
The sync-modes paragraph promised that copies copy mode made are replaced
with links without --force. Merge sync keeps a copy that no longer hashes to
the checksum copy mode recorded, so an edited copy, or one whose name: copy
mode rewrote for prefixed naming, still needs --force.
State the three cases in sync-modes and qualify the diff Modified and Local
override labels, in English and the ja, ko, zh-Hans and zh-Hant copies.
* fix(sync): keep the copy until its replacement link exists
Replacing a copy-mode copy removed the folder first and then created the
link. If creating the link failed (no symlink or junction rights on a
Windows or network filesystem), sync returned an error with the skill gone
from the target. This path now also runs on a plain sync, not only on
--force.
Park the folder beside the entry, create the link, then delete the parked
folder; on failure the folder is moved back. A parked folder left by a run
that died mid-way may be the only copy, so the next sync stops with a message
instead of deleting it. The manifest also forgets the copy-mode mtime and
naming records of an entry that is now a link.
* test(sourcefs): register replaceWithLink's target writes in the raw-write ratchet
The previous commit moved the merge-mode folder replacement into
replaceWithLink, which the ratchet reports as new raw os calls and the old
os.RemoveAll allowance as stale. All of them act on the sync target, not the
skills source, like the neighbouring entries.
* fix(sync): bound the parked copy's name and document the naming exception
The folder parked while a link is created was named after the entry, so an
entry near the 255-byte filename limit (a long flattened nested skill)
could not be moved aside and its replacement failed. The parked name is now
a fixed-length hash of the entry name.
sync-modes also says what happens when `target_naming` changes in the same
sync: the copy gets a new entry name and the prune pass removes it as an
orphan whether or not it was edited, as it did before this change.
* feat(sync): make prefixed target naming misconfigurations visible
Prefixed naming (#497) works, but several of its failure modes only showed up
at sync time or gave advice that cannot be followed:
- A collision that only prefixing creates told the user to "rename one in
SKILL.md", which a tracked skill cannot do, and never said the prefix caused
it. The hint now names the prefixing and points at renaming the other skill or
re-tracking the repo with --name.
- `target add` silently wrote mode: copy when the inherited naming is prefixed.
The CLI now says so.
- A target that resolves to prefixed outside copy mode was reported only by
sync. status, doctor and target list (plain and JSON) now flag it, and the
sync/validation and `--skills=true` errors say how to fix it.
- The dim "duplicate skill names (isolated by ...)" line printed on every sync
even when nothing was wrong, and before a failing sync. Isolated duplicates
are not a problem, so it is dropped; the website docs still showed an
outdated form of this output and are corrected in all locales.
* fix(status): flag prefixed-outside-copy in the TUI list and status --json
Codex review of #503 found two surfaces the new check missed:
- The interactive `target list` (the default on a terminal) never read the
item's naming error, so a prefixed + merge target looked healthy there. The
list row now marks the mode with "!" and the detail panel shows the fix.
- `status --json` (global and project) builds its target entries directly, so
scripts got no signal. Each target now carries a `warning` string, matching
`target list --json`.
* docs(troubleshooting): sync no longer prints a message for isolated duplicates
The collision troubleshooting tip still said sync shows an info message when
filters isolate duplicate skill names. That line was dropped, so the tip now
says sync prints nothing about them. Codex review of #503 flagged the stale
English page and its four translations.
* fix(config): point managed-project naming errors at the project settings
The "set mode: copy on the target" hint is wrong for a target a global
`projects:` entry expands into: it cannot be edited with `target` or under
`targets:`, and the mode lives in the project's skills settings. The hint now
depends on whether the target belongs to a managed project (Codex review of
#503).
The naming/mode check becomes a TargetConfig method so status, doctor and
target list share it, which also lets the hint see the project root. Along the
way: doctor reuses it, the TUI list renders the mode once, and
reportTargetAdded takes a flag instead of comparing a mode string.
* fix(config): hint the project settings for managed-project naming errors
ProjectNamingError (the config-load check for a global `projects:` entry) still
returned the bare naming error, so a project that inherits prefixed with a
non-copy mode got no fix. It now names the project's skills settings, like the
expanded targets do. The built-in skill's sync reference also mentions that
status, doctor and target list flag the misconfiguration before sync.
Found by the second /code-review pass on #503.
* fix(sync): detect prefix collisions from the colliding paths
reportCollisions decided a collision came from prefixing when its name was not
also a duplicate in the source. A tracked skill that joined two ordinary
skills already sharing the name was therefore sent to the "rename one in
SKILL.md" hint, which a tracked skill cannot follow (Codex review of #503).
A collision on a prefixed target that includes a tracked path now gets the
tracked-skill hint, whatever else shares the name. The wording no longer claims
prefixing renamed the skill, since a name that already starts with the repo
name is unchanged.
* fix(sync): use discovered repo metadata for the tracked-skill hint
The collision hint treated any path segment starting with "_" as a tracked
repo, so an ordinary skill under a folder such as org/_drafts (no .git) was
told it could not be renamed and to re-track a repo that does not exist. It now
uses DiscoveredSkill.IsInRepo, the same signal prefixed naming uses.
The prefixed docs also gain the fix for a target a global `projects:` entry
expands into (projects.<root>.skills.mode: copy), since `target` cannot edit
those. Both from Codex review of #503.
* fix(sync): keep both collision hints when targets disagree
The same name can clash on a prefixed target with a tracked skill and on
another target between ordinary skills only. The prefixed flag was OR-ed across
targets, so the second case lost its rename/filter hint. Track both kinds
separately while grouping, and print each hint that applies (Codex review of
#503).
* fix(sync): keep the rename hint inside a mixed collision group
When a tracked skill and two ordinary skills share a prefixed name, re-tracking
the repo fixes only the tracked one; the ordinary pair still clashes and is
excluded. The group now also shows the rename/filter hint when at least two of
its participants are not tracked (Codex review of #503).
* fix(sync): offer filters in the tracked-skill collision hint
Two tracked skills of the same repo with the same name collide after
prefixing, and neither renaming a tracked skill nor re-tracking the repo
separates them. The hint now also names include/exclude filters, so every
collision on a prefixed target has an actionable remedy (Codex review of #503).
* docs(sync-modes): limit the target list claim to targets under targets
target list builds from the config without project expansion, so it cannot
flag a target a `projects:` entry expands into; status and doctor can. The
prefixed paragraph and the built-in skill reference said all three flag it
(Codex review of #503).
* fix(frontmatter): read and rewrite SKILL.md that starts with a UTF-8 BOM
Windows editors such as Notepad write a BOM before the opening ---. The
lenient readers (ParseSkillName, ParseFrontmatterField/Fields/List, ReadSkillBody)
did not skip it, so under target_naming standard/prefixed the skill had no
readable name and was silently skipped. Strip the BOM in the shared frontmatter
locator and the line scanner, and in the hub, search, audit and sync/context
readers that split lines themselves (utils.TrimBOM).
The writers kept working on the unstripped text, so SetFrontmatterValue
prepended a second block and ToggleFrontmatterFlag/RewriteFrontmatterList
could leave a BOM in the middle of the file. They now split the BOM off and
put it back in front, rewriting only the name value (or flag/list) as before.
* fix(frontmatter): cover the dashboard parser and stop auditing a leading BOM
A consumer sweep after the first BOM commit found two more places that
mishandled a SKILL.md written by Notepad:
- audit reported the leading BOM as a HIGH hidden-unicode finding (U+FEFF is
in the zero-width rule), so every such skill showed a risk score. A BOM at
the very start of a file is its encoding mark and hides nothing; one past
the start is still reported.
- the dashboard's parseSkillMarkdown saw no frontmatter, so the skill editor
would treat the whole file as body and write a second block on save.
The audit-engine page and its four translations note the exemption.
* fix(ui): keep the BOM when the skill editor saves a SKILL.md
parseSkillMarkdown dropped the BOM so the editor could see the frontmatter,
but SkillEditor writes the composed text back through PUT .../content, so every
dashboard edit silently removed the marker from a Notepad-written file. The
parse result now carries the BOM and composeSkillMarkdown puts it back in front,
matching the Go rewrite paths.
The prefix kept only [a-z0-9], while skill names allow lowercase letters
and digits in any script after NFKC. A repo named _技能 got no prefix
at all and _café collapsed to caf, which could collide with _caf.
Normalize the repo name the way the name validator reads it.
Top-level prefixed naming with a merge global mode is valid while every
target overrides copy, but target add (CLI, dashboard, and Agent config
directories) wrote new targets without a mode, so they inherited the
invalid pair and failed at sync. Share one rule for global and project
additions: write copy mode when the inherited naming needs it.
A project target defaults to merge mode and target add has no mode
option, so adding one to a project whose top-level target_naming is
prefixed reported success and then failed validation at sync. Give the
new target copy mode in both the CLI and the dashboard API.
Users need to know when prefixed helps (same-named skills from different
tracked repos), what name it produces, that it is copy-only, and that
switching between any two namings now renames managed entries in place.
The translated pages follow, the ja and zh-Hans naming headings get an
explicit target-naming id so the new links resolve, and the target_naming
runbook gains steps for prefixed sync, flat -> prefixed -> standard
migration and the merge-mode rejection.
Bare `skillshare install` already restores everything .metadata.json records
but the disk lacks, yet the dashboard could only re-clone missing tracked
repos through a separate rehydrate path. Expose the CLI's install-from-config
flow instead (GET /api/install/missing, POST /api/install/from-config) so both
surfaces share one detection and one installer, and drop the old
missingTrackedRepos plumbing from update responses.
The install summary now counts tracked repos and their skills apart from
standalone skills, since "Installed 1 skill" hid a whole repo. New tracked
repos are named `_<owner>-<repo>` so two `skills` repos no longer collide;
existing installs keep their names. `check` passes the stale status through
so the dashboard can offer to prune skills deleted upstream.
Track phrase exclusions as built-in rule metadata so a full custom regex replacement retains normal whole-line exclusion behavior. Keep phrase exclusions when only severity or enabled state is overridden.
Add raw-content and Markdown regression coverage. Verified with make check, four CLI E2E steps, the five-locale website build, and the context-router check.
Avoid blocking legitimate Markdown SDK parameters and ambiguous disclosure advice by default while retaining visible HIGH findings and strict-policy gating. Preserve explicit concealment, custom severity overrides, and shell dataflow coverage in HTML and comments. Add regression coverage and document rule-ID compatibility.