From eceb9cc6e491be2233e22e4af52da930d7c7e20d Mon Sep 17 00:00:00 2001 From: Willie Date: Mon, 6 Apr 2026 11:04:01 +0800 Subject: [PATCH] =?UTF-8?q?test(agents):=20fill=20coverage=20gaps=20?= =?UTF-8?q?=E2=80=94=20project=20mode=20uninstall,=20trash=20empty/delete,?= =?UTF-8?q?=20multi-target,=20JSON=20kind?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7 new integration tests covering: - trash agents empty / delete - uninstall agents in project mode (fix: wire kind into project dispatch) - check all (combined skill + agent) - sync agents skips targets without agent path - list all --json verifies kind field on every entry - status agents --json with target details Total agent tests: 45 (38 + 7). --- cmd/skillshare/uninstall.go | 10 + tests/integration/agent_coverage_gaps_test.go | 196 ++++++++++++++++++ 2 files changed, 206 insertions(+) create mode 100644 tests/integration/agent_coverage_gaps_test.go diff --git a/cmd/skillshare/uninstall.go b/cmd/skillshare/uninstall.go index 1a8dc569c..2ba18b9f0 100644 --- a/cmd/skillshare/uninstall.go +++ b/cmd/skillshare/uninstall.go @@ -554,6 +554,16 @@ func cmdUninstall(args []string) error { kind, rest := parseKindArg(rest) if mode == modeProject { + if kind == kindAgents { + agentsDir := filepath.Join(cwd, ".skillshare", "agents") + opts, _, _ := parseUninstallArgs(rest) + if opts == nil { + opts = &uninstallOptions{skillNames: rest} + } + opts.force = opts.force || opts.jsonOutput + err := cmdUninstallAgents(agentsDir, opts, config.ProjectConfigPath(cwd), start) + return err + } err := cmdUninstallProject(rest, cwd) logUninstallOp(config.ProjectConfigPath(cwd), uninstallOpNames(rest), 0, start, err) return err diff --git a/tests/integration/agent_coverage_gaps_test.go b/tests/integration/agent_coverage_gaps_test.go new file mode 100644 index 000000000..c334ad49d --- /dev/null +++ b/tests/integration/agent_coverage_gaps_test.go @@ -0,0 +1,196 @@ +//go:build !online + +package integration + +import ( + "os" + "path/filepath" + "testing" + + "skillshare/internal/testutil" +) + +// --- trash agents empty --- + +func TestTrash_Agents_Empty(t *testing.T) { + sb := testutil.NewSandbox(t) + defer sb.Cleanup() + + createAgentSource(t, sb, map[string]string{ + "tutor.md": "# Tutor agent", + "reviewer.md": "# Reviewer agent", + }) + sb.WriteConfig(`source: ` + sb.SourcePath + "\ntargets: {}\n") + + // Uninstall both agents to trash + sb.RunCLI("uninstall", "-g", "agents", "--all", "--force") + + // Verify trash has items + listResult := sb.RunCLI("trash", "agents", "list", "--no-tui") + listResult.AssertSuccess(t) + listResult.AssertAnyOutputContains(t, "tutor") + + // Empty agent trash (use --force via input "y") + emptyResult := sb.RunCLIWithInput("y\n", "trash", "agents", "empty") + emptyResult.AssertSuccess(t) + emptyResult.AssertAnyOutputContains(t, "Emptied trash") + + // Verify trash is now empty + afterResult := sb.RunCLI("trash", "agents", "list", "--no-tui") + afterResult.AssertSuccess(t) + afterResult.AssertAnyOutputContains(t, "empty") +} + +// --- trash agents delete --- + +func TestTrash_Agents_Delete(t *testing.T) { + sb := testutil.NewSandbox(t) + defer sb.Cleanup() + + createAgentSource(t, sb, map[string]string{ + "tutor.md": "# Tutor agent", + }) + sb.WriteConfig(`source: ` + sb.SourcePath + "\ntargets: {}\n") + + sb.RunCLI("uninstall", "-g", "agents", "tutor", "--force") + + // Delete specific item from agent trash + result := sb.RunCLI("trash", "agents", "delete", "tutor") + result.AssertSuccess(t) + result.AssertAnyOutputContains(t, "Permanently deleted") +} + +// --- uninstall agents project mode --- + +func TestUninstall_Agents_ProjectMode(t *testing.T) { + sb := testutil.NewSandbox(t) + defer sb.Cleanup() + + // Setup project + projectDir := filepath.Join(sb.Root, "myproject") + os.MkdirAll(filepath.Join(projectDir, ".skillshare", "skills"), 0755) + agentsDir := filepath.Join(projectDir, ".skillshare", "agents") + os.MkdirAll(agentsDir, 0755) + os.WriteFile(filepath.Join(agentsDir, "tutor.md"), []byte("# Tutor agent"), 0644) + + // Write project config + projectCfgDir := filepath.Join(projectDir, ".skillshare") + os.WriteFile(filepath.Join(projectCfgDir, "config.yaml"), []byte("targets:\n - claude\n"), 0644) + + // Also need global config for the CLI to not error + sb.WriteConfig(`source: ` + sb.SourcePath + "\ntargets: {}\n") + + result := sb.RunCLIInDir(projectDir, "uninstall", "-p", "agents", "tutor", "--force") + result.AssertSuccess(t) + result.AssertAnyOutputContains(t, "Removed agent") + + // Verify removed + if _, err := os.Stat(filepath.Join(agentsDir, "tutor.md")); !os.IsNotExist(err) { + t.Error("agent should be removed from project agents dir") + } +} + +// --- check all (combined) --- + +func TestCheck_All_CombinedOutput(t *testing.T) { + sb := testutil.NewSandbox(t) + defer sb.Cleanup() + + sb.CreateSkill("my-skill", map[string]string{ + "SKILL.md": "---\nname: my-skill\n---\n# Content", + }) + createAgentSource(t, sb, map[string]string{ + "tutor.md": "# Tutor agent", + }) + sb.WriteConfig(`source: ` + sb.SourcePath + "\ntargets: {}\n") + + // "check all" should show both skills and agents + // Currently "check" defaults to skills-only, "check agents" is agents-only + // "check all" should combine both + result := sb.RunCLI("check", "all") + result.AssertSuccess(t) +} + +// --- multi-target agent config --- + +func TestSync_Agents_SkipsTargetsWithoutAgentPath(t *testing.T) { + sb := testutil.NewSandbox(t) + defer sb.Cleanup() + + createAgentSource(t, sb, map[string]string{ + "tutor.md": "# Tutor agent", + }) + claudeAgents := createAgentTarget(t, sb, "claude") + + // claude has agent path, cursor does NOT + sb.WriteConfig(`source: ` + sb.SourcePath + ` +targets: + claude: + skills: + path: ` + sb.CreateTarget("claude") + ` + agents: + path: ` + claudeAgents + ` + cursor: + skills: + path: ` + sb.CreateTarget("cursor") + ` +`) + + result := sb.RunCLI("sync", "agents") + result.AssertSuccess(t) + + // Claude agents should be synced + if _, err := os.Lstat(filepath.Join(claudeAgents, "tutor.md")); err != nil { + t.Error("claude agent should be synced") + } +} + +// --- list agents JSON with kind field --- + +func TestList_Agents_JSON_AllEntriesHaveKind(t *testing.T) { + sb := testutil.NewSandbox(t) + defer sb.Cleanup() + + sb.CreateSkill("my-skill", map[string]string{ + "SKILL.md": "---\nname: my-skill\n---\n# Content", + }) + createAgentSource(t, sb, map[string]string{ + "tutor.md": "# Tutor agent", + }) + sb.WriteConfig(`source: ` + sb.SourcePath + "\ntargets: {}\n") + + // "list all --json" should have kind on every entry + result := sb.RunCLI("list", "all", "--json") + result.AssertSuccess(t) + result.AssertAnyOutputContains(t, `"kind": "skill"`) + result.AssertAnyOutputContains(t, `"kind": "agent"`) +} + +// --- status agents JSON with targets --- + +func TestStatus_Agents_JSON_WithTargets(t *testing.T) { + sb := testutil.NewSandbox(t) + defer sb.Cleanup() + + createAgentSource(t, sb, map[string]string{ + "tutor.md": "# Tutor agent", + }) + claudeAgents := createAgentTarget(t, sb, "claude") + + sb.WriteConfig(`source: ` + sb.SourcePath + ` +targets: + claude: + skills: + path: ` + sb.CreateTarget("claude") + ` + agents: + path: ` + claudeAgents + ` +`) + + // Sync agents + sb.RunCLI("sync", "agents") + + result := sb.RunCLI("status", "agents", "--json") + result.AssertSuccess(t) + result.AssertAnyOutputContains(t, `"agents"`) + result.AssertAnyOutputContains(t, `"expected"`) + result.AssertAnyOutputContains(t, `"linked"`) +}