From e9ea9a8e07771b23bf474a53758b4db53a57bd63 Mon Sep 17 00:00:00 2001 From: Willie Date: Sat, 10 Oct 2026 00:22:54 +0800 Subject: [PATCH] fix(install): treat file://localhost URLs as local clone sources Git clones file://localhost/path from the local filesystem, but the containment guard only recognised an empty authority, so --track --force could still delete a source given that way. Accept localhost (any case) as local. --- internal/install/install_tracked.go | 3 ++- internal/install/install_tracked_test.go | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/install/install_tracked.go b/internal/install/install_tracked.go index b738ca5b6..4d41e6e0b 100644 --- a/internal/install/install_tracked.go +++ b/internal/install/install_tracked.go @@ -28,7 +28,8 @@ func localCloneSource(source *Source) string { return source.Path } u, err := url.Parse(source.CloneURL) - if err != nil || u.Scheme != "file" || u.Host != "" { + // file://localhost/path is the same local path as file:///path. + if err != nil || u.Scheme != "file" || (u.Host != "" && !strings.EqualFold(u.Host, "localhost")) { return "" } // file:///C:/repo carries the drive after a leading slash. diff --git a/internal/install/install_tracked_test.go b/internal/install/install_tracked_test.go index d8f81b2dd..f4d082500 100644 --- a/internal/install/install_tracked_test.go +++ b/internal/install/install_tracked_test.go @@ -325,6 +325,7 @@ func TestInstallTrackedRepo_RefusesLocalSourceInsideTheDestination(t *testing.T) {"same path", "", func(p string) string { return p }, false}, {"nested path", "nested", func(p string) string { return p }, false}, {"explicit file URL", "nested", func(p string) string { return fileURL(p) }, false}, + {"localhost file URL", "nested", func(p string) string { return "file://localhost" + p }, false}, {"dry run", "nested", func(p string) string { return p }, true}, } for _, tc := range cases {