diff --git a/internal/sync/extras.go b/internal/sync/extras.go index 4f4c19def..b70998044 100644 --- a/internal/sync/extras.go +++ b/internal/sync/extras.go @@ -617,8 +617,14 @@ func ClearExtraTarget(file, sourceDir, targetPath, as, mode string, managedFiles return 0, false, nil } if mode == "symlink" && !LinksTo(targetPath, sourceDir) { - _, err := os.Lstat(targetPath) - return 0, err == nil, nil + // Only a missing target is safe to forget; any other error must stop + // the caller before it drops the target from the config. + if _, err := os.Lstat(targetPath); err == nil { + return 0, true, nil + } else if !os.IsNotExist(err) { + return 0, false, []string{err.Error()} + } + return 0, false, nil } pruned, errors = PruneExtraTargetFiles(targetPath, sourceDir, mode, managedFiles) return pruned, false, errors diff --git a/internal/sync/extras_prune_target_test.go b/internal/sync/extras_prune_target_test.go index 9b8e48d89..70a0d18e0 100644 --- a/internal/sync/extras_prune_target_test.go +++ b/internal/sync/extras_prune_target_test.go @@ -138,3 +138,14 @@ func TestPruneExtraTargetFiles_SymlinkRequiresSymlink(t *testing.T) { t.Errorf("local file must be preserved, stat err = %v", err) } } + +func TestClearExtraTarget_SymlinkTargetThatCannotBeInspectedReportsError(t *testing.T) { + notDir := filepath.Join(t.TempDir(), "file") + os.WriteFile(notDir, []byte("x"), 0644) + + _, kept, errs := ClearExtraTarget("", t.TempDir(), filepath.Join(notDir, "docs"), "", "symlink", nil) + + if kept || len(errs) == 0 { + t.Errorf("kept = %v, errs = %v; want an error", kept, errs) + } +}