From e3c5208b50bc39dfdca7d9cde9cb6552fc59f2b6 Mon Sep 17 00:00:00 2001 From: Willie Date: Sat, 18 Apr 2026 23:15:08 +0800 Subject: [PATCH] style(ui): restore paper-themed segmented control in skill editor The shared SegmentedControl has no gap between icon and label, making Edit/Split/Preview look cramped. Revert the visual to the original editor-themed .seg-btn/.seg-group CSS (4px icon gap, paper background, shadow-sm active state). Keep the DRY JSX win by introducing a small EditorSegment helper that renders the same markup the three inline call sites previously duplicated. --- .../skill-editor/FrontmatterEditor.tsx | 10 +- .../components/skill-editor/SkillEditor.tsx | 39 ++-- .../skill-editor/controls/EditorSegment.tsx | 44 +++++ ui/src/components/skill-editor/styles.css | 186 +++++++++++++++++- 4 files changed, 259 insertions(+), 20 deletions(-) create mode 100644 ui/src/components/skill-editor/controls/EditorSegment.tsx diff --git a/ui/src/components/skill-editor/FrontmatterEditor.tsx b/ui/src/components/skill-editor/FrontmatterEditor.tsx index 462fbefb0..2f2eed281 100644 --- a/ui/src/components/skill-editor/FrontmatterEditor.tsx +++ b/ui/src/components/skill-editor/FrontmatterEditor.tsx @@ -3,7 +3,7 @@ import { Code2, LayoutGrid, Plus, X } from 'lucide-react'; import type { Frontmatter, FrontmatterValue } from '../../lib/frontmatter'; import { serializeFrontmatter } from '../../lib/frontmatter'; import { Input } from '../Input'; -import SegmentedControl from '../SegmentedControl'; +import EditorSegment from './controls/EditorSegment'; import SwitchToggle from './controls/SwitchToggle'; import CharBudget from './controls/CharBudget'; @@ -176,10 +176,9 @@ export default function FrontmatterEditor({ Frontmatter YAML metadata · drives routing & tool access - + value={yamlMode ? 'yaml' : 'fields'} onChange={(v) => onToggleYaml(v === 'yaml')} - connected options={[ { value: 'fields', label: <> Fields }, { value: 'yaml', label: <> YAML }, @@ -380,10 +379,11 @@ function FieldControl({ function EnumField({ def, value, setField }: { def: FieldDef; value: string; setField: SetField }) { return ( - + value={value} onChange={(next) => setField(def.key, next || null)} - connected + className="seg-group-field" + role="radiogroup" options={(def.options ?? []).map((o) => ({ value: o, label: o || 'inherit' }))} /> ); diff --git a/ui/src/components/skill-editor/SkillEditor.tsx b/ui/src/components/skill-editor/SkillEditor.tsx index da51dac0f..4d067780c 100644 --- a/ui/src/components/skill-editor/SkillEditor.tsx +++ b/ui/src/components/skill-editor/SkillEditor.tsx @@ -28,7 +28,7 @@ import { } from '../../lib/frontmatter'; import { api, ApiError } from '../../api/client'; import Button from '../Button'; -import SegmentedControl from '../SegmentedControl'; +import EditorSegment from './controls/EditorSegment'; import './styles.css'; type PreviewMode = 'edit' | 'split' | 'preview'; @@ -525,18 +525,16 @@ export default function SkillEditor({ {fileCount} files
-
- - value={previewMode} - onChange={setPreviewMode} - connected - options={[ - { value: 'edit', label: <> Edit }, - { value: 'split', label: <> Split }, - { value: 'preview', label: <> Preview }, - ]} - /> -
+ + value={previewMode} + onChange={setPreviewMode} + title="⌘P to cycle" + options={[ + { value: 'edit', label: <> Edit }, + { value: 'split', label: <> Split }, + { value: 'preview', label: <> Preview }, + ]} + />
Body · Markdown - ⌘S save · ⌘P toggle · Esc cancel + + + ⌘S + Save + + + ⌘P + Toggle + + + Esc + Cancel + +