From e12617df6ee3921fe82fc4e4eec7949374a56eba Mon Sep 17 00:00:00 2001 From: Willie Hung Date: Wed, 21 Jan 2026 13:06:38 +0800 Subject: [PATCH] fix: run brew update before upgrade for Homebrew installs Ensures users get the latest version by syncing the tap first. --- cmd/skillshare/upgrade.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/cmd/skillshare/upgrade.go b/cmd/skillshare/upgrade.go index f74fa57c5..12cf175fc 100644 --- a/cmd/skillshare/upgrade.go +++ b/cmd/skillshare/upgrade.go @@ -91,10 +91,9 @@ func upgradeCLIBinary(dryRun, force bool) error { if isHomebrewInstall(execPath) { ui.Info("Detected Homebrew installation") if dryRun { - ui.Info("Would run: brew upgrade runkids/tap/skillshare") + ui.Info("Would run: brew update && brew upgrade runkids/tap/skillshare") return nil } - ui.Info("Running: brew upgrade runkids/tap/skillshare") return runBrewUpgrade() } @@ -325,6 +324,17 @@ func isHomebrewInstall(execPath string) bool { } func runBrewUpgrade() error { + // First update the tap to get latest formula + ui.Info("Updating tap...") + updateCmd := exec.Command("brew", "update", "--quiet") + updateCmd.Stdout = os.Stdout + updateCmd.Stderr = os.Stderr + if err := updateCmd.Run(); err != nil { + ui.Warning("brew update failed, trying upgrade anyway...") + } + + // Then upgrade + ui.Info("Upgrading...") cmd := exec.Command("brew", "upgrade", "runkids/tap/skillshare") cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr