From d70d276bae495ad98367c34ebfd43e499c55a356 Mon Sep 17 00:00:00 2001 From: Willie Date: Wed, 28 Oct 2026 01:27:56 +0800 Subject: [PATCH] docs(contributing): require an approved label and add AI policy (#663) Feature PRs have arrived with a self-ticked "maintainer approved" box on issues the maintainer never answered, and with large AI-generated diffs the author could not stand behind. Make approval a label only the maintainer can add, and state what an AI-assisted contribution owes reviewers: an author who has read the diff, answers reviews personally, does not split changes to dodge the size guideline, and makes only checkable claims. --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++-- CONTRIBUTING.md | 13 +++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e44bc32ef..4a11f73fa 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,16 +5,18 @@ - [ ] Bug fix - [ ] Small improvement (docs, typo, minor refactor) - [ ] Feature proposal (`proposals/` only — see [CONTRIBUTING.md](../CONTRIBUTING.md)) +- [ ] Approved feature or large change (the linked issue has the `approved` label) ## Linked Issue - + Closes # ## Checklist -- [ ] I've read [CONTRIBUTING.md](../CONTRIBUTING.md) +- [ ] I've read [CONTRIBUTING.md](../CONTRIBUTING.md), including its AI-assisted contributions section +- [ ] I've reviewed every line of the diff and can explain it - [ ] Tests included and passing (`make check`) — for code changes - [ ] No unrelated changes in the diff - [ ] Scope is focused — one concern per PR diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2bffca7f6..0e8062191 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,11 +33,24 @@ For new features or large changes: Approved proposals will be added to the roadmap. Implementation is handled by the maintainer to ensure consistency with the project's architecture and codebase conventions. +Approval is the `approved` label on the issue, added by the maintainer. A feature or large-change PR needs a linked issue with that label; without it, the PR may be closed without review. + > **Note:** Due to the nature of this project, most feature PRs won't be merged directly — but every contribution is valuable. Your PR serves as a concrete reference that shapes the final implementation. +### AI-Assisted Contributions + +AI coding tools are welcome; skillshare is built for them. Fully autonomous contributions are not. + +- **You are the author.** You have read, run, and can explain every line of the diff. +- **Answer reviews yourself.** Don't paste review comments into a model and post its reply unchecked. +- **Don't split to fit.** Splitting one change into several PRs to stay under the size guideline doesn't make it small. +- **Keep claims checkable.** Statements such as "approved" or "tests pass" in a PR must match what the issue and CI show. + ### PR Checklist - [ ] Linked to an issue (required for features, recommended for bug fixes) +- [ ] Features and large changes: the linked issue has the `approved` label +- [ ] I've reviewed every line of the diff and can explain it - [ ] Tests included and passing (`make check`) - [ ] No unrelated changes in the diff - [ ] Commit messages explain "why", not just "what"