From af143a33304776a5ff457c8a12baffc21caead50 Mon Sep 17 00:00:00 2001 From: Willie Date: Tue, 17 Mar 2026 23:37:19 +0800 Subject: [PATCH] fix(doctor): add CLI text output for skillignore check checkSkillignore only wrote to the JSON result but never printed to the terminal, so skillignore status was invisible in CLI output. --- cmd/skillshare/doctor.go | 2 ++ internal/skillignore/skillignore_test.go | 10 +++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/cmd/skillshare/doctor.go b/cmd/skillshare/doctor.go index 414bf51ed..c7d10dd5f 100644 --- a/cmd/skillshare/doctor.go +++ b/cmd/skillshare/doctor.go @@ -246,11 +246,13 @@ func printDoctorSummary(result *doctorResult) { // checkSkillignore reports .skillignore status as an info or pass check. func checkSkillignore(result *doctorResult, stats *skillignore.IgnoreStats) { if stats == nil || !stats.Active() { + ui.Info("Skillignore: not configured") result.addInfo("skillignore", "No .skillignore found — you can create one to hide skills from discovery") return } msg := fmt.Sprintf(".skillignore: %d patterns, %d skills ignored", stats.PatternCount(), stats.IgnoredCount()) + ui.Success("Skillignore: %d patterns, %d skills ignored", stats.PatternCount(), stats.IgnoredCount()) var details []string details = append(details, stats.Patterns...) if len(stats.IgnoredSkills) > 0 { diff --git a/internal/skillignore/skillignore_test.go b/internal/skillignore/skillignore_test.go index 9ec7bd32f..dd6b6f4eb 100644 --- a/internal/skillignore/skillignore_test.go +++ b/internal/skillignore/skillignore_test.go @@ -213,12 +213,12 @@ func TestMatcherMatch(t *testing.T) { func TestParseRule(t *testing.T) { tests := []struct { - name string - line string - wantOK bool - negated bool + name string + line string + wantOK bool + negated bool anchored bool - dirOnly bool + dirOnly bool }{ {"blank line", "", false, false, false, false}, {"whitespace only", " ", false, false, false, false},