From aeddeb9dfe7350bc1af1c9c168d89bb96737c19a Mon Sep 17 00:00:00 2001 From: Willie Date: Wed, 25 Feb 2026 06:52:34 +0800 Subject: [PATCH] fix(install): show [dry-run] message for single-skill git install paths MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit handleGitInstall has two single-skill paths (subdir and non-subdir) that always printed "✓ Installed: " even in dry-run mode. Branch on opts.DryRun to show "[dry-run] Would install: " instead, matching the multi-skill path behavior. Fixes failing CI tests: TestInstall_Auth_HTTPSPublicWithToken, TestInstall_RemoteGitHubSubdir_DryRun. --- cmd/skillshare/install_handlers.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/cmd/skillshare/install_handlers.go b/cmd/skillshare/install_handlers.go index a13be323b..a8aadef5c 100644 --- a/cmd/skillshare/install_handlers.go +++ b/cmd/skillshare/install_handlers.go @@ -204,7 +204,11 @@ func handleGitInstall(source *install.Source, cfg *config.Config, opts install.I } installSpinner.Stop() - ui.SuccessMsg("Installed: %s", skill.Name) + if opts.DryRun { + ui.Warning("[dry-run] Would install: %s", skill.Name) + } else { + ui.SuccessMsg("Installed: %s", skill.Name) + } renderInstallWarningsWithResult("", result.Warnings, opts.AuditVerbose, result) if !opts.DryRun { @@ -278,7 +282,11 @@ func handleGitInstall(source *install.Source, cfg *config.Config, opts install.I } installSpinner.Stop() - ui.SuccessMsg("Installed: %s", skill.Name) + if opts.DryRun { + ui.Warning("[dry-run] Would install: %s", skill.Name) + } else { + ui.SuccessMsg("Installed: %s", skill.Name) + } renderInstallWarningsWithResult("", result.Warnings, opts.AuditVerbose, result) if !opts.DryRun {