From 5198a7428714b9efcff1ad9457da5c81d4e6d5ee Mon Sep 17 00:00:00 2001 From: Willie Date: Fri, 20 Mar 2026 11:05:17 +0800 Subject: [PATCH] fix(ui): fix assistant panel scrolling, remove false target warnings, add virtual scroll MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix Config and Audit Rules assistant panels with fixed 500px content height to enable scrolling (matching CodeMirror editor height) - Remove target name validation that produced false "Unknown target" warnings — target names are user-defined and freely configurable - Enrich targets field docs example with all sub-fields - Add react-virtuoso virtual scrolling to FilterStudioPage preview list - Add v0.17.9 changelog and website changelog --- CHANGELOG.md | 13 +++++ .../components/audit/AuditAssistantPanel.tsx | 4 +- ui/src/components/config/AssistantPanel.tsx | 7 +-- ui/src/components/config/ConfigStatusBar.tsx | 4 +- .../hooks/__tests__/useYamlValidation.test.ts | 38 +++++-------- ui/src/hooks/useYamlValidation.ts | 53 ++----------------- ui/src/lib/fieldDocs.ts | 2 +- ui/src/pages/AuditRulesYaml.tsx | 4 +- ui/src/pages/ConfigPage.tsx | 21 ++------ ui/src/pages/FilterStudioPage.tsx | 30 ++++++----- website/src/pages/changelog.md | 13 +++++ 11 files changed, 74 insertions(+), 115 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ccd13cfec..167a0b928 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,18 @@ # Changelog +## [0.17.9] - 2026-03-20 + +### Bug Fixes + +- **Config page assistant panel now scrollable** — the right-side Structure/Diff panel now has a fixed 500px content area matching the editor height, enabling vertical scrolling when the YAML structure is long +- **Removed false "Unknown target" warnings** — the config editor no longer flags custom target names as unknown. Target names are user-defined and freely configurable — any name is valid +- **Audit rules assistant panel scrollable** — same fixed-height scrolling fix applied to the Audit Rules page's assistant panel + +### Improvements + +- **Richer `targets` field docs** — the `targets` field documentation example now shows all sub-fields (`path`, `mode`, `include`, `exclude`) with multiple targets +- **Filter Studio virtual scrolling** — the skill preview list now uses virtual scrolling for smooth performance with large skill collections + ## [0.17.8] - 2026-03-19 ### New Features diff --git a/ui/src/components/audit/AuditAssistantPanel.tsx b/ui/src/components/audit/AuditAssistantPanel.tsx index 91c59367a..7cdc61336 100644 --- a/ui/src/components/audit/AuditAssistantPanel.tsx +++ b/ui/src/components/audit/AuditAssistantPanel.tsx @@ -155,7 +155,7 @@ export default function AuditAssistantPanel({ return (
{/* Status bar */} @@ -169,7 +169,7 @@ export default function AuditAssistantPanel({ /> {/* Context area */} -
{renderContextArea()}
+
{renderContextArea()}
{/* Bottom bar */}
diff --git a/ui/src/components/config/AssistantPanel.tsx b/ui/src/components/config/AssistantPanel.tsx index b1e6dba48..313b3b51d 100644 --- a/ui/src/components/config/AssistantPanel.tsx +++ b/ui/src/components/config/AssistantPanel.tsx @@ -23,7 +23,6 @@ interface Props { collapsed: boolean; onToggleCollapse: () => void; onRevert: () => void; - schemaUnavailable?: boolean; mode?: 'config' | 'skillignore'; ignoredSkills?: string[]; } @@ -39,7 +38,6 @@ export default function AssistantPanel({ collapsed, onToggleCollapse, onRevert, - schemaUnavailable = false, mode = 'config', ignoredSkills = [], }: Props) { @@ -121,7 +119,7 @@ export default function AssistantPanel({ return (
{/* Status bar */} @@ -131,12 +129,11 @@ export default function AssistantPanel({ collapsed={collapsed} onToggleCollapse={onToggleCollapse} onErrorsClick={handleErrorsClick} - schemaUnavailable={schemaUnavailable} mode={mode} /> {/* Context area */} -
{renderContextArea()}
+
{renderContextArea()}
{/* Bottom bar — config mode only */} {mode === 'config' && ( diff --git a/ui/src/components/config/ConfigStatusBar.tsx b/ui/src/components/config/ConfigStatusBar.tsx index 745fcf81f..8a97568ca 100644 --- a/ui/src/components/config/ConfigStatusBar.tsx +++ b/ui/src/components/config/ConfigStatusBar.tsx @@ -9,7 +9,6 @@ interface ConfigStatusBarProps { collapsed: boolean; onToggleCollapse: () => void; onErrorsClick: () => void; - schemaUnavailable?: boolean; mode?: 'config' | 'skillignore' | 'audit'; } @@ -19,7 +18,6 @@ export default function ConfigStatusBar({ collapsed, onToggleCollapse, onErrorsClick, - schemaUnavailable = false, mode = 'config', }: ConfigStatusBarProps) { const errorCount = errors.filter(e => e.severity === 'error').length; @@ -35,7 +33,7 @@ export default function ConfigStatusBar({ <> {isValid ? ( - {schemaUnavailable ? 'Valid YAML (schema unavailable)' : 'Valid YAML'} + Valid YAML ) : (
- {/* Panel: collapses via CSS transition */} + {/* Assistant panel */}
- + setShowRevertDialog(true)} - schemaUnavailable={schemaUnavailable} />
@@ -424,7 +411,7 @@ export default function ConfigPage() { panelCollapsed ? 'flex-[0] w-0 opacity-0 pointer-events-none' : 'flex-[2] opacity-100' }`} > - +
- {filteredPreview.map((entry) => ( - handleToggleSkill(entry)} - /> - ))} - {filteredPreview.length === 0 && previewSearch && ( + {filteredPreview.length === 0 && previewSearch ? (

No skills matching "{previewSearch}"

+ ) : ( + ( + handleToggleSkill(filteredPreview[index])} + /> + )} + /> )}
@@ -280,7 +286,7 @@ export default function FilterStudioPage() { } /** Single preview row with status indicator and click-to-toggle */ -function PreviewRow({ +const PreviewRow = memo(function PreviewRow({ entry, onClick, }: { @@ -323,7 +329,7 @@ function PreviewRow({ )}
); -} +}); function StatusIcon({ status }: { status: SyncMatrixEntry['status'] }) { switch (status) { diff --git a/website/src/pages/changelog.md b/website/src/pages/changelog.md index b7708459b..d0086875f 100644 --- a/website/src/pages/changelog.md +++ b/website/src/pages/changelog.md @@ -9,6 +9,19 @@ All notable changes to skillshare are documented here. For the full commit histo --- +## [0.17.9] - 2026-03-20 + +### Bug Fixes + +- **Config page assistant panel now scrollable** — the right-side Structure/Diff panel now has a fixed 500px content area matching the editor height, enabling vertical scrolling when the YAML structure is long +- **Removed false "Unknown target" warnings** — the config editor no longer flags custom target names as unknown. Target names are user-defined and freely configurable — any name is valid +- **Audit rules assistant panel scrollable** — same fixed-height scrolling fix applied to the Audit Rules page's assistant panel + +### Improvements + +- **Richer `targets` field docs** — the `targets` field documentation example now shows all sub-fields (`path`, `mode`, `include`, `exclude`) with multiple targets +- **Filter Studio virtual scrolling** — the skill preview list now uses virtual scrolling for smooth performance with large skill collections + ## [0.17.8] - 2026-03-19 ### New Features