From 40347477d5b6fbb0ea1216e68f11a61a4df20002 Mon Sep 17 00:00:00 2001 From: Willie Date: Thu, 9 Apr 2026 14:49:24 +0800 Subject: [PATCH] fix(audit): scan all agents including disabled ones MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Security audit should scan ALL agents regardless of .agentignore status — disabled agents may still contain threats. --- cmd/skillshare/audit.go | 3 ++- internal/server/handler_audit.go | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/skillshare/audit.go b/cmd/skillshare/audit.go index dba6eea51..64c698060 100644 --- a/cmd/skillshare/audit.go +++ b/cmd/skillshare/audit.go @@ -508,7 +508,8 @@ func collectInstalledAgentPaths(agentsSourcePath string) ([]auditSkillRef, error return nil, fmt.Errorf("failed to discover agents: %w", err) } var agentPaths []auditSkillRef - for _, d := range resource.ActiveAgents(discovered) { + // Audit scans ALL agents including disabled ones — security risks don't respect .agentignore. + for _, d := range discovered { agentPaths = append(agentPaths, auditSkillRef{name: d.FlatName, path: d.AbsPath}) } return agentPaths, nil diff --git a/internal/server/handler_audit.go b/internal/server/handler_audit.go index 42a399fc1..9c7ec090c 100644 --- a/internal/server/handler_audit.go +++ b/internal/server/handler_audit.go @@ -76,7 +76,7 @@ func discoverAuditAgents(source string) ([]skillEntry, error) { return nil, err } var agents []skillEntry - for _, d := range resource.ActiveAgents(discovered) { + for _, d := range discovered { agents = append(agents, skillEntry{name: d.FlatName, path: d.AbsPath}) } return agents, nil