From 3e8aec74aa7b2cd93cbfded83d6b74c007bfe78f Mon Sep 17 00:00:00 2001 From: Willie Date: Sun, 8 Feb 2026 17:45:18 +0800 Subject: [PATCH] fix: show helpful message when Windows upgrade fails due to locked binary When another process (e.g. `skillshare ui`) holds the exe file open, Windows denies the rename. Detect this and suggest closing other skillshare processes instead of showing a raw "Access is denied" error. --- cmd/skillshare/upgrade.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmd/skillshare/upgrade.go b/cmd/skillshare/upgrade.go index 1e716f82b..5e8e42be5 100644 --- a/cmd/skillshare/upgrade.go +++ b/cmd/skillshare/upgrade.go @@ -5,6 +5,7 @@ import ( "archive/zip" "bytes" "compress/gzip" + "errors" "fmt" "io" "net/http" @@ -331,6 +332,9 @@ func writeBinary(r io.Reader, destPath string) error { // Rename running exe to .old if err := os.Rename(destPath, oldPath); err != nil { os.Remove(tmpPath) + if errors.Is(err, os.ErrPermission) { + return fmt.Errorf("binary is locked by another process (is 'skillshare ui' running?)\n Close other skillshare processes and try again") + } return fmt.Errorf("failed to rename current binary: %w", err) } // Rename new exe to correct name