From 314d6a3dffc169843fdb9a24ea3c307f871e972f Mon Sep 17 00:00:00 2001 From: Willie Date: Wed, 11 Mar 2026 22:33:10 +0800 Subject: [PATCH] fix(sync): show duplicate skill names in collision message, fix vertical spacing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Display the actual duplicate skill name(s) in the "isolated by target filters" info message so users can identify which skills collide. Remove the extra fmt.Println() before backup section — ui.Header() already includes a leading newline, so the previous blank line created a double gap. Also replace VirtualizedGroupedView with native DOM GroupedView using sticky sub-headers that respect the toolbar height offset. --- cmd/skillshare/sync.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cmd/skillshare/sync.go b/cmd/skillshare/sync.go index e4a20efeb..70798af40 100644 --- a/cmd/skillshare/sync.go +++ b/cmd/skillshare/sync.go @@ -169,7 +169,6 @@ func cmdSync(args []string) error { // Backup targets before sync (only if not dry-run and there are skills) if !dryRun && len(discoveredSkills) > 0 && !jsonOutput { - fmt.Println() backupTargetsBeforeSync(cfg) } @@ -568,8 +567,12 @@ func reportCollisions(skills []sync.DiscoveredSkill, targets map[string]config.T fmt.Println() } else { // Global collision exists but filters isolate them — single summary line + names := make([]string, len(global)) + for i, c := range global { + names[i] = c.Name + } fmt.Println() - ui.Info("%d duplicate skill names (isolated by target filters)", len(global)) + ui.Info("%d duplicate skill names (isolated by target filters): %s", len(global), strings.Join(names, ", ")) } }