From 1bcd02a3d9b529b8fa1ac1c538efb51359e2e5c2 Mon Sep 17 00:00:00 2001 From: britz Date: Sat, 13 Jun 2026 21:30:49 +0530 Subject: [PATCH] fix: cache lint load error in package state to persist across Once calls --- internal/sync/lint.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/sync/lint.go b/internal/sync/lint.go index 48826ef9f..ed4bcb5d5 100644 --- a/internal/sync/lint.go +++ b/internal/sync/lint.go @@ -69,14 +69,14 @@ type compiledLintRule struct { var ( compiledLintRules []compiledLintRule lintOnce gosync.Once + lintLoadErr error ) func loadLintRules() ([]compiledLintRule, error) { - var retErr error lintOnce.Do(func() { var f lintRulesFile if err := yaml.Unmarshal(lintRulesData, &f); err != nil { - retErr = fmt.Errorf("lint: embedded rules YAML is invalid: %w", err) + lintLoadErr = fmt.Errorf("lint: embedded rules YAML is invalid: %w", err) return } for _, r := range f.Rules { @@ -84,7 +84,7 @@ func loadLintRules() ([]compiledLintRule, error) { if r.Pattern != "" { re, err := regexp.Compile(r.Pattern) if err != nil { - retErr = fmt.Errorf("lint: invalid regex in rule %s: %w", r.ID, err) + lintLoadErr = fmt.Errorf("lint: invalid regex in rule %s: %w", r.ID, err) return } cr.compiledPattern = re @@ -92,7 +92,7 @@ func loadLintRules() ([]compiledLintRule, error) { compiledLintRules = append(compiledLintRules, cr) } }) - return compiledLintRules, retErr + return compiledLintRules, lintLoadErr } // LintSkill runs all lint rules against a skill's metadata.