mirror of
https://github.com/rohitg00/skillkit.git
synced 2026-11-19 02:13:58 +00:00
* feat: implement phases 12-18 - complete agentic development platform This comprehensive update implements 7 major phases (12-18) transforming SkillKit into a universal agentic development platform with methodology packs, hooks, orchestration, planning, and AI capabilities. Phase 12: Methodology Framework - MethodologyManager for pack-based methodology distribution - 5 methodology packs (testing, debugging, planning, collaboration, meta) - 13 curated methodology skills - Pack loader with validation and installation - 56 comprehensive tests Phase 13: Hooks & Automatic Triggering System - HookManager with event-driven skill activation - 10+ event types (session:start, file:open, task:start, etc.) - Pattern-based triggers with glob support - Agent-specific hook generation - 29 comprehensive tests Phase 14: Subagent Orchestration - TeamOrchestrator for multi-agent coordination - TaskManager with cross-agent assignment - Plan approval workflow (submit → approve/reject) - TeamMessageBus for agent communication - Two-stage review system (spec compliance + code quality) - 36 comprehensive tests Phase 15: Structured Plan System - PlanParser for markdown → structured plan conversion - PlanValidator for completeness checking - PlanExecutor with dry-run support - Bite-sized task format (2-5 min atomic tasks) - 36 comprehensive tests Phase 16: Slash Commands & Agent Integration - CommandRegistry for slash command management - Agent-specific command generation (Claude, Cursor, OpenCode) - Command aliases and arguments support - 42 comprehensive tests Phase 17: Enhanced Agent Features - Permission system (allow/deny/ask patterns) - Glob pattern matching for file-scoped skills - Bootstrap files (AGENTS.md, SOUL.md, TOOLS.md) - Multi-mode support (Code/Architect/Debug/Ask) - Agent feature tests Phase 18: Advanced Features (AI & Audit) - AIManager with natural language skill search - Automatic skill generation from examples/code - MockAIProvider for testing without API keys - AuditLogger with complete operation trail - Query, export (JSON/CSV/text), and statistics - 37 comprehensive tests (15 AI + 22 audit) CLI Commands Added: - skillkit methodology list|install|sync - skillkit hook add|remove|list|generate - skillkit plan parse|validate|execute|create - skillkit commands generate|list - skillkit ai search|generate|similar - skillkit audit log|export|stats|clear TUI Enhancements: - Methodology screen (o key) for pack browsing - Plan screen (n key) for plan viewing/execution - Updated navigation and sidebar Test Coverage: - Total: 619 tests passing (582 core + 49 agents + 1 cli + 3 app) - New: 245+ tests for phases 12-18 - Coverage maintained at 80%+ Breaking Changes: None Dependencies: No new external dependencies added * fix: apply CodeRabbit security and quality improvements Security Fixes: - Replace custom glob-to-regex with minimatch to prevent ReDoS vulnerabilities - Fix regex pattern generation in globs.ts using battle-tested library - Eliminate unsafe regex patterns in modes.ts and permissions.ts Code Quality Improvements: - Use shared GlobMatcher utility to eliminate code duplication in modes.ts - Preserve command metadata on updates to prevent data loss - Fix single-file vs directory output path handling in command.ts - Pass --strict flag through to plan validator Race Condition & Concurrency Fixes: - Add Promise-based mutex to prevent race condition in audit logger flush() - Handle both sync and async event listeners to prevent unhandled rejections - Maintain synchronous event emission while safely handling async listeners Data Integrity Fixes: - Fix dependency checking to detect missing dependencies - Rehydrate Date fields when importing tasks from JSON - Fix executePlan to properly detect incomplete tasks State Management: - Add validation for missing step executor (fail fast) - Handle cancellation and reset executor state in finally block - Add 'cancelled' status and event to PlanStatus/PlanEvent types Dependencies: - Add minimatch@^10.0.1 to @skillkit/agents package All 639 tests passing. * docs: update READMEs with Phase 10-18 features - Root README: add minimal "What's New in v1.5.0" section with 5 bullet points - packages/core: add usage examples for Team, Plugin, Methodology, Orchestration, Plan, Hooks - packages/cli: add command sections for team, plugin, methodology, plan, hook, command - packages/tui: add screen descriptions for Marketplace, Workflow, Execute, Team, Plugins, Methodology, Plan, Memory - apps/skillkit: expand with practical usage examples for all new features All updates are clean, user-focused, and avoid AI marketing fluff. * fix: resolve multiple code quality and robustness issues - Fix minimatch dependency: downgrade to ^9.0.0 for Node 18 compatibility - Fix command.ts export: handle directory paths and ensure parent directories exist - Fix command.ts merge: preserve curated examples when merging commands - Fix plan.ts: filter empty entries from comma-separated inputs - Fix audit logger pagination: respect explicit 0 for limit and offset - Fix audit logger: gracefully handle malformed JSON lines without data loss - Fix team orchestrator: prevent task assignment to non-idle agents - Fix plan executor: unblock waitIfPaused() when cancel() is called All 639 tests passing. * fix: additional robustness improvements for plan and executor - Fix plan.ts createPlan: filter empty strings from techStack after split/trim - Fix executor.ts: re-check abort signal after waitIfPaused() in both execute() and executeTask() to prevent running additional tasks/steps after cancellation during pause All 639 tests passing.