mirror of
https://github.com/rohitg00/skillkit.git
synced 2026-11-20 12:23:29 +00:00
* refactor(docs): simplify website components and update README Website Code Simplification: - Convert arrow functions to named function declarations with explicit return types - Extract inline styles to module-level constants (BASE_STYLES, VARIANT_STYLES, etc.) - Extract SVG icons to constants (GITHUB_ICON, CHECK_ICON, COPY_ICON) - Extract CSS animations to constants (FADE_ANIMATION_STYLES, SCROLL_ANIMATION_STYLES) - Add explicit TypeScript interfaces (Feature, Agent, TerminalLine, etc.) - Replace nested ternaries with switch statements for clarity - Extract inline handlers to named functions (scrollToTop, openGitHub, etc.) - Improve variable naming (idx -> index, cap -> feature) - Use meaningful React keys instead of index-only keys README Updates: - Remove "What's New in v1.6" section (release notes should be in CHANGELOG) Components updated: - App.tsx, Button.tsx, Card.tsx, Terminal.tsx, Footer.tsx - Features.tsx, Agents.tsx, Hero.tsx - SkillSubmitForm.tsx, SkillGenerator.tsx * fix: address CodeRabbit review suggestions Security: - Add noopener,noreferrer to window.open in Hero.tsx - Handle clipboard API errors with try/catch Accessibility: - Add Space key support to Card.tsx for keyboard navigation - Add aria-label to GitHub icon link in Footer.tsx Error Handling: - Fix useCallback dependency for processMarkdownFile in SkillSubmitForm - Add input validation for topic in geminiService.ts Data Validation: - Add defensive checks for malformed source URLs in skills-index.ts - Generate proper skill ID for upload mode in SkillSubmitForm Type Safety: - Replace unsafe 'as any' cast with proper type annotation in geminiService Code Quality: - Use array filter pattern for class concatenation in Button.tsx
53 lines
1.8 KiB
TypeScript
53 lines
1.8 KiB
TypeScript
import React from 'react';
|
|
|
|
interface ButtonProps extends React.ButtonHTMLAttributes<HTMLButtonElement> {
|
|
variant?: 'primary' | 'secondary' | 'outline' | 'ghost';
|
|
fullWidth?: boolean;
|
|
isLoading?: boolean;
|
|
}
|
|
|
|
const BASE_STYLES = "inline-flex items-center justify-center px-6 py-3 text-sm font-medium transition-all duration-200 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-offset-black disabled:opacity-50 font-mono tracking-tight";
|
|
|
|
const VARIANT_STYLES = {
|
|
primary: "bg-white text-black hover:bg-zinc-200 border border-white",
|
|
secondary: "bg-zinc-900 text-zinc-100 hover:bg-zinc-800 border border-zinc-800",
|
|
outline: "bg-transparent text-zinc-300 border border-zinc-700 hover:border-zinc-500 hover:text-white",
|
|
ghost: "bg-transparent text-zinc-400 hover:text-white hover:bg-zinc-900"
|
|
} as const;
|
|
|
|
export function Button({
|
|
children,
|
|
variant = 'primary',
|
|
className = '',
|
|
fullWidth = false,
|
|
isLoading = false,
|
|
disabled,
|
|
...props
|
|
}: ButtonProps): React.ReactElement {
|
|
const widthClass = fullWidth ? 'w-full' : '';
|
|
|
|
const classes = [
|
|
BASE_STYLES,
|
|
VARIANT_STYLES[variant],
|
|
widthClass,
|
|
className,
|
|
].filter(Boolean).join(' ');
|
|
|
|
return (
|
|
<button
|
|
className={classes}
|
|
disabled={disabled || isLoading}
|
|
{...props}
|
|
>
|
|
{isLoading ? (
|
|
<>
|
|
<svg className="animate-spin -ml-1 mr-2 h-4 w-4" xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24">
|
|
<circle className="opacity-25" cx="12" cy="12" r="10" stroke="currentColor" strokeWidth="4"></circle>
|
|
<path className="opacity-75" fill="currentColor" d="M4 12a8 8 0 018-8V0C5.373 0 0 5.373 0 12h4zm2 5.291A7.962 7.962 0 014 12H0c0 3.042 1.135 5.824 3 7.938l3-2.647z"></path>
|
|
</svg>
|
|
PROCESSING
|
|
</>
|
|
) : children}
|
|
</button>
|
|
);
|
|
} |