Files
skillkit/packages/cli/src/commands/settings.ts
T
Rohit Ghumare 7805a5fd4b feat: add team collaboration and plugin system (#4)
* feat: add team collaboration and plugin system

Team Collaboration (Phase 10):
- TeamManager for skill sharing with remote registries
- Skill bundles (create, export, import)
- Team CLI commands: init, share, import, list, sync, remove, bundle-*
- Team TUI screen with navigation key 'a'

Plugin System (Phase 11):
- PluginManager with lifecycle hooks
- Plugin loader (files, npm packages, directories)
- TranslatorPlugin for custom agent formats
- ProviderPlugin for custom skill sources
- CommandPlugin for custom CLI commands
- Plugin CLI commands: list, install, uninstall, enable, disable, info
- Plugins TUI screen with navigation key 'p'

Additional:
- CI/CD command for template generation
- Settings command improvements
- Updated CLAUDE.md with all 11 phases complete
- 359 tests passing

* fix: address PR review comments from Devin

- Fix skill-executor.ts: handle undefined agentToUse when strategy is 'cli'
  Previously, if strategy was 'cli' but no CLI agent was available, the
  code would fall through and call executeWithAgent with undefined agent,
  causing a runtime error.

- Fix cicd.ts: prevent GitLab CI config overwrite without --force
  Previously, if .gitlab-ci.yml existed but didn't contain 'skillkit',
  it would be overwritten without checking --force. Now it properly
  returns early with a helpful message, consistent with CircleCI behavior.

* fix: address PR review comments from CodeRabbit and Devin

Plugin command fixes:
- Fix double-nested .skillkit path when using --global flag

Settings command fixes:
- Add defaultTimeout to help text for available keys
- Wrap const timeout in block scope for switch case
- Fix --set flag validation to require equals sign

Core package fixes:
- Remove .ts from supported plugin extensions (runtime imports fail)
- Store skill name instead of full path in bundle manifest
- Use ESM import for execSync instead of require()
- Replace custom YAML parser with yaml library for proper nested structure handling

TUI screen fixes:
- Guard against empty plugins array in navigation
- Fix empty object pattern in Settings.tsx
- Surface config load failures in Settings screen
- Add manager.load() before sync/import in Team screen
- Guard against empty skills array in Team navigation
- Clamp selection index after skills update

CI/CD command fixes:
- Properly handle skipped workflows (not reported as success)
- Show different final message when nothing was created
- Wrap readFileSync in try/catch for GitLab CI

* fix: address PR review feedback (round 2)

- Security: Add path traversal protection in bundle import
- Fix Plugins.tsx to load plugins from directory before listing
- Fix plugin.ts to persist plugin files to disk on install/uninstall
- Fix Settings.tsx auto-detect vs universal display inconsistency
- Add null check for registry in team/manager.ts sync()
- Thread TeamConfig.auth through provider clone calls
- Fix GitLab CI rules vs only conflict (use rules instead of only)
- Make loadConfig() accept global parameter for --global flag
- Fix relative path detection in plugins/loader.ts (../plugins)

* fix: address PR review feedback (round 3)

- plugin.ts: Add '../' and '~' to isLocalPath detection, use
  loader-recognized names (index.js, plugin.json) for single-file copy
- plugin.ts: Remove unused 'basename' import
- settings.ts: Change defaultTimeout validation from < 0 to <= 0
- settings.ts: Use knownKeys whitelist for unknown key detection
- loader.ts: Wrap statSync in try/catch for scanDirectory
- loader.ts: Validate required fields (name, version) before pushing
- loader.ts: Update regex to allow scoped npm names (@scope/name)
- bundle.ts: Resolve targetDir to absolute path for path containment
- Plugins.tsx: Only ignore ENOENT errors, rethrow others
- Plugins.tsx: Load plugins in togglePlugin before enable/disable

* fix: address PR review issues - round 4

CRITICAL fixes:
- loader.ts: Wrap statSync in try/catch in loadPluginsFromDirectory to handle
  permission denied and broken symlinks
- bundle.ts: Block path traversal attacks via skill names in importBundle by
  validating skill names don't contain / \ or start with .

MAJOR fixes:
- bundle.ts: Use dirname() instead of join('..') for output directory calculation

MINOR fixes:
- plugin.ts: Expand tilde paths (~) before existsSync for proper file operations
- settings.ts: Show defaultTimeout and marketplaceSources in default output
- bundle.ts: Prevent duplicate skill names in bundle with early error
- bundle.ts: Handle single-file skills properly in detectAgents

* fix: address PR review issues - round 5

CRITICAL fixes:
- plugin.ts: Add path traversal protection in uninstallPlugin with name validation
  and resolved path checks
- bundle.ts: Fix parseSkillContent to not drop first file when content starts
  with "--- file ---" header

MAJOR fixes:
- plugin.ts: Add isValidPluginName() helper and validate plugin.metadata.name
  before using in file paths
- plugin.ts: Preserve .mjs extension for single-file ESM plugins
- bundle.ts: Use cross-platform path containment checks with relative() and sep
  instead of hardcoded '/'
- loader.ts: Add support for .mjs files (index.mjs, plugin.mjs)

MINOR fixes:
- plugin.ts: Expand tilde (~) path BEFORE calling loadPlugin
- settings.ts: Use null instead of undefined in JSON output for --get so key
  is preserved

* fix: allow scoped npm names in isValidPluginName

Update isValidPluginName to allow scoped npm package names like @scope/name
while still preventing path traversal attacks. Uses the same regex pattern
as loader.ts validatePlugin for consistency.

Valid names: my-plugin, @scope/plugin-name
Invalid names: ../evil, .hidden, name\\path, @../evil/name

* fix: handle more relative path patterns in loadPlugin

- Use isAbsolute() for cross-platform absolute path detection
- Add check for paths containing '/' (excluding @scope packages)
- Simplify pattern to source.startsWith('.') for all dot-prefixed paths
- Now correctly handles: plugins/x.js, ../foo, ./bar, .hidden
2026-01-23 22:32:29 +00:00

229 lines
7.1 KiB
TypeScript

import { Command, Option } from 'clipanion';
import chalk from 'chalk';
import { loadConfig, saveConfig, type SkillkitConfig, type AgentType } from '@skillkit/core';
const VALID_AGENTS: AgentType[] = [
'claude-code', 'cursor', 'codex', 'gemini-cli', 'opencode',
'antigravity', 'amp', 'clawdbot', 'droid', 'github-copilot',
'goose', 'kilo', 'kiro-cli', 'roo', 'trae', 'windsurf', 'universal',
];
/**
* Settings command - view and modify SkillKit configuration
*/
export class SettingsCommand extends Command {
static override paths = [['settings'], ['config']];
static override usage = Command.Usage({
description: 'View and modify SkillKit settings',
details: `
View or modify SkillKit configuration. Settings are stored in skillkit.yaml.
Without arguments, shows all current settings.
With --set, modifies a specific setting.
`,
examples: [
['Show all settings', '$0 settings'],
['Set default agent', '$0 settings --set agent=claude-code'],
['Enable auto-sync', '$0 settings --set autoSync=true'],
['Set cache directory', '$0 settings --set cacheDir=~/.cache/skillkit'],
['Show settings as JSON', '$0 settings --json'],
['Save to global config', '$0 settings --set agent=cursor --global'],
],
});
// Set a setting
set = Option.String('--set,-s', {
description: 'Set a config value (key=value)',
});
// Get a specific setting
get = Option.String('--get,-g', {
description: 'Get a specific setting value',
});
// JSON output
json = Option.Boolean('--json,-j', false, {
description: 'Output as JSON',
});
// Global config
global = Option.Boolean('--global', false, {
description: 'Use global config (~/.config/skillkit/)',
});
// Reset to defaults
reset = Option.Boolean('--reset', false, {
description: 'Reset all settings to defaults',
});
async execute(): Promise<number> {
// Load current config (respect --global flag)
const config = loadConfig(this.global);
// Reset to defaults
if (this.reset) {
const defaultConfig: SkillkitConfig = {
version: 1,
agent: 'universal',
autoSync: true,
};
saveConfig(defaultConfig, this.global);
console.log(chalk.green('Settings reset to defaults'));
return 0;
}
// Get a specific setting
if (this.get) {
// Check if the key is a known setting (not just if value is undefined)
const knownKeys = [
'agent', 'autoSync', 'cacheDir', 'skillsDir',
'enabledSkills', 'disabledSkills', 'marketplaceSources', 'defaultTimeout'
];
if (!knownKeys.includes(this.get)) {
console.error(chalk.red(`Unknown setting: ${this.get}`));
return 1;
}
const value = this.getConfigValue(config, this.get);
if (this.json) {
// Use null instead of undefined so the key is preserved in JSON output
console.log(JSON.stringify({ [this.get]: value ?? null }));
} else {
console.log(value ?? '(not set)');
}
return 0;
}
// Set a setting
if (this.set) {
const [key, ...valueParts] = this.set.split('=');
const value = valueParts.join('=');
if (!key || !this.set.includes('=')) {
console.error(chalk.red('Invalid format. Use: --set key=value'));
return 1;
}
const result = this.setConfigValue(config, key, value);
if (!result.success) {
console.error(chalk.red(result.error));
return 1;
}
saveConfig(config, this.global);
console.log(chalk.green(`${key} = ${value}`));
return 0;
}
// Show all settings
if (this.json) {
console.log(JSON.stringify(config, null, 2));
} else {
console.log(chalk.cyan('SkillKit Settings'));
console.log(chalk.dim('─'.repeat(40)));
console.log();
const settings = [
{ key: 'agent', label: 'Default Agent', value: config.agent },
{ key: 'autoSync', label: 'Auto Sync', value: config.autoSync ? 'enabled' : 'disabled' },
{ key: 'cacheDir', label: 'Cache Dir', value: config.cacheDir || '~/.skillkit/cache' },
{ key: 'skillsDir', label: 'Skills Dir', value: config.skillsDir || '(default)' },
{ key: 'defaultTimeout', label: 'Timeout', value: config.defaultTimeout ? `${config.defaultTimeout}ms` : '(default)' },
];
for (const setting of settings) {
console.log(` ${chalk.white(setting.label.padEnd(14))} ${chalk.dim(setting.value)}`);
}
if (config.enabledSkills?.length) {
console.log();
console.log(` ${chalk.white('Enabled Skills'.padEnd(14))} ${chalk.dim(config.enabledSkills.join(', '))}`);
}
if (config.disabledSkills?.length) {
console.log(` ${chalk.white('Disabled Skills'.padEnd(14))} ${chalk.dim(config.disabledSkills.join(', '))}`);
}
if (config.marketplaceSources?.length) {
console.log(` ${chalk.white('Marketplaces'.padEnd(14))} ${chalk.dim(config.marketplaceSources.join(', '))}`);
}
console.log();
console.log(chalk.dim('Use --set key=value to modify settings'));
console.log(chalk.dim('Available keys: agent, autoSync, cacheDir, skillsDir, defaultTimeout'));
}
return 0;
}
private getConfigValue(config: SkillkitConfig, key: string): unknown {
switch (key) {
case 'agent':
return config.agent;
case 'autoSync':
return config.autoSync;
case 'cacheDir':
return config.cacheDir;
case 'skillsDir':
return config.skillsDir;
case 'enabledSkills':
return config.enabledSkills;
case 'disabledSkills':
return config.disabledSkills;
case 'marketplaceSources':
return config.marketplaceSources;
case 'defaultTimeout':
return config.defaultTimeout;
default:
return undefined;
}
}
private setConfigValue(
config: SkillkitConfig,
key: string,
value: string
): { success: boolean; error?: string } {
switch (key) {
case 'agent':
if (!VALID_AGENTS.includes(value as AgentType)) {
return {
success: false,
error: `Invalid agent. Valid options: ${VALID_AGENTS.join(', ')}`,
};
}
config.agent = value as AgentType;
break;
case 'autoSync':
if (!['true', 'false', 'enabled', 'disabled'].includes(value.toLowerCase())) {
return { success: false, error: 'autoSync must be true/false or enabled/disabled' };
}
config.autoSync = value.toLowerCase() === 'true' || value.toLowerCase() === 'enabled';
break;
case 'cacheDir':
config.cacheDir = value || undefined;
break;
case 'skillsDir':
config.skillsDir = value || undefined;
break;
case 'defaultTimeout': {
const timeout = parseInt(value, 10);
if (isNaN(timeout) || timeout <= 0) {
return { success: false, error: 'defaultTimeout must be a positive number (milliseconds)' };
}
config.defaultTimeout = timeout;
break;
}
default:
return { success: false, error: `Unknown setting: ${key}` };
}
return { success: true };
}
}