mirror of
https://github.com/rohitg00/skillkit.git
synced 2026-11-20 12:23:29 +00:00
* feat: implement phases 12-18 - complete agentic development platform This comprehensive update implements 7 major phases (12-18) transforming SkillKit into a universal agentic development platform with methodology packs, hooks, orchestration, planning, and AI capabilities. Phase 12: Methodology Framework - MethodologyManager for pack-based methodology distribution - 5 methodology packs (testing, debugging, planning, collaboration, meta) - 13 curated methodology skills - Pack loader with validation and installation - 56 comprehensive tests Phase 13: Hooks & Automatic Triggering System - HookManager with event-driven skill activation - 10+ event types (session:start, file:open, task:start, etc.) - Pattern-based triggers with glob support - Agent-specific hook generation - 29 comprehensive tests Phase 14: Subagent Orchestration - TeamOrchestrator for multi-agent coordination - TaskManager with cross-agent assignment - Plan approval workflow (submit → approve/reject) - TeamMessageBus for agent communication - Two-stage review system (spec compliance + code quality) - 36 comprehensive tests Phase 15: Structured Plan System - PlanParser for markdown → structured plan conversion - PlanValidator for completeness checking - PlanExecutor with dry-run support - Bite-sized task format (2-5 min atomic tasks) - 36 comprehensive tests Phase 16: Slash Commands & Agent Integration - CommandRegistry for slash command management - Agent-specific command generation (Claude, Cursor, OpenCode) - Command aliases and arguments support - 42 comprehensive tests Phase 17: Enhanced Agent Features - Permission system (allow/deny/ask patterns) - Glob pattern matching for file-scoped skills - Bootstrap files (AGENTS.md, SOUL.md, TOOLS.md) - Multi-mode support (Code/Architect/Debug/Ask) - Agent feature tests Phase 18: Advanced Features (AI & Audit) - AIManager with natural language skill search - Automatic skill generation from examples/code - MockAIProvider for testing without API keys - AuditLogger with complete operation trail - Query, export (JSON/CSV/text), and statistics - 37 comprehensive tests (15 AI + 22 audit) CLI Commands Added: - skillkit methodology list|install|sync - skillkit hook add|remove|list|generate - skillkit plan parse|validate|execute|create - skillkit commands generate|list - skillkit ai search|generate|similar - skillkit audit log|export|stats|clear TUI Enhancements: - Methodology screen (o key) for pack browsing - Plan screen (n key) for plan viewing/execution - Updated navigation and sidebar Test Coverage: - Total: 619 tests passing (582 core + 49 agents + 1 cli + 3 app) - New: 245+ tests for phases 12-18 - Coverage maintained at 80%+ Breaking Changes: None Dependencies: No new external dependencies added * fix: apply CodeRabbit security and quality improvements Security Fixes: - Replace custom glob-to-regex with minimatch to prevent ReDoS vulnerabilities - Fix regex pattern generation in globs.ts using battle-tested library - Eliminate unsafe regex patterns in modes.ts and permissions.ts Code Quality Improvements: - Use shared GlobMatcher utility to eliminate code duplication in modes.ts - Preserve command metadata on updates to prevent data loss - Fix single-file vs directory output path handling in command.ts - Pass --strict flag through to plan validator Race Condition & Concurrency Fixes: - Add Promise-based mutex to prevent race condition in audit logger flush() - Handle both sync and async event listeners to prevent unhandled rejections - Maintain synchronous event emission while safely handling async listeners Data Integrity Fixes: - Fix dependency checking to detect missing dependencies - Rehydrate Date fields when importing tasks from JSON - Fix executePlan to properly detect incomplete tasks State Management: - Add validation for missing step executor (fail fast) - Handle cancellation and reset executor state in finally block - Add 'cancelled' status and event to PlanStatus/PlanEvent types Dependencies: - Add minimatch@^10.0.1 to @skillkit/agents package All 639 tests passing. * docs: update READMEs with Phase 10-18 features - Root README: add minimal "What's New in v1.5.0" section with 5 bullet points - packages/core: add usage examples for Team, Plugin, Methodology, Orchestration, Plan, Hooks - packages/cli: add command sections for team, plugin, methodology, plan, hook, command - packages/tui: add screen descriptions for Marketplace, Workflow, Execute, Team, Plugins, Methodology, Plan, Memory - apps/skillkit: expand with practical usage examples for all new features All updates are clean, user-focused, and avoid AI marketing fluff. * fix: resolve multiple code quality and robustness issues - Fix minimatch dependency: downgrade to ^9.0.0 for Node 18 compatibility - Fix command.ts export: handle directory paths and ensure parent directories exist - Fix command.ts merge: preserve curated examples when merging commands - Fix plan.ts: filter empty entries from comma-separated inputs - Fix audit logger pagination: respect explicit 0 for limit and offset - Fix audit logger: gracefully handle malformed JSON lines without data loss - Fix team orchestrator: prevent task assignment to non-idle agents - Fix plan executor: unblock waitIfPaused() when cancel() is called All 639 tests passing. * fix: additional robustness improvements for plan and executor - Fix plan.ts createPlan: filter empty strings from techStack after split/trim - Fix executor.ts: re-check abort signal after waitIfPaused() in both execute() and executeTask() to prevent running additional tasks/steps after cancellation during pause All 639 tests passing.
289 lines
7.6 KiB
TypeScript
289 lines
7.6 KiB
TypeScript
import { Command, Option } from 'clipanion';
|
|
import { resolve } from 'node:path';
|
|
import { promises as fs } from 'fs';
|
|
import path from 'path';
|
|
import chalk from 'chalk';
|
|
import { AuditLogger, type AuditQuery, type AuditEventType } from '@skillkit/core';
|
|
|
|
export class AuditCommand extends Command {
|
|
static override paths = [['audit']];
|
|
|
|
static override usage = Command.Usage({
|
|
description: 'View and manage audit logs',
|
|
details: `
|
|
The audit command provides access to the audit log system.
|
|
All skill operations, team activities, and plugin actions are logged.
|
|
|
|
Subcommands:
|
|
log View recent audit log entries
|
|
export Export audit logs to file
|
|
stats Show audit statistics
|
|
clear Clear old audit entries
|
|
`,
|
|
examples: [
|
|
['View recent logs', '$0 audit log'],
|
|
['View logs with filters', '$0 audit log --type skill.install --limit 20'],
|
|
['Export logs to JSON', '$0 audit export --format json --output audit.json'],
|
|
['Show statistics', '$0 audit stats'],
|
|
['Clear logs older than 30 days', '$0 audit clear --days 30'],
|
|
],
|
|
});
|
|
|
|
subcommand = Option.String({ required: true });
|
|
|
|
// Query options
|
|
type = Option.Array('--type,-t', {
|
|
description: 'Filter by event type',
|
|
});
|
|
|
|
user = Option.String('--user,-u', {
|
|
description: 'Filter by user',
|
|
});
|
|
|
|
resource = Option.String('--resource,-r', {
|
|
description: 'Filter by resource',
|
|
});
|
|
|
|
success = Option.Boolean('--success', {
|
|
description: 'Show only successful operations',
|
|
});
|
|
|
|
failed = Option.Boolean('--failed', {
|
|
description: 'Show only failed operations',
|
|
});
|
|
|
|
since = Option.String('--since', {
|
|
description: 'Show events since date (ISO 8601)',
|
|
});
|
|
|
|
until = Option.String('--until', {
|
|
description: 'Show events until date (ISO 8601)',
|
|
});
|
|
|
|
limit = Option.String('--limit,-l', {
|
|
description: 'Maximum number of entries',
|
|
});
|
|
|
|
// Export options
|
|
format = Option.String('--format,-f', {
|
|
description: 'Export format (json, csv, text)',
|
|
});
|
|
|
|
output = Option.String('--output,-o', {
|
|
description: 'Output file path',
|
|
});
|
|
|
|
// Clear options
|
|
days = Option.String('--days', {
|
|
description: 'Clear entries older than N days',
|
|
});
|
|
|
|
// Common options
|
|
json = Option.Boolean('--json,-j', false, {
|
|
description: 'Output in JSON format',
|
|
});
|
|
|
|
projectPath = Option.String('--path,-p', {
|
|
description: 'Project path (default: current directory)',
|
|
});
|
|
|
|
async execute(): Promise<number> {
|
|
const targetPath = resolve(this.projectPath || process.cwd());
|
|
const logDir = path.join(targetPath, '.skillkit');
|
|
const logger = new AuditLogger(logDir);
|
|
|
|
try {
|
|
switch (this.subcommand) {
|
|
case 'log':
|
|
case 'list':
|
|
return await this.handleLog(logger);
|
|
case 'export':
|
|
return await this.handleExport(logger);
|
|
case 'stats':
|
|
return await this.handleStats(logger);
|
|
case 'clear':
|
|
return await this.handleClear(logger);
|
|
default:
|
|
console.error(chalk.red(`Unknown subcommand: ${this.subcommand}\n`));
|
|
console.log('Valid subcommands: log, export, stats, clear');
|
|
return 1;
|
|
}
|
|
} finally {
|
|
await logger.destroy();
|
|
}
|
|
}
|
|
|
|
private async handleLog(logger: AuditLogger): Promise<number> {
|
|
const query = this.buildQuery();
|
|
const events = await logger.query(query);
|
|
|
|
if (this.json) {
|
|
console.log(JSON.stringify(events, null, 2));
|
|
return 0;
|
|
}
|
|
|
|
if (events.length === 0) {
|
|
console.log(chalk.yellow('No audit events found'));
|
|
return 0;
|
|
}
|
|
|
|
console.log(chalk.cyan(`\nAudit Log (${events.length} entries):\n`));
|
|
|
|
for (const event of events) {
|
|
const statusIcon = event.success ? chalk.green('✓') : chalk.red('✗');
|
|
const timestamp = event.timestamp.toLocaleString();
|
|
|
|
console.log(
|
|
`${statusIcon} ${chalk.dim(timestamp)} ${chalk.bold(event.type)}`
|
|
);
|
|
console.log(
|
|
` ${event.action} on ${chalk.cyan(event.resource)}`
|
|
);
|
|
|
|
if (event.user) {
|
|
console.log(` ${chalk.dim('User:')} ${event.user}`);
|
|
}
|
|
|
|
if (event.duration) {
|
|
console.log(` ${chalk.dim('Duration:')} ${event.duration}ms`);
|
|
}
|
|
|
|
if (event.error) {
|
|
console.log(` ${chalk.red('Error:')} ${event.error}`);
|
|
}
|
|
|
|
if (event.details && Object.keys(event.details).length > 0) {
|
|
console.log(` ${chalk.dim('Details:')} ${JSON.stringify(event.details)}`);
|
|
}
|
|
|
|
console.log();
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
private async handleExport(logger: AuditLogger): Promise<number> {
|
|
const format = (this.format as 'json' | 'csv' | 'text') || 'json';
|
|
const query = this.buildQuery();
|
|
|
|
const content = await logger.export({ format, query });
|
|
|
|
if (this.output) {
|
|
const outputPath = resolve(this.output);
|
|
await fs.writeFile(outputPath, content, 'utf-8');
|
|
console.log(chalk.green(`✓ Exported audit log to: ${outputPath}`));
|
|
} else {
|
|
console.log(content);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
private async handleStats(logger: AuditLogger): Promise<number> {
|
|
const stats = await logger.stats();
|
|
|
|
if (this.json) {
|
|
console.log(JSON.stringify(stats, null, 2));
|
|
return 0;
|
|
}
|
|
|
|
console.log(chalk.cyan('\nAudit Statistics:\n'));
|
|
console.log(`Total Events: ${chalk.bold(stats.totalEvents.toString())}`);
|
|
console.log(
|
|
`Success Rate: ${chalk.bold(`${(stats.successRate * 100).toFixed(1)}%`)}`
|
|
);
|
|
|
|
if (Object.keys(stats.eventsByType).length > 0) {
|
|
console.log(chalk.cyan('\nEvents by Type:'));
|
|
const sorted = Object.entries(stats.eventsByType).sort(
|
|
([, a], [, b]) => b - a
|
|
);
|
|
for (const [type, count] of sorted) {
|
|
console.log(` ${type.padEnd(30)} ${count}`);
|
|
}
|
|
}
|
|
|
|
if (stats.topResources.length > 0) {
|
|
console.log(chalk.cyan('\nTop Resources:'));
|
|
for (const { resource, count } of stats.topResources) {
|
|
console.log(` ${resource.padEnd(40)} ${count}`);
|
|
}
|
|
}
|
|
|
|
if (stats.recentErrors.length > 0) {
|
|
console.log(chalk.cyan(`\nRecent Errors (${stats.recentErrors.length}):`));
|
|
for (const error of stats.recentErrors.slice(0, 5)) {
|
|
const timestamp = error.timestamp.toLocaleString();
|
|
console.log(
|
|
` ${chalk.red('✗')} ${chalk.dim(timestamp)} ${error.type}`
|
|
);
|
|
if (error.error) {
|
|
console.log(` ${chalk.dim(error.error)}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
console.log();
|
|
return 0;
|
|
}
|
|
|
|
private async handleClear(logger: AuditLogger): Promise<number> {
|
|
if (!this.days) {
|
|
console.error(chalk.red('--days option required'));
|
|
return 1;
|
|
}
|
|
|
|
const daysAgo = parseInt(this.days, 10);
|
|
const cutoffDate = new Date();
|
|
cutoffDate.setDate(cutoffDate.getDate() - daysAgo);
|
|
|
|
const cleared = await logger.clear(cutoffDate);
|
|
|
|
console.log(
|
|
chalk.green(
|
|
`✓ Cleared ${cleared} audit entries older than ${daysAgo} days`
|
|
)
|
|
);
|
|
|
|
return 0;
|
|
}
|
|
|
|
private buildQuery(): AuditQuery {
|
|
const query: AuditQuery = {};
|
|
|
|
if (this.type && this.type.length > 0) {
|
|
query.types = this.type as AuditEventType[];
|
|
}
|
|
|
|
if (this.user) {
|
|
query.user = this.user;
|
|
}
|
|
|
|
if (this.resource) {
|
|
query.resource = this.resource;
|
|
}
|
|
|
|
if (this.success) {
|
|
query.success = true;
|
|
} else if (this.failed) {
|
|
query.success = false;
|
|
}
|
|
|
|
if (this.since) {
|
|
query.startDate = new Date(this.since);
|
|
}
|
|
|
|
if (this.until) {
|
|
query.endDate = new Date(this.until);
|
|
}
|
|
|
|
if (this.limit) {
|
|
query.limit = parseInt(this.limit, 10);
|
|
} else {
|
|
query.limit = 50;
|
|
}
|
|
|
|
return query;
|
|
}
|
|
}
|