mirror of
https://github.com/rohitg00/skillkit.git
synced 2026-11-19 02:13:58 +00:00
* refactor(docs): simplify website components and update README Website Code Simplification: - Convert arrow functions to named function declarations with explicit return types - Extract inline styles to module-level constants (BASE_STYLES, VARIANT_STYLES, etc.) - Extract SVG icons to constants (GITHUB_ICON, CHECK_ICON, COPY_ICON) - Extract CSS animations to constants (FADE_ANIMATION_STYLES, SCROLL_ANIMATION_STYLES) - Add explicit TypeScript interfaces (Feature, Agent, TerminalLine, etc.) - Replace nested ternaries with switch statements for clarity - Extract inline handlers to named functions (scrollToTop, openGitHub, etc.) - Improve variable naming (idx -> index, cap -> feature) - Use meaningful React keys instead of index-only keys README Updates: - Remove "What's New in v1.6" section (release notes should be in CHANGELOG) Components updated: - App.tsx, Button.tsx, Card.tsx, Terminal.tsx, Footer.tsx - Features.tsx, Agents.tsx, Hero.tsx - SkillSubmitForm.tsx, SkillGenerator.tsx * fix: address CodeRabbit review suggestions Security: - Add noopener,noreferrer to window.open in Hero.tsx - Handle clipboard API errors with try/catch Accessibility: - Add Space key support to Card.tsx for keyboard navigation - Add aria-label to GitHub icon link in Footer.tsx Error Handling: - Fix useCallback dependency for processMarkdownFile in SkillSubmitForm - Add input validation for topic in geminiService.ts Data Validation: - Add defensive checks for malformed source URLs in skills-index.ts - Generate proper skill ID for upload mode in SkillSubmitForm Type Safety: - Replace unsafe 'as any' cast with proper type annotation in geminiService Code Quality: - Use array filter pattern for class concatenation in Button.tsx