Commit Graph
6 Commits
Author SHA1 Message Date
Rohit Ghumare 2bf8c7499c docs: add security scanner documentation, TUI screen, and README updates (#53)
- Add dedicated security.mdx docs page with full rule reference (46+ rules),
  threat categories, SARIF/CI integration guide, and programmatic usage
- Add TUI Scan screen (z key) with live scan results, severity colors,
  finding navigation, and rescan support
- Add scan to TUI sidebar nav, help shortcuts, and bottom status bar
- Add security scanner section to docs index page with link
- Add programmatic scan usage example to CLI README
- Remove stale --quiet option from commands.mdx
- Add security page to docs sidebar navigation
2026-02-08 20:50:45 +00:00
Rohit Ghumare b28a2801b2 feat: add security scanner for detecting malicious patterns in skills (#50)
* feat: add security scanner for detecting malicious patterns in skills

Add `skillkit scan <path>` command with 46+ detection rules across 6 threat
categories: prompt injection, command injection, data exfiltration, tool abuse,
hardcoded secrets, and unicode steganography.

- 3 analyzers: static pattern matching, SKILL.md manifest validation, secrets detection
- 4 output formats: summary (colored terminal), json, table, sarif (GitHub Code Scanning)
- Auto-scan on `skillkit install` (--no-scan to skip, --force to override)
- Auto-scan on `skillkit publish` (blocks on HIGH+ findings)
- Threat taxonomy with 10 categories and severity levels
- False-positive filtering for placeholders, test files, safe patterns
- Updated README, CLI docs, website commands, features, and fumadocs

* fix: address Devin and CodeRabbit review suggestions for security scanner

- Fix .env variant files (.env.local, .env.production) being skipped by scanner
- Add multiline rule support in StaticAnalyzer for cross-line pattern matching
- Fix PI004/PI013 patterns that contained literal \n (never matched per-line)
- Fix /g flag on CI006 path traversal regex causing intermittent misses
- Fix frontmatter regex to handle Windows CRLF line endings
- Fix allowed-tools parsing to detect multi-line YAML arrays
- Fix snippet redaction order: redact before truncate to prevent secret leaks
- Reset findingCounter per analyze() call for deterministic finding IDs
- Make SARIF artifactLocation.uri relative to skillPath for GitHub Code Scanning
- Use basename() instead of split('/').pop() for cross-platform paths
- Inject package version at build time via tsup define (replaces hardcoded 1.0.0)
- Validate --fail-on and --format CLI options with clear error messages
- Remove unused format/quiet from ScanOptions interface
- Move publish scan after name validation to avoid blocking on invalid skills
- Add excludePatterns for jailbreak detection to reduce false positives
- Add biome suppression for intentional control character regex in UC005
- Use alternation instead of character class for ZWJ in UC001

* fix: address CodeRabbit round 2 review suggestions

- Remove unused --quiet option from scan command
- Update OpenAI API key pattern to detect sk-proj- and sk-admin- prefixes

* fix: address deep review issues in security scanner

- SK001: add negative lookahead to prevent matching Anthropic keys
- static.ts: fix multiline loop hang for non-global regex with filtered matches
- CI005: reduce severity to MEDIUM, expand excludePatterns for template literals
- CI006: reduce severity to MEDIUM, add fileTypes whitelist, exclude markdown/YAML patterns
- PI011: fix literal \n in regex, use $/im for end-of-line matching
- UC004: use \u{...} notation for supplementary codepoint range
- scanner.ts: propagate skipRules to ManifestAnalyzer and SecretsAnalyzer
2026-02-08 12:56:45 +00:00
Rohit Ghumare f357c73e97 fix: update agent count from 17 to 32 across codebase (#24)
* fix: update agent count from 17 to 32 across codebase

- Update all documentation files (README.md, package READMEs)
- Update hardcoded AGENT_COUNT constant in onboarding
- Update JSDoc comments in core modules
- Update test files and e2e tests
- SkillKit now supports 32 AI coding agents:
  Primary: claude-code, codex, cursor, antigravity, opencode,
  gemini-cli, amp, clawdbot, droid, github-copilot, goose,
  kilo, kiro-cli, roo, trae, windsurf, universal
  Extended: cline, codebuddy, commandcode, continue, crush,
  factory, mcpjam, mux, neovate, openhands, pi, qoder, qwen,
  vercel, zencoder

* fix: add all 32 agents to documentation and tests

- apps/skillkit/README.md: Split agents into Primary (17) and Extended (15)
- e2e/onboarding-ui.e2e.test.ts: Add 15 extended agents to test array
- e2e/translation.e2e.test.ts: Add 15 extended agents to SUPPORTED_AGENTS
- README.md: Add extended agents to inline list and table
2026-01-29 13:21:58 +00:00
Rohit Ghumare 1344d65b3d feat: implement phases 12-18 - complete agentic development platform (#6)
* feat: implement phases 12-18 - complete agentic development platform

This comprehensive update implements 7 major phases (12-18) transforming
SkillKit into a universal agentic development platform with methodology
packs, hooks, orchestration, planning, and AI capabilities.

Phase 12: Methodology Framework
- MethodologyManager for pack-based methodology distribution
- 5 methodology packs (testing, debugging, planning, collaboration, meta)
- 13 curated methodology skills
- Pack loader with validation and installation
- 56 comprehensive tests

Phase 13: Hooks & Automatic Triggering System
- HookManager with event-driven skill activation
- 10+ event types (session:start, file:open, task:start, etc.)
- Pattern-based triggers with glob support
- Agent-specific hook generation
- 29 comprehensive tests

Phase 14: Subagent Orchestration
- TeamOrchestrator for multi-agent coordination
- TaskManager with cross-agent assignment
- Plan approval workflow (submit → approve/reject)
- TeamMessageBus for agent communication
- Two-stage review system (spec compliance + code quality)
- 36 comprehensive tests

Phase 15: Structured Plan System
- PlanParser for markdown → structured plan conversion
- PlanValidator for completeness checking
- PlanExecutor with dry-run support
- Bite-sized task format (2-5 min atomic tasks)
- 36 comprehensive tests

Phase 16: Slash Commands & Agent Integration
- CommandRegistry for slash command management
- Agent-specific command generation (Claude, Cursor, OpenCode)
- Command aliases and arguments support
- 42 comprehensive tests

Phase 17: Enhanced Agent Features
- Permission system (allow/deny/ask patterns)
- Glob pattern matching for file-scoped skills
- Bootstrap files (AGENTS.md, SOUL.md, TOOLS.md)
- Multi-mode support (Code/Architect/Debug/Ask)
- Agent feature tests

Phase 18: Advanced Features (AI & Audit)
- AIManager with natural language skill search
- Automatic skill generation from examples/code
- MockAIProvider for testing without API keys
- AuditLogger with complete operation trail
- Query, export (JSON/CSV/text), and statistics
- 37 comprehensive tests (15 AI + 22 audit)

CLI Commands Added:
- skillkit methodology list|install|sync
- skillkit hook add|remove|list|generate
- skillkit plan parse|validate|execute|create
- skillkit commands generate|list
- skillkit ai search|generate|similar
- skillkit audit log|export|stats|clear

TUI Enhancements:
- Methodology screen (o key) for pack browsing
- Plan screen (n key) for plan viewing/execution
- Updated navigation and sidebar

Test Coverage:
- Total: 619 tests passing (582 core + 49 agents + 1 cli + 3 app)
- New: 245+ tests for phases 12-18
- Coverage maintained at 80%+

Breaking Changes: None
Dependencies: No new external dependencies added

* fix: apply CodeRabbit security and quality improvements

Security Fixes:
- Replace custom glob-to-regex with minimatch to prevent ReDoS vulnerabilities
- Fix regex pattern generation in globs.ts using battle-tested library
- Eliminate unsafe regex patterns in modes.ts and permissions.ts

Code Quality Improvements:
- Use shared GlobMatcher utility to eliminate code duplication in modes.ts
- Preserve command metadata on updates to prevent data loss
- Fix single-file vs directory output path handling in command.ts
- Pass --strict flag through to plan validator

Race Condition & Concurrency Fixes:
- Add Promise-based mutex to prevent race condition in audit logger flush()
- Handle both sync and async event listeners to prevent unhandled rejections
- Maintain synchronous event emission while safely handling async listeners

Data Integrity Fixes:
- Fix dependency checking to detect missing dependencies
- Rehydrate Date fields when importing tasks from JSON
- Fix executePlan to properly detect incomplete tasks

State Management:
- Add validation for missing step executor (fail fast)
- Handle cancellation and reset executor state in finally block
- Add 'cancelled' status and event to PlanStatus/PlanEvent types

Dependencies:
- Add minimatch@^10.0.1 to @skillkit/agents package

All 639 tests passing.

* docs: update READMEs with Phase 10-18 features

- Root README: add minimal "What's New in v1.5.0" section with 5 bullet points
- packages/core: add usage examples for Team, Plugin, Methodology, Orchestration, Plan, Hooks
- packages/cli: add command sections for team, plugin, methodology, plan, hook, command
- packages/tui: add screen descriptions for Marketplace, Workflow, Execute, Team, Plugins, Methodology, Plan, Memory
- apps/skillkit: expand with practical usage examples for all new features

All updates are clean, user-focused, and avoid AI marketing fluff.

* fix: resolve multiple code quality and robustness issues

- Fix minimatch dependency: downgrade to ^9.0.0 for Node 18 compatibility
- Fix command.ts export: handle directory paths and ensure parent directories exist
- Fix command.ts merge: preserve curated examples when merging commands
- Fix plan.ts: filter empty entries from comma-separated inputs
- Fix audit logger pagination: respect explicit 0 for limit and offset
- Fix audit logger: gracefully handle malformed JSON lines without data loss
- Fix team orchestrator: prevent task assignment to non-idle agents
- Fix plan executor: unblock waitIfPaused() when cancel() is called

All 639 tests passing.

* fix: additional robustness improvements for plan and executor

- Fix plan.ts createPlan: filter empty strings from techStack after split/trim
- Fix executor.ts: re-check abort signal after waitIfPaused() in both execute() and executeTask()
  to prevent running additional tasks/steps after cancellation during pause

All 639 tests passing.
2026-01-24 11:54:47 +00:00
Rohit Ghumare b34177ca85 docs: rewrite READMEs with compelling value proposition
- Main README now leads with "One CLI. 17 AI Agents. Zero Lock-in."
- Clear problem/solution format showing SkillKit's value
- Feature comparison table (with vs without SkillKit)
- Organized command reference by category
- Updated all package READMEs with comprehensive docs:
  - @skillkit/core: Full API examples for all features
  - @skillkit/cli: Complete command reference
  - @skillkit/tui: Screen descriptions and keyboard shortcuts
  - @skillkit/agents: Agent adapter documentation
2026-01-23 18:24:07 +00:00
Rohit Ghumare bc12775e0e docs: add README files to all packages 2026-01-23 09:58:16 +00:00