mirror of
https://github.com/rohitg00/skillkit.git
synced 2026-11-20 12:23:29 +00:00
feat/skillssh-integration
3
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
12ed10d170 |
refactor(tui): migrate to OpenTUI/Solid.js framework (#32)
* refactor(tui): migrate to OpenTUI/Solid.js framework Complete TUI rewrite from Ink/React to OpenTUI/Solid.js: - Replace React with Solid.js for reactive state management - Migrate all 20 screens to OpenTUI component primitives - Add monochromatic design with 14 color themes - Implement cinematic splash screen with ASCII animation - Add vi-key navigation (j/k/h/l) throughout - Create 32 reusable components with consistent styling - Add service layer for @skillkit/core API integration - Remove deprecated react-opentui.d.ts type definitions - Update build config for Solid.js JSX transform Features covered: - Browse, Marketplace, Recommend (discovery) - Installed, Sync, Translate (management) - Workflow, Execute, Plan, History (execution) - Team, Context, Memory, Mesh, Message (collaboration) - Plugins, Methodology, Settings (configuration) - Help screen with 25+ keyboard shortcuts * fix(tui): address CodeRabbit review feedback Critical fixes: - Remove non-existent module exports from index.tsx (context, themes, ui, hooks, services) - Simplify App.tsx to remove missing context provider imports Major fixes: - ProgressBar: Add defensive guards for width/progress (NaN, Infinity, negative) - Browse: Fix filtered index loading wrong repository - Context: Add section navigation (h/l keys) and async error handling - Methodology: Add error handling with try/catch/finally for all async ops - Plan: Fix division by zero when plan has no tasks, add error handling - Team: Add error handling for loadTeamConfig and handleInitialize - Translate: Guard against missing skill.path before read operations * fix(tui): address remaining CodeRabbit feedback - Memory: Add error handling for loadData, handleDelete, handleClearAll, handleInitialize - Team: Fix key conflict by blocking global keys when detail pane is open - animations: Fix springCurve to return 0 at progress=0 and 1 at progress=1 * fix(tui): add Solid.js OpenTUI type definitions Required for TypeScript to recognize OpenTUI JSX elements (box, text, span) with their custom props (fg, bg, flexDirection, etc.) * fix(tui): add stub services and fix type errors for CI - Add minimal stub service implementations for all TUI screens: - context.service.ts - project context loading - executor.service.ts - skill execution - memory.service.ts - memory management - methodology.service.ts - methodology packs - plan.service.ts - plan management - plugin.service.ts - plugin management - recommend.service.ts - skill recommendations - team.service.ts - team collaboration - translator.service.ts - skill translation - workflow.service.ts - workflow orchestration - Fix type errors in screens: - Plan.tsx: Add non-null assertions for optional issues array - Plugins.tsx: Cast getPluginInfo result to Plugin type These stubs provide the expected interfaces for screens while the full integration with @skillkit/core is completed later. * fix(tui): add missing component files for CI Add the component files that screens depend on: - StatusIndicator - loading/success/error status display - DetailPane - side panel for detailed view - EmptyState/ErrorState - empty and error state components - SelectList - selection list component - SplitPane - split view layout - AnimatedText - text animations - Breadcrumb - navigation breadcrumb - Button/Clickable - interactive elements - CodeBlock - code display - FormField - form input wrapper - HoverHighlight - hover effect wrapper - RightSidebar/BottomStatusBar - layout components - TabBar - tab navigation - ErrorBoundary - error handling wrapper These components are required by the screen files and were missing from the previous commit. * fix(tui): resolve context import and duplicate export issues - RightSidebar: inline sidebar state instead of importing from context - services/index.ts: fix duplicate AgentType export by using explicit exports for executor and translator services * fix(tui): use export type for type-only re-exports * refactor(tui): simplify components and remove redundant exports * refactor(tui): remove unused imports and variables Code simplification pass: - Remove unused onCleanup import from Workflow, Recommend, Sync screens - Remove unused contentWidth from Browse, Recommend, Marketplace, Sync - Remove unused cols from Browse, Recommend - Remove unused JSX import from EmptyState component - Remove unused translate import from Sync screen - Remove unused SelectList import and listItems function from Memory screen * fix(tui): wire up interactive handlers and fix type definitions - AnimatedText: fix reactive dependency tracking in createEffect - BottomStatusBar: remove unused width prop - Breadcrumb: wire onNavigate handlers, fix off-by-one in getPathAtIndex - Button: wire onClick with disabled check, apply paddingX, fix ButtonGroup spacing - Clickable: wire click/double-click/right-click handlers, fix InteractiveArea - DetailPane: make close button interactive - ErrorBoundary: use terminal keyboard handler, prevent duplicate onError calls - FormField: fix placeholder show condition for empty string - SelectList: add onSelect/onHover interactive behavior - SplitPane: preserve string sizes like "50%" in width/height helpers - TabBar: wire onSelect callbacks for both horizontal and vertical variants - solid-opentui.d.ts: add missing event handler types to BoxProps/TextProps * fix(tui): address Devin review issues - App: restore process.exit(0) fallback when onExit is undefined - Execute: pass skill path instead of content to executeSkillWithAgent - Memory: add useKeyboard handler for j/k/Enter/d/c/i/Esc shortcuts * fix(tui): address Devin and CodeRabbit review issues Security & Robustness: - App: use execFile instead of exec to prevent command injection in openUrl - App: clamp cols/rows to minimum 1 to prevent negative dimensions - index: await render() and handle failures with exitTUI(1) Execute screen: - Add error state for load failures - Prevent re-entrant execution with executing() guard - Use try/finally to always clear executing state Memory screen: - Add missing 'r' shortcut for retry/refresh Workflow screen: - Use try/finally to always clear executing state even on rejection Sync screen: - Capture selectedIndex and agent values before await to prevent drift * fix(tui): implement list windowing to keep selection visible Execute, Marketplace, Recommend screens now use windowed list rendering that follows the selection, preventing the selected item from being off-screen when navigating through long lists. - Add createMemo for computing visible window based on selectedIndex - Show ▲/▼ indicators when items are above/below the visible window - Navigate through full list instead of clamping to visible window size * fix(tui): add error handling and index clamping Marketplace.tsx: - Set error signal when all repos fail or no skills loaded - Add reactive effect to clamp selectedIndex when filteredSkills changes Recommend.tsx: - Wrap loadData in try/catch to surface errors in UI - Clamp selectedIndex after recommendations update * fix(tui): add error handling to Plugins and Workflow screens Plugins.tsx: - Wrap loadData in try/catch to prevent stuck loading state - Wrap handleToggle in try/catch/finally to always reset toggling flag - Wrap handleShowDetail in try/catch to surface errors gracefully Workflow.tsx: - Wrap loadData in try/catch to prevent stuck loading state - Add catch block to handleExecute to show execution errors in UI |
||
|
|
0210556634 |
feat(tui): migrate to OpenTUI with monochromatic design (#11)
* feat(tui): migrate to OpenTUI with monochromatic design ## Summary - Migrate TUI from Ink to OpenTUI framework (requires Bun >=1.2.0) - Implement monochromatic B&W design with colored accents - Add Help screen accessible via `/` key - Fix terminal cleanup on exit (no more escape code garbage) - Clean up code: remove unnecessary comments, simplify components - Add 9 unit tests for TUI state, theme, and utilities ## Breaking Changes - TUI now requires Bun runtime (>=1.2.0) for OpenTUI - Help moved from `?` (requires Shift) to `/` key ## Changes - **index.tsx**: Clean exit handler with ANSI terminal restore - **App.tsx**: Simplified screen routing with switch statement - **Help.tsx**: New help screen with keyboard shortcuts reference - **Home.tsx**: Extract FEATURES constant, simplified agent width logic - **Sidebar.tsx**: Removed unused onNavigate prop usage - **state/types.ts**: Consolidated type definitions, added help screen - **README.md**: Updated with Bun requirement and new architecture ## Test Coverage - 757 tests passing (664 core + 80 agents + 9 tui + 1 cli + 3 app) ## Code Quality - Removed all JSDoc comments describing obvious code - Extracted reusable ShortcutSection component - Replaced nested ternaries with clearer if/else - Moved static data outside components to prevent recreation * fix: address CodeRabbit review issues - AgentGrid: prevent infinite loop when columns <= 0 - Splash: clamp progress width to prevent negative repeat - StatsCard: reset animation state when items change - Help: clamp contentWidth to minimum 1 - Browse: add useKeyboard handler for navigation and search - Installed: add useKeyboard handler for toggle functionality - Marketplace: add useKeyboard handler and clamp contentWidth - Recommend: fix spinner interval, add keyboard handler - Settings: add keyboard handler, fix SETTINGS -> settings state - Sync: add keyboard handler and sync flow implementation - Workflow: add keyboard handler and clamp contentWidth - skills.ts: add path validation to prevent directory traversal * fix: address additional CodeRabbit review issues Splash.tsx: - Change generateParticles from useMemo to useCallback for fresh random rows Browse.tsx: - Clamp maxLen to avoid negative slicing - Add Enter/Return handler to open selected repo Installed.tsx: - Wire up 'd' key to toggle handler - Update shortcuts label from "delete" to "disable" Marketplace.tsx: - Add handleInstall callback for Enter key - Add 'b' key handler to navigate to browse Recommend.tsx: - Add handleInstall callback for Enter key Settings.tsx: - Update shortcuts label from "enter edit" to "enter toggle" Sync.tsx: - Add useRef for timeout cleanup on unmount - Clamp selectedIndex when agents list shrinks Workflow.tsx: - Remove unimplemented shortcuts from display string * fix: address performance and stale closure issues Splash.tsx: - Cache getVersion() with useMemo to avoid repeated sync file I/O Installed.tsx: - Wrap keyboard handler in useCallback to prevent stale closures Settings.tsx: - Wrap keyboard handler in useCallback with proper dependencies Workflow.tsx: - Remove "Press 'n' to create one" text since 'n' key isn't implemented |
||
|
|
160d2b1534 |
feat: add TUI enhancements and monorepo structure (#2)
* feat: add TUI enhancements and monorepo structure - Add Translate screen for cross-agent skill translation - Add Context screen for project context management - Add Recommend screen with smart skill recommendations - Fix TUI screen duplication by using fixed height container - Clean up unnecessary comments following code-simplifier principles - Refactor to monorepo structure with @skillkit/core, @skillkit/cli, @skillkit/tui, and @skillkit/agents packages - Add comprehensive tests for translator, context, and recommend features - Update license to Apache-2.0 - Add CONTRIBUTING.md with contribution guidelines * ci: switch from npm to pnpm for monorepo support * ci: use pnpm version from package.json * fix: remove unused import in TUI helpers |